branches: fix error message for invalid name
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39
diff --git a/src/branch.c b/src/branch.c
index 69be8c7..22e7ba8 100644
--- a/src/branch.c
+++ b/src/branch.c
@@ -54,6 +54,12 @@ static int not_a_local_branch(const char *reference_name)
static bool branch_name_follows_pattern(const char *branch_name)
{
+ /*
+ * Discourage branch name starting with dash,
+ * https://github.com/git/git/commit/6348624010888b
+ * and discourage HEAD as branch name,
+ * https://github.com/git/git/commit/a625b092cc5994
+ */
return branch_name[0] != '-' && git__strcmp(branch_name, "HEAD");
}
@@ -78,7 +84,7 @@ static int create_branch(
GIT_ASSERT_ARG(git_commit_owner(commit) == repository);
if (!branch_name_follows_pattern(branch_name)) {
- git_error_set(GIT_ERROR_REFERENCE, "'HEAD' is not a valid branch name");
+ git_error_set(GIT_ERROR_REFERENCE, "'%s' is not a valid branch name", branch_name);
error = -1;
goto cleanup;
}
@@ -761,12 +767,6 @@ int git_branch_name_is_valid(int *valid, const char *name)
*valid = 0;
- /*
- * Discourage branch name starting with dash,
- * https://github.com/git/git/commit/6348624010888b
- * and discourage HEAD as branch name,
- * https://github.com/git/git/commit/a625b092cc5994
- */
if (!name || !branch_name_follows_pattern(name))
goto done;