Commit 79a343968a4a91c98fae1afa61cdadc5b573c93d

Sebastian Schuberth 2011-09-09T09:32:39

Fix a bug and GCC warning introduced in 932669b For unsigned types, the comparison >= 0 is always true, so avoid it by using a post-decrement and integrating the initial assigment into the loop body. No change in behavior is intended.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
diff --git a/src/config_file.c b/src/config_file.c
index 7fb54a6..4515c59 100644
--- a/src/config_file.c
+++ b/src/config_file.c
@@ -553,10 +553,8 @@ static char *cfg_readline(diskfile_backend *cfg)
 
 	memcpy(line, line_src, line_len);
 
-	line[line_len] = '\0';
-
-	while (--line_len >= 0 && isspace(line[line_len]))
-		line[line_len] = '\0';
+	do line[line_len] = '\0';
+	while (line_len-- > 0 && isspace(line[line_len]));
 
 	if (*line_end == '\n')
 		line_end++;