Commit 7a16d54b5457aa9f60c25a204277ae0ce609ad2e

Vicent Marti 2013-12-13T12:47:51

pool: Agh, this test doesn't really apply in 32-bit machines The size_t is 32-bit already, so it overflows before going into the function. The `-1` test should handle this gracefully in both cases anyway.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
diff --git a/tests/core/pool.c b/tests/core/pool.c
index 7a8b2de..351d0c2 100644
--- a/tests/core/pool.c
+++ b/tests/core/pool.c
@@ -141,9 +141,6 @@ void test_core_pool__strndup_limit(void)
 	cl_git_pass(git_pool_init(&p, 1, 100));
 	/* ensure 64 bit doesn't overflow */
 	cl_assert(git_pool_strndup(&p, "foo", (size_t)-1) == NULL);
-
-	/* ensure 32 bit doesn't overflow */
-	cl_assert(git_pool_strndup(&p, "bar", 0xfffffffful + 32) == NULL);
 	git_pool_clear(&p);
 }