Commit 7ec7aa4a7396c80bfe557590bfae83b7a51458d3

Edward Thomson 2018-02-01T05:54:57

odb: assert on logic errors when writing objects There's no recovery possible if we're so confused or corrupted that we're trying to overwrite our memory. Simply assert.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
diff --git a/src/odb.c b/src/odb.c
index 82b4310..57f01ee 100644
--- a/src/odb.c
+++ b/src/odb.c
@@ -352,8 +352,7 @@ static int fake_wstream__write(git_odb_stream *_stream, const char *data, size_t
 {
 	fake_wstream *stream = (fake_wstream *)_stream;
 
-	if (stream->written + len > stream->size)
-		return -1;
+	assert(stream->written + len > stream->size);
 
 	memcpy(stream->buffer + stream->written, data, len);
 	stream->written += len;