Commit 82d4c0e6b841ae0e466bd97ab1faec0920a6b7a2
2016-10-05T12:55:53
revwalk: update the description for the default sorting It changed from implementation-defined to git's default sorting, as there are systems (e.g. rebase) which depend on this order. Also specify more explicitly how you can get git's "date-order".
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
diff --git a/include/git2/revwalk.h b/include/git2/revwalk.h
index 2cc0053..d9376ce 100644
--- a/include/git2/revwalk.h
+++ b/include/git2/revwalk.h
@@ -25,17 +25,15 @@ GIT_BEGIN_DECL
*/
typedef enum {
/**
- * Sort the repository contents in no particular ordering;
- * this sorting is arbitrary, implementation-specific
- * and subject to change at any time.
+ * Sort the output with the same default time-order method from git.
* This is the default sorting for new walkers.
*/
GIT_SORT_NONE = 0,
/**
- * Sort the repository contents in topological order
- * (parents before children); this sorting mode
- * can be combined with time sorting.
+ * Sort the repository contents in topological order (parents before
+ * children); this sorting mode can be combined with time sorting to
+ * produce git's "time-order".
*/
GIT_SORT_TOPOLOGICAL = 1 << 0,
diff --git a/src/revwalk.c b/src/revwalk.c
index 80f5bdf..4753a37 100644
--- a/src/revwalk.c
+++ b/src/revwalk.c
@@ -555,10 +555,6 @@ static int prepare_walk(git_revwalk *walk)
}
}
- for (list = commits; list; list = list->next) {
- printf("%s: commit %s\n", __func__, git_oid_tostr_s(&list->item->oid));
- }
-
if ((error = limit_list(&commits, walk, commits)) < 0)
return error;