thodg/libgit2

2010-06-01T19:33:57

Fix sparse warnings: "symbol not declared. Should it be static?" In particular, sparse issues the following warnings: src/revobject.c:29:14: warning: symbol 'max_load_factor' was \ not declared. Should it be static? src/revobject.c:31:14: warning: symbol 'git_revpool_table__hash' was \ not declared. Should it be static? In order to suppress these warnings, we simply declare them as static, since they are not (currently) referenced outside of this file. In the case of max_load_factor, this is probably correct. However, this may not be appropriate for git_revpool_table__hash(), given how it is named. So, this should either be re-named to reflect it's non-external status, or a declaration needs to be added to the revobject.h header file. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Andreas Ericsson <ae@op5.se>

diff --git a/src/revobject.c b/src/revobject.c
index 4c64f55..7b6c856 100644
--- a/src/revobject.c
+++ b/src/revobject.c
@@ -26,9 +26,9 @@
 #include "common.h"
 #include "revobject.h"
 
-const double max_load_factor = 0.65;
+static const double max_load_factor = 0.65;
 
-unsigned int git_revpool_table__hash(const git_oid *id)
+static unsigned int git_revpool_table__hash(const git_oid *id)
 {
 	return *((unsigned int *)id->id);
 }