Commit 8b2f230cd519010d202c57185dc4dc39ca3d53f8

Vicent Martí 2013-08-29T13:27:37

repository: Make the is_empty check more explicit

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
diff --git a/src/repository.c b/src/repository.c
index e5f23e4..80904d5 100644
--- a/src/repository.c
+++ b/src/repository.c
@@ -1500,8 +1500,10 @@ int git_repository_is_empty(git_repository *repo)
 	if (git_reference_lookup(&head, repo, GIT_HEAD_FILE) < 0)
 		return -1;
 
-	if (!(error = (git_reference_type(head) == GIT_REF_SYMBOLIC)))
+	if (git_reference_type(head) != GIT_REF_SYMBOLIC) {
+		error = -1;
 		goto cleanup;
+	}
 
 	if (!(error = (strcmp(
 		git_reference_symbolic_target(head),