Commit 90d2b619575a5c61bde9498b5bf3912eca1a58ad
2022-04-11T17:07:20
repo: test configuration ownership validation Test that we prevent opening directories that are not owned by ourselves.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65
diff --git a/tests/libgit2/repo/config.c b/tests/libgit2/repo/config.c
index ee7e43d..37f6b52 100644
--- a/tests/libgit2/repo/config.c
+++ b/tests/libgit2/repo/config.c
@@ -28,7 +28,6 @@ void test_repo_config__cleanup(void)
cl_assert(!git_fs_path_isdir("alternate"));
cl_fixture_cleanup("empty_standard_repo");
-
}
void test_repo_config__can_open_global_when_there_is_no_file(void)
diff --git a/tests/libgit2/repo/open.c b/tests/libgit2/repo/open.c
index f7ed2c3..fa6e36b 100644
--- a/tests/libgit2/repo/open.c
+++ b/tests/libgit2/repo/open.c
@@ -7,9 +7,12 @@
void test_repo_open__cleanup(void)
{
cl_git_sandbox_cleanup();
+ cl_fixture_cleanup("empty_standard_repo");
if (git_fs_path_isdir("alternate"))
git_futils_rmdir_r("alternate", NULL, GIT_RMDIR_REMOVE_FILES);
+
+ git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_NONE);
}
void test_repo_open__bare_empty_repo(void)
@@ -453,3 +456,35 @@ void test_repo_open__force_bare(void)
git_repository_free(barerepo);
}
+void test_repo_open__validates_dir_ownership(void)
+{
+ git_repository *repo;
+
+ cl_fixture_sandbox("empty_standard_repo");
+ cl_git_pass(cl_rename("empty_standard_repo/.gitted", "empty_standard_repo/.git"));
+
+ /* When the current user owns the repo config, that's acceptable */
+ git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_CURRENT_USER);
+ cl_git_pass(git_repository_open(&repo, "empty_standard_repo"));
+ git_repository_free(repo);
+
+ /* When the system user owns the repo config, fail */
+ git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_SYSTEM);
+ cl_git_fail(git_repository_open(&repo, "empty_standard_repo"));
+
+ /* When an unknown user owns the repo config, fail */
+ git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_OTHER);
+ cl_git_fail(git_repository_open(&repo, "empty_standard_repo"));
+}
+
+void test_repo_open__can_allowlist_dirs_with_problematic_ownership(void)
+{
+ git_repository *repo;
+
+ cl_fixture_sandbox("empty_standard_repo");
+ cl_git_pass(cl_rename("empty_standard_repo/.gitted", "empty_standard_repo/.git"));
+
+ git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_OTHER);
+ cl_git_fail(git_repository_open(&repo, "empty_standard_repo"));
+
+}