Commit 9746b36cf9a86ba50a666bbc8cc97a37221cb954

Carlos Martín Nieto 2014-07-24T16:46:59

revwalk: remove preallocation of the uninteresting commits Preallocating two commits doesn't make much sense as leaving allocation to the first array usage will allocate a sensible size with room for growth. This preallocation has also been hiding issues with strict aliasing in the tests, as we have fairly simple histories and never trigger the growth.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
diff --git a/src/revwalk.c b/src/revwalk.c
index 530c970..bd07d02 100644
--- a/src/revwalk.c
+++ b/src/revwalk.c
@@ -48,9 +48,6 @@ static int mark_uninteresting(git_revwalk *walk, git_commit_list_node *commit)
 
 	assert(commit);
 
-	git_array_init_to_size(pending, 2);
-	GITERR_CHECK_ARRAY(pending);
-
 	do {
 		commit->uninteresting = 1;