git_merge_status -> git_merge_analysis
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
diff --git a/include/git2/merge.h b/include/git2/merge.h
index a4432ee..2cb8df3 100644
--- a/include/git2/merge.h
+++ b/include/git2/merge.h
@@ -235,41 +235,44 @@ GIT_EXTERN(int) git_merge_init_options(
int version);
/**
- * The results of `git_merge_status` indicate the state of a merge scenario.
+ * The results of `git_merge_analysis` indicate the merge opportunities.
*/
typedef enum {
+ /** No merge is possible. (Unused.) */
+ GIT_MERGE_ANALYSIS_NONE = 0,
+
/**
* A "normal" merge; both HEAD and the given merge input have diverged
* from their common ancestor. The divergent commits must be merged.
*/
- GIT_MERGE_STATUS_NORMAL = 0,
+ GIT_MERGE_ANALYSIS_NORMAL = (1 << 0),
/**
* The repository is already up-to-date and no merge needs to be
* performed. The given merge input already exists as a parent of HEAD.
*/
- GIT_MERGE_STATUS_UP_TO_DATE = (1 << 0),
+ GIT_MERGE_ANALYSIS_UP_TO_DATE = (1 << 1),
/**
* The given merge input is a fast-forward from HEAD and no merge
* needs to be performed. Instead, the client can check out the
* given merge input.
*/
- GIT_MERGE_STATUS_FASTFORWARD = (1 << 1),
-} git_merge_status_t;
+ GIT_MERGE_ANALYSIS_FASTFORWARD = (1 << 2),
+} git_merge_analysis_t;
/**
- * Determine the status of the merge between the given branch(es) and the
- * HEAD of the repository.
+ * Analyzes the given branch(es) and determines the opportunities for
+ * merging them into the HEAD of the repository.
*
- * @param status_out status enumeration that the result is written into
+ * @param analysis_out analysis enumeration that the result is written into
* @param repo the repository to merge
* @param their_heads the heads to merge into
* @param their_heads_len the number of heads to merge
* @return 0 on success or error code
*/
-GIT_EXTERN(int) git_merge_status(
- git_merge_status_t *status_out,
+GIT_EXTERN(int) git_merge_analysis(
+ git_merge_analysis_t *analysis_out,
git_repository *repo,
const git_merge_head **their_heads,
size_t their_heads_len);
diff --git a/src/merge.c b/src/merge.c
index 66b8be6..6b416a3 100644
--- a/src/merge.c
+++ b/src/merge.c
@@ -2517,8 +2517,8 @@ done:
return error;
}
-int git_merge_status(
- git_merge_status_t *out,
+int git_merge_analysis(
+ git_merge_analysis_t *out,
git_repository *repo,
const git_merge_head **their_heads,
size_t their_heads_len)
@@ -2528,7 +2528,7 @@ int git_merge_status(
assert(out && repo && their_heads);
- *out = GIT_MERGE_STATUS_NORMAL;
+ *out = GIT_MERGE_ANALYSIS_NORMAL;
if ((error = merge_heads(&ancestor_head, &our_head, repo, their_heads, their_heads_len)) < 0)
goto done;
@@ -2536,11 +2536,11 @@ int git_merge_status(
if (their_heads_len == 1 && ancestor_head != NULL) {
/* We're up-to-date if we're trying to merge our own common ancestor. */
if (git_oid_equal(&ancestor_head->oid, &their_heads[0]->oid))
- *out = GIT_MERGE_STATUS_UP_TO_DATE;
+ *out = GIT_MERGE_ANALYSIS_UP_TO_DATE;
/* We're fastforwardable if we're our own common ancestor. */
else if (git_oid_equal(&ancestor_head->oid, &our_head->oid))
- *out = GIT_MERGE_STATUS_FASTFORWARD;
+ *out = GIT_MERGE_ANALYSIS_FASTFORWARD | GIT_MERGE_ANALYSIS_NORMAL;
}
done:
diff --git a/tests/merge/workdir/analysis.c b/tests/merge/workdir/analysis.c
new file mode 100644
index 0000000..6a4b86d
--- /dev/null
+++ b/tests/merge/workdir/analysis.c
@@ -0,0 +1,90 @@
+#include "clar_libgit2.h"
+#include "git2/repository.h"
+#include "git2/merge.h"
+#include "git2/sys/index.h"
+#include "merge.h"
+#include "../merge_helpers.h"
+#include "refs.h"
+
+static git_repository *repo;
+static git_index *repo_index;
+
+#define TEST_REPO_PATH "merge-resolve"
+#define TEST_INDEX_PATH TEST_REPO_PATH "/.git/index"
+
+#define UPTODATE_BRANCH "master"
+#define PREVIOUS_BRANCH "previous"
+
+#define FASTFORWARD_BRANCH "ff_branch"
+#define FASTFORWARD_ID "fd89f8cffb663ac89095a0f9764902e93ceaca6a"
+
+#define NOFASTFORWARD_BRANCH "branch"
+#define NOFASTFORWARD_ID "7cb63eed597130ba4abb87b3e544b85021905520"
+
+
+// Fixture setup and teardown
+void test_merge_workdir_analysis__initialize(void)
+{
+ repo = cl_git_sandbox_init(TEST_REPO_PATH);
+ git_repository_index(&repo_index, repo);
+}
+
+void test_merge_workdir_analysis__cleanup(void)
+{
+ git_index_free(repo_index);
+ cl_git_sandbox_cleanup();
+}
+
+static git_merge_analysis_t analysis_from_branch(const char *branchname)
+{
+ git_buf refname = GIT_BUF_INIT;
+ git_reference *their_ref;
+ git_merge_head *their_heads[1];
+ git_merge_analysis_t analysis;
+
+ git_buf_printf(&refname, "%s%s", GIT_REFS_HEADS_DIR, branchname);
+
+ cl_git_pass(git_reference_lookup(&their_ref, repo, git_buf_cstr(&refname)));
+ cl_git_pass(git_merge_head_from_ref(&their_heads[0], repo, their_ref));
+
+ cl_git_pass(git_merge_analysis(&analysis, repo, their_heads, 1));
+
+ git_buf_free(&refname);
+ git_merge_head_free(their_heads[0]);
+ git_reference_free(their_ref);
+
+ return analysis;
+}
+
+void test_merge_workdir_analysis__fastforward(void)
+{
+ git_merge_analysis_t analysis;
+
+ analysis = analysis_from_branch(FASTFORWARD_BRANCH);
+ cl_assert_equal_i(GIT_MERGE_ANALYSIS_FASTFORWARD, (analysis & GIT_MERGE_ANALYSIS_FASTFORWARD));
+ cl_assert_equal_i(GIT_MERGE_ANALYSIS_NORMAL, (analysis & GIT_MERGE_ANALYSIS_NORMAL));
+}
+
+void test_merge_workdir_analysis__no_fastforward(void)
+{
+ git_merge_analysis_t analysis;
+
+ analysis = analysis_from_branch(NOFASTFORWARD_BRANCH);
+ cl_assert_equal_i(GIT_MERGE_ANALYSIS_NORMAL, analysis);
+}
+
+void test_merge_workdir_analysis__uptodate(void)
+{
+ git_merge_analysis_t analysis;
+
+ analysis = analysis_from_branch(UPTODATE_BRANCH);
+ cl_assert_equal_i(GIT_MERGE_ANALYSIS_UP_TO_DATE, analysis);
+}
+
+void test_merge_workdir_analysis__uptodate_merging_prev_commit(void)
+{
+ git_merge_analysis_t analysis;
+
+ analysis = analysis_from_branch(PREVIOUS_BRANCH);
+ cl_assert_equal_i(GIT_MERGE_ANALYSIS_UP_TO_DATE, analysis);
+}
diff --git a/tests/merge/workdir/status.c b/tests/merge/workdir/status.c
deleted file mode 100644
index 589299e..0000000
--- a/tests/merge/workdir/status.c
+++ /dev/null
@@ -1,89 +0,0 @@
-#include "clar_libgit2.h"
-#include "git2/repository.h"
-#include "git2/merge.h"
-#include "git2/sys/index.h"
-#include "merge.h"
-#include "../merge_helpers.h"
-#include "refs.h"
-
-static git_repository *repo;
-static git_index *repo_index;
-
-#define TEST_REPO_PATH "merge-resolve"
-#define TEST_INDEX_PATH TEST_REPO_PATH "/.git/index"
-
-#define UPTODATE_BRANCH "master"
-#define PREVIOUS_BRANCH "previous"
-
-#define FASTFORWARD_BRANCH "ff_branch"
-#define FASTFORWARD_ID "fd89f8cffb663ac89095a0f9764902e93ceaca6a"
-
-#define NOFASTFORWARD_BRANCH "branch"
-#define NOFASTFORWARD_ID "7cb63eed597130ba4abb87b3e544b85021905520"
-
-
-// Fixture setup and teardown
-void test_merge_workdir_status__initialize(void)
-{
- repo = cl_git_sandbox_init(TEST_REPO_PATH);
- git_repository_index(&repo_index, repo);
-}
-
-void test_merge_workdir_status__cleanup(void)
-{
- git_index_free(repo_index);
- cl_git_sandbox_cleanup();
-}
-
-static git_status_t status_from_branch(const char *branchname)
-{
- git_buf refname = GIT_BUF_INIT;
- git_reference *their_ref;
- git_merge_head *their_heads[1];
- git_status_t status;
-
- git_buf_printf(&refname, "%s%s", GIT_REFS_HEADS_DIR, branchname);
-
- cl_git_pass(git_reference_lookup(&their_ref, repo, git_buf_cstr(&refname)));
- cl_git_pass(git_merge_head_from_ref(&their_heads[0], repo, their_ref));
-
- cl_git_pass(git_merge_status(&status, repo, their_heads, 1));
-
- git_buf_free(&refname);
- git_merge_head_free(their_heads[0]);
- git_reference_free(their_ref);
-
- return status;
-}
-
-void test_merge_workdir_status__fastforward(void)
-{
- git_merge_status_t status;
-
- status = status_from_branch(FASTFORWARD_BRANCH);
- cl_assert_equal_i(GIT_MERGE_STATUS_FASTFORWARD, status);
-}
-
-void test_merge_workdir_status__no_fastforward(void)
-{
- git_merge_status_t status;
-
- status = status_from_branch(NOFASTFORWARD_BRANCH);
- cl_assert_equal_i(GIT_MERGE_STATUS_NORMAL, status);
-}
-
-void test_merge_workdir_status__uptodate(void)
-{
- git_merge_status_t status;
-
- status = status_from_branch(UPTODATE_BRANCH);
- cl_assert_equal_i(GIT_MERGE_STATUS_UP_TO_DATE, status);
-}
-
-void test_merge_workdir_status__uptodate_merging_prev_commit(void)
-{
- git_merge_status_t status;
-
- status = status_from_branch(PREVIOUS_BRANCH);
- cl_assert_equal_i(GIT_MERGE_STATUS_UP_TO_DATE, status);
-}