Merge pull request #541 from nulltoken/topic/repo-reinit Repository re-initialization
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220
diff --git a/src/repository.c b/src/repository.c
index 97d70c4..74f0d8f 100644
--- a/src/repository.c
+++ b/src/repository.c
@@ -24,6 +24,8 @@
#define GIT_BRANCH_MASTER "master"
+#define GIT_CONFIG_CORE_REPOSITORYFORMATVERSION "core.repositoryformatversion"
+#define GIT_REPOSITORYFORMATVERSION 0
static void drop_odb(git_repository *repo)
{
@@ -628,12 +630,46 @@ cleanup:
return error;
}
-static int repo_init_reinit(const char *repository_path, int is_bare)
+static int check_repositoryformatversion(git_repository *repo)
{
- /* TODO: reinit the repository */
- return git__throw(GIT_ENOTIMPLEMENTED,
- "Failed to reinitialize the %srepository at '%s'. "
- "This feature is not yet implemented",
+ git_config *config;
+ int version, error = GIT_SUCCESS;
+
+ if ((error = git_repository_config(&config, repo)) < GIT_SUCCESS)
+ return git__throw(error, "Failed to open config file.");
+
+ error = git_config_get_int32(config, GIT_CONFIG_CORE_REPOSITORYFORMATVERSION, &version);
+
+ if (GIT_REPOSITORYFORMATVERSION < version)
+ error = git__throw(GIT_ERROR, "Unsupported git repository version (Expected version <= %d, found %d).", GIT_REPOSITORYFORMATVERSION, version);
+
+ git_config_free(config);
+
+ return error;
+}
+
+static int repo_init_reinit(git_repository **repo_out, const char *repository_path, int is_bare)
+{
+ int error;
+ git_repository *repo = NULL;
+
+ if ((error = git_repository_open(&repo, repository_path)) < GIT_SUCCESS)
+ goto error;
+
+ if ((error = check_repositoryformatversion(repo)) < GIT_SUCCESS)
+ goto error;
+
+ /* TODO: reinitialize the templates */
+
+ *repo_out = repo;
+
+ return GIT_SUCCESS;
+
+error:
+ git_repository_free(repo);
+
+ return git__rethrow(error,
+ "Failed to reinitialize the %srepository at '%s'. ",
is_bare ? "bare " : "", repository_path);
}
@@ -673,7 +709,7 @@ static int repo_init_config(const char *git_dir, int is_bare)
goto cleanup;
SET_REPO_CONFIG(bool, "core.bare", is_bare);
- SET_REPO_CONFIG(int32, "core.repositoryformatversion", 0);
+ SET_REPO_CONFIG(int32, GIT_CONFIG_CORE_REPOSITORYFORMATVERSION, GIT_REPOSITORYFORMATVERSION);
/* TODO: what other defaults? */
cleanup:
@@ -735,7 +771,7 @@ int git_repository_init(git_repository **repo_out, const char *path, unsigned is
if (git_path_isdir(repository_path.ptr) == GIT_SUCCESS) {
if (quickcheck_repository_dir(&repository_path) == GIT_SUCCESS) {
- error = repo_init_reinit(repository_path.ptr, is_bare);
+ error = repo_init_reinit(repo_out, repository_path.ptr, is_bare);
git_buf_free(&repository_path);
return error;
}
diff --git a/tests-clar/repo/init.c b/tests-clar/repo/init.c
index ab5edfb..a12a2c2 100644
--- a/tests-clar/repo/init.c
+++ b/tests-clar/repo/init.c
@@ -1,5 +1,7 @@
#include "clar_libgit2.h"
#include "fileops.h"
+#include "repository.h"
+#include "config.h"
enum repo_mode {
STANDARD_REPOSITORY = 0,
@@ -75,32 +77,67 @@ void test_repo_init__bare_repo_noslash(void)
ensure_repository_init("testrepo.git", 1, "testrepo.git/", NULL);
}
-#if 0
-BEGIN_TEST(init2, "Initialize and open a bare repo with a relative path escaping out of the current working directory")
+void test_repo_init__bare_repo_escaping_current_workdir(void)
+{
git_buf path_repository = GIT_BUF_INIT;
- char current_workdir[GIT_PATH_MAX];
- const mode_t mode = 0777;
- git_repository* repo;
+ git_buf path_current_workdir = GIT_BUF_INIT;
+
+ cl_git_pass(git_path_prettify_dir(&path_current_workdir, ".", NULL));
+
+ cl_git_pass(git_buf_joinpath(&path_repository, git_buf_cstr(&path_current_workdir), "a/b/c"));
+ cl_git_pass(git_futils_mkdir_r(git_buf_cstr(&path_repository), NULL, GIT_DIR_MODE));
+
+ /* Change the current working directory */
+ cl_git_pass(chdir(git_buf_cstr(&path_repository)));
- must_pass(p_getcwd(current_workdir, sizeof(current_workdir)));
+ /* Initialize a bare repo with a relative path escaping out of the current working directory */
+ cl_git_pass(git_repository_init(&_repo, "../d/e.git", 1));
+ cl_git_pass(git__suffixcmp(git_repository_path(_repo), "/a/b/d/e.git/"));
+
+ git_repository_free(_repo);
- must_pass(git_buf_joinpath(&path_repository, TEMP_REPO_FOLDER, "a/b/c/"));
- must_pass(git_futils_mkdir_r(path_repository.ptr, mode));
+ /* Open a bare repo with a relative path escaping out of the current working directory */
+ cl_git_pass(git_repository_open(&_repo, "../d/e.git"));
- must_pass(chdir(path_repository.ptr));
+ cl_git_pass(chdir(git_buf_cstr(&path_current_workdir)));
+ git_buf_free(&path_current_workdir);
git_buf_free(&path_repository);
- must_pass(git_repository_init(&repo, "../d/e.git", 1));
- must_pass(git__suffixcmp(git_repository_path(_repo), "/a/b/d/e.git/"));
+ cleanup_repository("a");
+}
+
+void test_repo_init__reinit_bare_repo(void)
+{
+ cl_set_cleanup(&cleanup_repository, "reinit.git");
+
+ /* Initialize the repository */
+ cl_git_pass(git_repository_init(&_repo, "reinit.git", 1));
+ git_repository_free(_repo);
- git_repository_free(repo);
+ /* Reinitialize the repository */
+ cl_git_pass(git_repository_init(&_repo, "reinit.git", 1));
+}
- must_pass(git_repository_open(&repo, "../d/e.git"));
+void test_repo_init__reinit_too_recent_bare_repo(void)
+{
+ git_config *config;
- git_repository_free(repo);
+ /* Initialize the repository */
+ cl_git_pass(git_repository_init(&_repo, "reinit.git", 1));
+ git_repository_config(&config, _repo);
- must_pass(chdir(current_workdir));
- must_pass(git_futils_rmdir_r(TEMP_REPO_FOLDER, 1));
-END_TEST
-#endif
+ /*
+ * Hack the config of the repository to make it look like it has
+ * been created by a recenter version of git/libgit2
+ */
+ cl_git_pass(git_config_set_int32(config, "core.repositoryformatversion", 42));
+
+ git_config_free(config);
+ git_repository_free(_repo);
+
+ /* Try to reinitialize the repository */
+ cl_git_fail(git_repository_init(&_repo, "reinit.git", 1));
+
+ cl_fixture_cleanup("reinit.git");
+}
diff --git a/tests-clar/repo/open.c b/tests-clar/repo/open.c
index 3bd103c..b500284 100644
--- a/tests-clar/repo/open.c
+++ b/tests-clar/repo/open.c
@@ -22,34 +22,3 @@ void test_repo_open__standard_empty_repo(void)
git_repository_free(repo);
}
-
-/* TODO TODO */
-#if 0
-BEGIN_TEST(open2, "Open a bare repository with a relative path escaping out of the current working directory")
- char current_workdir[GIT_PATH_MAX];
- git_buf new_current_workdir = GIT_BUF_INIT;
- git_buf path_repository = GIT_BUF_INIT;
-
- const mode_t mode = 0777;
- git_repository* repo;
-
- /* Setup the repository to open */
- must_pass(p_getcwd(current_workdir, sizeof(current_workdir)));
- must_pass(git_buf_join_n(&path_repository, 3, current_workdir, TEMP_REPO_FOLDER, "a/d/e.git"));
- must_pass(copydir_recurs(REPOSITORY_FOLDER, path_repository.ptr));
- git_buf_free(&path_repository);
-
- /* Change the current working directory */
- must_pass(git_buf_joinpath(&new_current_workdir, TEMP_REPO_FOLDER, "a/b/c/"));
- must_pass(git_futils_mkdir_r(new_current_workdir.ptr, mode));
- must_pass(chdir(new_current_workdir.ptr));
- git_buf_free(&new_current_workdir);
-
- must_pass(git_repository_open(&repo, "../../d/e.git"));
-
- git_repository_free(repo);
-
- must_pass(chdir(current_workdir));
- must_pass(git_futils_rmdir_r(TEMP_REPO_FOLDER, 1));
-END_TEST
-#endif