Commit 99feb98897fa1daa0ff3fd70b17ccc9d9a51f1d0

Victor Garcia 2013-11-07T16:22:49

adding doc for new param and test to check fetch spec is correctly added

diff --git a/include/git2/remote.h b/include/git2/remote.h
index 0710259..f5e6f5a 100644
--- a/include/git2/remote.h
+++ b/include/git2/remote.h
@@ -27,13 +27,15 @@ GIT_BEGIN_DECL
 typedef int (*git_remote_rename_problem_cb)(const char *problematic_refspec, void *payload);
 
 /**
- * Add a remote with the default fetch refspec to the repository's configuration.  This
+ * Add a remote with the provided fetch refspec (or default if NULL) to the repository's
+ * configuration.  This
  * calls git_remote_save before returning.
  *
  * @param out the resulting remote
  * @param repo the repository in which to create the remote
  * @param name the remote's name
  * @param url the remote's url
+ * @param fetch the remote fetch value
  * @return 0, GIT_EINVALIDSPEC, GIT_EEXISTS or an error code
  */
 GIT_EXTERN(int) git_remote_create(
diff --git a/tests-clar/network/remote/remotes.c b/tests-clar/network/remote/remotes.c
index 3b7ce29..210790d 100644
--- a/tests-clar/network/remote/remotes.c
+++ b/tests-clar/network/remote/remotes.c
@@ -450,7 +450,6 @@ void test_network_remote_remotes__cannot_create_a_remote_which_name_conflicts_wi
 	assert_cannot_create_remote("test", GIT_EEXISTS);
 }
 
-
 void test_network_remote_remotes__cannot_create_a_remote_which_name_is_invalid(void)
 {
 	assert_cannot_create_remote("/", GIT_EINVALIDSPEC);
@@ -459,6 +458,17 @@ void test_network_remote_remotes__cannot_create_a_remote_which_name_is_invalid(v
 	assert_cannot_create_remote("a.lock", GIT_EINVALIDSPEC);
 }
 
+void test_network_remote_remotes__create_a_remote_with_custom_fetch_spec(void)
+{
+	git_remote *remote;
+	git_strarray array;
+
+	cl_git_pass(git_remote_create(&remote, _repo, "test-new", "git://github.com/libgit2/libgit2", "+refs/*:refs/*"));
+	git_remote_get_fetch_refspecs(&array, remote);
+	cl_assert_equal_s("+refs/*:refs/*", array.strings[0]);
+	git_remote_free(remote);
+}
+
 static const char *fetch_refspecs[] = {
 	"+refs/heads/*:refs/remotes/origin/*",
 	"refs/tags/*:refs/tags/*",