Merge pull request #949 from nulltoken/topic/deploy_repository_set_head Deploy git_repository_set_head()
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
diff --git a/include/git2/branch.h b/include/git2/branch.h
index f072799..f06609a 100644
--- a/include/git2/branch.h
+++ b/include/git2/branch.h
@@ -148,6 +148,17 @@ GIT_EXTERN(int) git_branch_tracking(
git_reference **tracking_out,
git_reference *branch);
+/**
+ * Determine if the current local branch is pointed at by HEAD.
+ *
+ * @param branch Current underlying reference of the branch.
+ *
+ * @return 1 if HEAD points at the branch, 0 if it isn't,
+ * error code otherwise.
+ */
+GIT_EXTERN(int) git_branch_is_head(
+ git_reference *branch);
+
/** @} */
GIT_END_DECL
#endif
diff --git a/src/branch.c b/src/branch.c
index 103dfe6..6d497b0 100644
--- a/src/branch.c
+++ b/src/branch.c
@@ -92,7 +92,7 @@ cleanup:
int git_branch_delete(git_reference *branch)
{
- git_reference *head = NULL;
+ int is_head;
assert(branch);
@@ -102,27 +102,16 @@ int git_branch_delete(git_reference *branch)
return -1;
}
- if (git_reference_lookup(&head, git_reference_owner(branch), GIT_HEAD_FILE) < 0) {
- giterr_set(GITERR_REFERENCE, "Cannot locate HEAD.");
- goto on_error;
- }
+ if ((is_head = git_branch_is_head(branch)) < 0)
+ return is_head;
- if ((git_reference_type(head) == GIT_REF_SYMBOLIC)
- && (strcmp(git_reference_target(head), git_reference_name(branch)) == 0)) {
- giterr_set(GITERR_REFERENCE,
- "Cannot delete branch '%s' as it is the current HEAD of the repository.", git_reference_name(branch));
- goto on_error;
+ if (is_head) {
+ giterr_set(GITERR_REFERENCE,
+ "Cannot delete branch '%s' as it is the current HEAD of the repository.", git_reference_name(branch));
+ return -1;
}
- if (git_reference_delete(branch) < 0)
- goto on_error;
-
- git_reference_free(head);
- return 0;
-
-on_error:
- git_reference_free(head);
- return -1;
+ return git_reference_delete(branch);
}
typedef struct {
@@ -271,3 +260,26 @@ cleanup:
git_buf_free(&buf);
return error;
}
+
+int git_branch_is_head(
+ git_reference *branch)
+{
+ git_reference *head;
+ bool is_same = false;
+
+ assert(branch);
+
+ if (!git_reference_is_branch(branch))
+ return false;
+
+ if (git_repository_head(&head, git_reference_owner(branch)) < 0)
+ return -1;
+
+ is_same = strcmp(
+ git_reference_name(branch),
+ git_reference_name(head)) == 0;
+
+ git_reference_free(head);
+
+ return is_same;
+}
diff --git a/src/clone.c b/src/clone.c
index 80a13d0..a5f4867 100644
--- a/src/clone.c
+++ b/src/clone.c
@@ -22,112 +22,219 @@
#include "refs.h"
#include "path.h"
-struct HeadInfo {
- git_repository *repo;
- git_oid remote_head_oid;
- git_buf branchname;
-};
-
-static int create_tracking_branch(git_repository *repo, const git_oid *target, const char *name)
+static int create_branch(
+ git_reference **branch,
+ git_repository *repo,
+ const git_oid *target,
+ const char *name)
{
git_object *head_obj = NULL;
git_reference *branch_ref;
- int retcode = GIT_ERROR;
+ int error;
/* Find the target commit */
- if (git_object_lookup(&head_obj, repo, target, GIT_OBJ_ANY) < 0)
- return GIT_ERROR;
+ if ((error = git_object_lookup(&head_obj, repo, target, GIT_OBJ_ANY)) < 0)
+ return error;
/* Create the new branch */
- if (!git_branch_create(&branch_ref, repo, name, head_obj, 0)) {
- git_config *cfg;
+ error = git_branch_create(&branch_ref, repo, name, head_obj, 0);
+ git_object_free(head_obj);
+
+ if (!error)
+ *branch = branch_ref;
+ else
git_reference_free(branch_ref);
- /* Set up tracking */
- if (!git_repository_config(&cfg, repo)) {
- git_buf remote = GIT_BUF_INIT;
- git_buf merge = GIT_BUF_INIT;
- git_buf merge_target = GIT_BUF_INIT;
- if (!git_buf_printf(&remote, "branch.%s.remote", name) &&
- !git_buf_printf(&merge, "branch.%s.merge", name) &&
- !git_buf_printf(&merge_target, "refs/heads/%s", name) &&
- !git_config_set_string(cfg, git_buf_cstr(&remote), "origin") &&
- !git_config_set_string(cfg, git_buf_cstr(&merge), git_buf_cstr(&merge_target))) {
- retcode = 0;
- }
- git_buf_free(&remote);
- git_buf_free(&merge);
- git_buf_free(&merge_target);
- git_config_free(cfg);
- }
- }
- git_object_free(head_obj);
- return retcode;
+ return error;
}
-static int reference_matches_remote_head(const char *head_name, void *payload)
+static int setup_tracking_config(
+ git_repository *repo,
+ const char *branch_name,
+ const char *remote_name,
+ const char *merge_target)
{
- struct HeadInfo *head_info = (struct HeadInfo *)payload;
+ git_config *cfg;
+ git_buf remote_key = GIT_BUF_INIT, merge_key = GIT_BUF_INIT;
+ int error = -1;
+
+ if (git_repository_config__weakptr(&cfg, repo) < 0)
+ return -1;
+
+ if (git_buf_printf(&remote_key, "branch.%s.remote", branch_name) < 0)
+ goto cleanup;
+
+ if (git_buf_printf(&merge_key, "branch.%s.merge", branch_name) < 0)
+ goto cleanup;
+
+ if (git_config_set_string(cfg, git_buf_cstr(&remote_key), remote_name) < 0)
+ goto cleanup;
+
+ if (git_config_set_string(cfg, git_buf_cstr(&merge_key), merge_target) < 0)
+ goto cleanup;
+
+ error = 0;
+
+cleanup:
+ git_buf_free(&remote_key);
+ git_buf_free(&merge_key);
+ return error;
+}
+
+static int create_tracking_branch(
+ git_reference **branch,
+ git_repository *repo,
+ const git_oid *target,
+ const char *branch_name)
+{
+ int error;
+
+ if ((error = create_branch(branch, repo, target, branch_name)) < 0)
+ return error;
+
+ return setup_tracking_config(
+ repo,
+ branch_name,
+ GIT_REMOTE_ORIGIN,
+ git_reference_name(*branch));
+}
+
+struct head_info {
+ git_repository *repo;
+ git_oid remote_head_oid;
+ git_buf branchname;
+ const git_refspec *refspec;
+};
+
+static int reference_matches_remote_head(
+ const char *reference_name,
+ void *payload)
+{
+ struct head_info *head_info = (struct head_info *)payload;
git_oid oid;
+ /* TODO: Should we guard against references
+ * which name doesn't start with refs/heads/ ?
+ */
+
/* Stop looking if we've already found a match */
- if (git_buf_len(&head_info->branchname) > 0) return 0;
+ if (git_buf_len(&head_info->branchname) > 0)
+ return 0;
+
+ if (git_reference_name_to_oid(
+ &oid,
+ head_info->repo,
+ reference_name) < 0) {
+ /* TODO: How to handle not found references?
+ */
+ return -1;
+ }
- if (!git_reference_name_to_oid(&oid, head_info->repo, head_name) &&
- !git_oid_cmp(&head_info->remote_head_oid, &oid)) {
- git_buf_puts(&head_info->branchname,
- head_name+strlen("refs/remotes/origin/"));
+ if (git_oid_cmp(&head_info->remote_head_oid, &oid) == 0) {
+ /* Determine the local reference name from the remote tracking one */
+ if (git_refspec_transform_l(
+ &head_info->branchname,
+ head_info->refspec,
+ reference_name) < 0)
+ return -1;
+
+ if (git_buf_sets(
+ &head_info->branchname,
+ git_buf_cstr(&head_info->branchname) + strlen(GIT_REFS_HEADS_DIR)) < 0)
+ return -1;
}
+
return 0;
}
-static int update_head_to_new_branch(git_repository *repo, const git_oid *target, const char *name)
+static int update_head_to_new_branch(
+ git_repository *repo,
+ const git_oid *target,
+ const char *name)
{
- int retcode = GIT_ERROR;
+ git_reference *tracking_branch;
+ int error;
- if (!create_tracking_branch(repo, target, name)) {
- git_reference *head;
- if (!git_reference_lookup(&head, repo, GIT_HEAD_FILE)) {
- git_buf targetbuf = GIT_BUF_INIT;
- if (!git_buf_printf(&targetbuf, "refs/heads/%s", name)) {
- retcode = git_reference_set_target(head, git_buf_cstr(&targetbuf));
- }
- git_buf_free(&targetbuf);
- git_reference_free(head);
- }
- }
+ if ((error = create_tracking_branch(
+ &tracking_branch,
+ repo,
+ target,
+ name)) < 0)
+ return error;
- return retcode;
+ error = git_repository_set_head(repo, git_reference_name(tracking_branch));
+
+ git_reference_free(tracking_branch);
+
+ return error;
}
static int update_head_to_remote(git_repository *repo, git_remote *remote)
{
- int retcode = GIT_ERROR;
+ int retcode = -1;
git_remote_head *remote_head;
- git_oid oid;
- struct HeadInfo head_info;
+ struct head_info head_info;
+ git_buf remote_master_name = GIT_BUF_INIT;
+
+ /* Did we just clone an empty repository? */
+ if (remote->refs.length == 0) {
+ return setup_tracking_config(
+ repo,
+ "master",
+ GIT_REMOTE_ORIGIN,
+ GIT_REFS_HEADS_MASTER_FILE);
+ }
/* Get the remote's HEAD. This is always the first ref in remote->refs. */
remote_head = remote->refs.contents[0];
git_oid_cpy(&head_info.remote_head_oid, &remote_head->oid);
git_buf_init(&head_info.branchname, 16);
head_info.repo = repo;
-
- /* Check to see if "master" matches the remote head */
- if (!git_reference_name_to_oid(&oid, repo, "refs/remotes/origin/master") &&
- !git_oid_cmp(&remote_head->oid, &oid)) {
- retcode = update_head_to_new_branch(repo, &oid, "master");
+ head_info.refspec = git_remote_fetchspec(remote);
+
+ /* Determine the remote tracking reference name from the local master */
+ if (git_refspec_transform_r(
+ &remote_master_name,
+ head_info.refspec,
+ GIT_REFS_HEADS_MASTER_FILE) < 0)
+ return -1;
+
+ /* Check to see if the remote HEAD points to the remote master */
+ if (reference_matches_remote_head(git_buf_cstr(&remote_master_name), &head_info) < 0)
+ goto cleanup;
+
+ if (git_buf_len(&head_info.branchname) > 0) {
+ retcode = update_head_to_new_branch(
+ repo,
+ &head_info.remote_head_oid,
+ git_buf_cstr(&head_info.branchname));
+
+ goto cleanup;
}
+
/* Not master. Check all the other refs. */
- else if (!git_reference_foreach(repo, GIT_REF_LISTALL,
- reference_matches_remote_head,
- &head_info) &&
- git_buf_len(&head_info.branchname) > 0) {
- retcode = update_head_to_new_branch(repo, &head_info.remote_head_oid,
- git_buf_cstr(&head_info.branchname));
+ if (git_reference_foreach(
+ repo,
+ GIT_REF_LISTALL,
+ reference_matches_remote_head,
+ &head_info) < 0)
+ goto cleanup;
+
+ if (git_buf_len(&head_info.branchname) > 0) {
+ retcode = update_head_to_new_branch(
+ repo,
+ &head_info.remote_head_oid,
+ git_buf_cstr(&head_info.branchname));
+
+ goto cleanup;
+ } else {
+ /* TODO: What should we do if nothing has been found?
+ */
}
+cleanup:
+ git_buf_free(&remote_master_name);
git_buf_free(&head_info.branchname);
return retcode;
}
@@ -150,7 +257,7 @@ static int setup_remotes_and_fetch(git_repository *repo,
if (!fetch_stats) fetch_stats = &dummy_stats;
/* Create the "origin" remote */
- if (!git_remote_add(&origin, repo, "origin", origin_url)) {
+ if (!git_remote_add(&origin, repo, GIT_REMOTE_ORIGIN, origin_url)) {
/* Connect and download everything */
if (!git_remote_connect(origin, GIT_DIR_FETCH)) {
if (!git_remote_download(origin, &bytes, fetch_stats)) {
@@ -184,11 +291,14 @@ static bool path_is_okay(const char *path)
}
-static int clone_internal(git_repository **out,
- const char *origin_url,
- const char *path,
- git_indexer_stats *fetch_stats,
- int is_bare)
+static int clone_internal(
+ git_repository **out,
+ const char *origin_url,
+ const char *path,
+ git_indexer_stats *fetch_stats,
+ git_indexer_stats *checkout_stats,
+ git_checkout_opts *checkout_opts,
+ int is_bare)
{
int retcode = GIT_ERROR;
git_repository *repo = NULL;
@@ -211,6 +321,9 @@ static int clone_internal(git_repository **out,
}
}
+ if (!retcode && !is_bare && !git_repository_head_orphan(repo))
+ retcode = git_checkout_head(*out, checkout_opts, checkout_stats);
+
return retcode;
}
@@ -220,7 +333,15 @@ int git_clone_bare(git_repository **out,
git_indexer_stats *fetch_stats)
{
assert(out && origin_url && dest_path);
- return clone_internal(out, origin_url, dest_path, fetch_stats, 1);
+
+ return clone_internal(
+ out,
+ origin_url,
+ dest_path,
+ fetch_stats,
+ NULL,
+ NULL,
+ 1);
}
@@ -231,12 +352,14 @@ int git_clone(git_repository **out,
git_indexer_stats *checkout_stats,
git_checkout_opts *checkout_opts)
{
- int retcode = GIT_ERROR;
-
assert(out && origin_url && workdir_path);
- if (!(retcode = clone_internal(out, origin_url, workdir_path, fetch_stats, 0)))
- retcode = git_checkout_head(*out, checkout_opts, checkout_stats);
-
- return retcode;
+ return clone_internal(
+ out,
+ origin_url,
+ workdir_path,
+ fetch_stats,
+ checkout_stats,
+ checkout_opts,
+ 0);
}
diff --git a/src/refs.c b/src/refs.c
index bd6fbee..9dc422e 100644
--- a/src/refs.c
+++ b/src/refs.c
@@ -15,6 +15,7 @@
#include <git2/tag.h>
#include <git2/object.h>
#include <git2/oid.h>
+#include <git2/branch.h>
GIT__USE_STRMAP;
@@ -1343,9 +1344,7 @@ int git_reference_rename(git_reference *ref, const char *new_name, int force)
unsigned int normalization_flags;
git_buf aux_path = GIT_BUF_INIT;
char normalized[GIT_REFNAME_MAX];
-
- const char *head_target = NULL;
- git_reference *head = NULL;
+ bool should_head_be_updated = false;
normalization_flags = ref->flags & GIT_REF_SYMBOLIC ?
GIT_REF_FORMAT_ALLOW_ONELEVEL
@@ -1367,6 +1366,12 @@ int git_reference_rename(git_reference *ref, const char *new_name, int force)
return -1;
/*
+ * Check if we have to update HEAD.
+ */
+ if ((should_head_be_updated = git_branch_is_head(ref)) < 0)
+ goto cleanup;
+
+ /*
* Now delete the old ref and remove an possibly existing directory
* named `new_name`. Note that using the internal `reference_delete`
* method deletes the ref from disk but doesn't free the pointer, so
@@ -1390,25 +1395,13 @@ int git_reference_rename(git_reference *ref, const char *new_name, int force)
goto rollback;
/*
- * Check if we have to update HEAD.
+ * Update HEAD it was poiting to the reference being renamed.
*/
- if (git_reference_lookup(&head, ref->owner, GIT_HEAD_FILE) < 0) {
- giterr_set(GITERR_REFERENCE,
- "Failed to update HEAD after renaming reference");
- goto cleanup;
- }
-
- head_target = git_reference_target(head);
-
- if (head_target && !strcmp(head_target, ref->name)) {
- git_reference_free(head);
- head = NULL;
-
- if (git_reference_create_symbolic(&head, ref->owner, "HEAD", new_name, 1) < 0) {
+ if (should_head_be_updated &&
+ git_repository_set_head(ref->owner, new_name) < 0) {
giterr_set(GITERR_REFERENCE,
"Failed to update HEAD after renaming reference");
goto cleanup;
- }
}
/*
@@ -1426,12 +1419,10 @@ int git_reference_rename(git_reference *ref, const char *new_name, int force)
/* The reference is no longer packed */
ref->flags &= ~GIT_REF_PACKED;
- git_reference_free(head);
git_buf_free(&aux_path);
return 0;
cleanup:
- git_reference_free(head);
git_buf_free(&aux_path);
return -1;
diff --git a/src/refspec.c b/src/refspec.c
index cd3a528..b1790b3 100644
--- a/src/refspec.c
+++ b/src/refspec.c
@@ -194,20 +194,20 @@ int git_refspec_transform(char *out, size_t outlen, const git_refspec *spec, con
return 0;
}
-int git_refspec_transform_r(git_buf *out, const git_refspec *spec, const char *name)
+static int refspec_transform(git_buf *out, const char *from, const char *to, const char *name)
{
- if (git_buf_sets(out, spec->dst) < 0)
+ if (git_buf_sets(out, to) < 0)
return -1;
/*
- * No '*' at the end means that it's mapped to one specific local
+ * No '*' at the end means that it's mapped to one specific
* branch, so no actual transformation is needed.
*/
if (git_buf_len(out) > 0 && out->ptr[git_buf_len(out) - 1] != '*')
return 0;
git_buf_truncate(out, git_buf_len(out) - 1); /* remove trailing '*' */
- git_buf_puts(out, name + strlen(spec->src) - 1);
+ git_buf_puts(out, name + strlen(from) - 1);
if (git_buf_oom(out))
return -1;
@@ -215,3 +215,13 @@ int git_refspec_transform_r(git_buf *out, const git_refspec *spec, const char *n
return 0;
}
+int git_refspec_transform_r(git_buf *out, const git_refspec *spec, const char *name)
+{
+ return refspec_transform(out, spec->src, spec->dst, name);
+}
+
+int git_refspec_transform_l(git_buf *out, const git_refspec *spec, const char *name)
+{
+ return refspec_transform(out, spec->dst, spec->src, name);
+}
+
diff --git a/src/refspec.h b/src/refspec.h
index a5df458..6e0596a 100644
--- a/src/refspec.h
+++ b/src/refspec.h
@@ -40,4 +40,15 @@ void git_refspec__free(git_refspec *refspec);
*/
int git_refspec_transform_r(git_buf *out, const git_refspec *spec, const char *name);
+/**
+ * Transform a reference from its target following the refspec's rules,
+ * and writes the results into a git_buf.
+ *
+ * @param out where to store the source name
+ * @param spec the refspec
+ * @param name the name of the reference to transform
+ * @return 0 or error if buffer allocation fails
+ */
+int git_refspec_transform_l(git_buf *out, const git_refspec *spec, const char *name);
+
#endif
diff --git a/src/remote.h b/src/remote.h
index b8bb2c5..05073db 100644
--- a/src/remote.h
+++ b/src/remote.h
@@ -13,6 +13,8 @@
#include "transport.h"
#include "repository.h"
+#define GIT_REMOTE_ORIGIN "origin"
+
struct git_remote {
char *name;
char *url;
diff --git a/src/repository.c b/src/repository.c
index 1a46db0..1b49228 100644
--- a/src/repository.c
+++ b/src/repository.c
@@ -19,6 +19,7 @@
#include "refs.h"
#include "filter.h"
#include "odb.h"
+#include "remote.h"
#define GIT_FILE_CONTENT_PREFIX "gitdir:"
@@ -654,10 +655,10 @@ static int repo_init_create_head(const char *git_dir, const char *ref_name)
if (!ref_name)
ref_name = GIT_BRANCH_MASTER;
- if (git__prefixcmp(ref_name, "refs/") == 0)
+ if (git__prefixcmp(ref_name, GIT_REFS_DIR) == 0)
fmt = "ref: %s\n";
else
- fmt = "ref: refs/heads/%s\n";
+ fmt = "ref: " GIT_REFS_HEADS_DIR "%s\n";
if (git_filebuf_printf(&ref, fmt, ref_name) < 0 ||
git_filebuf_commit(&ref, GIT_REFS_FILE_MODE) < 0)
@@ -1095,7 +1096,7 @@ static int repo_init_create_origin(git_repository *repo, const char *url)
int error;
git_remote *remote;
- if (!(error = git_remote_add(&remote, repo, "origin", url))) {
+ if (!(error = git_remote_add(&remote, repo, GIT_REMOTE_ORIGIN, url))) {
error = git_remote_save(remote);
git_remote_free(remote);
}
@@ -1219,7 +1220,7 @@ int git_repository_is_empty(git_repository *repo)
git_reference *head = NULL, *branch = NULL;
int error;
- if (git_reference_lookup(&head, repo, "HEAD") < 0)
+ if (git_reference_lookup(&head, repo, GIT_HEAD_FILE) < 0)
return -1;
if (git_reference_type(head) != GIT_REF_SYMBOLIC) {
@@ -1227,7 +1228,7 @@ int git_repository_is_empty(git_repository *repo)
return 0;
}
- if (strcmp(git_reference_target(head), "refs/heads/master") != 0) {
+ if (strcmp(git_reference_target(head), GIT_REFS_HEADS_DIR "master") != 0) {
git_reference_free(head);
return 0;
}
diff --git a/src/reset.c b/src/reset.c
index 4ce21e2..c536e75 100644
--- a/src/reset.c
+++ b/src/reset.c
@@ -29,6 +29,7 @@ int git_reset(
git_tree *tree = NULL;
int error = -1;
git_checkout_opts opts;
+ git_reference *head = NULL;
assert(repo && target);
assert(reset_type == GIT_RESET_SOFT
@@ -49,7 +50,10 @@ int git_reset(
//TODO: Check for unmerged entries
- if (git_reference__update(repo, git_object_id(commit), GIT_HEAD_FILE) < 0)
+ if (git_repository_head(&head, repo) < 0)
+ goto cleanup;
+
+ if (git_reference_set_oid(head, git_object_id(commit)) < 0)
goto cleanup;
if (reset_type == GIT_RESET_SOFT) {
@@ -96,6 +100,7 @@ int git_reset(
error = 0;
cleanup:
+ git_reference_free(head);
git_object_free(commit);
git_index_free(index);
git_tree_free(tree);
diff --git a/src/revparse.c b/src/revparse.c
index 5e2db99..191f637 100644
--- a/src/revparse.c
+++ b/src/revparse.c
@@ -28,11 +28,11 @@ static int disambiguate_refname(git_reference **out, git_repository *repo, const
static const char* formatters[] = {
"%s",
- "refs/%s",
- "refs/tags/%s",
- "refs/heads/%s",
- "refs/remotes/%s",
- "refs/remotes/%s/HEAD",
+ GIT_REFS_DIR "%s",
+ GIT_REFS_TAGS_DIR "%s",
+ GIT_REFS_HEADS_DIR "%s",
+ GIT_REFS_REMOTES_DIR "%s",
+ GIT_REFS_REMOTES_DIR "%s/" GIT_HEAD_FILE,
NULL
};
@@ -520,7 +520,7 @@ static int handle_grep_syntax(git_object **out, git_repository *repo, const git_
if (spec_oid == NULL) {
// TODO: @carlosmn: The glob should be refs/* but this makes git_revwalk_next() fails
- if (git_revwalk_push_glob(walk, "refs/heads/*") < 0)
+ if (git_revwalk_push_glob(walk, GIT_REFS_HEADS_DIR "*") < 0)
goto cleanup;
} else if (git_revwalk_push(walk, spec_oid) < 0)
goto cleanup;
diff --git a/src/submodule.c b/src/submodule.c
index a216249..1805286 100644
--- a/src/submodule.c
+++ b/src/submodule.c
@@ -1315,7 +1315,7 @@ static int lookup_head_remote(git_buf *url, git_repository *repo)
/* remote should refer to something like refs/remotes/ORIGIN/BRANCH */
if (git_reference_type(remote) != GIT_REF_SYMBOLIC ||
- git__prefixcmp(git_reference_target(remote), "refs/remotes/") != 0)
+ git__prefixcmp(git_reference_target(remote), GIT_REFS_REMOTES_DIR) != 0)
{
giterr_set(GITERR_SUBMODULE,
"Cannot resolve relative URL when HEAD is not symbolic");
@@ -1323,7 +1323,7 @@ static int lookup_head_remote(git_buf *url, git_repository *repo)
goto cleanup;
}
- scan = tgt = git_reference_target(remote) + strlen("refs/remotes/");
+ scan = tgt = git_reference_target(remote) + strlen(GIT_REFS_REMOTES_DIR);
while (*scan && (*scan != '/' || (scan > tgt && scan[-1] != '\\')))
scan++; /* find non-escaped slash to end ORIGIN name */
diff --git a/tests-clar/clone/clone.c b/tests-clar/clone/clone.c
index 237e607..42ddb8a 100644
--- a/tests-clar/clone/clone.c
+++ b/tests-clar/clone/clone.c
@@ -6,6 +6,7 @@
#define DO_LOCAL_TEST 0
#define DO_LIVE_NETWORK_TESTS 0
#define LIVE_REPO_URL "git://github.com/nulltoken/TestGitRepository"
+#define LIVE_EMPTYREPO_URL "git://github.com/nulltoken/TestEmptyRepository"
static git_repository *g_repo;
@@ -15,12 +16,11 @@ void test_clone_clone__initialize(void)
g_repo = NULL;
}
-void test_clone_clone__cleanup(void)
+static void cleanup_repository(void *path)
{
- if (g_repo) {
+ if (g_repo)
git_repository_free(g_repo);
- g_repo = NULL;
- }
+ cl_fixture_cleanup((const char *)path);
}
// TODO: This is copy/pasted from network/remotelocal.c.
@@ -63,7 +63,6 @@ static void build_local_file_url(git_buf *out, const char *fixture)
git_buf_free(&path_buf);
}
-
void test_clone_clone__bad_url(void)
{
/* Clone should clean up the mess if the URL isn't a git repository */
@@ -73,33 +72,44 @@ void test_clone_clone__bad_url(void)
cl_assert(!git_path_exists("./foo.git"));
}
-
void test_clone_clone__local(void)
{
git_buf src = GIT_BUF_INIT;
build_local_file_url(&src, cl_fixture("testrepo.git"));
#if DO_LOCAL_TEST
+ cl_set_cleanup(&cleanup_repository, "./local");
+
cl_git_pass(git_clone(&g_repo, git_buf_cstr(&src), "./local", NULL, NULL, NULL));
- git_repository_free(g_repo);
- git_futils_rmdir_r("./local", GIT_DIRREMOVAL_FILES_AND_DIRS);
- cl_git_pass(git_clone_bare(&g_repo, git_buf_cstr(&src), "./local.git", NULL));
- git_futils_rmdir_r("./local.git", GIT_DIRREMOVAL_FILES_AND_DIRS);
#endif
git_buf_free(&src);
}
+void test_clone_clone__local_bare(void)
+{
+ git_buf src = GIT_BUF_INIT;
+ build_local_file_url(&src, cl_fixture("testrepo.git"));
+
+#if DO_LOCAL_TEST
+ cl_set_cleanup(&cleanup_repository, "./local.git");
+
+ cl_git_pass(git_clone_bare(&g_repo, git_buf_cstr(&src), "./local.git", NULL));
+#endif
+
+ git_buf_free(&src);
+}
void test_clone_clone__network_full(void)
{
#if DO_LIVE_NETWORK_TESTS
git_remote *origin;
+ cl_set_cleanup(&cleanup_repository, "./test2");
+
cl_git_pass(git_clone(&g_repo, LIVE_REPO_URL, "./test2", NULL, NULL, NULL));
cl_assert(!git_repository_is_bare(g_repo));
cl_git_pass(git_remote_load(&origin, g_repo, "origin"));
- git_futils_rmdir_r("./test2", GIT_DIRREMOVAL_FILES_AND_DIRS);
#endif
}
@@ -108,32 +118,58 @@ void test_clone_clone__network_bare(void)
#if DO_LIVE_NETWORK_TESTS
git_remote *origin;
- cl_git_pass(git_clone_bare(&g_repo, LIVE_REPO_URL, "test", NULL));
+ cl_set_cleanup(&cleanup_repository, "./test");
+
+ cl_git_pass(git_clone_bare(&g_repo, LIVE_REPO_URL, "./test", NULL));
cl_assert(git_repository_is_bare(g_repo));
cl_git_pass(git_remote_load(&origin, g_repo, "origin"));
- git_futils_rmdir_r("./test", GIT_DIRREMOVAL_FILES_AND_DIRS);
#endif
}
-
-void test_clone_clone__already_exists(void)
+void test_clone_clone__cope_with_already_existing_directory(void)
{
#if DO_LIVE_NETWORK_TESTS
- /* Should pass with existing-but-empty dir */
+ cl_set_cleanup(&cleanup_repository, "./foo");
+
p_mkdir("./foo", GIT_DIR_MODE);
cl_git_pass(git_clone(&g_repo, LIVE_REPO_URL, "./foo", NULL, NULL, NULL));
git_repository_free(g_repo); g_repo = NULL;
- git_futils_rmdir_r("./foo", GIT_DIRREMOVAL_FILES_AND_DIRS);
#endif
+}
+
+void test_clone_clone__fail_when_the_target_is_a_file(void)
+{
+ cl_set_cleanup(&cleanup_repository, "./foo");
- /* Should fail with a file */
cl_git_mkfile("./foo", "Bar!");
cl_git_fail(git_clone(&g_repo, LIVE_REPO_URL, "./foo", NULL, NULL, NULL));
- git_futils_rmdir_r("./foo", GIT_DIRREMOVAL_FILES_AND_DIRS);
+}
+
+void test_clone_clone__fail_with_already_existing_but_non_empty_directory(void)
+{
+ cl_set_cleanup(&cleanup_repository, "./foo");
- /* Should fail with existing-and-nonempty dir */
p_mkdir("./foo", GIT_DIR_MODE);
cl_git_mkfile("./foo/bar", "Baz!");
cl_git_fail(git_clone(&g_repo, LIVE_REPO_URL, "./foo", NULL, NULL, NULL));
- git_futils_rmdir_r("./foo", GIT_DIRREMOVAL_FILES_AND_DIRS);
+}
+
+void test_clone_clone__empty_repository(void)
+{
+#if DO_LIVE_NETWORK_TESTS
+ git_reference *head;
+
+ cl_set_cleanup(&cleanup_repository, "./empty");
+
+ cl_git_pass(git_clone(&g_repo, LIVE_EMPTYREPO_URL, "./empty", NULL, NULL, NULL));
+
+ cl_assert_equal_i(true, git_repository_is_empty(g_repo));
+ cl_assert_equal_i(true, git_repository_head_orphan(g_repo));
+
+ cl_git_pass(git_reference_lookup(&head, g_repo, GIT_HEAD_FILE));
+ cl_assert_equal_i(GIT_REF_SYMBOLIC, git_reference_type(head));
+ cl_assert_equal_s("refs/heads/master", git_reference_target(head));
+
+ git_reference_free(head);
+#endif
}
diff --git a/tests-clar/refs/branches/ishead.c b/tests-clar/refs/branches/ishead.c
new file mode 100644
index 0000000..c40a431
--- /dev/null
+++ b/tests-clar/refs/branches/ishead.c
@@ -0,0 +1,80 @@
+#include "clar_libgit2.h"
+#include "refs.h"
+
+static git_repository *repo;
+static git_reference *branch;
+
+void test_refs_branches_ishead__initialize(void)
+{
+ cl_git_pass(git_repository_open(&repo, cl_fixture("testrepo.git")));
+}
+
+void test_refs_branches_ishead__cleanup(void)
+{
+ git_reference_free(branch);
+ git_repository_free(repo);
+}
+
+void test_refs_branches_ishead__can_tell_if_a_branch_is_pointed_at_by_HEAD(void)
+{
+ cl_git_pass(git_reference_lookup(&branch, repo, "refs/heads/master"));
+
+ cl_assert_equal_i(true, git_branch_is_head(branch));
+}
+
+void test_refs_branches_ishead__can_tell_if_a_branch_is_not_pointed_at_by_HEAD(void)
+{
+ cl_git_pass(git_reference_lookup(&branch, repo, "refs/heads/br2"));
+
+ cl_assert_equal_i(false, git_branch_is_head(branch));
+}
+
+void test_refs_branches_ishead__wont_be_fooled_by_a_non_branch(void)
+{
+ cl_git_pass(git_reference_lookup(&branch, repo, "refs/tags/e90810b"));
+
+ cl_assert_equal_i(false, git_branch_is_head(branch));
+}
+
+/*
+ * $ git init .
+ * Initialized empty Git repository in d:/temp/tempee/.git/
+ *
+ * $ touch a && git add a
+ * $ git commit -m" boom"
+ * [master (root-commit) b47b758] boom
+ * 0 files changed
+ * create mode 100644 a
+ *
+ * $ echo "ref: refs/heads/master" > .git/refs/heads/linked
+ * $ echo "ref: refs/heads/linked" > .git/refs/heads/super
+ * $ echo "ref: refs/heads/super" > .git/HEAD
+ *
+ * $ git branch
+ * linked -> master
+ * * master
+ * super -> master
+ */
+void test_refs_branches_ishead__only_direct_references_are_considered(void)
+{
+ git_reference *linked, *super, *head;
+
+ git_repository_free(repo);
+ repo = cl_git_sandbox_init("testrepo.git");
+
+ cl_git_pass(git_reference_create_symbolic(&linked, repo, "refs/heads/linked", "refs/heads/master", 0));
+ cl_git_pass(git_reference_create_symbolic(&super, repo, "refs/heads/super", "refs/heads/linked", 0));
+ cl_git_pass(git_reference_create_symbolic(&head, repo, GIT_HEAD_FILE, "refs/heads/super", 1));
+
+ cl_assert_equal_i(false, git_branch_is_head(linked));
+ cl_assert_equal_i(false, git_branch_is_head(super));
+
+ cl_git_pass(git_repository_head(&branch, repo));
+ cl_assert_equal_s("refs/heads/master", git_reference_name(branch));
+
+ git_reference_free(linked);
+ git_reference_free(super);
+ git_reference_free(head);
+ cl_git_sandbox_cleanup();
+ repo = NULL;
+}
diff --git a/tests-clar/refs/branches/move.c b/tests-clar/refs/branches/move.c
index 6750473..9ab7da4 100644
--- a/tests-clar/refs/branches/move.c
+++ b/tests-clar/refs/branches/move.c
@@ -62,3 +62,16 @@ void test_refs_branches_move__can_force_move_over_an_existing_branch(void)
{
cl_git_pass(git_branch_move(ref, "master", 1));
}
+
+void test_refs_branches_move__moving_the_branch_pointed_at_by_HEAD_updates_HEAD(void)
+{
+ git_reference *branch;
+
+ cl_git_pass(git_reference_lookup(&branch, repo, "refs/heads/master"));
+ cl_git_pass(git_branch_move(branch, "master2", 0));
+ git_reference_free(branch);
+
+ cl_git_pass(git_repository_head(&branch, repo));
+ cl_assert_equal_s("refs/heads/master2", git_reference_name(branch));
+ git_reference_free(branch);
+}