Commit a4ffbae461999989bed33dcefeab7b80f775e450

Julian Ganz 2018-07-29T11:46:05

revwalk: remove tautologic condition for hiding a commit The contition cannot be reached with `commit->uninteresting` being true: either a `break` or a `continue` statement will be hit in this case.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/src/revwalk.c b/src/revwalk.c
index 072ae46..be647af 100644
--- a/src/revwalk.c
+++ b/src/revwalk.c
@@ -426,8 +426,8 @@ static int limit_list(git_commit_list **out, git_revwalk *walk, git_commit_list 
 			break;
 		}
 
-		if (!commit->uninteresting && walk->hide_cb && walk->hide_cb(&commit->oid, walk->hide_cb_payload))
-				continue;
+		if (walk->hide_cb && walk->hide_cb(&commit->oid, walk->hide_cb_payload))
+			continue;
 
 		time = commit->time;
 		p = &git_commit_list_insert(commit, p)->next;