Commit ae0ddc6f024c52d8a4144b31ff122b922d72aeb4

Ben Straub 2012-12-12T19:53:05

Merge pull request #1139 from ethomson/index_bugfix don't walk off the end of the index

diff --git a/src/index.c b/src/index.c
index 1e5b280..d4568aa 100644
--- a/src/index.c
+++ b/src/index.c
@@ -957,13 +957,14 @@ int git_index_conflict_remove(git_index *index, const char *path)
 			continue;
 		}
 
-		error = git_vector_remove(&index->entries, (unsigned int)pos);
+		if ((error = git_vector_remove(&index->entries, (unsigned int)pos)) < 0)
+			return error;
 
-		if (error >= 0)
-			index_entry_free(conflict_entry);
+		index_entry_free(conflict_entry);
+		posmax--;
 	}
 
-	return error;
+	return 0;
 }
 
 static int index_conflicts_match(const git_vector *v, size_t idx)