Commit b2559f477a3f8e2bc76140ca2c76d8cc30b5f5da

Carlos Martín Nieto 2014-05-08T17:14:59

pack: preallocate a 64-element chain Dependency chains are often large and require a few reallocations. Allocate a 64-element chain before doing anything else to avoid allocations during the loop. This value comes from the stack-allocated one git uses. We still allocate this on the heap, but it does help performance a little bit.

1
2
3
4
5
6
7
8
9
10
11
12
diff --git a/src/pack.c b/src/pack.c
index a8577d3..664e8ef 100644
--- a/src/pack.c
+++ b/src/pack.c
@@ -1236,6 +1236,7 @@ static int pack_dependency_chain(git_dependency_chain *chain_out, struct git_pac
 	if (!p->bases.entries && (cache_init(&p->bases) < 0))
 		return -1;
 
+	git_array_init_to_size(chain, 64);
 	while (!found_base && error == 0) {
 		struct pack_chain_elem *elem;
 		git_pack_cache_entry *cached = NULL;