Implement sending haves Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228
diff --git a/src/fetch.c b/src/fetch.c
index 59beb1e..c799c80 100644
--- a/src/fetch.c
+++ b/src/fetch.c
@@ -38,8 +38,8 @@
*/
static int whn_cmp(const void *a, const void *b)
{
- git_remote_head *heada = *(git_remote_head **)(a);
- git_remote_head *headb = *(git_remote_head **)(b);
+ git_remote_head *heada = (git_remote_head *) a;
+ git_remote_head *headb = (git_remote_head *) b;
return headb->type - heada->type;
}
@@ -57,7 +57,7 @@ int git_fetch_list_want(git_headarray *whn_list, git_repository *repo, git_remot
int error;
unsigned int i;
- error = git_vector_init(&list, whn_list->len, whn_cmp);
+ error = git_vector_init(&list, 16, whn_cmp);
if (error < GIT_SUCCESS)
return error;
@@ -182,8 +182,8 @@ int git_fetch_negotiate(git_headarray *list, git_repository *repo, git_remote *r
* Now we have everything set up so we can start tell the server
* what we want and what we have.
*/
- git_remote_send_wants(remote, list);
-
+ git_transport_send_wants(remote->transport, list);
+ git_transport_send_haves(remote->transport, repo);
cleanup:
git_revwalk_free(walk);
diff --git a/src/pkt.c b/src/pkt.c
index 06d1bc8..fbb5dfb 100644
--- a/src/pkt.c
+++ b/src/pkt.c
@@ -27,6 +27,8 @@
#include "git2/types.h"
#include "git2/errors.h"
+#include "git2/refs.h"
+#include "git2/revwalk.h"
#include "pkt.h"
#include "util.h"
@@ -229,9 +231,70 @@ int git_pkt_send_wants(git_headarray *refs, int fd)
for (i = 0; i < refs->len; ++i) {
head = refs->heads[i];
+ if (head->type != GIT_WHN_WANT)
+ continue;
+
git_oid_fmt(buf + STRLEN(WANT_PREFIX), &head->oid);
- printf("would send %s\n", buf);
+ printf("would send %s", buf);
+ }
+
+ /* TODO: git_pkt_send_flush(fd) */
+ printf("Wound send 0000\n");
+
+ return ret;
+}
+
+#define HAVE_PREFIX "0032have "
+
+int git_pkt_send_haves(git_repository *repo, int fd)
+{
+ unsigned int i;
+ int ret = GIT_SUCCESS;
+ char buf[STRLEN(HAVE_PREFIX) + GIT_OID_HEXSZ + 2];
+ git_oid oid;
+ git_revwalk *walk;
+ git_strarray refs;
+ git_reference *ref;
+ git_remote_head *head;
+
+ memcpy(buf, HAVE_PREFIX, STRLEN(HAVE_PREFIX));
+ buf[sizeof(buf) - 2] = '\n';
+ buf[sizeof(buf) - 1] = '\0';
+
+ ret = git_reference_listall(&refs, repo, GIT_REF_LISTALL);
+ if (ret < GIT_ERROR)
+ return git__rethrow(ret, "Failed to list all references");
+
+ ret = git_revwalk_new(&walk, repo);
+ if (ret < GIT_ERROR) {
+ ret = git__rethrow(ret, "Failed to list all references");
+ goto cleanup;
}
+ for (i = 0; i < refs.count; ++i) {
+ ret = git_reference_lookup(&ref, repo, refs.strings[i]);
+ if (ret < GIT_ERROR) {
+ ret = git__rethrow(ret, "Failed to lookup %s", refs.strings[i]);
+ goto cleanup;
+ }
+
+ ret = git_revwalk_push(walk, git_reference_oid(ref));
+ if (ret < GIT_ERROR) {
+ ret = git__rethrow(ret, "Failed to push %s", refs.strings[i]);
+ goto cleanup;
+ }
+ }
+
+ while ((ret = git_revwalk_next(&oid, walk)) == GIT_SUCCESS) {
+ git_oid_fmt(buf + STRLEN(HAVE_PREFIX), &oid);
+ printf("would send %s", buf);
+ }
+
+ /* TODO: git_pkt_send_flush(fd) */
+ printf("Wound send 0000\n");
+
+cleanup:
+ git_revwalk_free(walk);
+ git_strarray_free(&refs);
return ret;
}
diff --git a/src/pkt.h b/src/pkt.h
index 6dc5486..4340703 100644
--- a/src/pkt.h
+++ b/src/pkt.h
@@ -57,6 +57,8 @@ typedef struct {
int git_pkt_parse_line(git_pkt **head, const char *line, const char **out, size_t len);
int git_pkt_send_flush(int s);
+int git_pkt_send_haves(git_repository *repo, int fd);
+int git_pkt_send_wants(git_headarray *refs, int fd);
void git_pkt_free(git_pkt *pkt);
#endif
diff --git a/src/remote.c b/src/remote.c
index 997da00..2812f5d 100644
--- a/src/remote.c
+++ b/src/remote.c
@@ -31,11 +31,6 @@
#include "repository.h"
#include "remote.h"
-int git_remote_send_wants(git_remote *remote, git_headarray *list)
-{
- return git_transport_send_wants(remote->transport, list);
-}
-
static int refspec_parse(git_refspec *refspec, const char *str)
{
char *delim;
diff --git a/src/remote.h b/src/remote.h
index e0c3fbf..129671f 100644
--- a/src/remote.h
+++ b/src/remote.h
@@ -1,9 +1,9 @@
#ifndef INCLUDE_remote_h__
#define INCLUDE_remote_h__
-#include "remote.h"
#include "refspec.h"
#include "transport.h"
+#include "repository.h"
struct git_remote {
char *name;
@@ -13,6 +13,4 @@ struct git_remote {
git_transport *transport;
};
-int git_remote_send_wants(git_remote *remote, git_headarray *list);
-
#endif
diff --git a/src/transport.c b/src/transport.c
index 96b79dd..53caf9e 100644
--- a/src/transport.c
+++ b/src/transport.c
@@ -85,6 +85,11 @@ int git_transport_send_wants(struct git_transport *transport, git_headarray *arr
return transport->send_wants(transport, array);
}
+int git_transport_send_haves(struct git_transport *transport, git_repository *repo)
+{
+ return transport->send_haves(transport, repo);
+}
+
int git_transport_close(git_transport *transport)
{
return transport->close(transport);
diff --git a/src/transport.h b/src/transport.h
index 9105ea4..6e3501b 100644
--- a/src/transport.h
+++ b/src/transport.h
@@ -61,6 +61,10 @@ struct git_transport {
*/
int (*send_wants)(struct git_transport *transport, git_headarray *list);
/**
+ * Send the list of 'have' refs
+ */
+ int (*send_haves)(struct git_transport *transport, git_repository *repo);
+ /**
* Fetch the changes
*/
int (*fetch)(struct git_transport *transport);
diff --git a/src/transport_git.c b/src/transport_git.c
index 41b95ec..0453ca0 100644
--- a/src/transport_git.c
+++ b/src/transport_git.c
@@ -281,6 +281,13 @@ static int git_send_wants(git_transport *transport, git_headarray *array)
return git_pkt_send_wants(array, t->socket);
}
+static int git_send_haves(git_transport *transport, git_repository *repo)
+{
+ transport_git *t = (transport_git *) transport;
+
+ return git_pkt_send_haves(repo, t->socket);
+}
+
static int git_close(git_transport *transport)
{
transport_git *t = (transport_git*) transport;
@@ -326,6 +333,7 @@ int git_transport_git(git_transport **out)
t->parent.connect = git_connect;
t->parent.ls = git_ls;
t->parent.send_wants = git_send_wants;
+ t->parent.send_haves = git_send_haves;
t->parent.close = git_close;
t->parent.free = git_free;