Commit be0a1a79588c24b0cf032809c83d0b9cd167e0a9

Paul Holden 2013-12-08T02:03:05

commit: Fix potential segfault in git_commit_message Dereferencing commit pointer before asserting

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
diff --git a/src/commit.c b/src/commit.c
index bbb76f3..4ddfafb 100644
--- a/src/commit.c
+++ b/src/commit.c
@@ -276,10 +276,12 @@ GIT_COMMIT_GETTER(const git_oid *, tree_id, &commit->tree_id);
 
 const char *git_commit_message(const git_commit *commit)
 {
-	const char *message = commit->raw_message;
+	const char *message;
 
 	assert(commit);
 
+	message = commit->raw_message;
+
 	/* trim leading newlines from raw message */
 	while (*message && *message == '\n')
 		++message;