Add git notes API This commit adds basic git notes support to libgit2, namely: * git_note_read * git_note_message * git_note_oid * git_note_create * git_note_remove In the long run, we probably want to provide some convenience callback mechanism for merging and moving (filter-branch) notes. Signed-off-by: schu <schu-github@schulog.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662
diff --git a/include/git2.h b/include/git2.h
index d68a04e..e5b9bf5 100644
--- a/include/git2.h
+++ b/include/git2.h
@@ -41,4 +41,6 @@
#include "git2/status.h"
#include "git2/indexer.h"
+#include "git2/notes.h"
+
#endif
diff --git a/include/git2/notes.h b/include/git2/notes.h
new file mode 100644
index 0000000..1b5944f
--- /dev/null
+++ b/include/git2/notes.h
@@ -0,0 +1,97 @@
+/*
+ * Copyright (C) 2009-2012 the libgit2 contributors
+ *
+ * This file is part of libgit2, distributed under the GNU GPL v2 with
+ * a Linking Exception. For full terms see the included COPYING file.
+ */
+#ifndef INCLUDE_git_note_h__
+#define INCLUDE_git_note_h__
+
+#include "oid.h"
+
+/**
+ * @file git2/notes.h
+ * @brief Git notes management routines
+ * @defgroup git_note Git notes management routines
+ * @ingroup Git
+ * @{
+ */
+GIT_BEGIN_DECL
+
+/**
+ * Read the note for an object
+ *
+ * The note must be freed manually by the user.
+ *
+ * @param note the note; NULL in case of error
+ * @param repo the Git repository
+ * @param notes_ref OID reference to use (optional); defaults to "refs/notes/commits"
+ * @param oid OID of the object
+ *
+ * @return GIT_SUCCESS or an error code
+ */
+GIT_EXTERN(int) git_note_read(git_note **note, git_repository *repo,
+ const char *notes_ref, const git_oid *oid);
+
+/**
+ * Get the note message
+ *
+ * @param note
+ * @return the note message
+ */
+GIT_EXTERN(const char *) git_note_message(git_note *note);
+
+
+/**
+ * Get the note object OID
+ *
+ * @param note
+ * @return the note object OID
+ */
+GIT_EXTERN(const git_oid *) git_note_oid(git_note *note);
+
+
+/**
+ * Add a note for an object
+ *
+ * @param oid pointer to store the OID (optional); NULL in case of error
+ * @param repo the Git repository
+ * @param author signature of the notes commit author
+ * @param committer signature of the notes commit committer
+ * @param notes_ref OID reference to update (optional); defaults to "refs/notes/commits"
+ * @param oid The OID of the object
+ * @param oid The note to add for object oid
+ *
+ * @return GIT_SUCCESS or an error code
+ */
+GIT_EXTERN(int) git_note_create(git_oid *out, git_repository *repo,
+ git_signature *author, git_signature *committer,
+ const char *notes_ref, const git_oid *oid,
+ const char *note);
+
+
+/**
+ * Remove the note for an object
+ *
+ * @param repo the Git repository
+ * @param notes_ref OID reference to use (optional); defaults to "refs/notes/commits"
+ * @param author signature of the notes commit author
+ * @param committer signature of the notes commit committer
+ * @param oid the oid which note's to be removed
+ *
+ * @return GIT_SUCCESS or an error code
+ */
+GIT_EXTERN(int) git_note_remove(git_repository *repo, const char *notes_ref,
+ git_signature *author, git_signature *committer,
+ const git_oid *oid);
+
+/**
+ * Free a git_note object
+ *
+ * @param note git_note object
+ */
+GIT_EXTERN(void) git_note_free(git_note *note);
+
+/** @} */
+GIT_END_DECL
+#endif
diff --git a/include/git2/types.h b/include/git2/types.h
index 669e4cc..ffada63 100644
--- a/include/git2/types.h
+++ b/include/git2/types.h
@@ -131,6 +131,9 @@ typedef struct git_reflog_entry git_reflog_entry;
/** Representation of a reference log */
typedef struct git_reflog git_reflog;
+/** Representation of a git note */
+typedef struct git_note git_note;
+
/** Time in a signature */
typedef struct git_time {
git_time_t time; /** time in seconds from epoch */
diff --git a/src/notes.c b/src/notes.c
new file mode 100644
index 0000000..81fc003
--- /dev/null
+++ b/src/notes.c
@@ -0,0 +1,439 @@
+/*
+ * Copyright (C) 2009-2012 the libgit2 contributors
+ *
+ * This file is part of libgit2, distributed under the GNU GPL v2 with
+ * a Linking Exception. For full terms see the included COPYING file.
+ */
+
+#include "notes.h"
+
+#include "git2.h"
+#include "refs.h"
+
+static int find_subtree(git_tree **subtree, const git_oid *root,
+ git_repository *repo, const char *target, int *fanout)
+{
+ int error;
+ unsigned int i;
+ git_tree *tree;
+ const git_tree_entry *entry;
+
+ *subtree = NULL;
+
+ error = git_tree_lookup(&tree, repo, root);
+ if (error < GIT_SUCCESS) {
+ if (error == GIT_ENOTFOUND)
+ return error; /* notes tree doesn't exist yet */
+ return git__rethrow(error, "Failed to open notes tree");
+ }
+
+ for (i=0; i<git_tree_entrycount(tree); i++) {
+ entry = git_tree_entry_byindex(tree, i);
+
+ if (!git__ishex(git_tree_entry_name(entry)))
+ continue;
+
+ /*
+ * A notes tree follows a strict byte-based progressive fanout
+ * (i.e. using 2/38, 2/2/36, etc. fanouts, not e.g. 4/36 fanout)
+ */
+
+ if (S_ISDIR(git_tree_entry_attributes(entry))
+ && strlen(git_tree_entry_name(entry)) == 2
+ && !strncmp(git_tree_entry_name(entry), target + *fanout, 2)) {
+
+ /* found matching subtree - unpack and resume lookup */
+
+ git_oid subtree_sha;
+ git_oid_cpy(&subtree_sha, git_tree_entry_id(entry));
+ git_tree_free(tree);
+
+ *fanout += 2;
+
+ return find_subtree(subtree, &subtree_sha, repo,
+ target, fanout);
+ }
+ }
+
+ *subtree = tree;
+ return GIT_SUCCESS;
+}
+
+static int find_blob(git_oid *blob, git_tree *tree, const char *target)
+{
+ unsigned int i;
+ const git_tree_entry *entry;
+
+ for (i=0; i<git_tree_entrycount(tree); i++) {
+ entry = git_tree_entry_byindex(tree, i);
+
+ if (!strcmp(git_tree_entry_name(entry), target)) {
+ /* found matching note object - return */
+
+ git_oid_cpy(blob, git_tree_entry_id(entry));
+ return GIT_SUCCESS;
+ }
+ }
+ return GIT_ENOTFOUND;
+}
+
+static int note_write(git_oid *out, git_repository *repo,
+ git_signature *author, git_signature *committer,
+ const char *notes_ref, const char *note,
+ const git_oid *tree_sha, const char *target,
+ int nparents, git_commit **parents)
+{
+ int error, fanout = 0;
+ git_oid oid;
+ git_tree *tree = NULL;
+ git_tree_entry *entry;
+ git_treebuilder *tb;
+
+ /* check for existing notes tree */
+
+ if (tree_sha) {
+ error = find_subtree(&tree, tree_sha, repo, target, &fanout);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to lookup subtree");
+
+ error = find_blob(&oid, tree, target + fanout);
+ if (error < GIT_SUCCESS && error != GIT_ENOTFOUND) {
+ git_tree_free(tree);
+ return git__throw(GIT_ENOTFOUND, "Failed to read subtree %s", target);
+ }
+
+ if (error == GIT_SUCCESS) {
+ git_tree_free(tree);
+ return git__throw(GIT_EEXISTS, "Note for `%s` exists already", target);
+ }
+ }
+
+ /* no matching tree entry - add note object to target tree */
+
+ error = git_treebuilder_create(&tb, tree);
+ git_tree_free(tree);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to create treebuilder");
+
+ if (!tree_sha)
+ /* no notes tree yet - create fanout */
+ fanout += 2;
+
+ /* create note object */
+ error = git_blob_create_frombuffer(&oid, repo, note, strlen(note));
+ if (error < GIT_SUCCESS) {
+ git_treebuilder_free(tb);
+ return git__rethrow(error, "Failed to create note object");
+ }
+
+ error = git_treebuilder_insert(&entry, tb, target + fanout, &oid, 0100644);
+ if (error < GIT_SUCCESS) {
+ /* libgit2 doesn't support object removal (gc) yet */
+ /* we leave an orphaned blob object behind - TODO */
+
+ git_treebuilder_free(tb);
+ return git__rethrow(error, "Failed to insert note object");
+ }
+
+ if (out)
+ git_oid_cpy(out, git_tree_entry_id(entry));
+
+ error = git_treebuilder_write(&oid, repo, tb);
+ git_treebuilder_free(tb);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to write notes tree");
+
+ if (!tree_sha) {
+ /* create fanout subtree */
+
+ char subtree[3];
+ strncpy(subtree, target, 2);
+ subtree[2] = '\0';
+
+ error = git_treebuilder_create(&tb, NULL);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to create treebuilder");
+
+ error = git_treebuilder_insert(NULL, tb, subtree, &oid, 0040000);
+ if (error < GIT_SUCCESS) {
+ git_treebuilder_free(tb);
+ return git__rethrow(error, "Failed to insert note object");
+ }
+
+ error = git_treebuilder_write(&oid, repo, tb);
+ git_treebuilder_free(tb);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to write notes tree");
+ }
+
+ /* create new notes commit */
+
+ error = git_tree_lookup(&tree, repo, &oid);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to open new notes tree");
+
+ error = git_commit_create(&oid, repo, notes_ref, author, committer,
+ NULL, GIT_NOTES_DEFAULT_MSG_ADD,
+ tree, nparents, (const git_commit **) parents);
+
+ git_tree_free(tree);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to create new notes commit");
+
+ return GIT_SUCCESS;
+}
+
+static int note_lookup(git_note **out, git_repository *repo,
+ const git_oid *tree_sha, const char *target)
+{
+ int error, fanout = 0;
+ git_oid oid;
+ git_blob *blob;
+ git_tree *tree;
+ git_note *note;
+
+ error = find_subtree(&tree, tree_sha, repo, target, &fanout);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to lookup subtree");
+
+ error = find_blob(&oid, tree, target + fanout);
+ if (error < GIT_SUCCESS) {
+ git_tree_free(tree);
+ return git__throw(GIT_ENOTFOUND, "No note found for object %s",
+ target);
+ }
+ git_tree_free(tree);
+
+ error = git_blob_lookup(&blob, repo, &oid);
+ if (error < GIT_SUCCESS)
+ return git__throw(GIT_ERROR, "Failed to lookup note object");
+
+ note = git__malloc(sizeof(git_note));
+ if (note == NULL) {
+ git_blob_free(blob);
+ return GIT_ENOMEM;
+ }
+
+ git_oid_cpy(¬e->oid, &oid);
+ note->message = git__strdup(git_blob_rawcontent(blob));
+ if (note->message == NULL)
+ error = GIT_ENOMEM;
+
+ *out = note;
+
+ git_blob_free(blob);
+ return error;
+}
+
+static int note_remove(git_repository *repo,
+ git_signature *author, git_signature *committer,
+ const char *notes_ref, const git_oid *tree_sha,
+ const char *target, int nparents, git_commit **parents)
+{
+ int error, fanout = 0;
+ git_oid oid;
+ git_tree *tree;
+ git_treebuilder *tb;
+
+ error = find_subtree(&tree, tree_sha, repo, target, &fanout);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to lookup subtree");
+
+ error = find_blob(&oid, tree, target + fanout);
+ if (error < GIT_SUCCESS) {
+ git_tree_free(tree);
+ return git__throw(GIT_ENOTFOUND, "No note found for object %s",
+ target);
+ }
+
+ error = git_treebuilder_create(&tb, tree);
+ git_tree_free(tree);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to create treebuilder");
+
+ error = git_treebuilder_remove(tb, target + fanout);
+ if (error < GIT_SUCCESS) {
+ git_treebuilder_free(tb);
+ return git__rethrow(error, "Failed to remove entry from notes tree");
+ }
+
+ error = git_treebuilder_write(&oid, repo, tb);
+ git_treebuilder_free(tb);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to write notes tree");
+
+ /* create new notes commit */
+
+ error = git_tree_lookup(&tree, repo, &oid);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to open new notes tree");
+
+ error = git_commit_create(&oid, repo, notes_ref, author, committer,
+ NULL, GIT_NOTES_DEFAULT_MSG_RM,
+ tree, nparents, (const git_commit **) parents);
+
+ git_tree_free(tree);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to create new notes commit");
+
+ return error;
+}
+
+int git_note_read(git_note **out, git_repository *repo,
+ const char *notes_ref, const git_oid *oid)
+{
+ int error;
+ char *target;
+ git_reference *ref;
+ git_commit *commit;
+ const git_oid *sha;
+
+ *out = NULL;
+
+ if (!notes_ref)
+ notes_ref = GIT_NOTES_DEFAULT_REF;
+
+ error = git_reference_lookup(&ref, repo, notes_ref);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to lookup reference `%s`", notes_ref);
+
+ assert(git_ref_type(ref) == GIT_REF_OID);
+
+ sha = git_reference_oid(ref);
+ error = git_commit_lookup(&commit, repo, sha);
+
+ git_reference_free(ref);
+
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to find notes commit object");
+
+ sha = git_commit_tree_oid(commit);
+ git_commit_free(commit);
+
+ target = git_oid_allocfmt(oid);
+ if (target == NULL)
+ return GIT_ENOMEM;
+
+ error = note_lookup(out, repo, sha, target);
+
+ git__free(target);
+ return error == GIT_SUCCESS ? GIT_SUCCESS :
+ git__rethrow(error, "Failed to read note");
+}
+
+int git_note_create(git_oid *out, git_repository *repo,
+ git_signature *author, git_signature *committer,
+ const char *notes_ref, const git_oid *oid,
+ const char *note)
+{
+ int error, nparents = 0;
+ char *target;
+ git_oid sha;
+ git_commit *commit = NULL;
+ git_reference *ref;
+
+ if (!notes_ref)
+ notes_ref = GIT_NOTES_DEFAULT_REF;
+
+ error = git_reference_lookup(&ref, repo, notes_ref);
+ if (error < GIT_SUCCESS && error != GIT_ENOTFOUND)
+ return git__rethrow(error, "Failed to lookup reference `%s`", notes_ref);
+
+ if (error == GIT_SUCCESS) {
+ assert(git_ref_type(ref) == GIT_REF_OID);
+
+ /* lookup existing notes tree oid */
+
+ git_oid_cpy(&sha, git_reference_oid(ref));
+ git_reference_free(ref);
+
+ error = git_commit_lookup(&commit, repo, &sha);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to find notes commit object");
+
+ git_oid_cpy(&sha, git_commit_tree_oid(commit));
+ nparents++;
+ }
+
+ target = git_oid_allocfmt(oid);
+ if (target == NULL)
+ return GIT_ENOMEM;
+
+ error = note_write(out, repo, author, committer, notes_ref,
+ note, nparents ? &sha : NULL, target,
+ nparents, &commit);
+
+ git__free(target);
+ git_commit_free(commit);
+ return error == GIT_SUCCESS ? GIT_SUCCESS :
+ git__rethrow(error, "Failed to write note");
+}
+
+int git_note_remove(git_repository *repo, const char *notes_ref,
+ git_signature *author, git_signature *committer,
+ const git_oid *oid)
+{
+ int error;
+ char *target;
+ git_oid sha;
+ git_commit *commit;
+ git_reference *ref;
+
+ if (!notes_ref)
+ notes_ref = GIT_NOTES_DEFAULT_REF;
+
+ error = git_reference_lookup(&ref, repo, notes_ref);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to lookup reference `%s`", notes_ref);
+
+ assert(git_ref_type(ref) == GIT_REF_OID);
+
+ git_oid_cpy(&sha, git_reference_oid(ref));
+ git_reference_free(ref);
+
+ error = git_commit_lookup(&commit, repo, &sha);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to find notes commit object");
+
+ git_oid_cpy(&sha, git_commit_tree_oid(commit));
+
+ target = git_oid_allocfmt(oid);
+ if (target == NULL)
+ return GIT_ENOMEM;
+
+ error = note_remove(repo, author, committer, notes_ref,
+ &sha, target, 1, &commit);
+
+ git__free(target);
+ git_commit_free(commit);
+ return error == GIT_SUCCESS ? GIT_SUCCESS :
+ git__rethrow(error, "Failed to read note");
+}
+
+const char * git_note_message(git_note *note)
+{
+ assert(note);
+ return note->message;
+}
+
+const git_oid * git_note_oid(git_note *note)
+{
+ assert(note);
+ return ¬e->oid;
+}
+
+void git_note_free(git_note *note)
+{
+ if (note == NULL)
+ return;
+
+ git__free(note->message);
+ git__free(note);
+}
diff --git a/src/notes.h b/src/notes.h
new file mode 100644
index 0000000..219db1a
--- /dev/null
+++ b/src/notes.h
@@ -0,0 +1,28 @@
+/*
+ * Copyright (C) 2009-2012 the libgit2 contributors
+ *
+ * This file is part of libgit2, distributed under the GNU GPL v2 with
+ * a Linking Exception. For full terms see the included COPYING file.
+ */
+#ifndef INCLUDE_note_h__
+#define INCLUDE_note_h__
+
+#include "common.h"
+
+#include "git2/oid.h"
+
+#define GIT_NOTES_DEFAULT_REF "refs/notes/commits"
+
+#define GIT_NOTES_DEFAULT_MSG_ADD \
+ "Notes added by 'git_note_create' from libgit2"
+
+#define GIT_NOTES_DEFAULT_MSG_RM \
+ "Notes removed by 'git_note_remove' from libgit2"
+
+struct git_note {
+ git_oid oid;
+
+ char *message;
+};
+
+#endif /* INCLUDE_notes_h__ */
diff --git a/tests-clar/notes/notes.c b/tests-clar/notes/notes.c
new file mode 100644
index 0000000..eeb25ec
--- /dev/null
+++ b/tests-clar/notes/notes.c
@@ -0,0 +1,49 @@
+#include "clar_libgit2.h"
+
+static git_repository *_repo;
+static git_note *_note;
+static git_blob *_blob;
+static git_signature *_sig;
+
+void test_notes_notes__initialize(void)
+{
+ cl_fixture_sandbox("testrepo.git");
+ cl_git_pass(git_repository_open(&_repo, "testrepo.git"));
+}
+
+void test_notes_notes__cleanup(void)
+{
+ git_note_free(_note);
+ git_blob_free(_blob);
+ git_signature_free(_sig);
+
+ git_repository_free(_repo);
+ cl_fixture_cleanup("testrepo.git");
+}
+
+void test_notes_notes__1(void)
+{
+ git_oid oid, note_oid;
+
+ cl_git_pass(git_signature_now(&_sig, "alice", "alice@example.com"));
+
+ cl_git_pass(git_note_create(¬e_oid, _repo, _sig, _sig, "refs/notes/some/namespace", &oid, "hello world\n"));
+ cl_git_pass(git_note_create(¬e_oid, _repo, _sig, _sig, NULL, &oid, "hello world\n"));
+
+ cl_git_pass(git_note_read(&_note, _repo, NULL, &oid));
+
+ cl_assert(!strcmp(git_note_message(_note), "hello world\n"));
+ cl_assert(!git_oid_cmp(git_note_oid(_note), ¬e_oid));
+
+ cl_git_pass(git_blob_lookup(&_blob, _repo, ¬e_oid));
+ cl_assert(!strcmp(git_note_message(_note), git_blob_rawcontent(_blob)));
+
+ cl_git_fail(git_note_create(¬e_oid, _repo, _sig, _sig, NULL, &oid, "hello world\n"));
+ cl_git_fail(git_note_create(¬e_oid, _repo, _sig, _sig, "refs/notes/some/namespace", &oid, "hello world\n"));
+
+ cl_git_pass(git_note_remove(_repo, NULL, _sig, _sig, &oid));
+ cl_git_pass(git_note_remove(_repo, "refs/notes/some/namespace", _sig, _sig, &oid));
+
+ cl_git_fail(git_note_remove(_repo, NULL, _sig, _sig, ¬e_oid));
+ cl_git_fail(git_note_remove(_repo, "refs/notes/some/namespace", _sig, _sig, &oid));
+}