Refactor zlib for easier deflate streaming
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270
diff --git a/src/compress.c b/src/compress.c
deleted file mode 100644
index 14b7940..0000000
--- a/src/compress.c
+++ /dev/null
@@ -1,53 +0,0 @@
-/*
- * Copyright (C) the libgit2 contributors. All rights reserved.
- *
- * This file is part of libgit2, distributed under the GNU GPL v2 with
- * a Linking Exception. For full terms see the included COPYING file.
- */
-
-#include "compress.h"
-
-#include <zlib.h>
-
-#define BUFFER_SIZE (1024 * 1024)
-
-int git__compress(git_buf *buf, const void *buff, size_t len)
-{
- z_stream zs;
- char *zb;
- size_t have;
-
- memset(&zs, 0, sizeof(zs));
- if (deflateInit(&zs, Z_DEFAULT_COMPRESSION) != Z_OK)
- return -1;
-
- zb = git__malloc(BUFFER_SIZE);
- GITERR_CHECK_ALLOC(zb);
-
- zs.next_in = (void *)buff;
- zs.avail_in = (uInt)len;
-
- do {
- zs.next_out = (unsigned char *)zb;
- zs.avail_out = BUFFER_SIZE;
-
- if (deflate(&zs, Z_FINISH) == Z_STREAM_ERROR) {
- git__free(zb);
- return -1;
- }
-
- have = BUFFER_SIZE - (size_t)zs.avail_out;
-
- if (git_buf_put(buf, zb, have) < 0) {
- git__free(zb);
- return -1;
- }
-
- } while (zs.avail_out == 0);
-
- assert(zs.avail_in == 0);
-
- deflateEnd(&zs);
- git__free(zb);
- return 0;
-}
diff --git a/src/compress.h b/src/compress.h
deleted file mode 100644
index 49e6f47..0000000
--- a/src/compress.h
+++ /dev/null
@@ -1,16 +0,0 @@
-/*
- * Copyright (C) the libgit2 contributors. All rights reserved.
- *
- * This file is part of libgit2, distributed under the GNU GPL v2 with
- * a Linking Exception. For full terms see the included COPYING file.
- */
-#ifndef INCLUDE_compress_h__
-#define INCLUDE_compress_h__
-
-#include "common.h"
-
-#include "buffer.h"
-
-int git__compress(git_buf *buf, const void *buff, size_t len);
-
-#endif /* INCLUDE_compress_h__ */
diff --git a/src/indexer.c b/src/indexer.c
index 6132571..ccab8fc 100644
--- a/src/indexer.c
+++ b/src/indexer.c
@@ -5,8 +5,6 @@
* a Linking Exception. For full terms see the included COPYING file.
*/
-#include <zlib.h>
-
#include "git2/indexer.h"
#include "git2/object.h"
@@ -18,7 +16,7 @@
#include "filebuf.h"
#include "oid.h"
#include "oidmap.h"
-#include "compress.h"
+#include "zstream.h"
#define UINT31_MAX (0x7FFFFFFF)
@@ -662,7 +660,7 @@ static int inject_object(git_indexer *idx, git_oid *id)
idx->pack->mwf.size += hdr_len;
entry->crc = crc32(entry->crc, hdr, hdr_len);
- if ((error = git__compress(&buf, data, len)) < 0)
+ if ((error = git_zstream_deflatebuf(&buf, data, len)) < 0)
goto cleanup;
/* And then the compressed object */
diff --git a/src/pack-objects.c b/src/pack-objects.c
index 335944c..0d31d50 100644
--- a/src/pack-objects.c
+++ b/src/pack-objects.c
@@ -7,7 +7,7 @@
#include "pack-objects.h"
-#include "compress.h"
+#include "zstream.h"
#include "delta.h"
#include "iterator.h"
#include "netops.h"
@@ -319,7 +319,7 @@ static int write_object(git_buf *buf, git_packbuilder *pb, git_pobject *po)
/* Write data */
if (po->z_delta_size)
size = po->z_delta_size;
- else if (git__compress(&zbuf, data, size) < 0)
+ else if (git_zstream_deflatebuf(&zbuf, data, size) < 0)
goto on_error;
else {
if (po->delta)
@@ -931,7 +931,7 @@ static int find_deltas(git_packbuilder *pb, git_pobject **list,
* between writes at that moment.
*/
if (po->delta_data) {
- if (git__compress(&zbuf, po->delta_data, po->delta_size) < 0)
+ if (git_zstream_deflatebuf(&zbuf, po->delta_data, po->delta_size) < 0)
goto on_error;
git__free(po->delta_data);
diff --git a/src/zstream.c b/src/zstream.c
new file mode 100644
index 0000000..e043dd3
--- /dev/null
+++ b/src/zstream.c
@@ -0,0 +1,90 @@
+/*
+ * Copyright (C) the libgit2 contributors. All rights reserved.
+ *
+ * This file is part of libgit2, distributed under the GNU GPL v2 with
+ * a Linking Exception. For full terms see the included COPYING file.
+ */
+
+#include <zlib.h>
+
+#include "zstream.h"
+#include "buffer.h"
+
+#define BUFFER_SIZE (1024 * 1024)
+
+static int zstream_seterr(int zerr, git_zstream *zstream)
+{
+ if (zerr == Z_MEM_ERROR)
+ giterr_set_oom();
+ else if (zstream->msg)
+ giterr_set(GITERR_ZLIB, zstream->msg);
+ else
+ giterr_set(GITERR_ZLIB, "Unknown compression error");
+
+ return -1;
+}
+
+int git_zstream_init(git_zstream *zstream)
+{
+ int zerr;
+
+ if ((zerr = deflateInit(zstream, Z_DEFAULT_COMPRESSION)) != Z_OK)
+ return zstream_seterr(zerr, zstream);
+
+ return 0;
+}
+
+ssize_t git_zstream_deflate(void *out, size_t out_len, git_zstream *zstream, const void *in, size_t in_len)
+{
+ int zerr;
+
+ if ((ssize_t)out_len < 0)
+ out_len = INT_MAX;
+
+ zstream->next_in = (Bytef *)in;
+ zstream->avail_in = in_len;
+ zstream->next_out = out;
+ zstream->avail_out = out_len;
+
+ if ((zerr = deflate(zstream, Z_FINISH)) == Z_STREAM_ERROR)
+ return zstream_seterr(zerr, zstream);
+
+ return (out_len - zstream->avail_out);
+}
+
+void git_zstream_free(git_zstream *zstream)
+{
+ deflateEnd(zstream);
+}
+
+int git_zstream_deflatebuf(git_buf *out, const void *in, size_t in_len)
+{
+ git_zstream zstream = GIT_ZSTREAM_INIT;
+ size_t out_len;
+ ssize_t written;
+ int error = 0;
+
+ if ((error = git_zstream_init(&zstream)) < 0)
+ goto done;
+
+ do {
+ if (out->asize - out->size < BUFFER_SIZE)
+ git_buf_grow(out, out->asize + BUFFER_SIZE);
+
+ out_len = out->asize - out->size;
+
+ if ((written = git_zstream_deflate(out->ptr + out->size, out_len, &zstream, in, in_len)) <= 0)
+ break;
+
+ in = (char *)in + written;
+ in_len -= written;
+ out->size += written;
+ } while (written > 0);
+
+ if (written < 0)
+ error = written;
+
+done:
+ git_zstream_free(&zstream);
+ return error;
+}
diff --git a/src/zstream.h b/src/zstream.h
new file mode 100644
index 0000000..e6c8411
--- /dev/null
+++ b/src/zstream.h
@@ -0,0 +1,25 @@
+/*
+ * Copyright (C) the libgit2 contributors. All rights reserved.
+ *
+ * This file is part of libgit2, distributed under the GNU GPL v2 with
+ * a Linking Exception. For full terms see the included COPYING file.
+ */
+#ifndef INCLUDE_zstream_h__
+#define INCLUDE_zstream_h__
+
+#include <zlib.h>
+
+#include "common.h"
+#include "buffer.h"
+
+#define git_zstream z_stream
+
+#define GIT_ZSTREAM_INIT {0}
+
+int git_zstream_init(git_zstream *zstream);
+ssize_t git_zstream_deflate(void *out, size_t out_len, git_zstream *zstream, const void *in, size_t in_len);
+void git_zstream_free(git_zstream *zstream);
+
+int git_zstream_deflatebuf(git_buf *out, const void *in, size_t in_len);
+
+#endif /* INCLUDE_zstream_h__ */