git_revision -> git_revspec
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
diff --git a/include/git2/revparse.h b/include/git2/revparse.h
index 3e334b4..c0479c3 100644
--- a/include/git2/revparse.h
+++ b/include/git2/revparse.h
@@ -53,7 +53,7 @@ typedef struct {
git_object *from;
git_object *to;
unsigned int flags;
-} git_revision;
+} git_revspec;
/**
* Parse a revision string for left, right, and intent. See `man gitrevisions` or
@@ -72,7 +72,7 @@ typedef struct {
* @return 0 on success, GIT_INVALIDSPEC, GIT_ENOTFOUND, GIT_EAMBIGUOUS or an error code
*/
GIT_EXTERN(int) git_revparse(
- git_revision *revision,
+ git_revspec *revspec,
git_repository *repo,
const char *spec);
diff --git a/src/revparse.c b/src/revparse.c
index a4fedd2..74635ed 100644
--- a/src/revparse.c
+++ b/src/revparse.c
@@ -870,41 +870,41 @@ cleanup:
int git_revparse(
- git_revision *revision,
+ git_revspec *revspec,
git_repository *repo,
const char *spec)
{
const char *dotdot;
int error = 0;
- assert(revision && repo && spec);
+ assert(revspec && repo && spec);
- memset(revision, 0x0, sizeof(*revision));
+ memset(revspec, 0x0, sizeof(*revspec));
if ((dotdot = strstr(spec, "..")) != NULL) {
char *lstr;
const char *rstr;
- revision->flags = GIT_REVPARSE_RANGE;
+ revspec->flags = GIT_REVPARSE_RANGE;
lstr = git__substrdup(spec, dotdot - spec);
rstr = dotdot + 2;
if (dotdot[2] == '.') {
- revision->flags |= GIT_REVPARSE_MERGE_BASE;
+ revspec->flags |= GIT_REVPARSE_MERGE_BASE;
rstr++;
}
- if ((error = git_revparse_single(&revision->from, repo, lstr)) < 0) {
+ if ((error = git_revparse_single(&revspec->from, repo, lstr)) < 0) {
return error;
}
- if ((error = git_revparse_single(&revision->to, repo, rstr)) < 0) {
+ if ((error = git_revparse_single(&revspec->to, repo, rstr)) < 0) {
return error;
}
git__free((void*)lstr);
} else {
- revision->flags = GIT_REVPARSE_SINGLE;
- error = git_revparse_single(&revision->from, repo, spec);
+ revspec->flags = GIT_REVPARSE_SINGLE;
+ error = git_revparse_single(&revspec->from, repo, spec);
}
return error;
diff --git a/src/revwalk.c b/src/revwalk.c
index 9e32198..16f0662 100644
--- a/src/revwalk.c
+++ b/src/revwalk.c
@@ -231,26 +231,26 @@ int git_revwalk_push_ref(git_revwalk *walk, const char *refname)
int git_revwalk_push_range(git_revwalk *walk, const char *range)
{
- git_revision revision;
+ git_revspec revspec;
int error = 0;
- if ((error = git_revparse(&revision, walk->repo, range)))
+ if ((error = git_revparse(&revspec, walk->repo, range)))
return error;
- if (revision.flags & GIT_REVPARSE_MERGE_BASE) {
+ if (revspec.flags & GIT_REVPARSE_MERGE_BASE) {
/* TODO: support "<commit>...<commit>" */
giterr_set(GITERR_INVALID, "Symmetric differences not implemented in revwalk");
return GIT_EINVALIDSPEC;
}
- if ((error = push_commit(walk, git_object_id(revision.from), 1)))
+ if ((error = push_commit(walk, git_object_id(revspec.from), 1)))
goto out;
- error = push_commit(walk, git_object_id(revision.to), 0);
+ error = push_commit(walk, git_object_id(revspec.to), 0);
out:
- git_object_free(revision.from);
- git_object_free(revision.to);
+ git_object_free(revspec.from);
+ git_object_free(revspec.to);
return error;
}
diff --git a/tests-clar/refs/revparse.c b/tests-clar/refs/revparse.c
index ad52006..74472b1 100644
--- a/tests-clar/refs/revparse.c
+++ b/tests-clar/refs/revparse.c
@@ -34,28 +34,28 @@ static void test_id_inrepo(
git_revparse_mode_t expected_flags,
git_repository *repo)
{
- git_revision revision;
- int error = git_revparse(&revision, repo, spec);
+ git_revspec revspec;
+ int error = git_revparse(&revspec, repo, spec);
if (expected_left) {
char str[64] = {0};
cl_assert_equal_i(0, error);
- git_oid_fmt(str, git_object_id(revision.from));
+ git_oid_fmt(str, git_object_id(revspec.from));
cl_assert_equal_s(str, expected_left);
- git_object_free(revision.from);
+ git_object_free(revspec.from);
} else {
cl_assert_equal_i(GIT_ENOTFOUND, error);
}
if (expected_right) {
char str[64] = {0};
- git_oid_fmt(str, git_object_id(revision.to));
+ git_oid_fmt(str, git_object_id(revspec.to));
cl_assert_equal_s(str, expected_right);
- git_object_free(revision.to);
+ git_object_free(revspec.to);
}
if (expected_flags)
- cl_assert_equal_i(expected_flags, revision.flags);
+ cl_assert_equal_i(expected_flags, revspec.flags);
}
static void test_object(const char *spec, const char *expected_oid)
@@ -69,23 +69,23 @@ static void test_rangelike(const char *rangelike,
git_revparse_mode_t expected_revparseflags)
{
char objstr[64] = {0};
- git_revision revision;
+ git_revspec revspec;
int error;
- error = git_revparse(&revision, g_repo, rangelike);
+ error = git_revparse(&revspec, g_repo, rangelike);
if (expected_left != NULL) {
cl_assert_equal_i(0, error);
- cl_assert_equal_i(revision.flags, expected_revparseflags);
- git_oid_fmt(objstr, git_object_id(revision.from));
+ cl_assert_equal_i(revspec.flags, expected_revparseflags);
+ git_oid_fmt(objstr, git_object_id(revspec.from));
cl_assert_equal_s(objstr, expected_left);
- git_oid_fmt(objstr, git_object_id(revision.to));
+ git_oid_fmt(objstr, git_object_id(revspec.to));
cl_assert_equal_s(objstr, expected_right);
} else
cl_assert(error != 0);
- git_object_free(revision.from);
- git_object_free(revision.to);
+ git_object_free(revspec.from);
+ git_object_free(revspec.to);
}