Merge pull request #151 from carlosmn/root-commit. Support root commits
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124
diff --git a/src/commit.c b/src/commit.c
index 9621703..0c37ec5 100644
--- a/src/commit.c
+++ b/src/commit.c
@@ -224,9 +224,18 @@ int git_commit_create(
if (error < GIT_SUCCESS)
return error;
- if (git_reference_type(head) == GIT_REF_SYMBOLIC) {
- if ((error = git_reference_resolve(&head, head)) < GIT_SUCCESS)
+ error = git_reference_resolve(&head, head);
+ if (error < GIT_SUCCESS) {
+ if (error != GIT_ENOTFOUND)
return error;
+ /*
+ * The target of the reference was not found. This can happen
+ * just after a repository has been initialized (the master
+ * branch doesn't exist yet, as it doesn't have anything to
+ * point to) or after an orphan checkout, so if the target
+ * branch doesn't exist yet, create it and return.
+ */
+ return git_reference_create_oid_f(&head, repo, git_reference_target(head), oid);
}
error = git_reference_set_oid(head, oid);
diff --git a/src/refs.c b/src/refs.c
index 8c84540..ea96819 100644
--- a/src/refs.c
+++ b/src/refs.c
@@ -1482,8 +1482,9 @@ int git_reference_resolve(git_reference **resolved_ref, git_reference *ref)
for (i = 0; i < MAX_NESTING_LEVEL; ++i) {
reference_symbolic *ref_sym;
+ *resolved_ref = ref;
+
if (ref->type & GIT_REF_OID) {
- *resolved_ref = ref;
return GIT_SUCCESS;
}
diff --git a/tests/t04-commit.c b/tests/t04-commit.c
index 3e02df9..36f3e66 100644
--- a/tests/t04-commit.c
+++ b/tests/t04-commit.c
@@ -474,6 +474,72 @@ BEGIN_TEST(write0, "write a new commit object from memory to disk")
git_repository_free(repo);
END_TEST
+#define ROOT_COMMIT_MESSAGE "This is a root commit\n\
+This is a root commit and should be the only one in this branch\n"
+
+BEGIN_TEST(root0, "create a root commit")
+ git_repository *repo;
+ git_commit *commit;
+ git_oid tree_id, commit_id;
+ const git_oid *branch_oid;
+ const git_signature *author, *committer;
+ const char *branch_name = "refs/heads/root-commit-branch";
+ git_reference *head, *branch;
+ char *head_old;
+
+ must_pass(git_repository_open(&repo, REPOSITORY_FOLDER));
+
+ git_oid_mkstr(&tree_id, tree_oid);
+
+ /* create signatures */
+ committer = git_signature_new(COMMITTER_NAME, COMMITTER_EMAIL, 123456789, 60);
+ must_be_true(committer != NULL);
+
+ author = git_signature_new(COMMITTER_NAME, COMMITTER_EMAIL, 987654321, 90);
+ must_be_true(author != NULL);
+
+ /* First we need to update HEAD so it points to our non-existant branch */
+ must_pass(git_reference_lookup(&head, repo, "HEAD"));
+ must_be_true(git_reference_type(head) == GIT_REF_SYMBOLIC);
+ head_old = git__strdup(git_reference_target(head));
+ must_be_true(head_old != NULL);
+
+ must_pass(git_reference_set_target(head, branch_name));
+
+ must_pass(git_commit_create_v(
+ &commit_id, /* out id */
+ repo,
+ "HEAD",
+ author,
+ committer,
+ ROOT_COMMIT_MESSAGE,
+ &tree_id,
+ 0));
+
+ git_signature_free((git_signature *)committer);
+ git_signature_free((git_signature *)author);
+
+ /*
+ * The fact that creating a commit works has already been
+ * tested. Here we just make sure it's our commit and that it was
+ * written as a root commit.
+ */
+ must_pass(git_commit_lookup(&commit, repo, &commit_id));
+ must_be_true(git_commit_parentcount(commit) == 0);
+ must_pass(git_reference_lookup(&branch, repo, branch_name));
+ branch_oid = git_reference_oid(branch);
+ must_pass(git_oid_cmp(branch_oid, &commit_id));
+ must_be_true(!strcmp(git_commit_message(commit), ROOT_COMMIT_MESSAGE));
+
+ /* Remove the data we just added to the repo */
+ must_pass(git_reference_lookup(&head, repo, "HEAD"));
+ must_pass(git_reference_set_target(head, head_old));
+ must_pass(git_reference_delete(branch));
+ must_pass(remove_loose_object(REPOSITORY_FOLDER, (git_object *)commit));
+ free(head_old);
+ git_commit_close(commit);
+ git_repository_free(repo);
+END_TEST
BEGIN_SUITE(commit)
ADD_TEST(parse0);
@@ -483,4 +549,6 @@ BEGIN_SUITE(commit)
ADD_TEST(write0);
//ADD_TEST(write1);
+
+ ADD_TEST(root0);
END_SUITE