Commit cef170abf2704a3e3aa109020f7041e43b5e4f71

Russell Belfer 2014-03-14T16:45:46

Fix leak when using push and pop with ignores The iterator pushes and pops ignores incrementally onto a list as it traverses the directory structure so that it doesn't have to constantly recheck which ignore files apply. With the new ref counting, it wasn't decrementing the refcount on the ignores that it removed from the vector.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/src/ignore.c b/src/ignore.c
index 9b3c6a8..0fb042a 100644
--- a/src/ignore.c
+++ b/src/ignore.c
@@ -191,7 +191,10 @@ int git_ignore__pop_dir(git_ignores *ign)
 
 		if (ign->dir.size >= keylen &&
 			!memcmp(ign->dir.ptr + ign->dir.size - keylen, start, keylen))
+		{
+			git_attr_file__free(git_vector_last(&ign->ign_path));
 			git_vector_pop(&ign->ign_path);
+		}
 	}
 
 	if (--ign->depth > 0) {