Merge pull request #932 from ben/clone_pack_race ODB: re-load packfiles on failed lookup
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166
diff --git a/src/odb_pack.c b/src/odb_pack.c
index b4f958b..964e82a 100644
--- a/src/odb_pack.c
+++ b/src/odb_pack.c
@@ -24,7 +24,6 @@ struct pack_backend {
git_vector packs;
struct git_pack_file *last_found;
char *pack_folder;
- time_t pack_folder_mtime;
};
/**
@@ -237,6 +236,7 @@ static int packfile_refresh_all(struct pack_backend *backend)
{
int error;
struct stat st;
+ git_buf path = GIT_BUF_INIT;
if (backend->pack_folder == NULL)
return 0;
@@ -244,38 +244,33 @@ static int packfile_refresh_all(struct pack_backend *backend)
if (p_stat(backend->pack_folder, &st) < 0 || !S_ISDIR(st.st_mode))
return git_odb__error_notfound("failed to refresh packfiles", NULL);
- if (st.st_mtime != backend->pack_folder_mtime) {
- git_buf path = GIT_BUF_INIT;
- git_buf_sets(&path, backend->pack_folder);
+ git_buf_sets(&path, backend->pack_folder);
- /* reload all packs */
- error = git_path_direach(&path, packfile_load__cb, (void *)backend);
+ /* reload all packs */
+ error = git_path_direach(&path, packfile_load__cb, (void *)backend);
- git_buf_free(&path);
+ git_buf_free(&path);
- if (error < 0)
- return error;
+ if (error < 0)
+ return error;
- git_vector_sort(&backend->packs);
- backend->pack_folder_mtime = st.st_mtime;
- }
+ git_vector_sort(&backend->packs);
return 0;
}
-static int pack_entry_find(struct git_pack_entry *e, struct pack_backend *backend, const git_oid *oid)
+static int pack_entry_find_inner(
+ struct git_pack_entry *e,
+ struct pack_backend *backend,
+ const git_oid *oid,
+ struct git_pack_file *last_found)
{
- int error;
unsigned int i;
- struct git_pack_file *last_found = backend->last_found;
if (last_found &&
git_pack_entry_find(e, last_found, oid, GIT_OID_HEXSZ) == 0)
return 0;
- if ((error = packfile_refresh_all(backend)) < 0)
- return error;
-
for (i = 0; i < backend->packs.length; ++i) {
struct git_pack_file *p;
@@ -289,22 +284,38 @@ static int pack_entry_find(struct git_pack_entry *e, struct pack_backend *backen
}
}
- return git_odb__error_notfound("failed to find pack entry", oid);
+ return -1;
}
-static int pack_entry_find_prefix(
- struct git_pack_entry *e,
- struct pack_backend *backend,
- const git_oid *short_oid,
- size_t len)
+static int pack_entry_find(struct git_pack_entry *e, struct pack_backend *backend, const git_oid *oid)
{
int error;
- unsigned int i;
- unsigned found = 0;
struct git_pack_file *last_found = backend->last_found;
+ if (backend->last_found &&
+ git_pack_entry_find(e, backend->last_found, oid, GIT_OID_HEXSZ) == 0)
+ return 0;
+
+ if (!pack_entry_find_inner(e, backend, oid, last_found))
+ return 0;
if ((error = packfile_refresh_all(backend)) < 0)
return error;
+ if (!pack_entry_find_inner(e, backend, oid, last_found))
+ return 0;
+
+ return git_odb__error_notfound("failed to find pack entry", oid);
+}
+
+static unsigned pack_entry_find_prefix_inner(
+ struct git_pack_entry *e,
+ struct pack_backend *backend,
+ const git_oid *short_oid,
+ size_t len,
+ struct git_pack_file *last_found)
+{
+ int error;
+ unsigned int i;
+ unsigned found = 0;
if (last_found) {
error = git_pack_entry_find(e, last_found, short_oid, len);
@@ -331,6 +342,26 @@ static int pack_entry_find_prefix(
}
}
+ return found;
+}
+
+static int pack_entry_find_prefix(
+ struct git_pack_entry *e,
+ struct pack_backend *backend,
+ const git_oid *short_oid,
+ size_t len)
+{
+ unsigned found = 0;
+ int error;
+ struct git_pack_file *last_found = backend->last_found;
+
+ if ((found = pack_entry_find_prefix_inner(e, backend, short_oid, len, last_found)) > 0)
+ goto cleanup;
+ if ((error = packfile_refresh_all(backend)) < 0)
+ return error;
+ found = pack_entry_find_prefix_inner(e, backend, short_oid, len, last_found);
+
+cleanup:
if (!found)
return git_odb__error_notfound("no matching pack entry for prefix", short_oid);
else if (found > 1)
@@ -515,7 +546,6 @@ int git_odb_backend_pack(git_odb_backend **backend_out, const char *objects_dir)
if (git_path_isdir(git_buf_cstr(&path)) == true) {
backend->pack_folder = git_buf_detach(&path);
- backend->pack_folder_mtime = 0;
}
backend->parent.read = &pack_backend__read;
diff --git a/tests-clar/clone/clone.c b/tests-clar/clone/clone.c
index 4cca15f..237e607 100644
--- a/tests-clar/clone/clone.c
+++ b/tests-clar/clone/clone.c
@@ -5,7 +5,7 @@
#define DO_LOCAL_TEST 0
#define DO_LIVE_NETWORK_TESTS 0
-#define LIVE_REPO_URL "http://github.com/libgit2/node-gitteh"
+#define LIVE_REPO_URL "git://github.com/nulltoken/TestGitRepository"
static git_repository *g_repo;