Commit d10c846e4e91fc299de194b3d4dd76fc4451cf67

Christoph Thelen 2020-08-27T21:47:48

Fix crash in git_describe_commit when opts are NULL. The argument "opts" can be NULL, which selects default options. Do not access "opts" directly but only the normalized copy.

1
2
3
4
5
6
7
8
9
10
11
12
13
diff --git a/src/describe.c b/src/describe.c
index c8a1752..8beffde 100644
--- a/src/describe.c
+++ b/src/describe.c
@@ -685,7 +685,7 @@ int git_describe_commit(
 			get_name, &data)) < 0)
 				goto cleanup;
 
-	if (git_oidmap_size(data.names) == 0 && !opts->show_commit_oid_as_fallback) {
+	if (git_oidmap_size(data.names) == 0 && !normalized.show_commit_oid_as_fallback) {
 		git_error_set(GIT_ERROR_DESCRIBE, "cannot describe - "
 			"no reference found, cannot describe anything.");
 		error = -1;