Copy custom_headers insteach of referencing the caller's copy
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120
diff --git a/src/remote.c b/src/remote.c
index 84b8d59..2f8ffcb 100644
--- a/src/remote.c
+++ b/src/remote.c
@@ -689,7 +689,7 @@ int set_transport_callbacks(git_transport *t, const git_remote_callbacks *cbs)
static int set_transport_custom_headers(git_transport *t, const git_strarray *custom_headers)
{
- if (!t->set_custom_headers || !custom_headers)
+ if (!t->set_custom_headers)
return 0;
return t->set_custom_headers(t, custom_headers);
diff --git a/src/transports/http.c b/src/transports/http.c
index 73ea050..e5f2b9f 100644
--- a/src/transports/http.c
+++ b/src/transports/http.c
@@ -211,11 +211,9 @@ static int gen_request(
} else
git_buf_puts(buf, "Accept: */*\r\n");
- if (t->owner->custom_headers) {
- for (i = 0; i < t->owner->custom_headers->count; i++) {
- if (t->owner->custom_headers->strings[i])
- git_buf_printf(buf, "%s\r\n", t->owner->custom_headers->strings[i]);
- }
+ for (i = 0; i < t->owner->custom_headers.count; i++) {
+ if (t->owner->custom_headers.strings[i])
+ git_buf_printf(buf, "%s\r\n", t->owner->custom_headers.strings[i]);
}
/* Apply credentials to the request */
diff --git a/src/transports/smart.c b/src/transports/smart.c
index 8c5bc89..b0611c3 100644
--- a/src/transports/smart.c
+++ b/src/transports/smart.c
@@ -124,6 +124,12 @@ static int git_smart__set_custom_headers(
transport_smart *t = (transport_smart *)transport;
size_t i;
+ if (t->custom_headers.count)
+ git_strarray_free(&t->custom_headers);
+
+ if (!custom_headers)
+ return 0;
+
for (i = 0; i < custom_headers->count; i++) {
if (is_malformed_http_header(custom_headers->strings[i])) {
giterr_set(GITERR_INVALID, "custom HTTP header '%s' is malformed", custom_headers->strings[i]);
@@ -135,9 +141,7 @@ static int git_smart__set_custom_headers(
}
}
- t->custom_headers = custom_headers;
-
- return 0;
+ return git_strarray_copy(&t->custom_headers, custom_headers);
}
int git_smart__update_heads(transport_smart *t, git_vector *symrefs)
@@ -436,6 +440,8 @@ static void git_smart__free(git_transport *transport)
git_vector_free(refs);
+ git_strarray_free(&t->custom_headers);
+
git__free(t);
}
diff --git a/src/transports/smart.h b/src/transports/smart.h
index 2c87e02..800466a 100644
--- a/src/transports/smart.h
+++ b/src/transports/smart.h
@@ -139,7 +139,7 @@ typedef struct {
git_transport_message_cb error_cb;
git_transport_certificate_check_cb certificate_check_cb;
void *message_cb_payload;
- const git_strarray *custom_headers;
+ git_strarray custom_headers;
git_smart_subtransport *wrapped;
git_smart_subtransport_stream *current_stream;
transport_smart_caps caps;
diff --git a/src/transports/winhttp.c b/src/transports/winhttp.c
index 5b00d90..b364e90 100644
--- a/src/transports/winhttp.c
+++ b/src/transports/winhttp.c
@@ -410,21 +410,19 @@ static int winhttp_stream_connect(winhttp_stream *s)
}
}
- if (t->owner->custom_headers) {
- for (i = 0; i < t->owner->custom_headers->count; i++) {
- if (t->owner->custom_headers->strings[i]) {
- git_buf_clear(&buf);
- git_buf_puts(&buf, t->owner->custom_headers->strings[i]);
- if (git__utf8_to_16(ct, MAX_CONTENT_TYPE_LEN, git_buf_cstr(&buf)) < 0) {
- giterr_set(GITERR_OS, "Failed to convert custom header to wide characters");
- goto on_error;
- }
+ for (i = 0; i < t->owner->custom_headers.count; i++) {
+ if (t->owner->custom_headers.strings[i]) {
+ git_buf_clear(&buf);
+ git_buf_puts(&buf, t->owner->custom_headers.strings[i]);
+ if (git__utf8_to_16(ct, MAX_CONTENT_TYPE_LEN, git_buf_cstr(&buf)) < 0) {
+ giterr_set(GITERR_OS, "Failed to convert custom header to wide characters");
+ goto on_error;
+ }
- if (!WinHttpAddRequestHeaders(s->request, ct, (ULONG)-1L,
- WINHTTP_ADDREQ_FLAG_ADD | WINHTTP_ADDREQ_FLAG_REPLACE)) {
- giterr_set(GITERR_OS, "Failed to add a header to the request");
- goto on_error;
- }
+ if (!WinHttpAddRequestHeaders(s->request, ct, (ULONG)-1L,
+ WINHTTP_ADDREQ_FLAG_ADD | WINHTTP_ADDREQ_FLAG_REPLACE)) {
+ giterr_set(GITERR_OS, "Failed to add a header to the request");
+ goto on_error;
}
}
}