Commit e23c0b18e68f1912c5c6e55b216967c7d257a92d
2019-08-02T07:52:58
remote: remove unused block of code In "remote.c", we have a chunk of code that is #ifdef'fed out via `#if 0` with a comment that we could export it as a helper function. The code was implemented in 2013 and ifdef'fed in 2014, which shows that there's clearly no interest in having such a helper at all. As this block has recently created some confusion about `p_getenv` due to it containing the only reference to that function in our codebase, let's remove this block altogether.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
diff --git a/src/remote.c b/src/remote.c
index 8e8dda8..19aa45d 100644
--- a/src/remote.c
+++ b/src/remote.c
@@ -136,35 +136,6 @@ cleanup:
return 0;
}
-#if 0
-/* We could export this as a helper */
-static int get_check_cert(int *out, git_repository *repo)
-{
- git_config *cfg;
- const char *val;
- int error = 0;
-
- assert(out && repo);
-
- /* By default, we *DO* want to verify the certificate. */
- *out = 1;
-
- /* Go through the possible sources for SSL verification settings, from
- * most specific to least specific. */
-
- /* GIT_SSL_NO_VERIFY environment variable */
- if ((val = p_getenv("GIT_SSL_NO_VERIFY")) != NULL)
- return git_config_parse_bool(out, val);
-
- /* http.sslVerify config setting */
- if ((error = git_repository_config__weakptr(&cfg, repo)) < 0)
- return error;
-
- *out = git_config__get_bool_force(cfg, "http.sslverify", 1);
- return 0;
-}
-#endif
-
static int canonicalize_url(git_buf *out, const char *in)
{
if (in == NULL || strlen(in) == 0) {