Commit e2b3dc16b904b4989e076ec263da429724e7294b

Etienne Samson 2017-01-23T13:29:47

variable 'i' is used uninitialized whenever 'if' condition is true

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
diff --git a/src/submodule.c b/src/submodule.c
index 21e3d45..e1f59b8 100644
--- a/src/submodule.c
+++ b/src/submodule.c
@@ -349,9 +349,10 @@ done:
 static int submodules_from_index(git_strmap *map, git_index *idx, git_config *cfg)
 {
 	int error;
-	git_iterator *i;
+	git_iterator *i = NULL;
 	const git_index_entry *entry;
 	git_strmap *names = 0;
+
 	git_strmap_alloc(&names);
 	if ((error = load_submodule_names(names, cfg)))
 		goto done;