Commit e536fa33749f155e23469325cda1d66ede7ea97a

Edward Thomson 2017-08-14T21:59:11

Merge pull request #4326 from libgit2/peff/binary-search-do-while sha1_position: convert do-while to while

diff --git a/src/sha1_lookup.c b/src/sha1_lookup.c
index ead26de..60a7444 100644
--- a/src/sha1_lookup.c
+++ b/src/sha1_lookup.c
@@ -232,7 +232,7 @@ int sha1_position(const void *table,
 {
 	const unsigned char *base = table;
 
-	do {
+	while (lo < hi) {
 		unsigned mi = (lo + hi) / 2;
 		int cmp = git_oid__hashcmp(base + mi * stride, key);
 
@@ -243,7 +243,7 @@ int sha1_position(const void *table,
 			hi = mi;
 		else
 			lo = mi+1;
-	} while (lo < hi);
+	}
 
 	return -((int)lo)-1;
 }