Merge pull request #2552 from KindDragon/master Several CppCat warnings fixed
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
diff --git a/src/blame.c b/src/blame.c
index eb977c2..2cc5e55 100644
--- a/src/blame.c
+++ b/src/blame.c
@@ -316,7 +316,6 @@ static int blame_internal(git_blame *blame)
ent->suspect = o;
blame->ent = ent;
- blame->path = blame->path;
git_blame__like_git(blame, blame->options.flags);
diff --git a/src/pack.c b/src/pack.c
index b05aa91..7c1cfe0 100644
--- a/src/pack.c
+++ b/src/pack.c
@@ -648,9 +648,6 @@ int git_packfile_unpack(
base_type = elem->type;
}
- if (error < 0)
- goto cleanup;
-
switch (base_type) {
case GIT_OBJ_COMMIT:
case GIT_OBJ_TREE:
diff --git a/src/stash.c b/src/stash.c
index 86e0a62..22f756e 100644
--- a/src/stash.c
+++ b/src/stash.c
@@ -634,7 +634,8 @@ int git_stash_drop(
entry = git_reflog_entry_byindex(reflog, 0);
git_reference_free(stash);
- if ((error = git_reference_create(&stash, repo, GIT_REFS_STASH_FILE, &entry->oid_cur, 1, NULL, NULL) < 0))
+ error = git_reference_create(&stash, repo, GIT_REFS_STASH_FILE, &entry->oid_cur, 1, NULL, NULL);
+ if (error < 0)
goto cleanup;
/* We need to undo the writing that we just did */
diff --git a/src/transports/smart_protocol.c b/src/transports/smart_protocol.c
index 8289116..5ca5065 100644
--- a/src/transports/smart_protocol.c
+++ b/src/transports/smart_protocol.c
@@ -314,7 +314,7 @@ static int wait_while_ack(gitno_buffer *buf)
break;
if (pkt->type == GIT_PKT_ACK &&
- (pkt->status != GIT_ACK_CONTINUE ||
+ (pkt->status != GIT_ACK_CONTINUE &&
pkt->status != GIT_ACK_COMMON)) {
git__free(pkt);
return 0;