fileutils: Finish dropping the old `prettify_path`
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552
diff --git a/src/fileops.c b/src/fileops.c
index fa45fde..52aeb41 100644
--- a/src/fileops.c
+++ b/src/fileops.c
@@ -306,153 +306,6 @@ int git_futils_mkdir_r(const char *path, int mode)
return GIT_SUCCESS;
}
-static int retrieve_previous_path_component_start(const char *path)
-{
- int offset, len, root_offset, start = 0;
-
- root_offset = git_path_root(path);
- if (root_offset > -1)
- start += root_offset;
-
- len = strlen(path);
- offset = len - 1;
-
- /* Skip leading slash */
- if (path[start] == '/')
- start++;
-
- /* Skip trailing slash */
- if (path[offset] == '/')
- offset--;
-
- if (offset < root_offset)
- return git__throw(GIT_ERROR, "Failed to retrieve path component. Wrong offset");
-
- while (offset > start && path[offset-1] != '/') {
- offset--;
- }
-
- return offset;
-}
-
-int git_futils_prettify_dir(char *buffer_out, size_t size, const char *path, const char *base_path)
-{
- int len = 0, segment_len, only_dots, root_path_offset, error = GIT_SUCCESS;
- char *current;
- const char *buffer_out_start, *buffer_end;
-
- current = (char *)path;
- buffer_end = path + strlen(path);
- buffer_out_start = buffer_out;
-
- root_path_offset = git_path_root(path);
- if (root_path_offset < 0) {
- if (base_path == NULL) {
- error = p_getcwd(buffer_out, size);
- if (error < GIT_SUCCESS)
- return error; /* The callee already takes care of setting the correct error message. */
- } else {
- if (size < (strlen(base_path) + 1) * sizeof(char))
- return git__throw(GIT_EOVERFLOW, "Failed to prettify dir path: the base path is too long for the buffer.");
-
- strcpy(buffer_out, base_path);
- git_path_mkposix(buffer_out);
- git_path_join(buffer_out, buffer_out, "");
- }
-
- len = strlen(buffer_out);
- buffer_out += len;
- }
-
- while (current < buffer_end) {
- /* Prevent multiple slashes from being added to the output */
- if (*current == '/' && len > 0 && buffer_out_start[len - 1] == '/') {
- current++;
- continue;
- }
-
- only_dots = 1;
- segment_len = 0;
-
- /* Copy path segment to the output */
- while (current < buffer_end && *current != '/')
- {
- only_dots &= (*current == '.');
- *buffer_out++ = *current++;
- segment_len++;
- len++;
- }
-
- /* Skip current directory */
- if (only_dots && segment_len == 1)
- {
- current++;
- buffer_out -= segment_len;
- len -= segment_len;
- continue;
- }
-
- /* Handle the double-dot upward directory navigation */
- if (only_dots && segment_len == 2)
- {
- current++;
- buffer_out -= segment_len;
-
- *buffer_out ='\0';
- len = retrieve_previous_path_component_start(buffer_out_start);
-
- /* Are we escaping out of the root dir? */
- if (len < 0)
- return git__throw(GIT_EINVALIDPATH, "Failed to normalize path `%s`. The path escapes out of the root directory", path);
-
- buffer_out = (char *)buffer_out_start + len;
- continue;
- }
-
- /* Guard against potential multiple dot path traversal (cf http://cwe.mitre.org/data/definitions/33.html) */
- if (only_dots && segment_len > 0)
- return git__throw(GIT_EINVALIDPATH, "Failed to normalize path `%s`. The path contains a segment with three `.` or more", path);
-
- *buffer_out++ = '/';
- len++;
- }
-
- *buffer_out = '\0';
- return GIT_SUCCESS;
-}
-
-int git_futils_prettyify_file(char *buffer_out, size_t size, const char *path, const char *base_path)
-{
- int error, path_len, i, root_offset;
- const char* pattern = "/..";
-
- path_len = strlen(path);
-
- /* Let's make sure the filename isn't empty nor a dot */
- if (path_len == 0 || (path_len == 1 && *path == '.'))
- return git__throw(GIT_EINVALIDPATH, "Failed to normalize file path `%s`. The path is either empty or equals `.`", path);
-
- /* Let's make sure the filename doesn't end with "/", "/." or "/.." */
- for (i = 1; path_len > i && i < 4; i++) {
- if (!strncmp(path + path_len - i, pattern, i))
- return git__throw(GIT_EINVALIDPATH, "Failed to normalize file path `%s`. The path points to a folder", path);
- }
-
- error = git_futils_prettify_dir(buffer_out, size, path, base_path);
- if (error < GIT_SUCCESS)
- return error; /* The callee already takes care of setting the correct error message. */
-
- path_len = strlen(buffer_out);
- root_offset = git_path_root(buffer_out) + 1;
- if (path_len == root_offset)
- return git__throw(GIT_EINVALIDPATH, "Failed to normalize file path `%s`. The path points to a folder", path);
-
- /* Remove the trailing slash */
- buffer_out[path_len - 1] = '\0';
-
- return GIT_SUCCESS;
-}
-
int git_futils_cmp_path(const char *name1, int len1, int isdir1,
const char *name2, int len2, int isdir2)
{
diff --git a/src/fileops.h b/src/fileops.h
index c9ede49..4bfebe9 100644
--- a/src/fileops.h
+++ b/src/fileops.h
@@ -149,54 +149,4 @@ extern int git_futils_direach(
extern int git_futils_cmp_path(const char *name1, int len1, int isdir1,
const char *name2, int len2, int isdir2);
-
-/**
- * Clean up a provided absolute or relative directory path.
- *
- * This prettification relies on basic operations such as coalescing
- * multiple forward slashes into a single slash, removing '.' and
- * './' current directory segments, and removing parent directory
- * whenever '..' is encountered.
- *
- * If not empty, the returned path ends with a forward slash.
- *
- * For instance, this will turn "d1/s1///s2/..//../s3" into "d1/s3/".
- *
- * This only performs a string based analysis of the path.
- * No checks are done to make sure the path actually makes sense from
- * the file system perspective.
- *
- * @param buffer_out buffer to populate with the normalized path.
- * @param size buffer size.
- * @param path directory path to clean up.
- * @return
- * - GIT_SUCCESS on success;
- * - GIT_ERROR when the input path is invalid or escapes the current directory.
- */
-int git_futils_prettify_dir(char *buffer_out, size_t size, const char *path, const char *base_path);
-
-/**
- * Clean up a provided absolute or relative file path.
- *
- * This prettification relies on basic operations such as coalescing
- * multiple forward slashes into a single slash, removing '.' and
- * './' current directory segments, and removing parent directory
- * whenever '..' is encountered.
- *
- * For instance, this will turn "d1/s1///s2/..//../s3" into "d1/s3".
- *
- * This only performs a string based analysis of the path.
- * No checks are done to make sure the path actually makes sense from
- * the file system perspective.
- *
- * @param buffer_out buffer to populate with the normalized path.
- * @param size buffer size.
- * @param path file path to clean up.
- * @return
- * - GIT_SUCCESS on success;
- * - GIT_ERROR when the input path is invalid or escapes the current directory.
- */
-int git_futils_prettyify_file(char *buffer_out, size_t size, const char *path, const char *base_path);
-
-
#endif /* INCLUDE_fileops_h__ */
diff --git a/src/repository.c b/src/repository.c
index c820608..dac2cbb 100644
--- a/src/repository.c
+++ b/src/repository.c
@@ -67,7 +67,7 @@ static int assign_repository_dirs(
if (git_dir == NULL)
return git__throw(GIT_ENOTFOUND, "Failed to open repository. Git dir not found");
- error = git_futils_prettify_dir(path_aux, sizeof(path_aux), git_dir, NULL);
+ error = git_path_prettify_dir(path_aux, git_dir, NULL);
if (error < GIT_SUCCESS)
return git__rethrow(error, "Failed to open repository");
@@ -80,7 +80,7 @@ static int assign_repository_dirs(
if (git_object_directory == NULL)
git_path_join(path_aux, repo->path_repository, GIT_OBJECTS_DIR);
else {
- error = git_futils_prettify_dir(path_aux, sizeof(path_aux), git_object_directory, NULL);
+ error = git_path_prettify_dir(path_aux, git_object_directory, NULL);
if (error < GIT_SUCCESS)
return git__rethrow(error, "Failed to open repository");
}
@@ -94,7 +94,7 @@ static int assign_repository_dirs(
if (git_work_tree == NULL)
repo->is_bare = 1;
else {
- error = git_futils_prettify_dir(path_aux, sizeof(path_aux), git_work_tree, NULL);
+ error = git_path_prettify_dir(path_aux, git_work_tree, NULL);
if (error < GIT_SUCCESS)
return git__rethrow(error, "Failed to open repository");
@@ -107,7 +107,7 @@ static int assign_repository_dirs(
if (git_index_file == NULL)
git_path_join(path_aux, repo->path_repository, GIT_INDEX_FILE);
else {
- error = git_futils_prettyify_file(path_aux, sizeof(path_aux), git_index_file, NULL);
+ error = git_path_prettify(path_aux, git_index_file, NULL);
if (error < GIT_SUCCESS)
return git__rethrow(error, "Failed to open repository");
}
@@ -670,12 +670,15 @@ static int repo_init_find_dir(repo_init *results, const char* path)
char temp_path[GIT_PATH_MAX];
int error;
- error = git_futils_prettify_dir(temp_path, sizeof(temp_path), path, NULL);
- if (error < GIT_SUCCESS)
- return git__throw(GIT_ENOTFOUND, "Invalid directory to initialize repository");
+ if (git_futils_isdir(path) < GIT_SUCCESS) {
+ error = git_futils_mkdir_r(path, 0755);
+ if (error < GIT_SUCCESS)
+ return git__throw(GIT_EOSERR,
+ "Failed to initialize repository; cannot create full path");
+ }
-// if (p_realpath(path, temp_path) == NULL)
-// return git__throw(GIT_ENOTFOUND, "Invalid directory to initialize repository");
+ if (git_path_prettify_dir(temp_path, path, NULL) < GIT_SUCCESS)
+ return git__throw(GIT_ENOTFOUND, "Failed to resolve repository path (%s)", path);
if (!results->is_bare)
git_path_join(temp_path, temp_path, GIT_DIR);
diff --git a/tests/t00-core.c b/tests/t00-core.c
index 7ce51a7..ba5188a 100644
--- a/tests/t00-core.c
+++ b/tests/t00-core.c
@@ -152,206 +152,6 @@ BEGIN_TEST(path2, "get the latest component in a path")
#undef TOPDIR_TEST
END_TEST
-typedef int (normalize_path)(char *, size_t, const char *, const char *);
-
-/* Assert flags */
-#define CWD_AS_PREFIX 1
-#define PATH_AS_SUFFIX 2
-#define ROOTED_PATH 4
-
-static int ensure_normalized(const char *input_path, const char *expected_path, normalize_path normalizer, int assert_flags)
-{
- int error = GIT_SUCCESS;
- char buffer_out[GIT_PATH_MAX];
- char current_workdir[GIT_PATH_MAX];
-
- error = p_getcwd(current_workdir, sizeof(current_workdir));
- if (error < GIT_SUCCESS)
- return error;
-
- error = normalizer(buffer_out, sizeof(buffer_out), input_path, NULL);
- if (error < GIT_SUCCESS)
- return error;
-
- if (expected_path == NULL)
- return error;
-
- if ((assert_flags & PATH_AS_SUFFIX) != 0)
- if (git__suffixcmp(buffer_out, expected_path))
- return GIT_ERROR;
-
- if ((assert_flags & CWD_AS_PREFIX) != 0)
- if (git__prefixcmp(buffer_out, current_workdir))
- return GIT_ERROR;
-
- if ((assert_flags & ROOTED_PATH) != 0) {
- error = strcmp(expected_path, buffer_out);
- }
-
- return error;
-}
-
-static int ensure_dir_path_normalized(const char *input_path, const char *expected_path, int assert_flags)
-{
- return ensure_normalized(input_path, expected_path, git_futils_prettify_dir, assert_flags);
-}
-
-static int ensure_file_path_normalized(const char *input_path, const char *expected_path, int assert_flags)
-{
- return ensure_normalized(input_path, expected_path, git_futils_prettyify_file, assert_flags);
-}
-
-BEGIN_TEST(path3, "prettify and validate a path to a file")
- must_pass(ensure_file_path_normalized("a", "a", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_file_path_normalized("./testrepo.git", "testrepo.git", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_file_path_normalized("./.git", ".git", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_file_path_normalized("./git.", "git.", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_fail(ensure_file_path_normalized("git./", NULL, 0));
- must_fail(ensure_file_path_normalized("", NULL, 0));
- must_fail(ensure_file_path_normalized(".", NULL, 0));
- must_fail(ensure_file_path_normalized("./", NULL, 0));
- must_fail(ensure_file_path_normalized("./.", NULL, 0));
- must_fail(ensure_file_path_normalized("./..", NULL, 0));
- must_fail(ensure_file_path_normalized("../.", NULL, 0));
- must_fail(ensure_file_path_normalized("./.././/", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/..", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub/../..", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub/..///..", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub///../..", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub///..///..", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub/../../..", NULL, 0));
- must_pass(ensure_file_path_normalized("dir", "dir", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_fail(ensure_file_path_normalized("dir//", NULL, 0));
- must_pass(ensure_file_path_normalized("./dir", "dir", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_fail(ensure_file_path_normalized("dir/.", NULL, 0));
- must_fail(ensure_file_path_normalized("dir///./", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub/..", NULL, 0));
- must_fail(ensure_file_path_normalized("dir//sub/..",NULL, 0));
- must_fail(ensure_file_path_normalized("dir//sub/../", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub/../", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/sub/../.", NULL, 0));
- must_fail(ensure_file_path_normalized("dir/s1/../s2/", NULL, 0));
- must_fail(ensure_file_path_normalized("d1/s1///s2/..//../s3/", NULL, 0));
- must_pass(ensure_file_path_normalized("d1/s1//../s2/../../d2", "d2", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_fail(ensure_file_path_normalized("dir/sub/../", NULL, 0));
- must_pass(ensure_file_path_normalized("../a/../b/c/d/../../e", "b/e", PATH_AS_SUFFIX));
- must_fail(ensure_file_path_normalized("....", NULL, 0));
- must_fail(ensure_file_path_normalized("...", NULL, 0));
- must_fail(ensure_file_path_normalized("./...", NULL, 0));
- must_fail(ensure_file_path_normalized("d1/...", NULL, 0));
- must_fail(ensure_file_path_normalized("d1/.../", NULL, 0));
- must_fail(ensure_file_path_normalized("d1/.../d2", NULL, 0));
-
- must_pass(ensure_file_path_normalized("/a", "/a", ROOTED_PATH));
- must_pass(ensure_file_path_normalized("/./testrepo.git", "/testrepo.git", ROOTED_PATH));
- must_pass(ensure_file_path_normalized("/./.git", "/.git", ROOTED_PATH));
- must_pass(ensure_file_path_normalized("/./git.", "/git.", ROOTED_PATH));
- must_fail(ensure_file_path_normalized("/git./", NULL, 0));
- must_fail(ensure_file_path_normalized("/", NULL, 0));
- must_fail(ensure_file_path_normalized("/.", NULL, 0));
- must_fail(ensure_file_path_normalized("/./", NULL, 0));
- must_fail(ensure_file_path_normalized("/./.", NULL, 0));
- must_fail(ensure_file_path_normalized("/./..", NULL, 0));
- must_fail(ensure_file_path_normalized("/../.", NULL, 0));
- must_fail(ensure_file_path_normalized("/./.././/", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/..", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub/../..", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub/..///..", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub///../..", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub///..///..", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub/../../..", NULL, 0));
- must_pass(ensure_file_path_normalized("/dir", "/dir", 0));
- must_fail(ensure_file_path_normalized("/dir//", NULL, 0));
- must_pass(ensure_file_path_normalized("/./dir", "/dir", 0));
- must_fail(ensure_file_path_normalized("/dir/.", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir///./", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub/..", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir//sub/..",NULL, 0));
- must_fail(ensure_file_path_normalized("/dir//sub/../", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub/../", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/sub/../.", NULL, 0));
- must_fail(ensure_file_path_normalized("/dir/s1/../s2/", NULL, 0));
- must_fail(ensure_file_path_normalized("/d1/s1///s2/..//../s3/", NULL, 0));
- must_pass(ensure_file_path_normalized("/d1/s1//../s2/../../d2", "/d2", 0));
- must_fail(ensure_file_path_normalized("/dir/sub/../", NULL, 0));
- must_fail(ensure_file_path_normalized("/....", NULL, 0));
- must_fail(ensure_file_path_normalized("/...", NULL, 0));
- must_fail(ensure_file_path_normalized("/./...", NULL, 0));
- must_fail(ensure_file_path_normalized("/d1/...", NULL, 0));
- must_fail(ensure_file_path_normalized("/d1/.../", NULL, 0));
- must_fail(ensure_file_path_normalized("/d1/.../d2", NULL, 0));
-END_TEST
-
-BEGIN_TEST(path4, "validate and prettify a path to a folder")
- must_pass(ensure_dir_path_normalized("./testrepo.git", "testrepo.git/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("./.git", ".git/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("./git.", "git./", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("git./", "git./", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized(".", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("./", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("./.", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/..", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub/../..", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub/..///..", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub///../..", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub///..///..", "", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir//", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("./dir", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/.", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir///./", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub/..", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir//sub/..", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir//sub/../", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub/../", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub/../.", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/s1/../s2/", "dir/s2/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("d1/s1///s2/..//../s3/", "d1/s3/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("d1/s1//../s2/../../d2", "d2/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("dir/sub/../", "dir/", CWD_AS_PREFIX | PATH_AS_SUFFIX));
- must_pass(ensure_dir_path_normalized("../a/../b/c/d/../../e", "b/e/", PATH_AS_SUFFIX));
- must_fail(ensure_dir_path_normalized("....", NULL, 0));
- must_fail(ensure_dir_path_normalized("...", NULL, 0));
- must_fail(ensure_dir_path_normalized("./...", NULL, 0));
- must_fail(ensure_dir_path_normalized("d1/...", NULL, 0));
- must_fail(ensure_dir_path_normalized("d1/.../", NULL, 0));
- must_fail(ensure_dir_path_normalized("d1/.../d2", NULL, 0));
-
- must_pass(ensure_dir_path_normalized("/./testrepo.git", "/testrepo.git/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/./.git", "/.git/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/./git.", "/git./", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/git./", "/git./", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/", "/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("//", "/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("///", "/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/.", "/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/./", "/", ROOTED_PATH));
- must_fail(ensure_dir_path_normalized("/./..", NULL, 0));
- must_fail(ensure_dir_path_normalized("/../.", NULL, 0));
- must_fail(ensure_dir_path_normalized("/./.././/", NULL, 0));
- must_pass(ensure_dir_path_normalized("/dir/..", "/", 0));
- must_pass(ensure_dir_path_normalized("/dir/sub/../..", "/", 0));
- must_fail(ensure_dir_path_normalized("/dir/sub/../../..", NULL, 0));
- must_pass(ensure_dir_path_normalized("/dir", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/dir//", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/./dir", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/dir/.", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/dir///./", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/dir//sub/..", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/dir/sub/../", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("//dir/sub/../.", "/dir/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/dir/s1/../s2/", "/dir/s2/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/d1/s1///s2/..//../s3/", "/d1/s3/", ROOTED_PATH));
- must_pass(ensure_dir_path_normalized("/d1/s1//../s2/../../d2", "/d2/", ROOTED_PATH));
- must_fail(ensure_dir_path_normalized("/....", NULL, 0));
- must_fail(ensure_dir_path_normalized("/...", NULL, 0));
- must_fail(ensure_dir_path_normalized("/./...", NULL, 0));
- must_fail(ensure_dir_path_normalized("/d1/...", NULL, 0));
- must_fail(ensure_dir_path_normalized("/d1/.../", NULL, 0));
- must_fail(ensure_dir_path_normalized("/d1/.../d2", NULL, 0));
-END_TEST
-
static int ensure_joinpath(const char *path_a, const char *path_b, const char *expected_path)
{
char joined_path[GIT_PATH_MAX];
@@ -390,37 +190,6 @@ BEGIN_TEST(path6, "properly join path components for more than one path")
must_pass(ensure_joinpath_n("a", "b", "", "/c/d", "a/b/c/d"));
END_TEST
-static int count_number_of_path_segments(const char *path)
-{
- int number = 0;
- char *current = (char *)path;
-
- while (*current)
- {
- if (*current++ == '/')
- number++;
- }
-
- assert (number > 0);
-
- return --number;
-}
-
-BEGIN_TEST(path7, "prevent a path which escapes the root directory from being prettified")
- char current_workdir[GIT_PATH_MAX];
- char prettified[GIT_PATH_MAX];
- int i = 0, number_to_escape;
-
- must_pass(p_getcwd(current_workdir, sizeof(current_workdir)));
-
- number_to_escape = count_number_of_path_segments(current_workdir);
-
- for (i = 0; i < number_to_escape + 1; i++)
- git_path_join(current_workdir, current_workdir, "../");
-
- must_fail(git_futils_prettify_dir(prettified, sizeof(prettified), current_workdir, NULL));
-END_TEST
-
typedef struct name_data {
int count; /* return count */
char *name; /* filename */
@@ -715,11 +484,8 @@ BEGIN_SUITE(core)
ADD_TEST(path0);
ADD_TEST(path1);
ADD_TEST(path2);
- ADD_TEST(path3);
- ADD_TEST(path4);
ADD_TEST(path5);
ADD_TEST(path6);
- ADD_TEST(path7);
ADD_TEST(dirent0);
ADD_TEST(dirent1);
diff --git a/tests/t12-repo.c b/tests/t12-repo.c
index 4881e75..6d897a1 100644
--- a/tests/t12-repo.c
+++ b/tests/t12-repo.c
@@ -374,7 +374,7 @@ static int append_ceiling_dir(char *ceiling_dirs, const char *path)
int len = strlen(ceiling_dirs);
int error;
- error = git_futils_prettify_dir(ceiling_dirs + len + (len ? 1 : 0), GIT_PATH_MAX, path, NULL);
+ error = git_path_prettify_dir(ceiling_dirs + len + (len ? 1 : 0), path, NULL);
if (error < GIT_SUCCESS)
return git__rethrow(error, "Failed to append ceiling directory.");