Commit f195395ab1a84c20331fab94992348dbf21ec990

Edward Thomson 2018-10-21T09:16:35

ci: bind specifically to localhost for proxy Bind the proxy specifically to 127.0.0.1 instead of all addresses. This is not strictly necessary for operations, but having a potentially open proxy on a network is not a good idea.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/ci/test.sh b/ci/test.sh
index e50e6fa..5d7c913 100755
--- a/ci/test.sh
+++ b/ci/test.sh
@@ -73,8 +73,8 @@ fi
 
 if [ -z "$SKIP_PROXY_TESTS" ]; then
 	echo "Starting HTTP proxy..."
-	curl -L https://github.com/ethomson/poxyproxy/releases/download/v0.1.0/poxyproxy-0.1.0.jar >poxyproxy.jar
-	java -jar poxyproxy.jar -d --port 8080 --credentials foo:bar >/dev/null 2>&1 &
+	curl -L https://github.com/ethomson/poxyproxy/releases/download/v0.2.0/poxyproxy-0.2.0.jar >poxyproxy.jar
+	java -jar poxyproxy.jar -d --address 127.0.0.1 --port 8080 --credentials foo:bar >/dev/null 2>&1 &
 fi
 
 if [ -z "$SKIP_SSH_TESTS" ]; then