Cleanup nitpicky things
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57
diff --git a/include/git2/refs.h b/include/git2/refs.h
index c926461..af6c2f4 100644
--- a/include/git2/refs.h
+++ b/include/git2/refs.h
@@ -381,7 +381,7 @@ GIT_EXTERN(int) git_reference_foreach_glob(
git_repository *repo,
const char *glob,
unsigned int list_flags,
- int (*callback)(const char *reference_name, void *payload),
+ git_reference_foreach_cb callback,
void *payload);
/**
diff --git a/include/git2/strarray.h b/include/git2/strarray.h
index 0305679..338d138 100644
--- a/include/git2/strarray.h
+++ b/include/git2/strarray.h
@@ -19,11 +19,10 @@
GIT_BEGIN_DECL
/** Array of strings */
-typedef struct _git_strarray git_strarray;
-struct _git_strarray {
+typedef struct git_strarray {
char **strings;
size_t count;
-};
+} git_strarray;
/**
* Close a string array object
diff --git a/tests-clar/network/fetch.c b/tests-clar/network/fetch.c
index 84c9472..26937c6 100644
--- a/tests-clar/network/fetch.c
+++ b/tests-clar/network/fetch.c
@@ -78,6 +78,7 @@ void test_network_fetch__no_tags_http(void)
static void transferProgressCallback(const git_transfer_progress *stats, void *payload)
{
+ GIT_UNUSED(stats);
bool *invoked = (bool *)payload;
*invoked = true;
}
diff --git a/tests-clar/refs/branches/tracking.c b/tests-clar/refs/branches/tracking.c
index e8b2f24..84d2961 100644
--- a/tests-clar/refs/branches/tracking.c
+++ b/tests-clar/refs/branches/tracking.c
@@ -65,7 +65,8 @@ static void assert_merge_and_or_remote_key_missing(git_repository *repository, g
{
git_reference *branch;
- cl_git_pass(git_branch_create(&branch, repository, entry_name, target, 0));
+ cl_assert_equal_i(GIT_OBJ_COMMIT, git_object_type(target));
+ cl_git_pass(git_branch_create(&branch, repository, entry_name, (git_commit*)target, 0));
cl_assert_equal_i(GIT_ENOTFOUND, git_branch_tracking(&tracking, branch));