kmx git

Commit	Date	Message
d1fb89dd	2016-06-07T12:55:17	global: clean up crt only after freeing tls data The thread local storage is used to hold some global state that is dynamically allocated and should be freed upon exit. On Windows, we clean up the C run-time right after execution of registered shutdown callbacks and before cleaning up the TLS. When we clean up the CRT, we also cause it to analyze for memory leaks. As we did not free the TLS yet this will lead to false positives. Fix the issue by first freeing the TLS and cleaning up the CRT only afterwards.
feea2849	2016-05-26T12:52:29	win32: clean up unused warnings in DllMain
a1cf2644	2016-03-18T13:00:27	win32: free thread-local data on thread exit
c1ec732f	2016-03-14T12:02:00	Setup better defaults for OpenSSL ciphers This ensures that when using OpenSSL a safe default set of ciphers is selected. This is done so that the client communicates securely and we don't accidentally enable unsafe ciphers like RC4, or even worse some old export ciphers. Implements the first part of https://github.com/libgit2/libgit2/issues/3682
22f3d3aa	2016-03-03T22:26:31	ssh: initialize libssh2 We should have been doing this, but it initializes itself upon first use, which works as long as nobody's doing concurrent network operations. Initialize it on our init to make sure it's not getting initialized concurrently.
bf127eec	2016-02-19T13:24:41	global: remove an unused variable
8a6d6677	2016-02-08T16:14:03	global: make openssl registration like the rest
bad2702c	2016-02-06T11:25:47	global: refactor setup and cleanup Move the common initialization and cleanup methods to reduce unnecessary duplication.
de870533	2015-10-02T03:43:11	settings: add a setter for a custom user-agent
f85fc367	2015-07-26T21:12:00	error: store the error messages in a reusable buffer Instead of allocating a brand new buffer for each error string we want to store, we can use a per-thread buffer to store the error string and re-use the underlying storage. We already use the buffer to format the string, so this mostly makes that more direct.
9830fbba	2015-07-22T11:33:18	Merge branch 'master' into fix-init-ordering
cf198fdf	2015-07-22T10:51:38	Increment `git__n_inits` before doing `init_once`. Fixes #3318.
93b42728	2015-06-09T14:38:30	Include stacktrace summary in memory leak output.
20f8edb7	2015-06-04T02:22:10	global: Ensure we free our SSL context.
24e53d2f	2015-03-19T09:55:20	Rename GIT_SSL to GIT_OPENSSL This is what it's meant all along, but now we actually have multiple implementations, it's clearer to use the name of the library.
06c985d8	2015-04-18T09:07:48	Rename routine to free TLS data
d3fb7d93	2015-04-17T10:04:01	Remove DllMain now that TLS data freed by threads
f5ffb40e	2015-04-17T09:58:09	Also fix leak of TLS data on main thread.
55c5f756	2015-04-17T09:30:22	Attempt to fix Windows TLS memory leak.
8e851c1e	2015-03-03T16:41:59	libgit2_shutdown: free TLS data (win32) Free TLS data on thread exit (win32)
83fe60fa	2015-03-03T14:10:50	libgit2_shutdown: clear err message on shutdown Clear the error message on git_libgit2_shutdown for all versions of the library (no threads and Win32 threads). Drop the giterr_clear in clar, as that shouldn't be necessary.
3a8b69d1	2015-02-26T11:47:07	Fix leak of TLS error message in shutdown (ptherad version)
73f0278e	2014-12-23T16:40:01	global: include sys/openssl.h for GIT_EXPORT of fn The openssl setup function needs to be GIT_EXPORT'ed, be sure to include the `sys/openssl.h` header so that it is appropriately decorated as an export function.
263b1d6e	2014-12-12T08:29:43	Make the OpenSSL locking function warnings more severe Our git_openssl_set_locking() would ideally not exist. Make it clearer that we provide it as a last resort and you should prefer anything else.
e79fbd9e	2014-12-05T07:09:08	Merge pull request #2743 from ethomson/init_val init: return the number of initializations
6d91dc53	2014-12-03T15:28:44	init: return the number of initializations
2d2cd625	2014-12-03T21:01:42	Add missing else directive Add missing else directive to fix compiler warning: control reaches end of non-void function
d6ecc311	2014-11-15T14:35:58	Plug possible leak in the openssl locks
799e22ea	2014-10-23T17:34:41	Rename git_threads_ to git_libgit2_ This describes their purpose better, as we now initialize ssl and some other global stuff in there. Calling the init function is not something which has been optional for a while now.
7bb63991	2014-11-06T10:25:23	Merge pull request #2676 from libgit2/cmn/threading Threading and crypto libraries
bc48bcdc	2014-11-03T14:23:13	Make the Visual Studio compiler happy
fe6b51ae	2014-11-01T10:45:33	ssl: separate locking init from general init Extract the lock-setting functions into their own, as we cannot assume that it's ok for us to set this unconditionally.
e0836577	2014-11-01T10:26:09	ssl: clear the OpenSSL locking function We're freeing the memory which holds the locks so we must make sure that the locking function doesn't try to use it.
50aae000	2014-10-25T19:52:11	global: clean up openssl_locks on shutdown
f0f97370	2014-10-18T15:52:10	ssl: dump the SSL ciphers in favour of TLS All versions of SSL are considered deprecated now, so let's ask OpenSSl to only use TLSv1. We still ask it to load those ciphers for compatibility with servers which want to use an older hello but will use TLS for encryption. For good measure we also disable compression, which can be exploitable, if the OpenSSL version supports it.
fdea219a	2014-09-10T18:28:19	global: free the error message when exiting a thread When we free the global state at thread termination, we must also free the error message in order not to leak the string once per thread.
f59a34d2	2014-07-12T14:45:34	Only create openssl_locks if thread support is enabled
e6b0ae7a	2014-06-30T09:19:05	ssl: init only once without threads The OpenSSL library-loading functions do not expect to be called multiple times. Add a flag in the non-threaded libgit2 init so we only call once. This fixes #2446.
e93206e0	2014-06-14T12:58:03	Merge pull request #2421 from libgit2/cmn/init-ssl-once netops: init OpenSSL once under lock
081e76ba	2014-06-12T16:20:52	ssl: init everything all the time Bring together all of the OpenSSL initialization to git_threads_init() so it's together and doesn't need locks. Moving it here also gives us libssh2 thread safety (when built against openssl).
8f897b6f	2014-06-12T14:50:08	ssl: init also without threads
cf15ac8a	2014-06-12T03:20:34	ssl: cargo-cult thread safety OpenSSL's tests init everything in the main thread, so let's do that.
1d3364ac	2014-06-11T20:52:15	netops: init OpenSSL once under lock The OpenSSL init functions are not reentrant, which means that running multiple fetches in parallel can cause us to crash. Use a mutex to init OpenSSL, and since we're adding this extra checks, init it only once.
fb591767	2014-06-07T12:51:48	Win32: Fix object::cache::threadmania test on x64
138af337	2014-05-19T12:20:31	Merge pull request #2303 from jacquesg/mingw-lseek WIP: Windows fixes
0bf5430d	2014-05-06T13:33:47	Fix the issues in git_shutdown 1) Call to git_shutdown results in setting git__n_shutdown_callbacks to -1. Next call to git__on_shutdown results in ABW (Array Bound Write) for array git__shutdown_callbacks. In the current Implementation, git_atomic_dec is called git__n_shutdown_callbacks + 1 times. I have modified it to a for loop so that it is more readable. It would not set git__n_shutdown_callbacks to a negative number and reset the elements of git__shutdown_callbacks to NULL. 2) In function git_sysdir_get, shutdown function is registered only if git_sysdir__dirs_shutdown_set is set to 0. However, after this variable is set to 1, it is never reset to 0. If git_sysdir_global_init is called again from synchronized_threads_init it does not register shutdown function for this subsystem.
001befcd	2014-05-06T12:16:24	Fix the issues in git__on_shutdown
6e94a1ef	2014-04-27T14:25:49	_InterlockedExchange expects a volatile LONG
3816debc	2014-03-14T14:51:04	Fix threading tests when threads disabled
efaa342c	2014-04-11T22:07:49	Correct C90 warnings
83634d38	2014-02-24T17:43:10	Move system directory cache out of utils
22661448	2013-10-04T19:35:32	Don't use git_atomic as an integer
cdc95a0d	2013-10-04T18:38:37	Use InterlockedCompareExchange for the lock
e411b74e	2013-10-04T19:33:48	Posix synchronized init, prototype win32 version
a3aa5f4d	2013-09-11T12:45:20	Add simple global shutdown hooks Increasingly there are a number of components that want to do some cleanup at global shutdown time (at least if there are not going to be memory leaks). This creates a very simple system of shutdown hooks that will be invoked by git_threads_shutdown. Right now, the maximum number of hooks is hardcoded, but since adding a hook is not a public API, it should be fine and I thought it was better to start off with really simple code.
43095341	2013-08-26T14:56:31	Load SRWLock APIs at runtime This loads SRWLock APIs at runtime and in their absence (i.e. on Windows before Vista) falls back on a regular CRITICAL_SECTION that will not permit concurrent readers.
0a1c8f55	2013-07-11T17:09:15	preload configuration paths
1a42dd17	2013-05-31T14:13:11	Mutex init can fail It is obviously quite a serious problem if this happens, but mutex initialization can fail and we should detect it. It's a bit like a memory allocation failure, in that you're probably pretty screwed if this occurs, but at least we'll catch it.
53607868	2013-04-15T00:09:03	Further threading fixes This builds on the earlier thread safety work to make it so that setting the odb, index, refdb, or config for a repository is done in a threadsafe manner with minimized locking time. This is done by adding a lock to the repository object and using it to guard the assignment of the above listed pointers. The lock is only held to assign the pointer value. This also contains some minor fixes to the other work with pack files to reduce the time that locks are being held to and fix an apparently memory leak.
41954a49	2013-03-18T14:19:35	Switch search paths to classic delimited strings This switches the APIs for setting and getting the global/system search paths from using git_strarray to using a simple string with GIT_PATH_LIST_SEPARATOR delimited paths, just as the environment PATH variable would contain. This makes it simpler to get and set the value. I also added code to expand "$PATH" when setting a new value to embed the old value of the path. This means that I no longer require separate actions to PREPEND to the value.
359fc2d2	2013-01-08T17:07:25	update copyrights
c3320aca	2012-12-09T02:22:50	git__mwindow_mutex needs to be initialized even with pthreads This could also use PTHREAD_MUTEX_INITIALIZER, but a dynamic initializer seems like a more portable concept, and we won't need another #define on top of git_mutex_init()
a8527429	2012-11-13T14:48:10	unload dll / destroy hash ctxs at shutdown
7ebefd22	2012-11-13T10:10:40	move hash library func ptrs to global global
93b5fabc	2012-10-01T17:59:04	threads: Assert that the global state is initialized
8cef828d	2012-08-18T22:11:49	Make the memory-window conrol structures global Up to now, the idea was that the user would do all the operations for one repository in the same thread. Thus we could have the memory-mapped window information thread-local and avoid any locking. This is not practical in a few environments, such as Apple's GCD which allocates threads arbitrarily or the .NET CLR, where the OS-level thread can change at any moment. Make the control structure global and protect it with a mutex so we don't depend on the thread currently executing the code.
2bc8fa02	2012-04-17T10:14:24	Implement git_pool paged memory allocator This adds a `git_pool` object that can do simple paged memory allocation with free for the entire pool at once. Using this, you can replace many small allocations with large blocks that can then cheaply be doled out in small pieces. This is best used when you plan to free the small blocks all at once - for example, if they represent the parsed state from a file or data stream that are either all kept or all discarded. There are two real patterns of usage for `git_pools`: either for "string" allocation, where the item size is a single byte and you end up just packing the allocations in together, or for "fixed size" allocation where you are allocating a large object (e.g. a `git_oid`) and you generally just allocation single objects that can be tightly packed. Of course, you can use it for other things, but those two cases are the easiest.
5e0de328	2012-02-13T17:10:24	Update Copyright header Signed-off-by: schu <schu-github@schulog.org>
a15c550d	2011-11-16T14:09:44	threads: Fix the shared global state with TLS See `global.c` for a description of what we're doing. When libgit2 is built with GIT_THREADS support, the threading system must be explicitly initialized with `git_threads_init()`.

d1fb89dd

2016-06-07T12:55:17

global: clean up crt only after freeing tls data The thread local storage is used to hold some global state that is dynamically allocated and should be freed upon exit. On Windows, we clean up the C run-time right after execution of registered shutdown callbacks and before cleaning up the TLS. When we clean up the CRT, we also cause it to analyze for memory leaks. As we did not free the TLS yet this will lead to false positives. Fix the issue by first freeing the TLS and cleaning up the CRT only afterwards.

feea2849

2016-05-26T12:52:29

win32: clean up unused warnings in DllMain

a1cf2644

2016-03-18T13:00:27

win32: free thread-local data on thread exit

c1ec732f

2016-03-14T12:02:00

Setup better defaults for OpenSSL ciphers This ensures that when using OpenSSL a safe default set of ciphers is selected. This is done so that the client communicates securely and we don't accidentally enable unsafe ciphers like RC4, or even worse some old export ciphers. Implements the first part of https://github.com/libgit2/libgit2/issues/3682

22f3d3aa

2016-03-03T22:26:31

ssh: initialize libssh2 We should have been doing this, but it initializes itself upon first use, which works as long as nobody's doing concurrent network operations. Initialize it on our init to make sure it's not getting initialized concurrently.

bf127eec

2016-02-19T13:24:41

global: remove an unused variable

8a6d6677

2016-02-08T16:14:03

global: make openssl registration like the rest

bad2702c

2016-02-06T11:25:47

global: refactor setup and cleanup Move the common initialization and cleanup methods to reduce unnecessary duplication.

de870533

2015-10-02T03:43:11

settings: add a setter for a custom user-agent

f85fc367

2015-07-26T21:12:00

error: store the error messages in a reusable buffer Instead of allocating a brand new buffer for each error string we want to store, we can use a per-thread buffer to store the error string and re-use the underlying storage. We already use the buffer to format the string, so this mostly makes that more direct.

9830fbba

2015-07-22T11:33:18

Merge branch 'master' into fix-init-ordering

cf198fdf

2015-07-22T10:51:38

Increment `git__n_inits` before doing `init_once`. Fixes #3318.

93b42728

2015-06-09T14:38:30

Include stacktrace summary in memory leak output.

20f8edb7

2015-06-04T02:22:10

global: Ensure we free our SSL context.

24e53d2f

2015-03-19T09:55:20

Rename GIT_SSL to GIT_OPENSSL This is what it's meant all along, but now we actually have multiple implementations, it's clearer to use the name of the library.

06c985d8

2015-04-18T09:07:48

Rename routine to free TLS data

d3fb7d93

2015-04-17T10:04:01

Remove DllMain now that TLS data freed by threads

f5ffb40e

2015-04-17T09:58:09

Also fix leak of TLS data on main thread.

55c5f756

2015-04-17T09:30:22

Attempt to fix Windows TLS memory leak.

8e851c1e

2015-03-03T16:41:59

libgit2_shutdown: free TLS data (win32) Free TLS data on thread exit (win32)

83fe60fa

2015-03-03T14:10:50

libgit2_shutdown: clear err message on shutdown Clear the error message on git_libgit2_shutdown for all versions of the library (no threads and Win32 threads). Drop the giterr_clear in clar, as that shouldn't be necessary.

3a8b69d1

2015-02-26T11:47:07

Fix leak of TLS error message in shutdown (ptherad version)

73f0278e

2014-12-23T16:40:01

global: include sys/openssl.h for GIT_EXPORT of fn The openssl setup function needs to be GIT_EXPORT'ed, be sure to include the `sys/openssl.h` header so that it is appropriately decorated as an export function.

263b1d6e

2014-12-12T08:29:43

Make the OpenSSL locking function warnings more severe Our git_openssl_set_locking() would ideally not exist. Make it clearer that we provide it as a last resort and you should prefer anything else.

e79fbd9e

2014-12-05T07:09:08

Merge pull request #2743 from ethomson/init_val init: return the number of initializations

6d91dc53

2014-12-03T15:28:44

init: return the number of initializations

2d2cd625

2014-12-03T21:01:42

Add missing else directive Add missing else directive to fix compiler warning: control reaches end of non-void function

d6ecc311

2014-11-15T14:35:58

Plug possible leak in the openssl locks

799e22ea

2014-10-23T17:34:41

Rename git_threads_ to git_libgit2_ This describes their purpose better, as we now initialize ssl and some other global stuff in there. Calling the init function is not something which has been optional for a while now.

7bb63991

2014-11-06T10:25:23

Merge pull request #2676 from libgit2/cmn/threading Threading and crypto libraries

bc48bcdc

2014-11-03T14:23:13

Make the Visual Studio compiler happy

fe6b51ae

2014-11-01T10:45:33

ssl: separate locking init from general init Extract the lock-setting functions into their own, as we cannot assume that it's ok for us to set this unconditionally.

e0836577

2014-11-01T10:26:09

ssl: clear the OpenSSL locking function We're freeing the memory which holds the locks so we must make sure that the locking function doesn't try to use it.

50aae000

2014-10-25T19:52:11

global: clean up openssl_locks on shutdown

f0f97370

2014-10-18T15:52:10

ssl: dump the SSL ciphers in favour of TLS All versions of SSL are considered deprecated now, so let's ask OpenSSl to only use TLSv1. We still ask it to load those ciphers for compatibility with servers which want to use an older hello but will use TLS for encryption. For good measure we also disable compression, which can be exploitable, if the OpenSSL version supports it.

fdea219a

2014-09-10T18:28:19

global: free the error message when exiting a thread When we free the global state at thread termination, we must also free the error message in order not to leak the string once per thread.

f59a34d2

2014-07-12T14:45:34

Only create openssl_locks if thread support is enabled

e6b0ae7a

2014-06-30T09:19:05

ssl: init only once without threads The OpenSSL library-loading functions do not expect to be called multiple times. Add a flag in the non-threaded libgit2 init so we only call once. This fixes #2446.

e93206e0

2014-06-14T12:58:03

Merge pull request #2421 from libgit2/cmn/init-ssl-once netops: init OpenSSL once under lock

081e76ba

2014-06-12T16:20:52

ssl: init everything all the time Bring together all of the OpenSSL initialization to git_threads_init() so it's together and doesn't need locks. Moving it here also gives us libssh2 thread safety (when built against openssl).

8f897b6f

2014-06-12T14:50:08

ssl: init also without threads

cf15ac8a

2014-06-12T03:20:34

ssl: cargo-cult thread safety OpenSSL's tests init everything in the main thread, so let's do that.

1d3364ac

2014-06-11T20:52:15

netops: init OpenSSL once under lock The OpenSSL init functions are not reentrant, which means that running multiple fetches in parallel can cause us to crash. Use a mutex to init OpenSSL, and since we're adding this extra checks, init it only once.

fb591767

2014-06-07T12:51:48

Win32: Fix object::cache::threadmania test on x64

138af337

2014-05-19T12:20:31

Merge pull request #2303 from jacquesg/mingw-lseek WIP: Windows fixes

0bf5430d

2014-05-06T13:33:47

Fix the issues in git_shutdown 1) Call to git_shutdown results in setting git__n_shutdown_callbacks to -1. Next call to git__on_shutdown results in ABW (Array Bound Write) for array git__shutdown_callbacks. In the current Implementation, git_atomic_dec is called git__n_shutdown_callbacks + 1 times. I have modified it to a for loop so that it is more readable. It would not set git__n_shutdown_callbacks to a negative number and reset the elements of git__shutdown_callbacks to NULL. 2) In function git_sysdir_get, shutdown function is registered only if git_sysdir__dirs_shutdown_set is set to 0. However, after this variable is set to 1, it is never reset to 0. If git_sysdir_global_init is called again from synchronized_threads_init it does not register shutdown function for this subsystem.

001befcd

2014-05-06T12:16:24

Fix the issues in git__on_shutdown

6e94a1ef

2014-04-27T14:25:49

_InterlockedExchange expects a volatile LONG

3816debc

2014-03-14T14:51:04

Fix threading tests when threads disabled

efaa342c

2014-04-11T22:07:49

Correct C90 warnings

83634d38

2014-02-24T17:43:10

Move system directory cache out of utils

22661448

2013-10-04T19:35:32

Don't use git_atomic as an integer

cdc95a0d

2013-10-04T18:38:37

Use InterlockedCompareExchange for the lock

e411b74e

2013-10-04T19:33:48

Posix synchronized init, prototype win32 version

a3aa5f4d

2013-09-11T12:45:20

Add simple global shutdown hooks Increasingly there are a number of components that want to do some cleanup at global shutdown time (at least if there are not going to be memory leaks). This creates a very simple system of shutdown hooks that will be invoked by git_threads_shutdown. Right now, the maximum number of hooks is hardcoded, but since adding a hook is not a public API, it should be fine and I thought it was better to start off with really simple code.

43095341

2013-08-26T14:56:31

Load SRWLock APIs at runtime This loads SRWLock APIs at runtime and in their absence (i.e. on Windows before Vista) falls back on a regular CRITICAL_SECTION that will not permit concurrent readers.

0a1c8f55

2013-07-11T17:09:15

preload configuration paths

1a42dd17

2013-05-31T14:13:11

Mutex init can fail It is obviously quite a serious problem if this happens, but mutex initialization can fail and we should detect it. It's a bit like a memory allocation failure, in that you're probably pretty screwed if this occurs, but at least we'll catch it.

53607868

2013-04-15T00:09:03

Further threading fixes This builds on the earlier thread safety work to make it so that setting the odb, index, refdb, or config for a repository is done in a threadsafe manner with minimized locking time. This is done by adding a lock to the repository object and using it to guard the assignment of the above listed pointers. The lock is only held to assign the pointer value. This also contains some minor fixes to the other work with pack files to reduce the time that locks are being held to and fix an apparently memory leak.

41954a49

2013-03-18T14:19:35

Switch search paths to classic delimited strings This switches the APIs for setting and getting the global/system search paths from using git_strarray to using a simple string with GIT_PATH_LIST_SEPARATOR delimited paths, just as the environment PATH variable would contain. This makes it simpler to get and set the value. I also added code to expand "$PATH" when setting a new value to embed the old value of the path. This means that I no longer require separate actions to PREPEND to the value.

359fc2d2

2013-01-08T17:07:25

update copyrights

c3320aca

2012-12-09T02:22:50

git__mwindow_mutex needs to be initialized even with pthreads This could also use PTHREAD_MUTEX_INITIALIZER, but a dynamic initializer seems like a more portable concept, and we won't need another #define on top of git_mutex_init()

a8527429

2012-11-13T14:48:10

unload dll / destroy hash ctxs at shutdown

7ebefd22

2012-11-13T10:10:40

move hash library func ptrs to global global

93b5fabc

2012-10-01T17:59:04

threads: Assert that the global state is initialized

8cef828d

2012-08-18T22:11:49

Make the memory-window conrol structures global Up to now, the idea was that the user would do all the operations for one repository in the same thread. Thus we could have the memory-mapped window information thread-local and avoid any locking. This is not practical in a few environments, such as Apple's GCD which allocates threads arbitrarily or the .NET CLR, where the OS-level thread can change at any moment. Make the control structure global and protect it with a mutex so we don't depend on the thread currently executing the code.

2bc8fa02

2012-04-17T10:14:24

Implement git_pool paged memory allocator This adds a `git_pool` object that can do simple paged memory allocation with free for the entire pool at once. Using this, you can replace many small allocations with large blocks that can then cheaply be doled out in small pieces. This is best used when you plan to free the small blocks all at once - for example, if they represent the parsed state from a file or data stream that are either all kept or all discarded. There are two real patterns of usage for `git_pools`: either for "string" allocation, where the item size is a single byte and you end up just packing the allocations in together, or for "fixed size" allocation where you are allocating a large object (e.g. a `git_oid`) and you generally just allocation single objects that can be tightly packed. Of course, you can use it for other things, but those two cases are the easiest.

5e0de328

2012-02-13T17:10:24

Update Copyright header Signed-off-by: schu <schu-github@schulog.org>

a15c550d

2011-11-16T14:09:44

threads: Fix the shared global state with TLS See `global.c` for a description of what we're doing. When libgit2 is built with GIT_THREADS support, the threading system must be explicitly initialized with `git_threads_init()`.

thodg/libgit2/src/global.c

src/global.c

Log