kmx git

Commit	Date	Message
c1b5e8c4	2013-02-15T11:35:33	branch: Make git_branch_remote_name() cope with orphaned heads
56543a60	2013-02-15T16:02:45	Clear up warnings from cppcheck The cppcheck static analyzer generates warnings for a bunch of places in the libgit2 code base. All the ones fixed in this commit are actually false positives, but I've reorganized the code to hopefully make it easier for static analysis tools to correctly understand the structure. I wouldn't do this if I felt like it was making the code harder to read or worse for humans, but in this case, these fixes don't seem too bad and will hopefully make it easier for better analysis tools to get at any real issues.
2bca5b67	2013-02-07T23:44:18	remote: Introduce git_remote_is_valid_name() Fix libgit2/libgit2sharp#318
4d811c3b	2013-02-07T23:40:10	refs: No component of a refname can end with '.lock'
e5ef0f18	2013-01-31T20:23:30	refs: handle ALLOW_ONELEVEL normalization with leading slash A leading slash confuses the name normalization code when the flags include ALLOW_ONELEVEL. Catch this case in particular to avoid triggering an assertion in the uppercase check which expects us not to pass it an empty string. The existing tests don't catch this as they simply use the NORMAL flag. This fixes #1300.
cb35094b	2013-01-22T15:49:51	Allow peeled references without trailing newline at end of file Also ammends one of the tag tests to make sure it's working.
2a707d0e	2013-01-22T14:08:50	Revert "Handle packed peeled objects without trailing newlines" This reverts commit 28b1cdf3a1bdcd37cf9d550c92b8c19b1782ea6b. //cc #1262 #1267
28b1cdf3	2013-01-21T14:45:43	Handle packed peeled objects without trailing newlines Fixes #1262
bf031581	2013-01-14T14:22:11	branch: Introduce git_branch_tracking_name()
359fc2d2	2013-01-08T17:07:25	update copyrights
ef82ff30	2013-01-05T00:46:39	Handle packed refs with no trailing newline I saw a repo in the wild today which had a master branch ref which was packed, but had no trailing newline. Git handled it fine, but libgit2 choked on it. Fix seems simple enough. If we don't see a newline, assume the end of the buffer is the end of the ref line.
3865f7f6	2012-12-27T23:23:12	Invalid ref name normalization leaked memory When normalizing a reference name, if there is an error because the name is invalid, then the memory allocated for storing the name could be leaked if the caller was not careful and assumed that the error return code meant that no allocation had occurred. This fixes that by explicitly deallocating the reference name buffer if there is an error in normalizing the name.
ed4e887d	2012-12-18T16:09:57	Also, whitespace. I was totally flaunting @ben's 3-space tab advice.
33f169e2	2012-12-18T16:07:18	Improve comment text This looked wrong to me. I think this is more appropriate commentary.
28abb187	2012-12-14T14:16:10	Stop returning incorrect error message
b524fe1a	2012-12-14T08:35:59	Local Only ignore ENOTFOUNDs when adding corrupted refs
80d9d1df	2012-11-12T15:42:15	refs: Deploy EINVALIDSPEC usage
83458bb7	2012-11-12T14:06:13	refs: Fix error clearing
d9023dbe	2012-11-20T17:06:54	API updates for tag.h
eecc8050	2012-11-20T14:03:05	Update callback fn ptr for git_reference_foreach As part of API review, use a typedef for the callback fn ptr.
2508cc66	2012-11-18T21:38:08	Rename ref and reflog apis for consistency
331e7de9	2012-10-24T17:32:50	Extensions to rmdir and mkdir utilities * Rework GIT_DIRREMOVAL values to GIT_RMDIR flags, allowing combinations of flags * Add GIT_RMDIR_EMPTY_PARENTS flag to remove parent dirs that are left empty after removal * Add GIT_MKDIR_VERIFY_DIR to give an error if item is a file, not a dir (previously an EEXISTS error was ignored, even for files) and enable this flag for git_futils_mkpath2file call * Improve accuracy of error messages from git_futils_mkdir
b90500f0	2012-11-01T14:08:30	Improve docs, examples, warnings This improves docs in some of the public header files, cleans up and improves some of the example code, and fixes a couple of pedantic warnings in places.
744cc03e	2012-10-30T12:10:36	Add git_config_refresh() API to reload config This adds a new API that allows users to reload the config if the file has changed on disk. A new config callback function to refresh the config was added. The modified time and file size are used to test if the file needs to be reloaded (and are now stored in the disk backend object). In writing tests, just using mtime was a problem / race, so I wanted to check file size as well. To support that, I extended `git_futils_readbuffer_updated` to optionally check file size in addition to mtime, and I added a new function `git_filebuf_stats` to fetch the mtime and size for an open filebuf (so that the config could be easily refreshed after a write). Lastly, I moved some similar file checking code for attributes into filebuf. It is still only being used for attrs, but it seems potentially reusable, so I thought I'd move it over.
4c47a8bc	2012-10-17T14:14:51	Merge pull request #968 from arrbee/diff-support-typechange Support TYPECHANGE records in status and adjust checkout accordingly
7ae5ab56	2012-10-15T16:35:10	Fix leak in the tests Also introduce the slective ref trimming promised but also missed in the previous commit.
47f44b6e	2012-10-15T13:51:25	refs: loosen the OID parsing We used to require loose references to contain only an OID (possibly after trimming the string). This is however not enough for letting us lookup FETCH_HEAD, which can have a lot of content after the initial OID. Change the parsing rules so that a loose refernce must e at least 40 bytes long and the 41st (if it's there) must be accepted by isspace(3). This makes the trim unnecessary, so only do it for symrefs. This fixes #977.
3548fcf5	2012-10-11T14:00:26	refs: propagate EEXISTS upon renaming
0d64bef9	2012-10-05T15:56:57	Add complex checkout test and then fix checkout This started as a complex new test for checkout going through the "typechanges" test repository, but that revealed numerous issues with checkout, including: * complete failure with submodules * failure to create blobs with exec bits * problems when replacing a tree with a blob because the tree "example/" sorts after the blob "example" so the delete was being processed after the single file blob was created This fixes most of those problems and includes a number of other minor changes that made it easier to do that, including improving the TYPECHANGE support in diff/status, etc.
4ba23be1	2012-10-06T12:20:13	branch: deploy git_branch_is_head()
f3cc7834	2012-09-22T12:51:34	refs: deploy git_repository_set_head() usage
74a24005	2012-09-21T10:28:20	refs: use constants for well-known names
8bc5cacc	2012-10-01T13:57:32	Merge pull request #961 from arrbee/win64-cleanups Win64 cleanups
7c411fd9	2012-10-01T12:32:55	Fix up more Win64 compile warnings
c1281493	2012-09-30T11:37:53	refs: propagate EEXISTS Indicate whether the error comes from the ref already existing or elsewhere. We always perform the check and this lets the user write more concise code.
0adfa20a	2012-09-11T11:42:13	refspec: introduce git_refspec__parse()
77e06d7e	2012-09-17T07:11:32	refs: introduce git_reference_is_valid_name()
c030ada7	2012-09-11T12:06:57	refs: make git_reference_normalize_name() accept refspec pattern
c2948c77	2012-09-14T21:36:49	refs: prevent locked refs from being enumerated Fix #936
31665948	2012-08-24T21:30:45	refs: introduce git_reference_peel() Fix #530
f335ecd6	2012-08-30T14:24:16	Diff iterators This refactors the diff output code so that an iterator object can be used to traverse and generate the diffs, instead of just the `foreach()` style with callbacks. The code has been rearranged so that the two styles can still share most functions. This also replaces `GIT_REVWALKOVER` with `GIT_ITEROVER` and uses that as a common error code for marking the end of iteration when using a iterator style of object.
0844ed06	2012-08-28T20:15:21	Fix parentheses warning
62eafd06	2012-08-27T14:54:52	Merge branch 'branch-delete-ref' into development Conflicts: include/git2/refs.h
2e0c8816	2012-08-26T22:08:22	refs: expose git_reference_normalize_name()
1c947daa	2012-08-23T15:47:29	branch: Change `git_branch_delete` to take a ref
c07d9c95	2012-08-09T15:33:04	oid: Explicitly include `oid.h` for the inlined CMP
186c054d	2012-08-09T14:47:29	Revert implementation changes
28e00681	2012-08-09T14:39:56	Ignore ref oid terminator
2fe293b6	2012-08-09T11:36:21	trim whitespace when parsing loose refs
6ab68290	2012-08-09T12:39:09	Parse ref oids without trailing newline
51e1d808	2012-08-06T12:41:08	Merge remote-tracking branch 'arrbee/tree-walk-fixes' into development Conflicts: src/notes.c src/transports/git.c src/transports/http.c src/transports/local.c tests-clar/odb/foreach.c
5dca2010	2012-08-03T17:08:01	Update iterators for consistency across library This updates all the `foreach()` type functions across the library that take callbacks from the user to have a consistent behavior. The rules are: * A callback terminates the loop by returning any non-zero value * Once the callback returns non-zero, it will not be called again (i.e. the loop stops all iteration regardless of state) * If the callback returns non-zero, the parent fn returns GIT_EUSER * Although the parent returns GIT_EUSER, no error will be set in the library and `giterr_last()` will return NULL if called. This commit makes those changes across the library and adds tests for most of the iteration APIs to make sure that they follow the above rules.
ef4d795e	2012-07-20T16:39:22	refs: drop git_reference_remote_tracking_from_branch()
88bcd515	2012-07-20T16:27:56	branch: introduce git_reference_is_branch()
151d81a6	2012-07-12T22:03:28	refs: fix a memory leak
84f18e35	2012-07-12T00:44:07	refs: introduce git_reference_remote_tracking_from_branch()
5ffd510d	2012-07-04T12:23:03	refs: remove seemingly useless giterr_clear() call
33c33707	2012-07-04T12:20:43	refs: deploy git_reference_has_log()
75261421	2012-07-04T11:58:04	refs: add git_reference_has_log()
b6bfd96f	2012-07-03T12:07:33	refs: fix moving of the reflog when renaming a ref
527ed554	2012-06-22T15:51:44	references: introduce git_reference_foreach_glob()
edebceff	2012-05-01T13:57:45	Add git_reset() Currently supports Soft and Mixed modes.
904b67e6	2012-05-18T01:48:50	errors: Rename error codes
e172cf08	2012-05-18T01:21:06	errors: Rename the generic return codes
2e2e9785	2012-05-18T00:42:24	Properly tag all `enums` with a `_t`
4fbd1c00	2012-05-17T20:35:48	refs: git_reference_listall -> git_reference_list
fa6420f7	2012-04-29T21:46:33	buf: deploy git_buf_len()
9738e2cd	2012-04-27T18:04:58	refs: fix unused-but-set warning
c2b67043	2012-04-25T15:20:28	Rename git_khash_str to git_strmap, etc. This renamed `git_khash_str` to `git_strmap`, `git_hash_oid` to `git_oidmap`, and deletes `git_hashtable` from the tree, plus adds unit tests for `git_strmap`.
01fed0a8	2012-04-25T10:36:01	Convert hashtable usage over to khash This updates khash.h with some extra features (like error checking on allocations, ability to use wrapped malloc, foreach calls, etc), creates two high-level wrappers around khash: `git_khash_str` and `git_khash_oid` for string-to-void-ptr and oid-to-void-ptr tables, then converts all of the old usage of `git_hashtable` over to use these new hashtables. For `git_khash_str`, I've tried to create a set of macros that yield an API not too unlike the old `git_hashtable` API. Since the oid hashtable is only used in one file, I haven't bother to set up all those macros and just use the khash APIs directly for now.
2bc8fa02	2012-04-17T10:14:24	Implement git_pool paged memory allocator This adds a `git_pool` object that can do simple paged memory allocation with free for the entire pool at once. Using this, you can replace many small allocations with large blocks that can then cheaply be doled out in small pieces. This is best used when you plan to free the small blocks all at once - for example, if they represent the parsed state from a file or data stream that are either all kept or all discarded. There are two real patterns of usage for `git_pools`: either for "string" allocation, where the item size is a single byte and you end up just packing the allocations in together, or for "fixed size" allocation where you are allocating a large object (e.g. a `git_oid`) and you generally just allocation single objects that can be tightly packed. Of course, you can use it for other things, but those two cases are the easiest.
26515e73	2012-04-23T10:06:31	Rename to git_reference_name_to_oid
44ef8b1b	2012-04-13T13:00:10	Fix warnings on 64-bit windows builds This fixes all the warnings on win64 except those in deps, which come from the regex code.
f201d613	2012-04-13T10:33:14	Add git_reference_lookup_oid and lookup_resolved Adds a new public reference function `git_reference_lookup_oid` that directly resolved a reference name to an OID without returning the intermediate `git_reference` object (hence, no free needed). Internally, this adds a `git_reference_lookup_resolved` function that combines looking up and resolving a reference. This allows us to be more efficient with memory reallocation. The existing `git_reference_lookup` and `git_reference_resolve` are reimplmented on top of the new utility and a few places in the code are changed to use one of the two new functions.
4615f0f7	2012-04-09T03:22:14	branch: add git_branch_move()
0d0fa7c3	2012-03-16T15:56:01	Convert attr, ignore, mwindow, status to new errors Also cleaned up some previously converted code that still had little things to polish.
e1de726c	2012-03-12T22:55:40	Migrate ODB files to new error handling This migrates odb.c, odb_loose.c, odb_pack.c and pack.c to the new style of error handling. Also got the unix and win32 versions of map.c. There are some minor changes to other files but no others were completely converted. This also contains an update to filebuf so that a zeroed out filebuf will not think that the fd (== 0) is actually open (and inadvertently call close() on fd 0 if cleaned up). Lastly, this was built and tested on win32 and contains a bunch of fixes for the win32 build which was pretty broken.
ae9e29fd	2012-03-06T16:14:31	Migrating diff to new error handling Ended up migrating a bunch of upstream functions as well including vector, attr_file, and odb in order to get this to work right.
1a481123	2012-02-17T00:13:34	error-handling: References Yes, this is error handling solely for `refs.c`, but some of the abstractions leak all ofer the code base.
45d387ac	2012-02-15T16:54:17	refs: Error handling rework. WIP
854eccbb	2012-02-29T12:04:59	Clean up GIT_UNUSED macros on all platforms It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5 did not fix the GIT_USUSED behavior on all platforms. This commit walks through and really cleans things up more thoroughly, getting rid of the unnecessary stuff. To remove the use of some GIT_UNUSED, I ended up adding a couple of new iterators for hashtables that allow you to iterator just over keys or just over values. In making this change, I found a bug in the clar tests (where we were doing count++ but meant to do (count)++ to increment the value). I fixed that but then found the test failing because it was not really using an empty repo. So, I took some of the code that I wrote for iterator testing and moved it to clar_helpers.c, then made use of that to make it easier to open fixtures on a per test basis even within a single test file.
13224ea4	2012-02-27T04:28:31	buffer: Unify `git_fbuffer` and `git_buf` This makes so much sense that I can't believe it hasn't been done before. Kill the old `git_fbuffer` and read files straight into `git_buf` objects. Also: In order to fully support 4GB files in 32-bit systems, the `git_buf` implementation has been changed from using `ssize_t` for storage and storing negative values on allocation failure, to using `size_t` and changing the buffer pointer to a magical pointer on allocation failure. Hopefully this won't break anything.
5e0de328	2012-02-13T17:10:24	Update Copyright header Signed-off-by: schu <schu-github@schulog.org>
20c50b9e	2012-01-19T19:09:47	refs: don't leak the packref when deleting/renaming When we remove the ref from the hashtable, we need to free the packref.
1744fafe	2012-01-17T15:49:47	Move path related functions from fileops to path This takes all of the functions that look up simple data about paths (such as `git_futils_isdir`) and moves them over to path.h (becoming `git_path_isdir`). This leaves fileops.h just with functions that actually manipulate the filesystem or look at the file contents in some way. As part of this, the dir.h header which is really just for win32 support was moved into win32 (with some minor changes).
9191a6d2	2012-01-02T09:56:48	Merge remote-tracking branch 'arrbee/git-attributes' into development Conflicts: tests-clay/clay_main.c
fa515656	2011-12-25T00:22:20	refs: Fix double free Includes relevant Clay test
ee1f0b1a	2011-12-16T10:56:43	Add APIs for git attributes This adds APIs for querying git attributes. In addition to the new API in include/git2/attr.h, most of the action is in src/attr_file.[hc] which contains utilities for dealing with a single attributes file, and src/attr.[hc] which contains the implementation of the APIs that merge all applicable attributes files.
97769280	2011-11-30T11:27:15	Use git_buf for path storage instead of stack-based buffers This converts virtually all of the places that allocate GIT_PATH_MAX buffers on the stack for manipulating paths to use git_buf objects instead. The patch is pretty careful not to touch the public API for libgit2, so there are a few places that still use GIT_PATH_MAX. This extends and changes some details of the git_buf implementation to add a couple of extra functions and to make error handling easier. This includes serious alterations to all the path.c functions, and several of the fileops.c ones, too. Also, there are a number of new functions that parallel existing ones except that use a git_buf instead of a stack-based buffer (such as git_config_find_global_r that exists alongsize git_config_find_global). This also modifies the win32 version of p_realpath to allocate whatever buffer size is needed to accommodate the realpath instead of hardcoding a GIT_PATH_MAX limit, but that change needs to be tested still.
45e79e37	2011-11-26T04:59:21	Rename all `_close` methods There's no difference between `_free` and `_close` semantics: keep everything with the same name to avoid confusions.
9462c471	2011-11-25T08:16:26	repository: Change ownership semantics The ownership semantics have been changed all over the library to be consistent. There are no more "borrowed" or duplicated references. Main changes: - `git_repository_open2` and `3` have been dropped. - Added setters and getters to hotswap all the repository owned objects: `git_repository_index` `git_repository_set_index` `git_repository_odb` `git_repository_set_odb` `git_repository_config` `git_repository_set_config` `git_repository_workdir` `git_repository_set_workdir` Now working directories/index files/ODBs and so on can be hot-swapped after creating a repository and between operations. - All these objects now have proper ownership semantics with refcounting: they all require freeing after they are no longer needed (the repository always keeps its internal reference). - Repository open and initialization has been updated to keep in mind the configuration files. Bare repositories are now always detected, and a default config file is created on init. - All the tests affected by these changes have been dropped from the old test suite and ported to the new one.
e42ea1f4	2011-11-25T21:30:08	Merge pull request #491 from schu/refs-cleanup reference_rename() cleanup
b762e576	2011-11-17T15:10:27	filebuf: add GIT_FILEBUF_INIT and protect multiple opens and cleanups Update all stack allocations of git_filebuf to use GIT_FILEBUF_INIT and make git_filebuf_open and git_filebuf_cleanup safe to be called multiple times on the same buffer. Signed-off-by: Vicent Marti <tanoku@gmail.com>
a5cd086d	2011-11-21T11:56:00	reference_rename: don't delete the reflog reference_rename used to delete an old reflog file when renaming a reference to not confuse git.git. Don't do this anymore but let the user take care of writing a reflog entry. Signed-off-by: schu <schu-github@schulog.org>
64093ce5	2011-11-21T11:30:14	reference_rename: make sure to rollback Actually rollback when we can't create the new reference. Mark the rolled back reference as loose. Signed-off-by: schu <schu-github@schulog.org>
9788e72a	2011-11-16T11:39:03	refs: move GIT_PACKED_REFS_FILE_MODE to refs.h as GIT_PACKEDREFS_FILE_MODE This groups the #define with the other ref-related file modes, and it makes the name consistent with the other packed-refs definitions.
7096d0f9	2011-11-16T11:36:13	refs: use 0666 permissions when writing packed-refs, not 0644 This matches stock Git's behavior.
657a3951	2011-11-07T20:32:03	Write packed-refs with 0644 permissions Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
718eb4b8	2011-11-07T20:06:01	Reword packed-refs error messages so they're easier to track down Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
d4a0b124	2011-10-30T21:58:33	refs: Partial rewrite for read-only refs This new version of the references code is significantly faster and hopefully easier to read. External API stays the same. A new method `git_reference_reload()` has been added to force updating a memory reference from disk. In-memory references are no longer updated automagically -- this was killing us. If a reference is deleted externally and the user doesn't reload the memory object, nothing critical happens: any functions using that reference should fail gracefully (e.g. deletion, renaming, and so on). All generated references from the API are read only and must be free'd by the user. There is no reference counting and no traces of generated references are kept in the library. There is no longer an internal representation for references. There is only one reference struct `git_reference`, and symbolic/oid targets are stored inside an union. Packfile references are stored using an optimized struct with flex array for reference names. This should significantly reduce the memory cost of loading the packfile from disk.

c1b5e8c4

2013-02-15T11:35:33

branch: Make git_branch_remote_name() cope with orphaned heads

56543a60

2013-02-15T16:02:45

Clear up warnings from cppcheck The cppcheck static analyzer generates warnings for a bunch of places in the libgit2 code base. All the ones fixed in this commit are actually false positives, but I've reorganized the code to hopefully make it easier for static analysis tools to correctly understand the structure. I wouldn't do this if I felt like it was making the code harder to read or worse for humans, but in this case, these fixes don't seem too bad and will hopefully make it easier for better analysis tools to get at any real issues.

2bca5b67

2013-02-07T23:44:18

remote: Introduce git_remote_is_valid_name() Fix libgit2/libgit2sharp#318

4d811c3b

2013-02-07T23:40:10

refs: No component of a refname can end with '.lock'

e5ef0f18

2013-01-31T20:23:30

refs: handle ALLOW_ONELEVEL normalization with leading slash A leading slash confuses the name normalization code when the flags include ALLOW_ONELEVEL. Catch this case in particular to avoid triggering an assertion in the uppercase check which expects us not to pass it an empty string. The existing tests don't catch this as they simply use the NORMAL flag. This fixes #1300.

cb35094b

2013-01-22T15:49:51

Allow peeled references without trailing newline at end of file Also ammends one of the tag tests to make sure it's working.

2a707d0e

2013-01-22T14:08:50

Revert "Handle packed peeled objects without trailing newlines" This reverts commit 28b1cdf3a1bdcd37cf9d550c92b8c19b1782ea6b. //cc #1262 #1267

28b1cdf3

2013-01-21T14:45:43

Handle packed peeled objects without trailing newlines Fixes #1262

bf031581

2013-01-14T14:22:11

branch: Introduce git_branch_tracking_name()

359fc2d2

2013-01-08T17:07:25

update copyrights

ef82ff30

2013-01-05T00:46:39

Handle packed refs with no trailing newline I saw a repo in the wild today which had a master branch ref which was packed, but had no trailing newline. Git handled it fine, but libgit2 choked on it. Fix seems simple enough. If we don't see a newline, assume the end of the buffer is the end of the ref line.

3865f7f6

2012-12-27T23:23:12

Invalid ref name normalization leaked memory When normalizing a reference name, if there is an error because the name is invalid, then the memory allocated for storing the name could be leaked if the caller was not careful and assumed that the error return code meant that no allocation had occurred. This fixes that by explicitly deallocating the reference name buffer if there is an error in normalizing the name.

ed4e887d

2012-12-18T16:09:57

Also, whitespace. I was totally flaunting @ben's 3-space tab advice.

33f169e2

2012-12-18T16:07:18

Improve comment text This looked wrong to me. I *think* this is more appropriate commentary.

28abb187

2012-12-14T14:16:10

Stop returning incorrect error message

b524fe1a

2012-12-14T08:35:59

Local Only ignore ENOTFOUNDs when adding corrupted refs

80d9d1df

2012-11-12T15:42:15

refs: Deploy EINVALIDSPEC usage

83458bb7

2012-11-12T14:06:13

refs: Fix error clearing

d9023dbe

2012-11-20T17:06:54

API updates for tag.h

eecc8050

2012-11-20T14:03:05

Update callback fn ptr for git_reference_foreach As part of API review, use a typedef for the callback fn ptr.

2508cc66

2012-11-18T21:38:08

Rename ref and reflog apis for consistency

331e7de9

2012-10-24T17:32:50

Extensions to rmdir and mkdir utilities * Rework GIT_DIRREMOVAL values to GIT_RMDIR flags, allowing combinations of flags * Add GIT_RMDIR_EMPTY_PARENTS flag to remove parent dirs that are left empty after removal * Add GIT_MKDIR_VERIFY_DIR to give an error if item is a file, not a dir (previously an EEXISTS error was ignored, even for files) and enable this flag for git_futils_mkpath2file call * Improve accuracy of error messages from git_futils_mkdir

b90500f0

2012-11-01T14:08:30

Improve docs, examples, warnings This improves docs in some of the public header files, cleans up and improves some of the example code, and fixes a couple of pedantic warnings in places.

744cc03e

2012-10-30T12:10:36

Add git_config_refresh() API to reload config This adds a new API that allows users to reload the config if the file has changed on disk. A new config callback function to refresh the config was added. The modified time and file size are used to test if the file needs to be reloaded (and are now stored in the disk backend object). In writing tests, just using mtime was a problem / race, so I wanted to check file size as well. To support that, I extended `git_futils_readbuffer_updated` to optionally check file size in addition to mtime, and I added a new function `git_filebuf_stats` to fetch the mtime and size for an open filebuf (so that the config could be easily refreshed after a write). Lastly, I moved some similar file checking code for attributes into filebuf. It is still only being used for attrs, but it seems potentially reusable, so I thought I'd move it over.

4c47a8bc

2012-10-17T14:14:51

Merge pull request #968 from arrbee/diff-support-typechange Support TYPECHANGE records in status and adjust checkout accordingly

7ae5ab56

2012-10-15T16:35:10

Fix leak in the tests Also introduce the slective ref trimming promised but also missed in the previous commit.

47f44b6e

2012-10-15T13:51:25

refs: loosen the OID parsing We used to require loose references to contain only an OID (possibly after trimming the string). This is however not enough for letting us lookup FETCH_HEAD, which can have a lot of content after the initial OID. Change the parsing rules so that a loose refernce must e at least 40 bytes long and the 41st (if it's there) must be accepted by isspace(3). This makes the trim unnecessary, so only do it for symrefs. This fixes #977.

3548fcf5

2012-10-11T14:00:26

refs: propagate EEXISTS upon renaming

0d64bef9

2012-10-05T15:56:57

Add complex checkout test and then fix checkout This started as a complex new test for checkout going through the "typechanges" test repository, but that revealed numerous issues with checkout, including: * complete failure with submodules * failure to create blobs with exec bits * problems when replacing a tree with a blob because the tree "example/" sorts after the blob "example" so the delete was being processed after the single file blob was created This fixes most of those problems and includes a number of other minor changes that made it easier to do that, including improving the TYPECHANGE support in diff/status, etc.

4ba23be1

2012-10-06T12:20:13

branch: deploy git_branch_is_head()

f3cc7834

2012-09-22T12:51:34

refs: deploy git_repository_set_head() usage

74a24005

2012-09-21T10:28:20

refs: use constants for well-known names

8bc5cacc

2012-10-01T13:57:32

Merge pull request #961 from arrbee/win64-cleanups Win64 cleanups

7c411fd9

2012-10-01T12:32:55

Fix up more Win64 compile warnings

c1281493

2012-09-30T11:37:53

refs: propagate EEXISTS Indicate whether the error comes from the ref already existing or elsewhere. We always perform the check and this lets the user write more concise code.

0adfa20a

2012-09-11T11:42:13

refspec: introduce git_refspec__parse()

77e06d7e

2012-09-17T07:11:32

refs: introduce git_reference_is_valid_name()

c030ada7

2012-09-11T12:06:57

refs: make git_reference_normalize_name() accept refspec pattern

c2948c77

2012-09-14T21:36:49

refs: prevent locked refs from being enumerated Fix #936

31665948

2012-08-24T21:30:45

refs: introduce git_reference_peel() Fix #530

f335ecd6

2012-08-30T14:24:16

Diff iterators This refactors the diff output code so that an iterator object can be used to traverse and generate the diffs, instead of just the `foreach()` style with callbacks. The code has been rearranged so that the two styles can still share most functions. This also replaces `GIT_REVWALKOVER` with `GIT_ITEROVER` and uses that as a common error code for marking the end of iteration when using a iterator style of object.

0844ed06

2012-08-28T20:15:21

Fix parentheses warning

62eafd06

2012-08-27T14:54:52

Merge branch 'branch-delete-ref' into development Conflicts: include/git2/refs.h

2e0c8816

2012-08-26T22:08:22

refs: expose git_reference_normalize_name()

1c947daa

2012-08-23T15:47:29

branch: Change `git_branch_delete` to take a ref

c07d9c95

2012-08-09T15:33:04

oid: Explicitly include `oid.h` for the inlined CMP

186c054d

2012-08-09T14:47:29

Revert implementation changes

28e00681

2012-08-09T14:39:56

Ignore ref oid terminator

2fe293b6

2012-08-09T11:36:21

trim whitespace when parsing loose refs

6ab68290

2012-08-09T12:39:09

Parse ref oids without trailing newline

51e1d808

2012-08-06T12:41:08

Merge remote-tracking branch 'arrbee/tree-walk-fixes' into development Conflicts: src/notes.c src/transports/git.c src/transports/http.c src/transports/local.c tests-clar/odb/foreach.c

5dca2010

2012-08-03T17:08:01

Update iterators for consistency across library This updates all the `foreach()` type functions across the library that take callbacks from the user to have a consistent behavior. The rules are: * A callback terminates the loop by returning any non-zero value * Once the callback returns non-zero, it will not be called again (i.e. the loop stops all iteration regardless of state) * If the callback returns non-zero, the parent fn returns GIT_EUSER * Although the parent returns GIT_EUSER, no error will be set in the library and `giterr_last()` will return NULL if called. This commit makes those changes across the library and adds tests for most of the iteration APIs to make sure that they follow the above rules.

ef4d795e

2012-07-20T16:39:22

refs: drop git_reference_remote_tracking_from_branch()

88bcd515

2012-07-20T16:27:56

branch: introduce git_reference_is_branch()

151d81a6

2012-07-12T22:03:28

refs: fix a memory leak

84f18e35

2012-07-12T00:44:07

refs: introduce git_reference_remote_tracking_from_branch()

5ffd510d

2012-07-04T12:23:03

refs: remove seemingly useless giterr_clear() call

33c33707

2012-07-04T12:20:43

refs: deploy git_reference_has_log()

75261421

2012-07-04T11:58:04

refs: add git_reference_has_log()

b6bfd96f

2012-07-03T12:07:33

refs: fix moving of the reflog when renaming a ref

527ed554

2012-06-22T15:51:44

references: introduce git_reference_foreach_glob()

edebceff

2012-05-01T13:57:45

Add git_reset() Currently supports Soft and Mixed modes.

904b67e6

2012-05-18T01:48:50

errors: Rename error codes

e172cf08

2012-05-18T01:21:06

errors: Rename the generic return codes

2e2e9785

2012-05-18T00:42:24

Properly tag all `enums` with a `_t`

4fbd1c00

2012-05-17T20:35:48

refs: git_reference_listall -> git_reference_list

fa6420f7

2012-04-29T21:46:33

buf: deploy git_buf_len()

9738e2cd

2012-04-27T18:04:58

refs: fix unused-but-set warning

c2b67043

2012-04-25T15:20:28

Rename git_khash_str to git_strmap, etc. This renamed `git_khash_str` to `git_strmap`, `git_hash_oid` to `git_oidmap`, and deletes `git_hashtable` from the tree, plus adds unit tests for `git_strmap`.

01fed0a8

2012-04-25T10:36:01

Convert hashtable usage over to khash This updates khash.h with some extra features (like error checking on allocations, ability to use wrapped malloc, foreach calls, etc), creates two high-level wrappers around khash: `git_khash_str` and `git_khash_oid` for string-to-void-ptr and oid-to-void-ptr tables, then converts all of the old usage of `git_hashtable` over to use these new hashtables. For `git_khash_str`, I've tried to create a set of macros that yield an API not too unlike the old `git_hashtable` API. Since the oid hashtable is only used in one file, I haven't bother to set up all those macros and just use the khash APIs directly for now.

2bc8fa02

2012-04-17T10:14:24

Implement git_pool paged memory allocator This adds a `git_pool` object that can do simple paged memory allocation with free for the entire pool at once. Using this, you can replace many small allocations with large blocks that can then cheaply be doled out in small pieces. This is best used when you plan to free the small blocks all at once - for example, if they represent the parsed state from a file or data stream that are either all kept or all discarded. There are two real patterns of usage for `git_pools`: either for "string" allocation, where the item size is a single byte and you end up just packing the allocations in together, or for "fixed size" allocation where you are allocating a large object (e.g. a `git_oid`) and you generally just allocation single objects that can be tightly packed. Of course, you can use it for other things, but those two cases are the easiest.

26515e73

2012-04-23T10:06:31

Rename to git_reference_name_to_oid

44ef8b1b

2012-04-13T13:00:10

Fix warnings on 64-bit windows builds This fixes all the warnings on win64 except those in deps, which come from the regex code.

f201d613

2012-04-13T10:33:14

Add git_reference_lookup_oid and lookup_resolved Adds a new public reference function `git_reference_lookup_oid` that directly resolved a reference name to an OID without returning the intermediate `git_reference` object (hence, no free needed). Internally, this adds a `git_reference_lookup_resolved` function that combines looking up and resolving a reference. This allows us to be more efficient with memory reallocation. The existing `git_reference_lookup` and `git_reference_resolve` are reimplmented on top of the new utility and a few places in the code are changed to use one of the two new functions.

4615f0f7

2012-04-09T03:22:14

branch: add git_branch_move()

0d0fa7c3

2012-03-16T15:56:01

Convert attr, ignore, mwindow, status to new errors Also cleaned up some previously converted code that still had little things to polish.

e1de726c

2012-03-12T22:55:40

Migrate ODB files to new error handling This migrates odb.c, odb_loose.c, odb_pack.c and pack.c to the new style of error handling. Also got the unix and win32 versions of map.c. There are some minor changes to other files but no others were completely converted. This also contains an update to filebuf so that a zeroed out filebuf will not think that the fd (== 0) is actually open (and inadvertently call close() on fd 0 if cleaned up). Lastly, this was built and tested on win32 and contains a bunch of fixes for the win32 build which was pretty broken.

ae9e29fd

2012-03-06T16:14:31

Migrating diff to new error handling Ended up migrating a bunch of upstream functions as well including vector, attr_file, and odb in order to get this to work right.

1a481123

2012-02-17T00:13:34

error-handling: References Yes, this is error handling solely for `refs.c`, but some of the abstractions leak all ofer the code base.

45d387ac

2012-02-15T16:54:17

refs: Error handling rework. WIP

854eccbb

2012-02-29T12:04:59

Clean up GIT_UNUSED macros on all platforms It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5 did not fix the GIT_USUSED behavior on all platforms. This commit walks through and really cleans things up more thoroughly, getting rid of the unnecessary stuff. To remove the use of some GIT_UNUSED, I ended up adding a couple of new iterators for hashtables that allow you to iterator just over keys or just over values. In making this change, I found a bug in the clar tests (where we were doing *count++ but meant to do (*count)++ to increment the value). I fixed that but then found the test failing because it was not really using an empty repo. So, I took some of the code that I wrote for iterator testing and moved it to clar_helpers.c, then made use of that to make it easier to open fixtures on a per test basis even within a single test file.

13224ea4

2012-02-27T04:28:31

buffer: Unify `git_fbuffer` and `git_buf` This makes so much sense that I can't believe it hasn't been done before. Kill the old `git_fbuffer` and read files straight into `git_buf` objects. Also: In order to fully support 4GB files in 32-bit systems, the `git_buf` implementation has been changed from using `ssize_t` for storage and storing negative values on allocation failure, to using `size_t` and changing the buffer pointer to a magical pointer on allocation failure. Hopefully this won't break anything.

5e0de328

2012-02-13T17:10:24

Update Copyright header Signed-off-by: schu <schu-github@schulog.org>

20c50b9e

2012-01-19T19:09:47

refs: don't leak the packref when deleting/renaming When we remove the ref from the hashtable, we need to free the packref.

1744fafe

2012-01-17T15:49:47

Move path related functions from fileops to path This takes all of the functions that look up simple data about paths (such as `git_futils_isdir`) and moves them over to path.h (becoming `git_path_isdir`). This leaves fileops.h just with functions that actually manipulate the filesystem or look at the file contents in some way. As part of this, the dir.h header which is really just for win32 support was moved into win32 (with some minor changes).

9191a6d2

2012-01-02T09:56:48

Merge remote-tracking branch 'arrbee/git-attributes' into development Conflicts: tests-clay/clay_main.c

fa515656

2011-12-25T00:22:20

refs: Fix double free Includes relevant Clay test

ee1f0b1a

2011-12-16T10:56:43

Add APIs for git attributes This adds APIs for querying git attributes. In addition to the new API in include/git2/attr.h, most of the action is in src/attr_file.[hc] which contains utilities for dealing with a single attributes file, and src/attr.[hc] which contains the implementation of the APIs that merge all applicable attributes files.

97769280

2011-11-30T11:27:15

Use git_buf for path storage instead of stack-based buffers This converts virtually all of the places that allocate GIT_PATH_MAX buffers on the stack for manipulating paths to use git_buf objects instead. The patch is pretty careful not to touch the public API for libgit2, so there are a few places that still use GIT_PATH_MAX. This extends and changes some details of the git_buf implementation to add a couple of extra functions and to make error handling easier. This includes serious alterations to all the path.c functions, and several of the fileops.c ones, too. Also, there are a number of new functions that parallel existing ones except that use a git_buf instead of a stack-based buffer (such as git_config_find_global_r that exists alongsize git_config_find_global). This also modifies the win32 version of p_realpath to allocate whatever buffer size is needed to accommodate the realpath instead of hardcoding a GIT_PATH_MAX limit, but that change needs to be tested still.

45e79e37

2011-11-26T04:59:21

Rename all `_close` methods There's no difference between `_free` and `_close` semantics: keep everything with the same name to avoid confusions.

9462c471

2011-11-25T08:16:26

repository: Change ownership semantics The ownership semantics have been changed all over the library to be consistent. There are no more "borrowed" or duplicated references. Main changes: - `git_repository_open2` and `3` have been dropped. - Added setters and getters to hotswap all the repository owned objects: `git_repository_index` `git_repository_set_index` `git_repository_odb` `git_repository_set_odb` `git_repository_config` `git_repository_set_config` `git_repository_workdir` `git_repository_set_workdir` Now working directories/index files/ODBs and so on can be hot-swapped after creating a repository and between operations. - All these objects now have proper ownership semantics with refcounting: they all require freeing after they are no longer needed (the repository always keeps its internal reference). - Repository open and initialization has been updated to keep in mind the configuration files. Bare repositories are now always detected, and a default config file is created on init. - All the tests affected by these changes have been dropped from the old test suite and ported to the new one.

e42ea1f4

2011-11-25T21:30:08

Merge pull request #491 from schu/refs-cleanup reference_rename() cleanup

b762e576

2011-11-17T15:10:27

filebuf: add GIT_FILEBUF_INIT and protect multiple opens and cleanups Update all stack allocations of git_filebuf to use GIT_FILEBUF_INIT and make git_filebuf_open and git_filebuf_cleanup safe to be called multiple times on the same buffer. Signed-off-by: Vicent Marti <tanoku@gmail.com>

a5cd086d

2011-11-21T11:56:00

reference_rename: don't delete the reflog reference_rename used to delete an old reflog file when renaming a reference to not confuse git.git. Don't do this anymore but let the user take care of writing a reflog entry. Signed-off-by: schu <schu-github@schulog.org>

64093ce5

2011-11-21T11:30:14

reference_rename: make sure to rollback Actually rollback when we can't create the new reference. Mark the rolled back reference as loose. Signed-off-by: schu <schu-github@schulog.org>

9788e72a

2011-11-16T11:39:03

refs: move GIT_PACKED_REFS_FILE_MODE to refs.h as GIT_PACKEDREFS_FILE_MODE This groups the #define with the other ref-related file modes, and it makes the name consistent with the other packed-refs definitions.

7096d0f9

2011-11-16T11:36:13

refs: use 0666 permissions when writing packed-refs, not 0644 This matches stock Git's behavior.

657a3951

2011-11-07T20:32:03

Write packed-refs with 0644 permissions Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>

718eb4b8

2011-11-07T20:06:01

Reword packed-refs error messages so they're easier to track down Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>

d4a0b124

2011-10-30T21:58:33

refs: Partial rewrite for read-only refs This new version of the references code is significantly faster and hopefully easier to read. External API stays the same. A new method `git_reference_reload()` has been added to force updating a memory reference from disk. In-memory references are no longer updated automagically -- this was killing us. If a reference is deleted externally and the user doesn't reload the memory object, nothing critical happens: any functions using that reference should fail gracefully (e.g. deletion, renaming, and so on). All generated references from the API are read only and must be free'd by the user. There is no reference counting and no traces of generated references are kept in the library. There is no longer an internal representation for references. There is only one reference struct `git_reference`, and symbolic/oid targets are stored inside an union. Packfile references are stored using an optimized struct with flex array for reference names. This should significantly reduce the memory cost of loading the packfile from disk.

thodg/libgit2/src/refs.c

src/refs.c

Log