kmx git

Commit	Date	Message
90431f1b	2013-04-10T08:33:33	Merge pull request #1424 from phkelley/efficient_push Reduce the number of unnecessary objects in pushed packs
ad26434b	2013-04-09T14:52:32	Tests and more fixes for submodule diffs This adds tests for diffs with submodules in them and (perhaps unsurprisingly) requires further fixes to be made. Specifically, this fixes: - when considering if a submodule is dirty in the workdir, it was being treated as dirty even if only the index was dirty. - git_diff_patch_to_str (and git_diff_patch_print) were "printing" the headers for files (and submodules) that were unmodified or had no meaningful content. - added comment to previous fix and removed unneeded parens.
9da187e8	2013-04-09T11:40:00	Fix clang warnings and improve checks
94750e8a	2013-03-29T11:52:18	Fix submodule dirty states not showing if submodules comes before files, or there are only dirty submodules but no changed files GIT_DIFF_PATCH_DIFFABLE was not set, so the diff content was not shown When submodule is dirty, the hash may be the same, but the length is different because -dirty is appended We can therefore compare the length or hash
d9ecaf8c	2013-04-07T07:22:38	Merge remote-tracking branch 'gnprice/revwalk' into development
af079d8b	2013-03-03T20:54:23	revwalk: Parse revision ranges All the hard work is already in revparse. Signed-off-by: Greg Price <price@mit.edu>
b208d900	2013-03-20T10:01:58	revparse: Parse range-like syntax Signed-off-by: Greg Price <price@mit.edu>
08283cbd	2013-04-01T07:12:49	Merge pull request #1448 from phkelley/development Avoid pre-Win7 WinHTTP self-redirect quirk
b39f9697	2013-03-31T23:04:14	Fix whitespace in src/win32/version.h
5c5eeba6	2013-03-31T22:22:33	Add git_has_win32_version helper
8cc2f2d8	2013-03-31T12:10:27	Win32 error reporting: Support WinHTTP errors
24cb87e2	2013-03-31T13:27:43	tag: Fix parsing when no tagger nor message
0227fa2a	2013-03-30T21:36:04	Avoid pre-Win7 WinHTTP self-redirect quirk
54a1a042	2013-03-29T11:26:12	remove unmerged files during reset hard
8cfd54f0	2013-03-26T12:27:15	Fix Windows/Win32 warning
0b061b5b	2013-03-26T11:05:57	Merge pull request #1436 from schu/opts-cache-size opts: allow configuration of odb cache size
86d24ce4	2013-03-26T10:42:30	Merge pull request #1439 from arrbee/recurse-ignored-dirs Several diff and status fixes
ccfa6805	2013-03-25T23:58:40	Fix some diff ignores and submodule dirty workdir This started out trying to look at the problems from issue #1425 and gradually grew to a broader set of fixes. There are two core things fixed here: 1. When you had an ignore like "/bin" which is rooted at the top of your tree, instead of immediately adding the "bin/" entry as an ignored item in the diff, we were returning all of the direct descendants of the directory as ignored items. This changes things to immediately ignore the directory. Note that this effects the behavior in test_status_ignore__subdirectories so that we no longer exactly match core gits ignore behavior, but the new behavior probably makes more sense (i.e. we now will include an ignored directory inside an untracked directory that we previously would have left off). 2. When a submodule only contained working directory changes, the diff code was always considering it unmodified which was just an outright bug. The HEAD SHA of the submodule matches the SHA in the parent repo index, and since the SHAs matches, the diff code was overwriting the actual status with UNMODIFIED. These fixes broke existing tests test_diff_workdir__submodules and test_status_ignore__subdirectories but looking it over, I actually think the new results are correct and the old results were wrong. @nulltoken had actually commented on the subdirectory ignore issue previously. I also included in the tests some debugging versions of the shared iteration callback routines that print status or diff information. These aren't used actively in the tests, but can be quickly swapped in to test code to give a better picture of what is being scanned in some of the complex test scenarios.
37ee70fa	2013-03-25T22:19:39	Implement GIT_STATUS_OPT_EXCLUDE_SUBMODULES This option has been sitting unimplemented for a while, so I finally went through and implemented it along with some tests. As part of this, I improved the implementation of GIT_DIFF_IGNORE_SUBMODULES so it be more diligent about avoiding extra work and about leaving off delta records for submodules to the greatest extent possible (though it may include them still if you are request TYPECHANGE records).
d2a4a54b	2013-03-25T21:46:51	Merge pull request #1438 from ethomson/checkout_stat don't stat until the file is written
d828f118	2013-03-25T18:16:02	don't stat until the file is written
0c289dd7	2013-03-25T16:40:16	Recursing into ignored dirs for diff and status This implements working versions of GIT_DIFF_RECURSE_IGNORED_DIRS and GIT_STATUS_OPT_RECURSE_IGNORED_DIRS along with some tests for the newly available behaviors. This is not turned on by default for status, but can be accessed via the options to the extended version of the command.
f2850f33	2013-03-25T15:30:37	Merge pull request #1437 from phkelley/redirect http: Support 302 Found (arrbee did most of the work)
35e0f3c6	2013-03-25T17:59:30	Refine the redirect check condition
2c7f7a66	2013-03-25T17:35:36	http: Support 302 Found (arrbee did most of the work)
3658e81e	2013-03-25T14:20:07	Move crlf conversion into buf_text This adds crlf/lf conversion functions into buf_text with more efficient implementations that bypass the high level buffer functions. They attempt to minimize the number of reallocations done and they directly write the buffer data as needed if they know that there is enough memory allocated to memcpy data. Tests are added for these new functions. The crlf.c code is updated to use the new functions. Removed the include of buf_text.h from filter.h and just include it more narrowly in the places that need it.
4a15ea86	2013-03-21T14:02:25	don't convert CRLF to CRCRLF
9733e80c	2013-03-22T10:44:45	Add has_cr_in_index check to CRLF filter This adds a check to the drop_crlf filter path to check it the file in the index already has a CR in it, in which case this will not drop the CRs from the workdir file contents. This uncovered a "bug" in `git_blob_create_fromworkdir` where the full path to the file was passed to look up the attributes instead of the relative path from the working directory root. This meant that the check in the index for a pre-existing entry of the same name was failing.
13640d1b	2013-03-25T21:39:11	oid: Do not parse OIDs longer than 40
1f107478	2013-03-25T13:26:50	Merge pull request #1428 from xavier-l/nul-terminated-oid Nul terminated oid
f5e28202	2013-03-25T13:38:43	opts: allow configuration of odb cache size Currently, the odb cache has a fixed size of 128 slots as defined by GIT_DEFAULT_CACHE_SIZE. Allow users to set the size of the cache via git_libgit2_opts(). Fixes #1035.
33a59401	2013-03-22T20:22:39	graph: make the ahead-behind docs clearer Explain it in local-upstream branch terms so it's easier to grasp than with the `one` and `two` naming from the merge-base code.
1e7b7523	2013-03-21T12:30:08	git_oid_fromstrn already sets a maximum on the length of the string
0c8efb38	2013-03-21T11:59:01	Added an oid function that accepts nul-terminated strings
cd01dd5d	2013-03-19T15:43:34	Fix dumb mistake in the comparison function
bef2a12c	2013-03-19T15:35:26	Convert enqueue_object to a function
799f9a04	2013-03-19T14:56:45	Reduce the number of unnecessary objects in pushed packs
65025cb8	2013-03-18T17:24:13	Three submodule status bug fixes 1. Fix sort order problem with submodules where "mod" was sorting after "mod-plus" because they were being sorted as "mod/" and "mod-plus/". This involved pushing the "contains a .git entry" test significantly lower in the stack. 2. Reinstate behavior that a directory which contains a .git entry will be treated as a submodule during iteration even if it is not yet added to the .gitmodules. 3. Now that any directory containing .git is reported as submodule, we have to be more careful checking for GIT_EEXISTS when we do a submodule lookup, because that is the error code that is returned by git_submodule_lookup when you try to look up a directory containing .git that has no record in gitmodules or the index.
5b27bf7e	2013-03-18T16:17:14	Merge pull request #1417 from arrbee/opts-for-paths Implement opts interface for global/system file search paths
32460251	2013-03-18T15:54:35	Fixes and cleanups Get rid of some dead code, tighten things up a bit, and fix a bug with core::env test.
41954a49	2013-03-18T14:19:35	Switch search paths to classic delimited strings This switches the APIs for setting and getting the global/system search paths from using git_strarray to using a simple string with GIT_PATH_LIST_SEPARATOR delimited paths, just as the environment PATH variable would contain. This makes it simpler to get and set the value. I also added code to expand "$PATH" when setting a new value to embed the old value of the path. This means that I no longer require separate actions to PREPEND to the value.
50eb8520	2013-03-18T14:05:31	Merge pull request #1420 from KindDragon/static-code-analyzer-warnings Several warnings detected by static code analyzer fixed
677dce8a	2013-03-18T14:00:09	Merge pull request #1080 from carlosmn/config-set-null Failing config related test
10c06114	2013-03-17T04:46:46	Several warnings detected by static code analyzer fixed Implicit type conversion argument of function to size_t type Suspicious sequence of types castings: size_t -> int -> size_t Consider reviewing the expression of the 'A = B == C' kind. The expression is calculated as following: 'A = (B == C)' Unsigned type is never < 0
5540d947	2013-03-15T16:39:00	Implement global/system file search paths The goal of this work is to expose the search logic for "global", "system", and "xdg" files through the git_libgit2_opts() interface. Behind the scenes, I changed the logic for finding files to have a notion of a git_strarray that represents a search path and to store a separate search path for each of the three tiers of config file. For each tier, I implemented a function to initialize it to default values (generally based on environment variables), and then general interfaces to get it, set it, reset it, and prepend new directories to it. Next, I exposed these interfaces through the git_libgit2_opts interface, reusing the GIT_CONFIG_LEVEL_SYSTEM, etc., constants for the user to control which search path they were modifying. There are alternative designs for the opts interface / argument ordering, so I'm putting this phase out for discussion. Additionally, I ended up doing a little bit of clean up regarding attr.h and attr_file.h, adding a new attrcache.h so the other two files wouldn't have to be included in so many places.
a5f61384	2013-03-15T12:24:20	odb_pack: Unused functions
f16fb099	2013-03-15T12:11:02	pool: Internal struct name
5b229e20	2013-03-15T04:06:31	Merge pull request #1413 from arrbee/more-iterator-refactor Further tree_iterator refactoring
55e0f53d	2013-03-14T15:09:29	Fix various build warnings This fixes various build warnings on Mac and Windows (64-bit).
14bedad9	2013-03-14T15:08:04	Added pool freelist struct for readability This adds a git_pool_freelist_item struct that makes it a little easier to follow what's going on with the pool free list block management code. It is functionally neutral.
d85296ab	2013-03-14T13:50:54	Fix valgrind issues (and mmap fallback for diff) This fixes a number of issues identified by valgrind - mostly missed free calls. Inside valgrind, mmap() may fail which causes some of the diff tests to fail. This adds a fallback code path to diff_output.c:get_workdir_content() where is the mmap() fails the code will now try to read the file data directly into allocated memory (which is what it would do if the data needed to be filtered anyhow).
0c468633	2013-03-14T13:40:15	Improved tree iterator internals This updates the tree iterator internals to be more efficient. The tree_iterator_entry objects are now kept as pointers that are allocated from a git_pool, so that we may use git__tsort_r for sorting (which is better than qsort, given that the tree is likely mostly ordered already). Those tree_iterator_entry objects now keep direct pointers to the data they refer to instead of keeping indirect index values. This simplifies a lot of the data structure traversal code. This also adds bsearch to find the start item position for range- limited tree iterators, and is more explicit about using git_path_cmp instead of reimplementing it. The git_path_cmp changed a bit to make it easier for tree_iterators to use it (but it was barely being used previously, so not a big deal). This adds a git_pool_free_array function that efficiently frees a list of pool allocated pointers (which the tree_iterator keeps). Also, added new tests for the git_pool free list functionality that was not previously being tested (or used).
bbb13646	2013-03-13T14:59:51	Fix workdir iterator bugs This fixes two bugs with the workdir iterator depth check: first that the depth was not being decremented and second that empty directories were counting against the depth even though a frame was not being created for them. This also fixes a bug with the ENOTFOUND return code for workdir iterators when you attempt to advance_into an empty directory. Actually, that works correctly, but it was incorrectly being propogated into regular advance() calls in some circumstances. Added new tests for the above that create a huge hierarchy on the fly and try using the workdir iterator to traverse it.
ad003763	2013-03-12T20:36:35	MSVC: What could possibly be the size of a void*?
f5898324	2013-03-12T15:31:14	Style: Reverse lhs and rhs of == comparisons
b8c32580	2013-03-12T15:19:32	Advertise and support side-band-64k when calling receive-pack
1ac10aae	2013-03-12T09:23:53	Merge pull request #1408 from arrbee/refactor-iterators Refactor iterators
62beacd3	2013-03-11T16:43:58	Sorting function cleanup and MinGW fix Clean up some sorting function stuff including fixing qsort_r on MinGW, common function pointer type for comparison, and basic insertion sort implementation (which we, regrettably, fall back on for MinGW).
b70bf922	2013-03-11T14:35:49	Merge pull request #1406 from cpthamilton/local_push Implemented push on the local transport
20858f6e	2013-02-19T06:22:58	Implemented push on the local transport
a5eea2d7	2013-03-11T11:31:50	Stabilize order for equiv tree iterator entries Given a group of case-insensitively equivalent tree iterator entries, this ensures that the case-sensitively first trees will be used as the representative items. I.e. if you have conflicting entries "A/B/x", "a/b/x", and "A/b/x", this change ensures that the earliest entry "A/B/x" will be returned. The actual choice is not that important, but it is nice to have it stable and to have it been either the first or last item, as opposed to a random item from within the equivalent span.
aa408cbf	2013-03-11T11:18:00	handle small files in similarity metrics
aec4f663	2013-03-11T10:37:12	Fix tree iterator advance using wrong name compare Tree iterator advance was moving forward without taking the filemode of the entries into account, equating "a" and "a/". This makes the tree entry comparison code more easily reusable and fixes the problem.
92028ea5	2013-03-11T09:53:49	Fix tree iterator path for tree issue + cleanups This fixes an off by one error for generating full paths for tree entries in tree iterators when INCLUDE_TREES is set. Also, contains a bunch of small code cleanups with a couple of small utility functions and macro changes to eliminate redundant code.
61c7b61e	2013-03-10T22:38:53	Use correct case path in icase tree iterator If there are case-ambiguities in the path of a case insensitive tree iterator, it will now rewrite the entire path when it gives the path name to an entry, so a tree with "A/b/C/d.txt" and "a/B/c/E.txt" will give the true full paths (instead of case- folding them both to "A/B/C/d.txt" or "a/b/c/E.txt" or something like that.
1aa5318a	2013-03-09T16:04:34	diff: allow asking for diffs with no context Previously, 0 meant default. This is problematic, as asking for 0 context lines is a valid thing to do. Change GIT_DIFF_OPTIONS_INIT to default to three and stop treating 0 as a magic value. In case no options are provided, make sure the options in the diff object default to 3.
48bde2f1	2013-03-08T02:11:34	config: don't allow passing NULL as a value to set Passing NULL is non-sensical. The error message leaves to be desired, though, as it leaks internal implementation details. Catch it at the `git_config_set_string` level and set an appropriate error message.
e40f1c2d	2013-03-08T16:39:57	Make tree iterator handle icase equivalence There is a serious bug in the previous tree iterator implementation. If case insensitivity resulted in member elements being equivalent to one another, and those member elements were trees, then the children of the colliding elements would be processed in sequence instead of in a single flattened list. This meant that the tree iterator was not truly acting like a case-insensitive list. This completely reworks the tree iterator to manage lists with case insensitive equivalence classes and advance through the items in a unified manner in a single sorted frame. It is possible that at a future date we might want to update this to separate the case insensitive and case sensitive tree iterators so that the case sensitive one could be a minimal amount of code and the insensitive one would always know what it needed to do without checking flags. But there would be so much shared code between the two, that I'm not sure it that's a win. For now, this gets what we need. More tests are needed, though.
6f83a781	2013-03-07T11:14:03	Merge pull request #1403 from ethomson/tracing Optional tracing back to consumers
b5ec5430	2013-03-04T23:52:30	optional tracing
d00d5464	2013-03-01T15:37:33	immutable references and a pluggable ref database
bb45c57f	2013-03-07T16:38:44	refs: explicitly catch leading slashes It's somewhat common to try to write "/refs/tags/something". There is no easy way to catch it during the main body of the function, as there is no way to distinguish whether it's a leading slash or a double slash somewhere in the middle. Catch this at the beginning so we don't trigger the assert in is_all_caps_and_underscore().
9bea03ce	2013-03-06T15:16:34	Add INCLUDE_TREES, DONT_AUTOEXPAND iterator flags This standardizes iterator behavior across all three iterators (index, tree, and working directory). Previously the working directory iterator behaved differently from the other two. Each iterator can now operate in one of three modes: 1. No tree results, auto expand trees means that only non- tree items will be returned and when a tree/directory is encountered, we will automatically descend into it. 2. Tree results, auto expand trees means that results will be given for every item found, including trees, but you only need to call normal git_iterator_advance to yield every item (i.e. trees returned with pre-order iteration). 3. Tree results, no auto expand means that calling the normal git_iterator_advance when looking at a tree will not descend into the tree, but will skip over it to the next entry in the parent. Previously, behavior 1 was the only option for index and tree iterators, and behavior 3 was the only option for workdir. The main public API implications of this are that the `git_iterator_advance_into()` call is now valid for all iterators, not just working directory iterators, and all the existing uses of working directory iterators explicitly use the GIT_ITERATOR_DONT_AUTOEXPAND (for now). Interestingly, the majority of the implementation was in the index iterator, since there are no tree entries there and now have to fake them. The tree and working directory iterators only required small modifications.
cc216a01	2013-03-05T16:29:04	Retire spoolandsort iterator Since the case sensitivity is moved into the respective iterators, this removes the spoolandsort iterator code.
169dc616	2013-03-05T16:10:05	Make iterator APIs consistent with standards The iterator APIs are not currently consistent with the parameter ordering of the rest of the codebase. This rearranges the order of parameters, simplifies the naming of a number of functions, and makes somewhat better use of macros internally to clean up the iterator code. This also expands the test coverage of iterator functionality, making sure that case sensitive range-limited iteration works correctly.
ed4f95e5	2013-03-05T11:47:07	Add const to some buffer functions
aa518c70	2013-03-06T22:51:20	added missing free for git_note in clar tests
f7b18502	2013-03-06T22:25:01	fixed minor issues with new note iterator * fixed style issues * use new iterator functions for git_note_foreach()
1a90dcf6	2013-03-06T19:07:56	use git_note_iterator type instead of non-public git_iterator one
6edb427b	2013-03-06T16:43:21	basic note iterator implementation * git_note_iterator_new() - create a new note iterator * git_note_next() - retrieves the next item of the iterator
b72f5d40	2013-03-05T15:35:28	Merge pull request #1369 from arrbee/repo-init-template-hooks More tests (and fixes) for initializing repo from template
b8daa9e0	2013-03-04T16:19:38	Merge pull request #1380 from phkelley/index_icase Disable ignore_case when writing the index to a tree
5bddabcc	2013-03-04T17:40:48	clear REUC on checkout
323bb885	2013-03-04T00:21:56	Fix a few leaks `git_diff_get_patch()` would unconditionally load the patch object and then simply leak it if the user hadn't requested it. Short-circuit loading the object if the user doesn't want it. The rest of the plugs are simply calling the free functions of objects allocated during the tests.
0e040c03	2013-03-03T14:50:47	indexer: use a hashtable for keeping track of offsets These offsets are needed for REF_DELTA objects, which encode which object they use as a base, but not where it lies in the packfile, so we need a list. These objects are mostly from older packfiles, before OFS_DELTA was widely spread. The time spent in indexing these packfiles is greatly reduced, though remains above what git is able to do.
447ae791	2013-03-03T15:19:21	indexer: kill git_indexer This was the first implementation and its goal was simply to have something that worked. It is slow and now it's just taking up space. Remove it and switch the one known usage to use the streaming indexer.
487fc724	2013-03-01T13:41:53	Allow empty config object and use it This removes assertions that prevent us from having an empty git_config object and then updates some tests that were dependent on global config state to use an empty config before running anything.
cb53669e	2013-03-01T16:38:13	Rename function to __ prefix
3f0d0c85	2013-03-01T15:44:18	Disable ignore_case when writing the index to a tree
926acbcf	2013-03-01T11:07:53	Clone should not delete directories it did not create
cc427158	2013-02-28T15:09:32	Merge pull request #1373 from arrbee/why-cdecl-why Why cdecl why?
f443a72d	2013-02-28T14:41:26	Fix some deprecation warnings on Windows This fixes some snprintf and vsnprintf related deprecation warnings we've been having on Windows with recent compilers.
97b71374	2013-02-28T14:14:45	Add GIT_STDLIB_CALL This removes the one-off GIT_CDECL and adds a new standard way of doing this named GIT_STDLIB_CALL with a src/win32 specific def when on the Windows platform.
5fa8abb8	2013-02-28T17:36:20	w32-posix: Wrap the `timezone` declaration with a clause Allows compilation in newer versions of MinGW that already defined it.
f708c89f	2013-02-27T15:15:39	fixing some warnings on Windows
11b5beb7	2013-02-27T15:07:28	use cdecl for hashsig sorting functions on Windows
e68e33f3	2013-02-27T14:50:32	Merge pull request #1233 from arrbee/file-similarity-metric Add file similarity scoring to diff rename/copy detection
9f9477d6	2013-02-27T14:21:41	Merge pull request #1372 from ethomson/checkout_workdir_end don't dereference at the end of the workdir iterator
18f08264	2013-02-27T13:44:15	Make mode handling during init more like git When creating files, instead of actually using GIT_FILEMODE_BLOB and the other various constants that happen to correspond to mode values, apparently I should be just using 0666 and 0777, and relying on the umask to clear bits and make the value sane. This fixes the rules for copying a template directory and fixes the checks to match that new behavior. (Further changes to the checkout logic to follow separately.)
395509ff	2013-02-27T14:47:39	don't dereference at the end of the workdir iterator

90431f1b

2013-04-10T08:33:33

Merge pull request #1424 from phkelley/efficient_push Reduce the number of unnecessary objects in pushed packs

ad26434b

2013-04-09T14:52:32

Tests and more fixes for submodule diffs This adds tests for diffs with submodules in them and (perhaps unsurprisingly) requires further fixes to be made. Specifically, this fixes: - when considering if a submodule is dirty in the workdir, it was being treated as dirty even if only the index was dirty. - git_diff_patch_to_str (and git_diff_patch_print) were "printing" the headers for files (and submodules) that were unmodified or had no meaningful content. - added comment to previous fix and removed unneeded parens.

9da187e8

2013-04-09T11:40:00

Fix clang warnings and improve checks

94750e8a

2013-03-29T11:52:18

Fix submodule dirty states not showing if submodules comes before files, or there are only dirty submodules but no changed files GIT_DIFF_PATCH_DIFFABLE was not set, so the diff content was not shown When submodule is dirty, the hash may be the same, but the length is different because -dirty is appended We can therefore compare the length or hash

d9ecaf8c

2013-04-07T07:22:38

Merge remote-tracking branch 'gnprice/revwalk' into development

af079d8b

2013-03-03T20:54:23

revwalk: Parse revision ranges All the hard work is already in revparse. Signed-off-by: Greg Price <price@mit.edu>

b208d900

2013-03-20T10:01:58

revparse: Parse range-like syntax Signed-off-by: Greg Price <price@mit.edu>

08283cbd

2013-04-01T07:12:49

Merge pull request #1448 from phkelley/development Avoid pre-Win7 WinHTTP self-redirect quirk

b39f9697

2013-03-31T23:04:14

Fix whitespace in src/win32/version.h

5c5eeba6

2013-03-31T22:22:33

Add git_has_win32_version helper

8cc2f2d8

2013-03-31T12:10:27

Win32 error reporting: Support WinHTTP errors

24cb87e2

2013-03-31T13:27:43

tag: Fix parsing when no tagger nor message

0227fa2a

2013-03-30T21:36:04

Avoid pre-Win7 WinHTTP self-redirect quirk

54a1a042

2013-03-29T11:26:12

remove unmerged files during reset hard

8cfd54f0

2013-03-26T12:27:15

Fix Windows/Win32 warning

0b061b5b

2013-03-26T11:05:57

Merge pull request #1436 from schu/opts-cache-size opts: allow configuration of odb cache size

86d24ce4

2013-03-26T10:42:30

Merge pull request #1439 from arrbee/recurse-ignored-dirs Several diff and status fixes

ccfa6805

2013-03-25T23:58:40

Fix some diff ignores and submodule dirty workdir This started out trying to look at the problems from issue #1425 and gradually grew to a broader set of fixes. There are two core things fixed here: 1. When you had an ignore like "/bin" which is rooted at the top of your tree, instead of immediately adding the "bin/" entry as an ignored item in the diff, we were returning all of the direct descendants of the directory as ignored items. This changes things to immediately ignore the directory. Note that this effects the behavior in test_status_ignore__subdirectories so that we no longer exactly match core gits ignore behavior, but the new behavior probably makes more sense (i.e. we now will include an ignored directory inside an untracked directory that we previously would have left off). 2. When a submodule only contained working directory changes, the diff code was always considering it unmodified which was just an outright bug. The HEAD SHA of the submodule matches the SHA in the parent repo index, and since the SHAs matches, the diff code was overwriting the actual status with UNMODIFIED. These fixes broke existing tests test_diff_workdir__submodules and test_status_ignore__subdirectories but looking it over, I actually think the new results are correct and the old results were wrong. @nulltoken had actually commented on the subdirectory ignore issue previously. I also included in the tests some debugging versions of the shared iteration callback routines that print status or diff information. These aren't used actively in the tests, but can be quickly swapped in to test code to give a better picture of what is being scanned in some of the complex test scenarios.

37ee70fa

2013-03-25T22:19:39

Implement GIT_STATUS_OPT_EXCLUDE_SUBMODULES This option has been sitting unimplemented for a while, so I finally went through and implemented it along with some tests. As part of this, I improved the implementation of GIT_DIFF_IGNORE_SUBMODULES so it be more diligent about avoiding extra work and about leaving off delta records for submodules to the greatest extent possible (though it may include them still if you are request TYPECHANGE records).

d2a4a54b

2013-03-25T21:46:51

Merge pull request #1438 from ethomson/checkout_stat don't stat until the file is written

d828f118

2013-03-25T18:16:02

don't stat until the file is written

0c289dd7

2013-03-25T16:40:16

Recursing into ignored dirs for diff and status This implements working versions of GIT_DIFF_RECURSE_IGNORED_DIRS and GIT_STATUS_OPT_RECURSE_IGNORED_DIRS along with some tests for the newly available behaviors. This is not turned on by default for status, but can be accessed via the options to the extended version of the command.

f2850f33

2013-03-25T15:30:37

Merge pull request #1437 from phkelley/redirect http: Support 302 Found (arrbee did most of the work)

35e0f3c6

2013-03-25T17:59:30

Refine the redirect check condition

2c7f7a66

2013-03-25T17:35:36

http: Support 302 Found (arrbee did most of the work)

3658e81e

2013-03-25T14:20:07

Move crlf conversion into buf_text This adds crlf/lf conversion functions into buf_text with more efficient implementations that bypass the high level buffer functions. They attempt to minimize the number of reallocations done and they directly write the buffer data as needed if they know that there is enough memory allocated to memcpy data. Tests are added for these new functions. The crlf.c code is updated to use the new functions. Removed the include of buf_text.h from filter.h and just include it more narrowly in the places that need it.

4a15ea86

2013-03-21T14:02:25

don't convert CRLF to CRCRLF

9733e80c

2013-03-22T10:44:45

Add has_cr_in_index check to CRLF filter This adds a check to the drop_crlf filter path to check it the file in the index already has a CR in it, in which case this will not drop the CRs from the workdir file contents. This uncovered a "bug" in `git_blob_create_fromworkdir` where the full path to the file was passed to look up the attributes instead of the relative path from the working directory root. This meant that the check in the index for a pre-existing entry of the same name was failing.

13640d1b

2013-03-25T21:39:11

oid: Do not parse OIDs longer than 40

1f107478

2013-03-25T13:26:50

Merge pull request #1428 from xavier-l/nul-terminated-oid Nul terminated oid

f5e28202

2013-03-25T13:38:43

opts: allow configuration of odb cache size Currently, the odb cache has a fixed size of 128 slots as defined by GIT_DEFAULT_CACHE_SIZE. Allow users to set the size of the cache via git_libgit2_opts(). Fixes #1035.

33a59401

2013-03-22T20:22:39

graph: make the ahead-behind docs clearer Explain it in local-upstream branch terms so it's easier to grasp than with the `one` and `two` naming from the merge-base code.

1e7b7523

2013-03-21T12:30:08

git_oid_fromstrn already sets a maximum on the length of the string

0c8efb38

2013-03-21T11:59:01

Added an oid function that accepts nul-terminated strings

cd01dd5d

2013-03-19T15:43:34

Fix dumb mistake in the comparison function

bef2a12c

2013-03-19T15:35:26

Convert enqueue_object to a function

799f9a04

2013-03-19T14:56:45

Reduce the number of unnecessary objects in pushed packs

65025cb8

2013-03-18T17:24:13

Three submodule status bug fixes 1. Fix sort order problem with submodules where "mod" was sorting after "mod-plus" because they were being sorted as "mod/" and "mod-plus/". This involved pushing the "contains a .git entry" test significantly lower in the stack. 2. Reinstate behavior that a directory which contains a .git entry will be treated as a submodule during iteration even if it is not yet added to the .gitmodules. 3. Now that any directory containing .git is reported as submodule, we have to be more careful checking for GIT_EEXISTS when we do a submodule lookup, because that is the error code that is returned by git_submodule_lookup when you try to look up a directory containing .git that has no record in gitmodules or the index.

5b27bf7e

2013-03-18T16:17:14

Merge pull request #1417 from arrbee/opts-for-paths Implement opts interface for global/system file search paths

32460251

2013-03-18T15:54:35

Fixes and cleanups Get rid of some dead code, tighten things up a bit, and fix a bug with core::env test.

41954a49

2013-03-18T14:19:35

Switch search paths to classic delimited strings This switches the APIs for setting and getting the global/system search paths from using git_strarray to using a simple string with GIT_PATH_LIST_SEPARATOR delimited paths, just as the environment PATH variable would contain. This makes it simpler to get and set the value. I also added code to expand "$PATH" when setting a new value to embed the old value of the path. This means that I no longer require separate actions to PREPEND to the value.

50eb8520

2013-03-18T14:05:31

Merge pull request #1420 from KindDragon/static-code-analyzer-warnings Several warnings detected by static code analyzer fixed

677dce8a

2013-03-18T14:00:09

Merge pull request #1080 from carlosmn/config-set-null Failing config related test

10c06114

2013-03-17T04:46:46

Several warnings detected by static code analyzer fixed Implicit type conversion argument of function to size_t type Suspicious sequence of types castings: size_t -> int -> size_t Consider reviewing the expression of the 'A = B == C' kind. The expression is calculated as following: 'A = (B == C)' Unsigned type is never < 0

5540d947

2013-03-15T16:39:00

Implement global/system file search paths The goal of this work is to expose the search logic for "global", "system", and "xdg" files through the git_libgit2_opts() interface. Behind the scenes, I changed the logic for finding files to have a notion of a git_strarray that represents a search path and to store a separate search path for each of the three tiers of config file. For each tier, I implemented a function to initialize it to default values (generally based on environment variables), and then general interfaces to get it, set it, reset it, and prepend new directories to it. Next, I exposed these interfaces through the git_libgit2_opts interface, reusing the GIT_CONFIG_LEVEL_SYSTEM, etc., constants for the user to control which search path they were modifying. There are alternative designs for the opts interface / argument ordering, so I'm putting this phase out for discussion. Additionally, I ended up doing a little bit of clean up regarding attr.h and attr_file.h, adding a new attrcache.h so the other two files wouldn't have to be included in so many places.

a5f61384

2013-03-15T12:24:20

odb_pack: Unused functions

f16fb099

2013-03-15T12:11:02

pool: Internal struct name

5b229e20

2013-03-15T04:06:31

Merge pull request #1413 from arrbee/more-iterator-refactor Further tree_iterator refactoring

55e0f53d

2013-03-14T15:09:29

Fix various build warnings This fixes various build warnings on Mac and Windows (64-bit).

14bedad9

2013-03-14T15:08:04

Added pool freelist struct for readability This adds a git_pool_freelist_item struct that makes it a little easier to follow what's going on with the pool free list block management code. It is functionally neutral.

d85296ab

2013-03-14T13:50:54

Fix valgrind issues (and mmap fallback for diff) This fixes a number of issues identified by valgrind - mostly missed free calls. Inside valgrind, mmap() may fail which causes some of the diff tests to fail. This adds a fallback code path to diff_output.c:get_workdir_content() where is the mmap() fails the code will now try to read the file data directly into allocated memory (which is what it would do if the data needed to be filtered anyhow).

0c468633

2013-03-14T13:40:15

Improved tree iterator internals This updates the tree iterator internals to be more efficient. The tree_iterator_entry objects are now kept as pointers that are allocated from a git_pool, so that we may use git__tsort_r for sorting (which is better than qsort, given that the tree is likely mostly ordered already). Those tree_iterator_entry objects now keep direct pointers to the data they refer to instead of keeping indirect index values. This simplifies a lot of the data structure traversal code. This also adds bsearch to find the start item position for range- limited tree iterators, and is more explicit about using git_path_cmp instead of reimplementing it. The git_path_cmp changed a bit to make it easier for tree_iterators to use it (but it was barely being used previously, so not a big deal). This adds a git_pool_free_array function that efficiently frees a list of pool allocated pointers (which the tree_iterator keeps). Also, added new tests for the git_pool free list functionality that was not previously being tested (or used).

bbb13646

2013-03-13T14:59:51

Fix workdir iterator bugs This fixes two bugs with the workdir iterator depth check: first that the depth was not being decremented and second that empty directories were counting against the depth even though a frame was not being created for them. This also fixes a bug with the ENOTFOUND return code for workdir iterators when you attempt to advance_into an empty directory. Actually, that works correctly, but it was incorrectly being propogated into regular advance() calls in some circumstances. Added new tests for the above that create a huge hierarchy on the fly and try using the workdir iterator to traverse it.

ad003763

2013-03-12T20:36:35

MSVC: What could possibly be the size of a void*?

f5898324

2013-03-12T15:31:14

Style: Reverse lhs and rhs of == comparisons

b8c32580

2013-03-12T15:19:32

Advertise and support side-band-64k when calling receive-pack

1ac10aae

2013-03-12T09:23:53

Merge pull request #1408 from arrbee/refactor-iterators Refactor iterators

62beacd3

2013-03-11T16:43:58

Sorting function cleanup and MinGW fix Clean up some sorting function stuff including fixing qsort_r on MinGW, common function pointer type for comparison, and basic insertion sort implementation (which we, regrettably, fall back on for MinGW).

b70bf922

2013-03-11T14:35:49

Merge pull request #1406 from cpthamilton/local_push Implemented push on the local transport

20858f6e

2013-02-19T06:22:58

Implemented push on the local transport

a5eea2d7

2013-03-11T11:31:50

Stabilize order for equiv tree iterator entries Given a group of case-insensitively equivalent tree iterator entries, this ensures that the case-sensitively first trees will be used as the representative items. I.e. if you have conflicting entries "A/B/x", "a/b/x", and "A/b/x", this change ensures that the earliest entry "A/B/x" will be returned. The actual choice is not that important, but it is nice to have it stable and to have it been either the first or last item, as opposed to a random item from within the equivalent span.

aa408cbf

2013-03-11T11:18:00

handle small files in similarity metrics

aec4f663

2013-03-11T10:37:12

Fix tree iterator advance using wrong name compare Tree iterator advance was moving forward without taking the filemode of the entries into account, equating "a" and "a/". This makes the tree entry comparison code more easily reusable and fixes the problem.

92028ea5

2013-03-11T09:53:49

Fix tree iterator path for tree issue + cleanups This fixes an off by one error for generating full paths for tree entries in tree iterators when INCLUDE_TREES is set. Also, contains a bunch of small code cleanups with a couple of small utility functions and macro changes to eliminate redundant code.

61c7b61e

2013-03-10T22:38:53

Use correct case path in icase tree iterator If there are case-ambiguities in the path of a case insensitive tree iterator, it will now rewrite the entire path when it gives the path name to an entry, so a tree with "A/b/C/d.txt" and "a/B/c/E.txt" will give the true full paths (instead of case- folding them both to "A/B/C/d.txt" or "a/b/c/E.txt" or something like that.

1aa5318a

2013-03-09T16:04:34

diff: allow asking for diffs with no context Previously, 0 meant default. This is problematic, as asking for 0 context lines is a valid thing to do. Change GIT_DIFF_OPTIONS_INIT to default to three and stop treating 0 as a magic value. In case no options are provided, make sure the options in the diff object default to 3.

48bde2f1

2013-03-08T02:11:34

config: don't allow passing NULL as a value to set Passing NULL is non-sensical. The error message leaves to be desired, though, as it leaks internal implementation details. Catch it at the `git_config_set_string` level and set an appropriate error message.

e40f1c2d

2013-03-08T16:39:57

Make tree iterator handle icase equivalence There is a serious bug in the previous tree iterator implementation. If case insensitivity resulted in member elements being equivalent to one another, and those member elements were trees, then the children of the colliding elements would be processed in sequence instead of in a single flattened list. This meant that the tree iterator was not truly acting like a case-insensitive list. This completely reworks the tree iterator to manage lists with case insensitive equivalence classes and advance through the items in a unified manner in a single sorted frame. It is possible that at a future date we might want to update this to separate the case insensitive and case sensitive tree iterators so that the case sensitive one could be a minimal amount of code and the insensitive one would always know what it needed to do without checking flags. But there would be so much shared code between the two, that I'm not sure it that's a win. For now, this gets what we need. More tests are needed, though.

6f83a781

2013-03-07T11:14:03

Merge pull request #1403 from ethomson/tracing Optional tracing back to consumers

b5ec5430

2013-03-04T23:52:30

optional tracing

d00d5464

2013-03-01T15:37:33

immutable references and a pluggable ref database

bb45c57f

2013-03-07T16:38:44

refs: explicitly catch leading slashes It's somewhat common to try to write "/refs/tags/something". There is no easy way to catch it during the main body of the function, as there is no way to distinguish whether it's a leading slash or a double slash somewhere in the middle. Catch this at the beginning so we don't trigger the assert in is_all_caps_and_underscore().

9bea03ce

2013-03-06T15:16:34

Add INCLUDE_TREES, DONT_AUTOEXPAND iterator flags This standardizes iterator behavior across all three iterators (index, tree, and working directory). Previously the working directory iterator behaved differently from the other two. Each iterator can now operate in one of three modes: 1. *No tree results, auto expand trees* means that only non- tree items will be returned and when a tree/directory is encountered, we will automatically descend into it. 2. *Tree results, auto expand trees* means that results will be given for every item found, including trees, but you only need to call normal git_iterator_advance to yield every item (i.e. trees returned with pre-order iteration). 3. *Tree results, no auto expand* means that calling the normal git_iterator_advance when looking at a tree will not descend into the tree, but will skip over it to the next entry in the parent. Previously, behavior 1 was the only option for index and tree iterators, and behavior 3 was the only option for workdir. The main public API implications of this are that the `git_iterator_advance_into()` call is now valid for all iterators, not just working directory iterators, and all the existing uses of working directory iterators explicitly use the GIT_ITERATOR_DONT_AUTOEXPAND (for now). Interestingly, the majority of the implementation was in the index iterator, since there are no tree entries there and now have to fake them. The tree and working directory iterators only required small modifications.

cc216a01

2013-03-05T16:29:04

Retire spoolandsort iterator Since the case sensitivity is moved into the respective iterators, this removes the spoolandsort iterator code.

169dc616

2013-03-05T16:10:05

Make iterator APIs consistent with standards The iterator APIs are not currently consistent with the parameter ordering of the rest of the codebase. This rearranges the order of parameters, simplifies the naming of a number of functions, and makes somewhat better use of macros internally to clean up the iterator code. This also expands the test coverage of iterator functionality, making sure that case sensitive range-limited iteration works correctly.

ed4f95e5

2013-03-05T11:47:07

Add const to some buffer functions

aa518c70

2013-03-06T22:51:20

added missing free for git_note in clar tests

f7b18502

2013-03-06T22:25:01

fixed minor issues with new note iterator * fixed style issues * use new iterator functions for git_note_foreach()

1a90dcf6

2013-03-06T19:07:56

use git_note_iterator type instead of non-public git_iterator one

6edb427b

2013-03-06T16:43:21

basic note iterator implementation * git_note_iterator_new() - create a new note iterator * git_note_next() - retrieves the next item of the iterator

b72f5d40

2013-03-05T15:35:28

Merge pull request #1369 from arrbee/repo-init-template-hooks More tests (and fixes) for initializing repo from template

b8daa9e0

2013-03-04T16:19:38

Merge pull request #1380 from phkelley/index_icase Disable ignore_case when writing the index to a tree

5bddabcc

2013-03-04T17:40:48

clear REUC on checkout

323bb885

2013-03-04T00:21:56

Fix a few leaks `git_diff_get_patch()` would unconditionally load the patch object and then simply leak it if the user hadn't requested it. Short-circuit loading the object if the user doesn't want it. The rest of the plugs are simply calling the free functions of objects allocated during the tests.

0e040c03

2013-03-03T14:50:47

indexer: use a hashtable for keeping track of offsets These offsets are needed for REF_DELTA objects, which encode which object they use as a base, but not where it lies in the packfile, so we need a list. These objects are mostly from older packfiles, before OFS_DELTA was widely spread. The time spent in indexing these packfiles is greatly reduced, though remains above what git is able to do.

447ae791

2013-03-03T15:19:21

indexer: kill git_indexer This was the first implementation and its goal was simply to have something that worked. It is slow and now it's just taking up space. Remove it and switch the one known usage to use the streaming indexer.

487fc724

2013-03-01T13:41:53

Allow empty config object and use it This removes assertions that prevent us from having an empty git_config object and then updates some tests that were dependent on global config state to use an empty config before running anything.

cb53669e

2013-03-01T16:38:13

Rename function to __ prefix

3f0d0c85

2013-03-01T15:44:18

Disable ignore_case when writing the index to a tree

926acbcf

2013-03-01T11:07:53

Clone should not delete directories it did not create

cc427158

2013-02-28T15:09:32

Merge pull request #1373 from arrbee/why-cdecl-why Why cdecl why?

f443a72d

2013-02-28T14:41:26

Fix some deprecation warnings on Windows This fixes some snprintf and vsnprintf related deprecation warnings we've been having on Windows with recent compilers.

97b71374

2013-02-28T14:14:45

Add GIT_STDLIB_CALL This removes the one-off GIT_CDECL and adds a new standard way of doing this named GIT_STDLIB_CALL with a src/win32 specific def when on the Windows platform.

5fa8abb8

2013-02-28T17:36:20

w32-posix: Wrap the `timezone` declaration with a clause Allows compilation in newer versions of MinGW that already defined it.

f708c89f

2013-02-27T15:15:39

fixing some warnings on Windows

11b5beb7

2013-02-27T15:07:28

use cdecl for hashsig sorting functions on Windows

e68e33f3

2013-02-27T14:50:32

Merge pull request #1233 from arrbee/file-similarity-metric Add file similarity scoring to diff rename/copy detection

9f9477d6

2013-02-27T14:21:41

Merge pull request #1372 from ethomson/checkout_workdir_end don't dereference at the end of the workdir iterator

18f08264

2013-02-27T13:44:15

Make mode handling during init more like git When creating files, instead of actually using GIT_FILEMODE_BLOB and the other various constants that happen to correspond to mode values, apparently I should be just using 0666 and 0777, and relying on the umask to clear bits and make the value sane. This fixes the rules for copying a template directory and fixes the checks to match that new behavior. (Further changes to the checkout logic to follow separately.)

395509ff

2013-02-27T14:47:39

don't dereference at the end of the workdir iterator

thodg/libgit2/src

src

Log