Log

Author Commit Date CI Message
Edward Thomson 9aa22de6 2020-11-21T22:49:26 Merge pull request #5597 from lhchavez/ci-thread-sanitizer Add a ThreadSanitizer build
Edward Thomson d9d86e41 2020-11-21T22:13:51 Merge pull request #5580 from libgit2/ethomson/win32_leakcheck msvc crtdbg -> win32 leakcheck
Edward Thomson 045748bb 2020-11-21T22:06:57 Merge pull request #5692 from rbmclean/master Add missing worktree_dir check and test case
Edward Thomson c8fe4da3 2020-11-21T22:06:03 Apply suggestions from code review
Edward Thomson 6d44c87a 2020-07-12T18:44:50 ci: set WIN32_LEAKCHECK instead of MSVC_CRTDBG
Edward Thomson 8aed4629 2020-07-12T18:43:22 cmake: rename MSVC_CRTDBG to WIN32_LEAKCHECK
Edward Thomson 51825c4f 2020-07-12T18:18:12 alloc: rename the win32 leakcheck allocator The win32 leakchecking system is now named win32_leakcheck. Update the allocator to match.
Edward Thomson 31654a34 2020-07-12T18:07:10 win32: consolidate leak checking initialization Move leak check initialization into git_win32_leakcheck_global_init, and call it on library initialization.
Edward Thomson cb4b3bdf 2020-07-12T17:49:42 win32: "crtdbg" is now "leakcheck" msvc crtdbg is a mouthfull that is not particularly indicative of what it does. Let's rename it to "win32 leakcheck".
Edward Thomson a6d151bf 2020-11-21T21:31:41 Merge pull request #5690 from lhchavez/fix-filelimit-compile-error Fix the `-DTHREADSAFE=OFF` build
Edward Thomson 4f4f3bfd 2020-11-20T23:25:44 Merge pull request #5703 from libgit2/ethomson/arm-actions ci: propagate environment variables
Edward Thomson 2193f32a 2020-11-20T23:24:44 ci: propagate environment variables
Edward Thomson ca9c49c8 2020-11-20T23:15:34 Merge pull request #5702 from libgit2/ethomson/arm-actions ci: supply a token for self-hosted runners
Edward Thomson 823137dc 2020-11-20T23:14:18 ci: supply a token for self-hosted runners
Edward Thomson 4b41b1cc 2020-11-20T22:51:08 Merge pull request #5701 from libgit2/ethomson/arm-actions ci: supply a token for self-hosted runners
Edward Thomson cd6acb1d 2020-11-20T22:48:41 ci: supply a token for self-hosted runners
Edward Thomson 460dba46 2020-11-20T22:34:06 Merge pull request #5700 from libgit2/ethomson/arm-actions ci: GitHub Actions for arm64
Edward Thomson 938cf143 2020-11-20T22:32:12 ci: GitHub Actions for arm64
Edward Thomson d8a08227 2020-11-18T19:32:11 Merge pull request #5697 from libgit2/ethomson/actions ci: stop using deprecated set-env in GitHub Actions
Edward Thomson 3dc238c3 2020-11-18T19:30:13 coverity
Edward Thomson 11deb143 2020-11-18T19:10:00 ci: use GitHub Actions for nightly builds
Edward Thomson 3d6b9035 2020-11-18T18:08:23 ci: stop using deprecated set-env in GitHub Actions (And move the ci scripts into the `ci` directory.)
Reginald McLean 303b4c68 2020-11-07T16:30:44 worktree: change test to invalidate worktree via filesystem
Edward Thomson 2a516790 2020-11-07T09:36:11 Merge pull request #5659 from libgit2/ethomson/name_is_valid Deprecate `is_valid_name` functions; replace with `name_is_valid` functions
Reginald McLean 6405ce29 2020-11-06T11:36:25 worktree: Added worktree_dir check Fixes #5280
Reginald McLean 848c7793 2020-11-06T11:32:13 worktree: Demonstrate missing worktree check worktree_dir isn't validated when it should be
lhchavez aa532e29 2020-10-31T07:51:03 Fix the `-DTHREADSAFE=OFF` build This change avoids using the `(void)0` construct for some of the mutex `#define`s, since that makes the "return type" of those "functions" to be `void` instead of `int`.
Edward Thomson 8b0c7d7c 2020-10-25T16:38:45 changelog: include new reference validity functions
Edward Thomson 55a7117d 2020-10-11T13:55:44 remote: use git_remote_name_is_valid
Sven Strickroth 0caa4655 2020-09-09T10:48:00 Add git_tag_name_is_valid Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sven Strickroth fe11160c 2020-09-08T21:05:18 Add git_branch_name_is_valid Signed-off-by: Sven Strickroth <email@cs-ware.de>
Edward Thomson c7143d7c 2020-10-11T13:56:16 remote: deprecate git_remote_is_valid_name
Edward Thomson 023ebb9a 2020-10-11T13:48:07 refs: introduce git_remote_name_is_valid Provide a function that can check remote name validity but can also signal when an error occurs. Use the name "name_is_valid", which is more suggestive of checking a given name, rather than "is_valid_name", which suggests that the function checks the validity of the current remote's name.
Edward Thomson 68e35588 2020-10-11T13:35:35 refspec: return GIT_EINVALIDSPEC for invalid specs Disambiguate invalid specifications in `git_refspec__parse` so that callers can determine the difference between invalid specifications and actual errors. No call sites wil propagagte this new error message to an end-user, so there is no user-facing API change.
Edward Thomson 63460fe4 2020-10-11T13:21:13 refs: deprecate git_reference_is_valid_name
Edward Thomson b52bb4d4 2020-10-11T13:20:52 refs: use git_reference_name_is_valid
Edward Thomson 29715d40 2020-10-11T12:50:52 refs: introduce git_reference_name_is_valid Provide a function that can check reference name validity but can also signal when an error occurs. Use the name "name_is_valid", which is more suggestive of checking a given name, rather than "is_valid_name", which suggests that the function checks the validity of the current reference's name.
Edward Thomson d70979cf 2020-10-11T12:26:34 refs: error checking in internal name validation Move `git_reference__is_valid_name` to `git_reference__name_is_valid`, which returns errors and sets an out boolean parameter.
Edward Thomson 52294c41 2020-10-21T10:10:52 Merge pull request #5685 from staticfloat/sf/mbedtls_inc_fix Include `${MBEDTLS_INCLUDE_DIR}` when compiling `crypt_mbedtls.c`
Elliot Saba 1822b082 2020-10-20T23:26:47 Include `${MBEDTLS_INCLUDE_DIR}` when compiling `crypt_mbedtls.c` Without this, mbedTLS installs in non-default install locations that are otherwise found by the `FindmbedTLS.cmake` module are not found by the C preprocessor at compile time.
Edward Thomson b106834d 2020-10-14T16:49:29 Merge pull request #5668 from libgit2/ethomson/tlsdata threadstate: rename tlsdata when building w/o threads
Edward Thomson 246bc3cc 2020-10-14T15:05:11 threadstate: rename tlsdata when building w/o threads
Edward Thomson 20450cbe 2020-10-14T13:44:59 Merge pull request #5546 from libgit2/ethomson/init Refactor "global" state
Edward Thomson e9858645 2020-10-14T12:40:20 Merge pull request #5661 from lhchavez/windows-leak-detection-deflake Make the Windows leak detection more robust
Edward Thomson c964f73d 2020-10-14T12:35:00 Merge pull request #5664 from lhchavez/define-non-threadsafe-git-load Define `git___load` when building with `-DTHREADSAFE=OFF`
Edward Thomson a027efbb 2020-10-14T12:30:21 Merge pull request #5658 from libgit2/ethomson/ntlm_htonll ntlm: update ntlm dependency for htonll
lhchavez fa3daa82 2020-10-13T08:02:59 Define `git___load` when building with `-DTHREADSAFE=OFF` This should allow folks that build in non-thread-safe environments to still be able to build the library. Fixes: #5663
Edward Thomson 7f4fa178 2020-10-12T19:53:06 Merge pull request #5660 from libgit2/ethomson/v1.1 libgit2 v1.1.0
Edward Thomson f10c8875 2020-10-11T23:04:08 Release v1.1
Edward Thomson 699fd71a 2020-10-11T22:44:24 changelog: document changes since v1.1
lhchavez 4a0dceeb 2020-10-11T17:53:10 Make the Windows leak detection more robust This change: * Increases MY_ROW_LIMIT to 2M, since it has been failing in #5595's tests since it's _super_ close to the limit. * Calls `git_repository_free()` on a `git_repository` that was being leaked only in Windows. * Marks the global `git_repository` on `tests/repo/init.c` as `NULL` after being freed to make any accidental access more noisy. * Uses `cl_assert_equal_i()` in `test_trace_windows_stacktrace__leaks` to make the test failures more actionable. * Renames the globals in `tests/repo/init.c` so that they don't start with an underscore.
Edward Thomson 634c285a 2020-07-11T12:35:58 Move libgit2 settings into libgit2.c
Edward Thomson 1ec4702a 2020-07-11T12:25:51 Rename global.c to libgit2.c Now that we've identified that our global settings really aren't global at all, and refactored the library to match that, change global.c to libgit2.c, which is especially nice since the prefix of the functions matches the filename.
Edward Thomson e316b0d3 2020-05-15T11:47:09 runtime: move init/shutdown into the "runtime" Provide a mechanism for system components to register for initialization and shutdown of the libgit2 runtime.
Edward Thomson 8970acb7 2020-05-15T10:29:41 thread: don't use the global tlsdata for thread exit We want to store a pointer to emulate `pthread_exit` on Windows. Do this within the threading infrastructure so that it could potentially be re-used outside of the context of libgit2 itself.
Edward Thomson c40d2dc5 2020-05-15T10:09:51 thread: restore the git_thread_exit tests We were never properly testing git_thread_exit. Do so.
Edward Thomson 4853d94c 2020-05-14T10:36:35 global: separate global state from thread-local state Our "global initialization" has accumulated some debris over the years. It was previously responsible for both running the various global initializers (that set up various subsystems) _and_ setting up the "global state", which is actually the thread-local state for things like error reporting. Separate the thread local state out into "threadstate". Use the normal subsystem initialization functions that we already have to set it up. This makes both the global initialization system and the threadstate system simpler to reason about.
Edward Thomson bc3919ab 2020-07-11T12:14:26 global init: check error message buffer allocation Ensure that we can allocate the error message buffer. In keeping with our typical policiess, we allow (small) memory leaks in the case where we're out of memory.
Edward Thomson 8aa69f88 2020-05-13T10:48:13 mwindow: localize mutex Move the mwindow mutex into the mwindow code itself, initializing it in the mwindow global initialization function instead of in the global initializer.
Edward Thomson 6554b40e 2020-05-13T10:39:33 settings: localize global data Move the settings global data teardown into its own separate function, instead of intermingled with the global state.
Edward Thomson 521aa8c1 2020-05-12T13:21:26 win32: teach the allocator to deal with crtdbg Move the MSVC C runtime debugging bits into the allocator's global init function.
Edward Thomson fe12423a 2020-05-12T13:08:22 init: move thread init to git_global_threads_init Instead of treating win32 thread initialization specially in the win32 git_libgit2_init function, add a git_global_threads_init function.
Edward Thomson d79bb159 2020-10-11T11:41:38 ntlm: update ntlm dependency for htonll Update ntlm to include an htonll that is not dependent on system libraries.
Edward Thomson 2e5f27c7 2020-10-11T11:32:21 Merge pull request #5649 from libgit2/ethomson/pcre Update PCRE to 8.44
Edward Thomson 94e34582 2020-10-11T11:32:04 Merge pull request #5651 from libgit2/ethomson/clone_branch clone: update origin's HEAD
Edward Thomson 6244791a 2020-10-11T11:28:55 Merge pull request #5594 from lhchavez/git-atomics Improve the support of atomics
lhchavez 03c0938f 2020-08-25T06:13:38 Avoid using atomics in pool.c Instead, globally initialize the system page size.
lhchavez cc1d7f5c 2020-08-01T17:47:20 Improve the support of atomics This change: * Starts using GCC's and clang's `__atomic_*` intrinsics instead of the `__sync_*` ones, since the former supercede the latter (and can be safely replaced by their equivalent `__atomic_*` version with the sequentially consistent model). * Makes `git_atomic64`'s value `volatile`. Otherwise, this will make ThreadSanitizer complain. * Adds ways to load the values from atomics. As it turns out, unsynchronized read are okay only in some architectures, but if we want to be correct (and make ThreadSanitizer happy), those loads should also be performed with the atomic builtins. * Fixes two ThreadSanitizer warnings, as a proof-of-concept that this works: - Avoid directly accessing `git_refcount`'s `owner` directly, and instead makes all callers go through the `GIT_REFCOUNT_*()` macros, which also use the atomic utilities. - Makes `pool_system_page_size()` race-free. Part of: #5592
Edward Thomson 2307a225 2020-10-08T09:10:36 Merge pull request #5656 from ehuss/fix-check_extensions-err Fix error return for invalid extensions.
Eric Huss 5b7e7131 2020-10-07T15:54:08 Fix error return for invalid extensions.
Edward Thomson 9deadaee 2020-10-07T00:35:29 Merge pull request #5654 from dan-tull/master Change bare free to allocator free (fixes #5653)
Dan Tull cce966c3 2020-10-06T17:51:14 Change bare free to allocator free. The info pointer was allocated with git__malloc, so needs to be free'd with git__free. This bug can lurk pretty easily since if there's no custom allocator this is fine.
Edward Thomson c1f1bcad 2020-10-05T11:04:38 clone: update origin's HEAD Update `refs/remotes/origin/HEAD` as a symbolic link to the remote's default branch.
Edward Thomson c837bff1 2020-10-05T11:03:39 clone: test that the origin HEAD is created Ensure that we created `refs/remotes/origin/HEAD` when cloning, a symbolic link pointing to `refs/remotes/origin/<default>`
Edward Thomson d32a4072 2020-10-05T14:25:51 Merge pull request #5401 from lhchavez/multi-pack-index midx: Introduce a parser for multi-pack-index files
lhchavez 005e7715 2020-02-23T22:28:52 multipack: Introduce a parser for multi-pack-index files This change is the first in a series to add support for git's multi-pack-index. This should speed up large repositories significantly. Part of: #5399
Edward Thomson 6d1f1926 2020-10-05T09:41:08 Merge pull request #5648 from eltociear/patch-1 Fixed typo in comment
Edward Thomson 9293e165 2020-10-04T21:41:28 Merge pull request #5494 from kevinjswinton/master Fix binary diff showing /dev/null
Edward Thomson 722c01b6 2020-10-04T21:07:53 pcre: upgrade to 8.44
Edward Thomson dccfaa41 2020-10-04T20:36:22 pcre: upgrade to 8.43
Edward Thomson 600dd54e 2020-10-04T20:18:53 pcre: include the license We included their COPYING file, which was _not_ in fact their license. Add the LICENSE file as well.
kevinlul e8ab3db9 2020-07-07T22:29:05 p_chmod: Android compatibility Fix #5565 Pre-Android 5 did not implement a virtual filesystem atop FAT partitions for Unix permissions, which causes chmod to fail. However, Unix permissions have no effect on Android anyway as file permissions are not actually managed this way, so treating it as a no-op across all Android is safe.
Edward Thomson 2ab99c6d 2020-10-04T18:30:10 Merge pull request #5576 from lollipopman/double-auth httpclient: only free challenges for current_server type
Edward Thomson 3a72345b 2020-10-04T18:25:32 Merge pull request #5581 from libgit2/ethomson/mainbranch Respect `init.defaultBranch` setting
Edward Thomson a94fedc1 2020-10-04T18:04:01 Merge pull request #5620 from dlax/parse-patch-add-delete-no-index patch_parse: handle absence of "index" header for new/deleted cases
Edward Thomson a1f0135d 2020-10-04T18:01:09 Merge pull request #5626 from csware/parse_bool boolean config parsing fails in some cases with mapped values
Edward Thomson 36dc681e 2020-10-04T17:54:15 Merge pull request #5629 from csware/config-multiline-parse Fix config file parsing with multi line values containing quoted parts
Edward Thomson 30ba98a1 2020-10-04T17:40:38 Merge pull request #5636 from libgit2/pks-release-build-warnings Fix release build warnings
Ikko Ashimine 4b93f165 2020-10-04T12:45:26 Fixed typo in comment occured -> occurred
Sven Strickroth 6ac18625 2020-09-09T17:51:38 Fix config file parsing with multi line values containing quoted parts Signed-off-by: Sven Strickroth <email@cs-ware.de>
Patrick Steinhardt b254a585 2020-09-18T10:43:34 sysdir: fix formatting error message with NULL string When trying to the template dir, we pass in a `NULL` pointer for the filename. That's perfectly fine, but if we're failing to find the template directory then we'll creat an error message with the `NULL` pointer passed in. Fix the issue by setting different error messages based on whether the filename is given or not. This even makes sense, as we're not searching for a file in case we have no `name`, but for a directory. So the error would've been misleading anyway.
Patrick Steinhardt 8087498d 2020-09-18T10:49:24 Merge pull request #5631 from csware/issue-5611 Fix deprecation links inside of documentation not working
Patrick Steinhardt 37ae0079 2020-09-18T10:38:45 patch_parse: silence maybe-uninitialized warning When building libgit2 with the release build type, then GCC complains about mode being potentially uninitialized. While this seems to be a false positive, let's silence this warning by zero-initializing the mode.
Patrick Steinhardt 819492c1 2020-09-18T10:34:40 refs: fix potential free of uninitialized variable The `signature` variable in `git_reference_rename` isn't initialized and neither does `git_reference__log_signature` always do. So if the latter function fails, we'll call `git_signature_free` on this unininitialized variable. Fix the issue by initializing the pointer with `NULL`.
Patrick Steinhardt 9e81711b 2020-09-18T10:31:50 Merge pull request #5632 from csware/winhttp_typo Fix typo: Make ifndef macroname the same as the define name
Edward Thomson ae99e697 2020-09-17T11:19:49 Merge pull request #5619 from ddevault/diffstat-segfault diff stats: fix segfaults with new files
Drew DeVault ec26b16d 2020-08-29T10:44:40 diff stats: fix segfaults with new files
Edward Thomson 298b01ab 2020-09-15T09:26:08 Merge pull request #5633 from csware/winhttp1.3 WinHTTP: Try to use TLS1.3
Edward Thomson d65edcdc 2020-09-15T09:23:00 Merge pull request #5628 from interkosmos/master Fixed includes for FreeBSD
Philipp 6887e9db 2020-09-14T15:54:00 Removed FreeBSD-related macros.