thodg/libgit2/src/path.c

---

src/path.c

---

Log

Author	Commit	Date	CI	Message
	f18234fa	2014-08-08T13:17:50		Don't report status on named pipes Git skips entries in directories that are not S_ISDIR, S_ISREG, or S_ISLNK, so let's make libgit2 do the same thing.
	7d0ab0fa	2014-07-22T15:08:24		Merge remote-tracking branch 'origin/master' into fix-git-status-list-new-unreadable-folder
	529fd30d	2014-07-08T15:45:50		Handle local file:/// paths on Windows Windows can't handle a path like `/c:/foo`; when turning file:/// URIs into local paths, we must strip the leading slash.
	dc49e1b5	2014-06-04T15:36:28		Merge remote-tracking branch 'origin/development' into fix-git-status-list-new-unreadable-folder Conflicts: include/git2/diff.h
	54c02d21	2014-06-04T15:27:00		Clear out the struct.
	18d7896c	2014-06-03T21:47:53		clone: re-use the local transport's path resolution Whe already worked out the kinks with the function used in the local transport. Expose it and make use of it in the local clone method instead of trying to work it out again.
	86c9d3da	2014-05-21T22:54:34		Return GIT_FILEMODE_UNREADABLE for files that fail to stat.
	90553479	2014-05-20T17:40:28		Rename GIT_ENOACCESS -> GIT_EUNREADABLE
	dc4906f1	2014-05-15T17:40:28		Skip unreadable files for now.
	158c8ba1	2014-05-15T16:54:46		Return a specific error for EACCES.
	43a04135	2014-05-08T13:52:46		Pass unconverted data when iconv doesn't like it When using Iconv to convert unicode data and iconv doesn't like the source data (because it thinks that it's not actual UTF-8), instead of stopping the operation, just use the unconverted data. This will generally do the right thing on the filesystem, since that is the source of the non-UTF-8 path data anyhow. This adds some tests for creating and looking up branches with messy Unicode names. Also, this takes the helper function that was previously internal to `git_repository_init` and makes it into `git_path_does_fs_decompose_unicode` which is a useful in tests to understand what the expected results should be.
	7110000d	2014-04-22T10:21:19		React to feedback for UTF-8 <-> WCHAR and reparse work
	c2c81615	2014-04-19T18:05:31		Win32: UTF-8 <-> WCHAR conversion overhaul
	6a0956e5	2014-04-18T10:32:35		Pop ignore only if whole relative path matches When traversing the directory structure, the iterator pushes and pops ignore files using a vector. Some directories don't have ignore files, so it uses a path comparison to decide when it is right to actually pop the last ignore file. This was only comparing directory suffixes, though, so a subdirectory with the same name as a parent could result in the parent's .gitignore being popped off the list ignores too early. This changes the logic to compare the entire relative path of the ignore file.
	7167fd7e	2014-04-07T11:51:12		vmg is always right
	c813b345	2014-04-07T11:45:32		Fix bug with multiple iconv conversions in one dir The internal buffer in the `git_path_iconv_t` structure was not being reset before the calls to `iconv` were made to convert data, so if there were multiple decomposed Unicode paths in a single directory, paths after the first one were being appended to the first instead of treated as independent data.
	d3bc95fd	2014-03-25T12:37:05		Update behavior for untracked sub-repos When a directory containing a .git directory (or even just a plain gitlink) was found, libgit2 was going out of its way to treat it specially. This seemed like it was necessary because the diff code was not originally emulating Git's behavior for untracked directories correctly (i.e. scanning for ignored vs untracked items inside). Now that libgit2 diff mimics Git's untracked directory behavior, the special handling for contained Git repos is actually incorrect and this commit rips it out.
	a213a7bf	2014-03-05T20:32:53		refdb: catch a directory disappearing If a directory disappears between the time we look up the entries of its parent and the time when we go to look at it, we should ignore the error and move forward. This fixes #2046.
	4f46a98b	2014-02-24T23:32:25		Remove now-duplicated stdarg.h include
	7e3ed419	2013-12-11T16:56:17		Fix up some valgrind leaks and warnings
	26c1cb91	2013-12-09T09:44:03		One more rename/cleanup for callback err functions
	c7b3e1b3	2013-12-06T15:42:20		Some callback error check style cleanups I find this easier to read...
	25e0b157	2013-12-06T15:07:57		Remove converting user error to GIT_EUSER This changes the behavior of callbacks so that the callback error code is not converted into GIT_EUSER and instead we propagate the return value through to the caller. Instead of using the giterr_capture and giterr_restore functions, we now rely on all functions to pass back the return value from a callback. To avoid having a return value with no error message, the user can call the public giterr_set_str or some such function to set an error message. There is a new helper 'giterr_set_callback' that functions can invoke after making a callback which ensures that some error message was set in case the callback did not set one. In places where the sign of the callback return value is meaningful (e.g. positive to skip, negative to abort), only the negative values are returned back to the caller, obviously, since the other values allow for continuing the loop. The hardest parts of this were in the checkout code where positive return values were overloaded as meaningful values for checkout. I fixed this by adding an output parameter to many of the internal checkout functions and removing the overload. This added some code, but it is probably a better implementation. There is some funkiness in the network code where user provided callbacks could be returning a positive or a negative value and we want to rely on that to cancel the loop. There are still a couple places where an user error might get turned into GIT_EUSER there, I think, though none exercised by the tests.
	96869a4e	2013-12-03T16:45:39		Improve GIT_EUSER handling This adds giterr_user_cancel to return GIT_EUSER and clear any error message that is sitting around. As a result of using that in places, we need to be more thorough with capturing errors that happen inside a callback when used internally. To help with that, this also adds giterr_capture and giterr_restore so that when we internally use a foreach-type function that clears errors and converts them to GIT_EUSER, it is easier to restore not just the return value, but the actual error message text.
	0bfa7323	2013-11-01T17:07:44		iconv: Do not fake an API when iconv is not available
	14997dc5	2013-10-08T12:45:43		More filemode cleanups for FAT on MacOS This cleans up some additional issues. The main change is that on a filesystem that doesn't support mode bits, libgit2 will now create new blobs with GIT_FILEMODE_BLOB always instead of being at the mercy to the filesystem driver to report executable or not. This means that if "core.filemode" lies and claims that filemode is not supported, then we will ignore the executable bit from the filesystem. Previously we would have allowed it. This adds an option to the new git_repository_reset_filesystem to recurse through submodules if desired. There may be other types of APIs that would like a "recurse submodules" option, but this one is particularly useful. This also has a number of cleanups, etc., for related things including trying to give better error messages when problems come up from the filesystem. For example, the FAT filesystem driver on MacOS appears to return errno EINVAL if you attempt to write a filename with invalid UTF-8 in it. We try to capture that with a better error message now.
	618b7689	2013-10-02T12:06:26		Wrap iconv stuff and write tests This adds a simple wrapper around the iconv APIs and uses it instead of the old code that was inlining the iconv stuff. This makes it possible for me to test the iconv logic in isolation. A "no iconv" version of the API was defined with macros so that I could have fewer ifdefs in the code itself.
	d0849f83	2013-10-02T11:07:18		Simplify git_path_is_empty_dir implementation This simplifies git_path_is_empty_dir on both Windows (getting rid of git_buf allocation inside the function) and other platforms (by just using git_path_direach), and adds tests for the function, and uses the function to simplify some existing tests.
	219d3457	2013-10-01T16:12:15		Initial iconv hookup for precomposed unicode This hooks up git_path_direach and git_path_dirload so that they will take a flag indicating if directory entry names should be tested and converted from decomposed unicode to precomposed form. This code will only come into play on the Apple platform and even then, only when certain types of filesystems are used. This involved adding a flag to these functions which involved changing a lot of places in the code. This was an opportunity to do a bit of code cleanup here and there, for example, getting rid of the git_futils_cleanupdir_r function in favor of a simple flag to git_futils_rmdir_r to not remove the top level entry. That ended up adding depth tracking during rmdir_r which led to a safety check for infinite directory recursion. Yay. This hasn't actually been tested on the Mac filesystems where the issue occurs. I still need to get test environment for that.
	2fe54afa	2013-09-30T16:58:33		Put hooks in place for precompose in dirload fn This doesn't actual do string precompose but it puts the hooks in place into the iterators and the git_path_dirload function so that the actual precompose work is ready to go.
	5c3b8ef4	2013-09-24T14:52:58		Ignore files that disappear while iterating On occasion, files can disappear while we're iterating the filesystem, between calls to readdir and stat. Let's pretend those didn't exist in the first place.
	a9f51e43	2013-09-11T22:00:36		Merge git_buf and git_buffer This makes the git_buf struct that was used internally into an externally available structure and eliminates the git_buffer. As part of that, some of the special cases that arose with the externally used git_buffer were blended into the git_buf, such as being careful about git_buf objects that may have a NULL ptr and allowing for bufs with a valid ptr and size but zero asize as a way of referring to externally owned data.
	d0cd6c42	2013-09-08T18:22:28		path: Make direach() return EUSER on callback error
	cae52938	2013-09-03T14:00:27		Fix resolving relative windows network paths
	6d9a6c5c	2013-09-03T07:58:21		path: properly resolve relative paths
	40948998	2013-08-13T11:36:24		Merge pull request #1767 from libgit2/win32-bigger-utf8-buffer Bigger buffer for utf-8 parsing in win32
	ee065601	2013-08-13T09:53:56		Minor win32 fixes and improvements This is just a bunch of small fixes that I noticed while looking at the UTF8 and UTF16 path stuff. It fixes a slowdown in looking for an empty directory (not exiting loop asap), makes the dir name in the git__DIR structure be a GIT_FLEX_ARRAY to save an allocation, and fixes some slightly odd assumptions in the cl_getenv helper.
	d4cff0cb	2013-08-13T09:40:32		Rename git__win32_path fns to git_win32_path
	345b6307	2013-08-13T09:35:07		windows: Require order
	abf37327	2013-08-13T09:15:39		windows: Path conversion with better semantics
	ba8b8c04	2013-08-07T09:17:20		Improve building ignore file lists The routines to push and pop ignore files while traversing a directory had some issues. In particular, setting up the initial list would sometimes push an ignore file before it ought to be applied if the starting path was a directory containing an ignore file. Also, the pop function was not always matching the right part of the path and would fail to pop ignores from the list in some cases. This adds some tests that exercise a particular problematic case and then fixes the problems that I could find related to this. At some point, I'd like to isolate this ignore rule management code and rewrite it, but that's a larger project and right now, I'll opt to just try to fix the broken behaviors.
	aaefbdee	2013-08-08T08:48:57		Discriminate path-specific and general UTF-X conversions
	2c0128ee	2013-08-07T19:29:33		Rename git_win_str_utf* to git_win32_path_utf*
	9c38f7a6	2013-08-07T13:22:41		Add typedefs for win32 utf-8 and utf-16 buffers ...and normalize the signatures of the two conversion functions.
	d8563619	2013-08-05T11:41:39		Split UTF-16 and UTF-8 buffer sizes for win32 Also fixed up call-sites to use the correct buffer sizes, especially when converting to utf-8.
	65025cb8	2013-03-18T17:24:13		Three submodule status bug fixes 1. Fix sort order problem with submodules where "mod" was sorting after "mod-plus" because they were being sorted as "mod/" and "mod-plus/". This involved pushing the "contains a .git entry" test significantly lower in the stack. 2. Reinstate behavior that a directory which contains a .git entry will be treated as a submodule during iteration even if it is not yet added to the .gitmodules. 3. Now that any directory containing .git is reported as submodule, we have to be more careful checking for GIT_EEXISTS when we do a submodule lookup, because that is the error code that is returned by git_submodule_lookup when you try to look up a directory containing .git that has no record in gitmodules or the index.
	0c468633	2013-03-14T13:40:15		Improved tree iterator internals This updates the tree iterator internals to be more efficient. The tree_iterator_entry objects are now kept as pointers that are allocated from a git_pool, so that we may use git__tsort_r for sorting (which is better than qsort, given that the tree is likely mostly ordered already). Those tree_iterator_entry objects now keep direct pointers to the data they refer to instead of keeping indirect index values. This simplifies a lot of the data structure traversal code. This also adds bsearch to find the start item position for range- limited tree iterators, and is more explicit about using git_path_cmp instead of reimplementing it. The git_path_cmp changed a bit to make it easier for tree_iterators to use it (but it was barely being used previously, so not a big deal). This adds a git_pool_free_array function that efficiently frees a list of pool allocated pointers (which the tree_iterator keeps). Also, added new tests for the git_pool free list functionality that was not previously being tested (or used).
	8c29dca6	2013-02-11T09:25:57		Fix some incorrect MSVC #ifdef's. Fixes #1305
	23594c1d	2013-01-09T16:02:42		Add git_path_icmp to case-insensitive path cmp This adds git_path_icmp to complement git_path_cmp.
	359fc2d2	2013-01-08T17:07:25		update copyrights
	9651fdc2	2013-01-03T22:28:59		Give proper license notice to code from Android The usage of the Android derrived code contains a full notice which must be provided with the source code as per the terms given at: https://android.googlesource.com/platform/bionic/+/android-4.0.3_r1.1/libc/bionic/dirname_r.c
	1c5b3a41	2013-01-03T22:28:59		Give proper license notice to code from Android The usage of the Android derrived code contains a full notice which must be provided with the source code as per the terms given at: https://android.googlesource.com/platform/bionic/+/android-4.0.3_r1.1/libc/bionic/dirname_r.c
	2e40c616	2013-01-02T16:27:22		path: ifdef GIT_WIN32 looks_like_network_computer_name()
	50a762a5	2012-12-26T12:03:07		path: Teach UNC paths to git_path_dirname_r() Fix libgit2/libgit2sharp#256
	91e7d263	2012-12-10T15:29:44		Fix iterator reset and add reset ranges The `git_iterator_reset` command has not been working in all cases particularly when there is a start and end range. This fixes it and adds tests for it, and also extends it with the ability to update the start/end range strings when an iterator is reset.
	7bf87ab6	2012-11-28T09:58:48		Consolidate text buffer functions There are many scattered functions that look into the contents of buffers to do various text manipulations (such as escaping or unescaping data, calculating text stats, guessing if content is binary, etc). This groups all those functions together into a new file and converts the code to use that. This has two enhancements to existing functionality. The old text stats function is significantly rewritten and the BOM detection code was extended (although largely we can't deal with anything other than a UTF8 BOM).
	ad9a921b	2012-11-08T17:05:07		Rework checkout with new strategy options This is a major reworking of checkout strategy options. The checkout code is now sensitive to the contents of the HEAD tree and the new options allow you to update the working tree so that it will match the index content only when it previously matched the contents of the HEAD. This allows you to, for example, to distinguish between removing files that are in the HEAD but not in the index, vs just removing all untracked files. Because of various corner cases that arise, etc., this required some additional capabilities in rmdir and other utility functions. This includes the beginnings of an implementation of code to read a partial tree into the index based on a pathspec, but that is not enabled because of the possibility of creating conflicting index entries.
	0f4c6175	2012-08-28T22:19:08		Add bounds checking to UTF-8 conversion
	ca1b6e54	2012-07-31T17:02:54		Add template dir and set gid to repo init This extends git_repository_init_ext further with support for initializing the repository from an external template directory and with support for the "create shared" type flags that make a set GID repository directory. This also adds tests for much of the new functionality to the existing `repo/init.c` test suite. Also, this adds a bunch of new utility functions including a very general purpose `git_futils_mkdir` (with the ability to make paths and to chmod the paths post-creation) and a file tree copying function `git_futils_cp_r`. Also, this includes some new path functions that were useful to keep the code simple.
	bfc65634	2012-07-17T08:08:34		Merge branch 'development' into clone
	339f3d07	2012-07-11T19:17:07		Move is_dot_or_dotdotW into path.h.
	81167385	2012-07-11T15:33:19		Fix compile and workings on msvc. Signed-off-by: Ben Straub <bstraub@github.com>
	d024419f	2012-07-11T10:40:53		Add git_path_is_empty_dir.
	c3b5099f	2012-07-11T10:10:31		Add git_path_is_dot_or_dotdot. Also, remove some duplication in the clone test suite.
	b0fe1129	2012-07-10T15:13:30		Add path utilities to resolve relative paths This makes it easy to take a buffer containing a path with relative references (i.e. .. or . path segments) and resolve all of those into a clean path. This can be applied to URLs as well as file paths which can be useful. As part of this, I made the drive-letter detection apply on all platforms, not just windows. If you give a path that looks like "c:/..." on any platform, it seems like we might as well detect that as a rooted path. I suppose if you create a directory named "x:" on another platform and want to use that as the beginning of a relative path under the root directory of your repo, this could cause a problem, but then it seems like you're asking for trouble.
	296f60f5	2012-07-06T00:54:07		Fix libgit2 on GNU/Hurd. On GNU, the d_name field of the dirent structure is defined as "char d_name[1]", so we must allocate more than sizeof(struct dirent) bytes, just like on Sun.
	515a4c7c	2012-06-19T00:59:04		tree: Proper path comparison logic
	d043013f	2012-06-14T19:09:42		More changes resulting from pull request
	a8df98c6	2012-06-14T18:57:24		Updates from comments on OS4 compatibility pull request http://github.com/libgit2/libgit2/pull/766
	a21bb1aa	2012-06-13T23:28:51		Merge remote-tracking branch 'source/development' into development
	96ef3d84	2012-06-13T23:16:14		Make this more generic and mergeable. Needs AmigaOS.cmake now from CMake package at OS4Depot, or contents below: --8<-- SET(AMIGA 1) SET(CMAKE_SHARED_LIBRARY_C_FLAGS "-fPIC") SET(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "-shared") --8<--
	7d1983eb	2012-06-09T18:58:11		stop readdir parsing crashing
	ac971ecf	2012-06-08T14:08:34		Better fix for isalpha in drive letter detection Missed a place that used this and missed git__isalpha
	d17db71b	2012-06-08T13:56:53		isalpha is not great for UTF-8 When checking for a drive letter on windows, instead of using isalpha(), it is better to just check for a..z and A..Z, I think, particularly because the MS isalpha implementation appears to assert when given an 0xFF byte.
	aa5a92d1	2012-06-08T18:57:35		OS4 compatibility
	904b67e6	2012-05-18T01:48:50		errors: Rename error codes
	e172cf08	2012-05-18T01:21:06		errors: Rename the generic return codes
	6fb1c0b4	2012-05-09T23:45:55		Fix readdir_r() usage for Solaris On Solaris, struct dirent is defined differently than Linux. The field containing the path name is of size 0, rather than NAME_MAX. So, we need to use a properly sized buffer on Solaris to avoid a stack overflow. Also fix some DIR* leaks on cleanup.
	9abb5bca	2012-05-07T13:58:01		compat: make p_realpath Windows implementation be a bit more POSIX compliant and fail if the provided path does not lead to an existing entry
	46811561	2012-05-07T13:56:42		path: Make git_path_prettify() properly handle ENOTDIR errno value
	40879fac	2012-05-02T15:59:02		Merge branch 'new-error-handling' into development Conflicts: .travis.yml include/git2/diff.h src/config_file.c src/diff.c src/diff_output.c src/mwindow.c src/path.c tests-clar/clar_helpers.c tests-clar/object/tree/frompath.c tests/t00-core.c tests/t03-objwrite.c tests/t08-tag.c tests/t10-refs.c tests/t12-repo.c tests/t18-status.c tests/test_helpers.c tests/test_main.c
	fa6420f7	2012-04-29T21:46:33		buf: deploy git_buf_len()
	eb6db16d	2012-04-20T20:00:59		GetFileAttributes does not work for utf-8 encoded paths Signed-off-by: Sven Strickroth <email@cs-ware.de>
	44ef8b1b	2012-04-13T13:00:10		Fix warnings on 64-bit windows builds This fixes all the warnings on win64 except those in deps, which come from the regex code.
	7784bcbb	2012-04-11T11:52:59		Refactor git_repository_open with new options Add a new command `git_repository_open_ext` with extended options that control how searching for a repository will be done. The existing `git_repository_open` and `git_repository_discover` are reimplemented on top of it. We may want to change the default behavior of `git_repository_open` but this commit does not do that. Improve support for "gitdir" files where the work dir is separate from the repo and support for the "separate-git-dir" config. Also, add support for opening repos created with `git-new-workdir` script (although I have only confirmed that they can be opened, not that all functions work correctly). There are also a few minor changes that came up: - Fix `git_path_prettify` to allow in-place prettifying. - Fix `git_path_root` to support backslashes on Win32. This fix should help many repo open/discover scenarios - it is the one function called when opening before prettifying the path. - Tweak `git_config_get_string` to set the "out" pointer to NULL if the config value is not found. Allows some other cleanup. - Fix a couple places that should have been calling `git_repository_config__weakptr` and were not. - Fix `cl_git_sandbox_init` clar helper to support bare repos.
	0d0fa7c3	2012-03-16T15:56:01		Convert attr, ignore, mwindow, status to new errors Also cleaned up some previously converted code that still had little things to polish.
	7b93079b	2012-03-16T15:16:52		Make git_path_root() cope with windows network paths Fix libgit2/libgit2sharp#125
	deafee7b	2012-03-14T17:36:15		Continue error conversion This converts blob.c, fileops.c, and all of the win32 files. Also, various minor cleanups throughout the code. Plus, in testing the win32 build, I cleaned up a bunch (although not all) of the warnings with the 64-bit build.
	ab43ad2f	2012-03-14T11:07:14		Convert attr and other files to new errors This continues to add other files to the new error handling style. I think the only real concerns here are that there are a couple of error return cases that I have converted to asserts, but I think that it was the correct thing to do given the new error style.
	ae9e29fd	2012-03-06T16:14:31		Migrating diff to new error handling Ended up migrating a bunch of upstream functions as well including vector, attr_file, and odb in order to get this to work right.
	cb8a7961	2012-03-07T00:02:55		error-handling: Repository This also includes droping `git_buf_lasterror` because it makes no sense in the new system. Note that in most of the places were it has been dropped, the code needs cleanup. I.e. GIT_ENOMEM is going away, so instead it should return a generic `-1` and obviously not throw anything.
	1a481123	2012-02-17T00:13:34		error-handling: References Yes, this is error handling solely for `refs.c`, but some of the abstractions leak all ofer the code base.
	45d387ac	2012-02-15T16:54:17		refs: Error handling rework. WIP
	c19bc93c	2012-02-29T14:19:39		Fixing memory leaks indicated by valgrind This clears up the memory leaks that valgrind seems to find on my machine.
	74fa4bfa	2012-02-28T16:14:47		Update diff to use iterators This is a major reorganization of the diff code. This changes the diff functions to use the iterators for traversing the content. This allowed a lot of code to be simplified. Also, this moved the functions relating to outputting a diff into a new file (diff_output.c). This includes a number of other changes - adding utility functions, extending iterators, etc. plus more tests for the diff code. This also takes the example diff.c program much further in terms of emulating git-diff command line options.
	290f240e	2012-02-23T11:16:47		Fix readdir usage across platforms This fixes the missing readdir_r from win32 and fixes other platforms to always use the reentrant readdir_r form for reading directory contents.
	0534641d	2012-02-22T15:15:35		Fix iterators based on pull request feedback This update addresses all of the feedback in pull request #570. The biggest change was to create actual linked list stacks for storing the tree and workdir iterator state. This cleaned up the code a ton. Additionally, all of the static functions had their 'git_' prefix removed, and a lot of other unnecessary changes were removed from the original patch.
	b6c93aef	2012-02-21T14:46:24		Uniform iterators for trees, index, and workdir This create a new git_iterator type of object that provides a uniform interface for iterating over the index, an arbitrary tree, or the working directory of a repository. As part of this, git ignore support was extended to support push and pop of directory-based ignore files as the working directory is being traversed (so the array of ignores does not have to be recreated at each directory during traveral). There are a number of other small utility functions in buffer, path, vector, and fileops that are included in this patch that made the iterator implementation cleaner.
	5e0de328	2012-02-13T17:10:24		Update Copyright header Signed-off-by: schu <schu-github@schulog.org>
	1744fafe	2012-01-17T15:49:47		Move path related functions from fileops to path This takes all of the functions that look up simple data about paths (such as `git_futils_isdir`) and moves them over to path.h (becoming `git_path_isdir`). This leaves fileops.h just with functions that actually manipulate the filesystem or look at the file contents in some way. As part of this, the dir.h header which is really just for win32 support was moved into win32 (with some minor changes).