Commit cf6029aaf3a7625c9a87bc21814ab95467faba3e
2022-12-22T16:53:41
Drop generic support
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254
diff --git a/examples/rfc-6238.rs b/examples/rfc-6238.rs
index eefe4ed..ba4ef40 100644
--- a/examples/rfc-6238.rs
+++ b/examples/rfc-6238.rs
@@ -17,7 +17,7 @@ fn main() {
#[cfg(not(feature = "otpauth"))]
fn main() {
- let mut rfc = Rfc6238::with_defaults("totp-sercret-123").unwrap();
+ let mut rfc = Rfc6238::with_defaults("totp-sercret-123".into()).unwrap();
// optional, set digits, issuer, account_name
rfc.digits(8).unwrap();
diff --git a/src/lib.rs b/src/lib.rs
index 6fe89f9..cc71cc1 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -298,8 +298,8 @@ impl TOTP {
digits: usize,
skew: u8,
step: u64,
- secret: T,
- ) -> Result<TOTP<T>, TotpUrlError> {
+ secret: Vec<u8>,
+ ) -> Result<TOTP, TotpUrlError> {
crate::rfc::assert_digits(&digits)?;
crate::rfc::assert_secret_length(secret.as_ref())?;
Ok(TOTP {
@@ -686,40 +686,45 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn comparison_different_algo() {
- let reference = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
- let test = TOTP::new(Algorithm::SHA256, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let reference =
+ TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
+ let test = TOTP::new(Algorithm::SHA256, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert_ne!(reference, test);
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn comparison_different_digits() {
- let reference = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
- let test = TOTP::new(Algorithm::SHA1, 8, 1, 1, "TestSecretSuperSecret").unwrap();
+ let reference =
+ TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
+ let test = TOTP::new(Algorithm::SHA1, 8, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert_ne!(reference, test);
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn comparison_different_skew() {
- let reference = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
- let test = TOTP::new(Algorithm::SHA1, 6, 0, 1, "TestSecretSuperSecret").unwrap();
+ let reference =
+ TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
+ let test = TOTP::new(Algorithm::SHA1, 6, 0, 1, "TestSecretSuperSecret".into()).unwrap();
assert_ne!(reference, test);
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn comparison_different_step() {
- let reference = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
- let test = TOTP::new(Algorithm::SHA1, 6, 1, 30, "TestSecretSuperSecret").unwrap();
+ let reference =
+ TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
+ let test = TOTP::new(Algorithm::SHA1, 6, 1, 30, "TestSecretSuperSecret".into()).unwrap();
assert_ne!(reference, test);
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn comparison_different_secret() {
- let reference = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
- let test = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretDifferentSecret").unwrap();
+ let reference =
+ TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
+ let test = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretDifferentSecret".into()).unwrap();
assert_ne!(reference, test);
}
@@ -819,7 +824,7 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn returns_base32() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert_eq!(
totp.get_secret_base32().as_str(),
"KRSXG5CTMVRXEZLUKN2XAZLSKNSWG4TFOQ"
@@ -829,14 +834,14 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn generate_token() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert_eq!(totp.generate(1000).as_str(), "659761");
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn generate_token_current() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
let time = SystemTime::now()
.duration_since(SystemTime::UNIX_EPOCH)
.unwrap()
@@ -850,28 +855,28 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn generates_token_sha256() {
- let totp = TOTP::new(Algorithm::SHA256, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA256, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert_eq!(totp.generate(1000).as_str(), "076417");
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn generates_token_sha512() {
- let totp = TOTP::new(Algorithm::SHA512, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA512, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert_eq!(totp.generate(1000).as_str(), "473536");
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn checks_token() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 0, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 0, 1, "TestSecretSuperSecret".into()).unwrap();
assert!(totp.check("659761", 1000));
}
#[test]
#[cfg(not(feature = "otpauth"))]
fn checks_token_current() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 0, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 0, 1, "TestSecretSuperSecret".into()).unwrap();
assert!(totp
.check_current(&totp.generate_current().unwrap())
.unwrap());
@@ -881,7 +886,7 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn checks_token_with_skew() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 1, 1, "TestSecretSuperSecret".into()).unwrap();
assert!(
totp.check("174269", 1000) && totp.check("659761", 1000) && totp.check("260393", 1000)
);
@@ -890,7 +895,7 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn next_step() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 1, 30, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 1, 30, "TestSecretSuperSecret".into()).unwrap();
assert!(totp.next_step(0) == 30);
assert!(totp.next_step(29) == 30);
assert!(totp.next_step(30) == 60);
@@ -899,7 +904,7 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn next_step_current() {
- let totp = TOTP::new(Algorithm::SHA1, 6, 1, 30, "TestSecretSuperSecret").unwrap();
+ let totp = TOTP::new(Algorithm::SHA1, 6, 1, 30, "TestSecretSuperSecret".into()).unwrap();
let t = system_time().unwrap();
assert!(totp.next_step_current().unwrap() == totp.next_step(t));
}
@@ -919,10 +924,9 @@ mod tests {
#[test]
#[cfg(feature = "otpauth")]
fn from_url_default() {
- let totp = TOTP::from_url(
- "otpauth://totp/GitHub:test?secret=KRSXG5CTMVRXEZLUKN2XAZLSKNSWG4TFOQ",
- )
- .unwrap();
+ let totp =
+ TOTP::from_url("otpauth://totp/GitHub:test?secret=KRSXG5CTMVRXEZLUKN2XAZLSKNSWG4TFOQ")
+ .unwrap();
assert_eq!(
totp.secret,
base32::decode(
diff --git a/src/rfc.rs b/src/rfc.rs
index 0918a20..30ba33a 100644
--- a/src/rfc.rs
+++ b/src/rfc.rs
@@ -117,7 +117,7 @@ impl Rfc6238 {
})
}
#[cfg(not(feature = "otpauth"))]
- pub fn new(digits: usize, secret: T) -> Result<Rfc6238<T>, Rfc6238Error> {
+ pub fn new(digits: usize, secret: Vec<u8>) -> Result<Rfc6238, Rfc6238Error> {
assert_digits(&digits)?;
assert_secret_length(secret.as_ref())?;
@@ -144,7 +144,7 @@ impl Rfc6238 {
}
#[cfg(not(feature = "otpauth"))]
- pub fn with_defaults(secret: T) -> Result<Rfc6238<T>, Rfc6238Error> {
+ pub fn with_defaults(secret: Vec<u8>) -> Result<Rfc6238, Rfc6238Error> {
Rfc6238::new(6, secret)
}
@@ -169,11 +169,11 @@ impl Rfc6238 {
}
#[cfg(not(feature = "otpauth"))]
-impl<T: AsRef<[u8]>> TryFrom<Rfc6238<T>> for TOTP<T> {
+impl TryFrom<Rfc6238> for TOTP {
type Error = TotpUrlError;
/// Try to create a [TOTP](struct.TOTP.html) from a [Rfc6238](struct.Rfc6238.html) config
- fn try_from(rfc: Rfc6238<T>) -> Result<Self, Self::Error> {
+ fn try_from(rfc: Rfc6238) -> Result<Self, Self::Error> {
TOTP::new(rfc.algorithm, rfc.digits, rfc.skew, rfc.step, rfc.secret)
}
}
@@ -221,7 +221,7 @@ mod tests {
#[cfg(not(feature = "otpauth"))]
fn new_rfc_digits() {
for x in 0..=20 {
- let rfc = Rfc6238::new(x, GOOD_SECRET.to_string());
+ let rfc = Rfc6238::new(x, GOOD_SECRET.into());
if !(6..=8).contains(&x) {
assert!(rfc.is_err());
assert!(matches!(rfc.unwrap_err(), Rfc6238Error::InvalidDigits(_)));
@@ -237,8 +237,8 @@ mod tests {
let mut secret = String::from("");
for _ in 0..=20 {
secret = format!("{}{}", secret, "0");
- let rfc = Rfc6238::new(6, secret.clone());
- let rfc_default = Rfc6238::with_defaults(secret.clone());
+ let rfc = Rfc6238::new(6, secret.as_bytes().to_vec());
+ let rfc_default = Rfc6238::with_defaults(secret.as_bytes().to_vec());
if secret.len() < 16 {
assert!(rfc.is_err());
assert!(matches!(rfc.unwrap_err(), Rfc6238Error::SecretTooSmall(_)));
@@ -257,11 +257,11 @@ mod tests {
#[test]
#[cfg(not(feature = "otpauth"))]
fn rfc_to_totp_ok() {
- let rfc = Rfc6238::new(8, GOOD_SECRET.to_string()).unwrap();
+ let rfc = Rfc6238::new(8, GOOD_SECRET.into()).unwrap();
let totp = TOTP::try_from(rfc);
assert!(totp.is_ok());
let otp = totp.unwrap();
- assert_eq!(&otp.secret, GOOD_SECRET);
+ assert_eq!(&otp.secret, GOOD_SECRET.as_bytes());
assert_eq!(otp.algorithm, crate::Algorithm::SHA1);
assert_eq!(otp.digits, 8);
assert_eq!(otp.skew, 1);