IABSD.fr/src/libexec/ftpd/logutmp.c

Branch : - branch - master - tag -

• Show log

  Commit

• Author : deraadt
  Date : 2019-06-28 13:32:41
  Hash : df69c215
  Message : When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

• libexec/ftpd/logutmp.c

• /*	$OpenBSD: logutmp.c,v 1.14 2019/06/28 13:32:53 deraadt Exp $	*/
  /*
   * Portions Copyright (c) 1988, 1993
   *	The Regents of the University of California.  All rights reserved.
   * Portions Copyright (c) 1996, Jason Downs.  All rights reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   * 1. Redistributions of source code must retain the above copyright
   *    notice, this list of conditions and the following disclaimer.
   * 2. Redistributions in binary form must reproduce the above copyright
   *    notice, this list of conditions and the following disclaimer in the
   *    documentation and/or other materials provided with the distribution.
   * 3. Neither the name of the University nor the names of its contributors
   *    may be used to endorse or promote products derived from this software
   *    without specific prior written permission.
   *
   * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
   * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
   * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
   * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
   * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
   * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
   * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
   * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
   * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   */
  
  #include <sys/types.h>
  #include <sys/time.h>
  #include <sys/socket.h>
  #include <netinet/in.h>
  #include <netinet/ip.h>
  #include <netinet/tcp.h>
  
  #include <fcntl.h>
  #include <unistd.h>
  #include <stdlib.h>
  #include <utmp.h>
  #include <stdio.h>
  #include <string.h>
  #include <ttyent.h>
  
  #include "monitor.h"
  #include "extern.h"
  
  static int fd = -1;
  static int topslot = -1;
  
  /*
   * Special versions of login()/logout() which hold the utmp file open,
   * for use with ftpd.
   */
  
  void
  ftpd_login(struct utmp *ut)
  {
  	struct utmp ubuf;
  
  	/*
  	 * First, loop through /etc/ttys, if needed, to initialize the
  	 * top of the tty slots, since ftpd has no tty.
  	 */
  	if (topslot < 0) {
  		topslot = 0;
  		while (getttyent() != (struct ttyent *)NULL)
  			topslot++;
  	}
  	if ((topslot < 0) || ((fd < 0) &&
  	    (fd = open(_PATH_UTMP, O_RDWR|O_CREAT, 0644)) == -1))
  		return;
  
  	/*
  	 * Now find a slot that's not in use...
  	 */
  	(void)lseek(fd, (off_t)topslot * sizeof(struct utmp), SEEK_SET);
  
  	while (1) {
  		if (read(fd, &ubuf, sizeof(struct utmp)) ==
  		    sizeof(struct utmp)) {
  			if (!ubuf.ut_name[0]) {
  				(void)lseek(fd, -(off_t)sizeof(struct utmp),
  				    SEEK_CUR);
  				break;
  			}
  			topslot++;
  		} else {
  			(void)lseek(fd, (off_t)topslot * sizeof(struct utmp),
  			    SEEK_SET);
  			break;
  		}
  	}
  
  	(void)write(fd, ut, sizeof(struct utmp));
  }
  
  int
  ftpd_logout(char *line)
  {
  	struct timeval tv;
  	struct utmp ut;
  	int rval;
  
  	rval = 0;
  	if (fd < 0)
  		return(rval);
  
  	(void)lseek(fd, 0, SEEK_SET);
  
  	while (read(fd, &ut, sizeof(struct utmp)) == sizeof(struct utmp)) {
  		if (!ut.ut_name[0] ||
  		    strncmp(ut.ut_line, line, UT_LINESIZE))
  			continue;
  		bzero(ut.ut_name, UT_NAMESIZE);
  		bzero(ut.ut_host, UT_HOSTSIZE);
  		gettimeofday(&tv, NULL);
  		ut.ut_time = tv.tv_sec;
  		(void)lseek(fd, -(off_t)sizeof(struct utmp), SEEK_CUR);
  		(void)write(fd, &ut, sizeof(struct utmp));
  		rval = 1;
  	}
  	return(rval);
  }