Allow usage of the new Condition Variable code with Critical Sections Vista and later provide the SleepConditionVariableCS() function for this. Since SDL_syscond_srw.c doesn't require SRW locks anymore, rename it to SDL_syscond_cv.c which better reflects the implementation of condition variables rather than the implementation of mutexes. Fixes #4051.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 880415e..0a22a55 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1596,7 +1596,7 @@ elseif(WINDOWS)
set(SDL_THREAD_WINDOWS 1)
set(SOURCE_FILES ${SOURCE_FILES}
${SDL2_SOURCE_DIR}/src/thread/generic/SDL_syscond.c
- ${SDL2_SOURCE_DIR}/src/thread/windows/SDL_syscond_srw.c
+ ${SDL2_SOURCE_DIR}/src/thread/windows/SDL_syscond_cv.c
${SDL2_SOURCE_DIR}/src/thread/windows/SDL_sysmutex.c
${SDL2_SOURCE_DIR}/src/thread/windows/SDL_syssem.c
${SDL2_SOURCE_DIR}/src/thread/windows/SDL_systhread.c
diff --git a/VisualC/SDL/SDL.vcxproj b/VisualC/SDL/SDL.vcxproj
index d5deb7e..5cb8b03 100644
--- a/VisualC/SDL/SDL.vcxproj
+++ b/VisualC/SDL/SDL.vcxproj
@@ -559,7 +559,7 @@
<ClCompile Include="..\..\src\stdlib\SDL_strtokr.c" />
<ClCompile Include="..\..\src\thread\generic\SDL_syscond.c" />
<ClCompile Include="..\..\src\thread\SDL_thread.c" />
- <ClCompile Include="..\..\src\thread\windows\SDL_syscond_srw.c" />
+ <ClCompile Include="..\..\src\thread\windows\SDL_syscond_cv.c" />
<ClCompile Include="..\..\src\thread\windows\SDL_sysmutex.c" />
<ClCompile Include="..\..\src\thread\windows\SDL_syssem.c" />
<ClCompile Include="..\..\src\thread\windows\SDL_systhread.c" />
diff --git a/VisualC/SDL/SDL.vcxproj.filters b/VisualC/SDL/SDL.vcxproj.filters
index 8fa5c68..4924e6c 100644
--- a/VisualC/SDL/SDL.vcxproj.filters
+++ b/VisualC/SDL/SDL.vcxproj.filters
@@ -1201,7 +1201,7 @@
<ClCompile Include="..\..\src\thread\SDL_thread.c">
<Filter>thread</Filter>
</ClCompile>
- <ClCompile Include="..\..\src\thread\windows\SDL_syscond_srw.c">
+ <ClCompile Include="..\..\src\thread\windows\SDL_syscond_cv.c" />
<Filter>thread\windows</Filter>
</ClCompile>
<ClCompile Include="..\..\src\thread\windows\SDL_sysmutex.c">
diff --git a/include/SDL_hints.h b/include/SDL_hints.h
index 2c4818c..fdfb7ee 100644
--- a/include/SDL_hints.h
+++ b/include/SDL_hints.h
@@ -1547,9 +1547,6 @@ extern "C" {
* They offer better performance, allocate no kernel ressources and
* use less memory. SDL will fall back to Critical Sections on older
* OS versions or if forced to by this hint.
- * This also affects Condition Variables. When SRW mutexes are used,
- * SDL will use Windows Condition Variables as well. Else, a generic
- * SDL_cond implementation will be used that works with all mutexes.
*
* This variable can be set to the following values:
* "0" - Use SRW Locks when available. If not, fall back to Critical Sections. (default)
diff --git a/src/thread/windows/SDL_syscond_cv.c b/src/thread/windows/SDL_syscond_cv.c
new file mode 100644
index 0000000..587a585
--- /dev/null
+++ b/src/thread/windows/SDL_syscond_cv.c
@@ -0,0 +1,299 @@
+/*
+ Simple DirectMedia Layer
+ Copyright (C) 1997-2021 Sam Lantinga <slouken@libsdl.org>
+
+ This software is provided 'as-is', without any express or implied
+ warranty. In no event will the authors be held liable for any damages
+ arising from the use of this software.
+
+ Permission is granted to anyone to use this software for any purpose,
+ including commercial applications, and to alter it and redistribute it
+ freely, subject to the following restrictions:
+
+ 1. The origin of this software must not be misrepresented; you must not
+ claim that you wrote the original software. If you use this software
+ in a product, an acknowledgment in the product documentation would be
+ appreciated but is not required.
+ 2. Altered source versions must be plainly marked as such, and must not be
+ misrepresented as being the original software.
+ 3. This notice may not be removed or altered from any source distribution.
+*/
+#include "../../SDL_internal.h"
+
+#include "SDL_hints.h"
+#include "SDL_thread.h"
+
+#include "../generic/SDL_syscond_c.h"
+#include "SDL_sysmutex_c.h"
+
+typedef SDL_cond * (*pfnSDL_CreateCond)(void);
+typedef void (*pfnSDL_DestroyCond)(SDL_cond *);
+typedef int (*pfnSDL_CondSignal)(SDL_cond *);
+typedef int (*pfnSDL_CondBroadcast)(SDL_cond *);
+typedef int (*pfnSDL_CondWait)(SDL_cond *, SDL_mutex *);
+typedef int (*pfnSDL_CondWaitTimeout)(SDL_cond *, SDL_mutex *, Uint32);
+
+typedef struct SDL_cond_impl_t
+{
+ pfnSDL_CreateCond Create;
+ pfnSDL_DestroyCond Destroy;
+ pfnSDL_CondSignal Signal;
+ pfnSDL_CondBroadcast Broadcast;
+ pfnSDL_CondWait Wait;
+ pfnSDL_CondWaitTimeout WaitTimeout;
+} SDL_cond_impl_t;
+
+/* Implementation will be chosen at runtime based on available Kernel features */
+static SDL_cond_impl_t SDL_cond_impl_active = {0};
+
+
+/**
+ * Native Windows Condition Variable (SRW Locks)
+ */
+
+#ifndef CONDITION_VARIABLE_INIT
+#define CONDITION_VARIABLE_INIT {0}
+typedef struct CONDITION_VARIABLE {
+ PVOID Ptr;
+} CONDITION_VARIABLE, *PCONDITION_VARIABLE;
+#endif
+
+#if __WINRT__
+#define pWakeConditionVariable WakeConditionVariable
+#define pWakeAllConditionVariable WakeAllConditionVariable
+#define pSleepConditionVariableSRW SleepConditionVariableSRW
+#define pSleepConditionVariableCS SleepConditionVariableCS
+#else
+typedef VOID(WINAPI *pfnWakeConditionVariable)(PCONDITION_VARIABLE);
+typedef VOID(WINAPI *pfnWakeAllConditionVariable)(PCONDITION_VARIABLE);
+typedef BOOL(WINAPI *pfnSleepConditionVariableSRW)(PCONDITION_VARIABLE, PSRWLOCK, DWORD, ULONG);
+typedef BOOL(WINAPI* pfnSleepConditionVariableCS)(PCONDITION_VARIABLE, PCRITICAL_SECTION, DWORD);
+
+static pfnWakeConditionVariable pWakeConditionVariable = NULL;
+static pfnWakeAllConditionVariable pWakeAllConditionVariable = NULL;
+static pfnSleepConditionVariableSRW pSleepConditionVariableSRW = NULL;
+static pfnSleepConditionVariableCS pSleepConditionVariableCS = NULL;
+#endif
+
+typedef struct SDL_cond_cv
+{
+ CONDITION_VARIABLE cond;
+} SDL_cond_cv;
+
+
+static SDL_cond *
+SDL_CreateCond_cv(void)
+{
+ SDL_cond_cv *cond;
+
+ /* Relies on CONDITION_VARIABLE_INIT == 0. */
+ cond = (SDL_cond_cv *) SDL_calloc(1, sizeof(*cond));
+ if (!cond) {
+ SDL_OutOfMemory();
+ }
+
+ return (SDL_cond *)cond;
+}
+
+static void
+SDL_DestroyCond_cv(SDL_cond * cond)
+{
+ if (cond) {
+ /* There are no kernel allocated resources */
+ SDL_free(cond);
+ }
+}
+
+static int
+SDL_CondSignal_cv(SDL_cond * _cond)
+{
+ SDL_cond_cv *cond = (SDL_cond_cv *)_cond;
+ if (!cond) {
+ return SDL_SetError("Passed a NULL condition variable");
+ }
+
+ pWakeConditionVariable(&cond->cond);
+
+ return 0;
+}
+
+static int
+SDL_CondBroadcast_cv(SDL_cond * _cond)
+{
+ SDL_cond_cv *cond = (SDL_cond_cv *)_cond;
+ if (!cond) {
+ return SDL_SetError("Passed a NULL condition variable");
+ }
+
+ pWakeAllConditionVariable(&cond->cond);
+
+ return 0;
+}
+
+static int
+SDL_CondWaitTimeout_cv(SDL_cond * _cond, SDL_mutex * _mutex, Uint32 ms)
+{
+ SDL_cond_cv *cond = (SDL_cond_cv *)_cond;
+ DWORD timeout;
+ int ret;
+
+ if (!cond) {
+ return SDL_SetError("Passed a NULL condition variable");
+ }
+ if (!_mutex) {
+ return SDL_SetError("Passed a NULL mutex");
+ }
+
+ if (ms == SDL_MUTEX_MAXWAIT) {
+ timeout = INFINITE;
+ } else {
+ timeout = (DWORD) ms;
+ }
+
+ if (SDL_mutex_impl_active.Type == SDL_MUTEX_SRW) {
+ SDL_mutex_srw *mutex = (SDL_mutex_srw *)_mutex;
+
+ if (mutex->count != 1 || mutex->owner != GetCurrentThreadId()) {
+ return SDL_SetError("Passed mutex is not locked or locked recursively");
+ }
+
+ /* The mutex must be updated to the released state */
+ mutex->count = 0;
+ mutex->owner = 0;
+
+ if (pSleepConditionVariableSRW(&cond->cond, &mutex->srw, timeout, 0) == FALSE) {
+ if (GetLastError() == ERROR_TIMEOUT) {
+ ret = SDL_MUTEX_TIMEDOUT;
+ } else {
+ ret = SDL_SetError("SleepConditionVariableSRW() failed");
+ }
+ } else {
+ ret = 0;
+ }
+
+ /* The mutex is owned by us again, regardless of status of the wait */
+ SDL_assert(mutex->count == 0 && mutex->owner == 0);
+ mutex->count = 1;
+ mutex->owner = GetCurrentThreadId();
+ } else {
+ SDL_mutex_cs *mutex = (SDL_mutex_cs *)_mutex;
+
+ SDL_assert(SDL_mutex_impl_active.Type == SDL_MUTEX_CS);
+
+ if (pSleepConditionVariableCS(&cond->cond, &mutex->cs, timeout) == FALSE) {
+ if (GetLastError() == ERROR_TIMEOUT) {
+ ret = SDL_MUTEX_TIMEDOUT;
+ } else {
+ ret = SDL_SetError("SleepConditionVariableCS() failed");
+ }
+ } else {
+ ret = 0;
+ }
+ }
+
+ return ret;
+}
+
+static int
+SDL_CondWait_cv(SDL_cond * cond, SDL_mutex * mutex) {
+ return SDL_CondWaitTimeout_cv(cond, mutex, SDL_MUTEX_MAXWAIT);
+}
+
+static const SDL_cond_impl_t SDL_cond_impl_cv =
+{
+ &SDL_CreateCond_cv,
+ &SDL_DestroyCond_cv,
+ &SDL_CondSignal_cv,
+ &SDL_CondBroadcast_cv,
+ &SDL_CondWait_cv,
+ &SDL_CondWaitTimeout_cv,
+};
+
+/**
+ * Generic Condition Variable implementation using SDL_mutex and SDL_sem
+ */
+
+static const SDL_cond_impl_t SDL_cond_impl_generic =
+{
+ &SDL_CreateCond_generic,
+ &SDL_DestroyCond_generic,
+ &SDL_CondSignal_generic,
+ &SDL_CondBroadcast_generic,
+ &SDL_CondWait_generic,
+ &SDL_CondWaitTimeout_generic,
+};
+
+
+SDL_cond *
+SDL_CreateCond(void)
+{
+ if (SDL_cond_impl_active.Create == NULL) {
+ /* Default to generic implementation, works with all mutex implementations */
+ const SDL_cond_impl_t * impl = &SDL_cond_impl_generic;
+
+ if (SDL_mutex_impl_active.Type == SDL_MUTEX_INVALID) {
+ /* The mutex implementation isn't decided yet, trigger it */
+ SDL_mutex *mutex = SDL_CreateMutex();
+ if (!mutex) {
+ return NULL;
+ }
+ SDL_DestroyMutex(mutex);
+
+ SDL_assert(SDL_mutex_impl_active.Type != SDL_MUTEX_INVALID);
+ }
+
+#if __WINRT__
+ /* Link statically on this platform */
+ impl = &SDL_cond_impl_cv;
+#else
+ {
+ HMODULE kernel32 = GetModuleHandle(TEXT("kernel32.dll"));
+ if (kernel32) {
+ pWakeConditionVariable = (pfnWakeConditionVariable) GetProcAddress(kernel32, "WakeConditionVariable");
+ pWakeAllConditionVariable = (pfnWakeAllConditionVariable) GetProcAddress(kernel32, "WakeAllConditionVariable");
+ pSleepConditionVariableSRW = (pfnSleepConditionVariableSRW) GetProcAddress(kernel32, "SleepConditionVariableSRW");
+ pSleepConditionVariableCS = (pfnSleepConditionVariableCS) GetProcAddress(kernel32, "SleepConditionVariableCS");
+ if (pWakeConditionVariable && pWakeAllConditionVariable && pSleepConditionVariableSRW && pSleepConditionVariableCS) {
+ /* Use the Windows provided API */
+ impl = &SDL_cond_impl_cv;
+ }
+ }
+ }
+#endif
+
+ SDL_memcpy(&SDL_cond_impl_active, impl, sizeof(SDL_cond_impl_active));
+ }
+ return SDL_cond_impl_active.Create();
+}
+
+void
+SDL_DestroyCond(SDL_cond * cond)
+{
+ SDL_cond_impl_active.Destroy(cond);
+}
+
+int
+SDL_CondSignal(SDL_cond * cond)
+{
+ return SDL_cond_impl_active.Signal(cond);
+}
+
+int
+SDL_CondBroadcast(SDL_cond * cond)
+{
+ return SDL_cond_impl_active.Broadcast(cond);
+}
+
+int
+SDL_CondWaitTimeout(SDL_cond * cond, SDL_mutex * mutex, Uint32 ms)
+{
+ return SDL_cond_impl_active.WaitTimeout(cond, mutex, ms);
+}
+
+int
+SDL_CondWait(SDL_cond * cond, SDL_mutex * mutex)
+{
+ return SDL_cond_impl_active.Wait(cond, mutex);
+}
+
+/* vi: set ts=4 sw=4 expandtab: */
diff --git a/src/thread/windows/SDL_syscond_srw.c b/src/thread/windows/SDL_syscond_srw.c
deleted file mode 100644
index 763a546..0000000
--- a/src/thread/windows/SDL_syscond_srw.c
+++ /dev/null
@@ -1,282 +0,0 @@
-/*
- Simple DirectMedia Layer
- Copyright (C) 1997-2021 Sam Lantinga <slouken@libsdl.org>
-
- This software is provided 'as-is', without any express or implied
- warranty. In no event will the authors be held liable for any damages
- arising from the use of this software.
-
- Permission is granted to anyone to use this software for any purpose,
- including commercial applications, and to alter it and redistribute it
- freely, subject to the following restrictions:
-
- 1. The origin of this software must not be misrepresented; you must not
- claim that you wrote the original software. If you use this software
- in a product, an acknowledgment in the product documentation would be
- appreciated but is not required.
- 2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
- 3. This notice may not be removed or altered from any source distribution.
-*/
-#include "../../SDL_internal.h"
-
-#include "SDL_hints.h"
-#include "SDL_thread.h"
-
-#include "../generic/SDL_syscond_c.h"
-#include "SDL_sysmutex_c.h"
-
-typedef SDL_cond * (*pfnSDL_CreateCond)(void);
-typedef void (*pfnSDL_DestroyCond)(SDL_cond *);
-typedef int (*pfnSDL_CondSignal)(SDL_cond *);
-typedef int (*pfnSDL_CondBroadcast)(SDL_cond *);
-typedef int (*pfnSDL_CondWait)(SDL_cond *, SDL_mutex *);
-typedef int (*pfnSDL_CondWaitTimeout)(SDL_cond *, SDL_mutex *, Uint32);
-
-typedef struct SDL_cond_impl_t
-{
- pfnSDL_CreateCond Create;
- pfnSDL_DestroyCond Destroy;
- pfnSDL_CondSignal Signal;
- pfnSDL_CondBroadcast Broadcast;
- pfnSDL_CondWait Wait;
- pfnSDL_CondWaitTimeout WaitTimeout;
-} SDL_cond_impl_t;
-
-/* Implementation will be chosen at runtime based on available Kernel features */
-static SDL_cond_impl_t SDL_cond_impl_active = {0};
-
-
-/**
- * Native Windows Condition Variable (SRW Locks)
- */
-
-#ifndef CONDITION_VARIABLE_INIT
-#define CONDITION_VARIABLE_INIT {0}
-typedef struct CONDITION_VARIABLE {
- PVOID Ptr;
-} CONDITION_VARIABLE, *PCONDITION_VARIABLE;
-#endif
-
-#if __WINRT__
-#define pWakeConditionVariable WakeConditionVariable
-#define pWakeAllConditionVariable WakeAllConditionVariable
-#define pSleepConditionVariableSRW SleepConditionVariableSRW
-#else
-typedef VOID(WINAPI *pfnWakeConditionVariable)(PCONDITION_VARIABLE);
-typedef VOID(WINAPI *pfnWakeAllConditionVariable)(PCONDITION_VARIABLE);
-typedef BOOL(WINAPI *pfnSleepConditionVariableSRW)(PCONDITION_VARIABLE, PSRWLOCK, DWORD, ULONG);
-
-static pfnWakeConditionVariable pWakeConditionVariable = NULL;
-static pfnWakeAllConditionVariable pWakeAllConditionVariable = NULL;
-static pfnSleepConditionVariableSRW pSleepConditionVariableSRW = NULL;
-#endif
-
-typedef struct SDL_cond_srw
-{
- CONDITION_VARIABLE cond;
-} SDL_cond_srw;
-
-
-static SDL_cond *
-SDL_CreateCond_srw(void)
-{
- SDL_cond_srw *cond;
-
- /* Relies on CONDITION_VARIABLE_INIT == 0. */
- cond = (SDL_cond_srw *) SDL_calloc(1, sizeof(*cond));
- if (!cond) {
- SDL_OutOfMemory();
- }
-
- return (SDL_cond *)cond;
-}
-
-static void
-SDL_DestroyCond_srw(SDL_cond * cond)
-{
- if (cond) {
- /* There are no kernel allocated resources */
- SDL_free(cond);
- }
-}
-
-static int
-SDL_CondSignal_srw(SDL_cond * _cond)
-{
- SDL_cond_srw *cond = (SDL_cond_srw *)_cond;
- if (!cond) {
- return SDL_SetError("Passed a NULL condition variable");
- }
-
- pWakeConditionVariable(&cond->cond);
-
- return 0;
-}
-
-static int
-SDL_CondBroadcast_srw(SDL_cond * _cond)
-{
- SDL_cond_srw *cond = (SDL_cond_srw *)_cond;
- if (!cond) {
- return SDL_SetError("Passed a NULL condition variable");
- }
-
- pWakeAllConditionVariable(&cond->cond);
-
- return 0;
-}
-
-static int
-SDL_CondWaitTimeout_srw(SDL_cond * _cond, SDL_mutex * _mutex, Uint32 ms)
-{
- SDL_cond_srw *cond = (SDL_cond_srw *)_cond;
- SDL_mutex_srw *mutex = (SDL_mutex_srw *)_mutex;
- DWORD timeout;
- int ret;
-
- if (!cond) {
- return SDL_SetError("Passed a NULL condition variable");
- }
- if (!mutex) {
- return SDL_SetError("Passed a NULL mutex");
- }
-
- if (mutex->count != 1 || mutex->owner != GetCurrentThreadId()) {
- return SDL_SetError("Passed mutex is not locked or locked recursively");
- }
-
- if (ms == SDL_MUTEX_MAXWAIT) {
- timeout = INFINITE;
- } else {
- timeout = (DWORD) ms;
- }
-
- /* The mutex must be updated to the released state */
- mutex->count = 0;
- mutex->owner = 0;
-
- if (pSleepConditionVariableSRW(&cond->cond, &mutex->srw, timeout, 0) == FALSE) {
- if (GetLastError() == ERROR_TIMEOUT) {
- ret = SDL_MUTEX_TIMEDOUT;
- } else {
- ret = SDL_SetError("SleepConditionVariableSRW() failed");
- }
- } else {
- ret = 0;
- }
-
- /* The mutex is owned by us again, regardless of status of the wait */
- SDL_assert(mutex->count == 0 && mutex->owner == 0);
- mutex->count = 1;
- mutex->owner = GetCurrentThreadId();
-
- return ret;
-}
-
-static int
-SDL_CondWait_srw(SDL_cond * cond, SDL_mutex * mutex) {
- return SDL_CondWaitTimeout_srw(cond, mutex, SDL_MUTEX_MAXWAIT);
-}
-
-static const SDL_cond_impl_t SDL_cond_impl_srw =
-{
- &SDL_CreateCond_srw,
- &SDL_DestroyCond_srw,
- &SDL_CondSignal_srw,
- &SDL_CondBroadcast_srw,
- &SDL_CondWait_srw,
- &SDL_CondWaitTimeout_srw,
-};
-
-/**
- * Generic Condition Variable implementation using SDL_mutex and SDL_sem
- */
-
-static const SDL_cond_impl_t SDL_cond_impl_generic =
-{
- &SDL_CreateCond_generic,
- &SDL_DestroyCond_generic,
- &SDL_CondSignal_generic,
- &SDL_CondBroadcast_generic,
- &SDL_CondWait_generic,
- &SDL_CondWaitTimeout_generic,
-};
-
-
-SDL_cond *
-SDL_CreateCond(void)
-{
- if (SDL_cond_impl_active.Create == NULL) {
- /* Default to generic implementation, works with all mutex implementations */
- const SDL_cond_impl_t * impl = &SDL_cond_impl_generic;
-
- if (SDL_mutex_impl_active.Type == SDL_MUTEX_INVALID) {
- /* The mutex implementation isn't decided yet, trigger it */
- SDL_mutex *mutex = SDL_CreateMutex();
- if (!mutex) {
- return NULL;
- }
- SDL_DestroyMutex(mutex);
-
- SDL_assert(SDL_mutex_impl_active.Type != SDL_MUTEX_INVALID);
- }
-
- /* It is required SRW Locks are used */
- if (SDL_mutex_impl_active.Type == SDL_MUTEX_SRW) {
-#if __WINRT__
- /* Link statically on this platform */
- impl = &SDL_cond_impl_srw;
-#else
- HMODULE kernel32 = GetModuleHandle(TEXT("kernel32.dll"));
- if (kernel32) {
- pWakeConditionVariable = (pfnWakeConditionVariable) GetProcAddress(kernel32, "WakeConditionVariable");
- pWakeAllConditionVariable = (pfnWakeAllConditionVariable) GetProcAddress(kernel32, "WakeAllConditionVariable");
- pSleepConditionVariableSRW = (pfnSleepConditionVariableSRW) GetProcAddress(kernel32, "SleepConditionVariableSRW");
- if (pWakeConditionVariable && pWakeAllConditionVariable && pSleepConditionVariableSRW) {
- /* Use the Windows provided API */
- impl = &SDL_cond_impl_srw;
- }
- }
- if (!(kernel32 && pWakeConditionVariable && pWakeAllConditionVariable && pSleepConditionVariableSRW)) {
- SDL_LogWarn(SDL_LOG_CATEGORY_SYSTEM, "Could not load required imports for SRW Condition Variables although SRW Locks are used!");
- }
-#endif
- }
-
- SDL_memcpy(&SDL_cond_impl_active, impl, sizeof(SDL_cond_impl_active));
- }
- return SDL_cond_impl_active.Create();
-}
-
-void
-SDL_DestroyCond(SDL_cond * cond)
-{
- SDL_cond_impl_active.Destroy(cond);
-}
-
-int
-SDL_CondSignal(SDL_cond * cond)
-{
- return SDL_cond_impl_active.Signal(cond);
-}
-
-int
-SDL_CondBroadcast(SDL_cond * cond)
-{
- return SDL_cond_impl_active.Broadcast(cond);
-}
-
-int
-SDL_CondWaitTimeout(SDL_cond * cond, SDL_mutex * mutex, Uint32 ms)
-{
- return SDL_cond_impl_active.WaitTimeout(cond, mutex, ms);
-}
-
-int
-SDL_CondWait(SDL_cond * cond, SDL_mutex * mutex)
-{
- return SDL_cond_impl_active.Wait(cond, mutex);
-}
-
-/* vi: set ts=4 sw=4 expandtab: */
diff --git a/src/thread/windows/SDL_sysmutex.c b/src/thread/windows/SDL_sysmutex.c
index 6bf9f83..e4918de 100644
--- a/src/thread/windows/SDL_sysmutex.c
+++ b/src/thread/windows/SDL_sysmutex.c
@@ -169,11 +169,6 @@ static const SDL_mutex_impl_t SDL_mutex_impl_srw =
* Fallback Mutex implementation using Critical Sections (before Win 7)
*/
-typedef struct SDL_mutex_cs
-{
- CRITICAL_SECTION cs;
-} SDL_mutex_cs;
-
/* Create a mutex */
static SDL_mutex *
SDL_CreateMutex_cs(void)
diff --git a/src/thread/windows/SDL_sysmutex_c.h b/src/thread/windows/SDL_sysmutex_c.h
index 6480e94..1367ca6 100644
--- a/src/thread/windows/SDL_sysmutex_c.h
+++ b/src/thread/windows/SDL_sysmutex_c.h
@@ -66,4 +66,9 @@ typedef struct SDL_mutex_srw
DWORD owner;
} SDL_mutex_srw;
+typedef struct SDL_mutex_cs
+{
+ CRITICAL_SECTION cs;
+} SDL_mutex_cs;
+
/* vi: set ts=4 sw=4 expandtab: */