kc3-lang/SDL/src/audio/jack/SDL_jackaudio.h

• Show log

  Commit

• Hash : 1d25135b
  Author :
  Date : 2018-06-01T19:43:53
  

  Fixed bug 4184 - jack audio driver fails in presence of midi ports
  
  Martin ?irokov
  
  Launching an SDL application with SDL_AUDIODRIVER=jack, and then calling SDL_OpenAudioDevice() with whatever parameters fails with an error like this one:
  
  SDL_OpenAudioDevice: Couldn't connect JACK ports: SDL:sdl_jack_output_0 => system:midi_playback_1
  
  This happens because JACK_OpenDevice in src/audio/jack/SDL_jackaudio.c blindly tries to connect to all input ports without checking whether they are for audio or midi.
  
  The fix is to check port types and ignore all non audio ports. Also I removed devports field from struct SDL_PrivateAudioData, because it's never really used and removing unused ports from it would be PITA.
  

Download

• src/audio/jack/SDL_jackaudio.h

• /*
    Simple DirectMedia Layer
    Copyright (C) 1997-2018 Sam Lantinga <slouken@libsdl.org>
  
    This software is provided 'as-is', without any express or implied
    warranty.  In no event will the authors be held liable for any damages
    arising from the use of this software.
  
    Permission is granted to anyone to use this software for any purpose,
    including commercial applications, and to alter it and redistribute it
    freely, subject to the following restrictions:
  
    1. The origin of this software must not be misrepresented; you must not
       claim that you wrote the original software. If you use this software
       in a product, an acknowledgment in the product documentation would be
       appreciated but is not required.
    2. Altered source versions must be plainly marked as such, and must not be
       misrepresented as being the original software.
    3. This notice may not be removed or altered from any source distribution.
  */
  #ifndef SDL_jackaudio_h_
  #define SDL_jackaudio_h_
  
  #include <jack/jack.h>
  
  #include "../SDL_sysaudio.h"
  
  /* Hidden "this" pointer for the audio functions */
  #define _THIS SDL_AudioDevice *this
  
  struct SDL_PrivateAudioData
  {
      jack_client_t *client;
      SDL_sem *iosem;
      float *iobuffer;
      jack_port_t **sdlports;
  };
  
  #endif /* SDL_jackaudio_h_ */
  
  /* vi: set ts=4 sw=4 expandtab: */
  

Download