kc3-lang/SDL/src/video

• Show log

  Commit

• Hash : e14278ef
  Author :
  Date : 2018-03-24T10:26:40
  

  Fixed bug 3804 - Message box on Windows truncates button ID Simon Hug I just wanted to fix a simple compiler warning in SDL_ShowMessageBox on Windows (which Sam fixed recently) and ended up finding some issues. Attached patch fixes these issues: - Because Windows only reports the lower 16 bits of the control identifier that was pushed, the button IDs used by SDL (C type int, most likely 32 bits) can get cut off. - The documentation states (somewhat ambiguously) that the button ID will be -1 if the dialog was closed, but the current code sets 0. For SDL 2.1, I think this should be a return code of SDL_ShowMessageBox itself. That will free up the button ID and it seems a more appropriate place for signaling this event. - Ampersands in controls will create mnemonics on Windows (underlined letters that, if combined with the Alt key, will push the button). I was thinking of adding a hint or flag to let the users enable it, but that might have unexpected results. - When the size of the text gets calculated, it doesn't use the same parameters as the static control. This can cut off text or wrap it weirdly. - On Windows, the Tab key is used to switch between control groups and sometimes between buttons in dialogs. This didn't seem to work correctly. Attached patch also adds: - Icons. Just the system ones that can be loaded with the ordinals IDI_ERROR, IDI_WARNING and IDI_INFORMATION. - A button limit of 2^16 - 101. - Some more specific error messages, but they never reach the user because how SDL_ShowMessageBox handles them if an implementation returns with an error.

• Files

• SDL_RLEaccel.c
• SDL_RLEaccel_c.h
• SDL_blit.c
• SDL_blit.h
• SDL_blit_0.c
• SDL_blit_1.c
• SDL_blit_A.c
• SDL_blit_N.c
• SDL_blit_auto.c
• SDL_blit_auto.h
• SDL_blit_copy.c
• SDL_blit_copy.h
• SDL_blit_slow.c
• SDL_blit_slow.h
• SDL_bmp.c
• SDL_clipboard.c
• SDL_egl.c
• SDL_egl_c.h
• SDL_fillrect.c
• SDL_pixels.c
• SDL_pixels_c.h
• SDL_rect.c
• SDL_rect_c.h
• SDL_shape.c
• SDL_shape_internals.h
• SDL_stretch.c
• SDL_surface.c
• SDL_sysvideo.h
• SDL_video.c
• SDL_vulkan_internal.h
• SDL_vulkan_utils.c
• SDL_yuv.c
• SDL_yuv_c.h
• android/
• cocoa/
• directfb/
• dummy/
• emscripten/
• haiku/
• khronos/
• kmsdrm/
• mir/
• nacl/
• pandora/
• psp/
• qnx/
• raspberry/
• sdlgenblit.pl
• uikit/
• vivante/
• wayland/
• windows/
• winrt/
• x11/
• yuv2rgb/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags