kc3-lang/SDL/src/events

Diff

• Show log

  Commit

• Hash : 32d6dcdb
  Author :
  Date : 2015-05-28T12:48:20
  

  Fixed bug 2096 - Mapping from scancode to keycode doesn't work for remapped modifier keys
  
  Jacob Lee
  
  If a user has a non-standard keyboard mapping -- say, their caps lock key has been mapped to Ctrl -- then SDL_GetModState() is no longer accurate: it only considers the unmapped keys. This is a regression from SDL 1.2.
  
  I think there are two parts to this bug: first, GetModState should use keycodes, rather than scancodes, which is easy enough.
  
  Unfortunately, on my system, SDL considers Caps Lock, even when mapped as Control, to be both SDL_SCANCODE_CAPSLOCK and SDLK_CAPSLOCK. The output from checkkeys for it is:
  
  INFO: Key pressed :  scancode 57 = CapsLock, keycode 0x40000039 = CapsLock  modifiers: CAPS
  
  Whereas the output for xev is:
  
  KeyPress event, serial 41, synthetic NO, window 0x4a00001,
      root 0x9a, subw 0x0, time 40218333, (144,177), root:(1458,222),
      state 0x10, keycode 66 (keysym 0xffe3, Control_L), same_screen YES,
      XKeysymToKeycode returns keycode: 37
      XLookupString gives 0 bytes:
      XmbLookupString gives 0 bytes:
      XFilterEvent returns: False
  
  I think the problem is that X11_UpdateKeymap in SDL_x11keyboard.c only builds a mapping for keycodes associated with a Unicode character (anything where X11_KeyCodeToUcs returns a value). In the case of caps lock, SDL scancode 57 becomes x11 keycode 66, which becomes x11 keysym 65507(Control_L), which does not have a unicode value.
  
  To fix this, I suspect that SDL needs a mapping of the rest of the x11 keysyms to their corresponding SDL key codes.
  

• Files

• SDL_clipboardevents.c
• SDL_clipboardevents_c.h
• SDL_dropevents.c
• SDL_dropevents_c.h
• SDL_events.c
• SDL_events_c.h
• SDL_gesture.c
• SDL_gesture_c.h
• SDL_keyboard.c
• SDL_keyboard_c.h
• SDL_mouse.c
• SDL_mouse_c.h
• SDL_quit.c
• SDL_sysevents.h
• SDL_touch.c
• SDL_touch_c.h
• SDL_windowevents.c
• SDL_windowevents_c.h
• blank_cursor.h
• default_cursor.h
• scancodes_darwin.h
• scancodes_linux.h
• scancodes_windows.h
• scancodes_xfree86.h

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags