kc3-lang/SDL/src/video/x11

• Show log

  Commit

• Hash : 362d5496
  Author :
  Date : 2017-08-14T10:28:47
  

  Fixed bug 2500 - X11: SDL tries (and fails) to hide foreign windows Alvin I'm interested in this bug as well. I have experienced it when trying to embed an SDL_Window into a FLTK application. To do this, I create a FLTK window (window inside a window - think video player) and then use SDL_CreateWindowFrom() on the inner most window's Xlib Window*. After which, I create a renderer. In my situation I am using the FLTK GUI toolkit. What I have experienced is that the SDL_CreateRender() will recreate the window in order to properly setup OpenGL capability. As part of this process, the window is hidden and a call is executed that waits indefinitely for an acknowledgement that the window was indeed unmapped. This is where my program hangs. Please correct me if I am wrong, but should SDL2 not make Xlib calls that effect the Xlib Window in this situation (e.g. When SDL_CreateWindowFrom() is used)? The toolkit being used typically assumes responsibility and, I presume, tracks all Xlib Windows it creates. On line src/video/SDL_video.c:1372 the comment associated with setting SDL_WINDOW_FOREIGN reads: /* Can't destroy and re-create foreign windows, hrm */ Since I do not know the reason for hiding the window in the first place, the attached patch simply does not wait for a response when X11_XWithdrawWindow() and X11_XMapRaised() are issued by X11_HideWindow() and X11_ShowWindow(), respectively. I presume that the GUI toolkit (GTK, FLTK, etc.) has or will consume the acknowledging event as it is managing the Xlib Window (or it thinks it is). I have tested the patch against hg 5c645d037de2 and I have successfully tested: * Embedding the SDL_Window inside a FLTK application. * Calling SDL_SetWindowSize() when FLTK resizes the window (e.g. dragging cursor on the edge of the window). * Filling the renderer's default target blue and drawing a red fill square at the centre (exciting, I know!) * Calling SDL_Quit() when the application terminates I do not receive any Xlib erorr messages (BadWindow, etc.) in any of those situations.

• Files

• SDL_x11clipboard.c
• SDL_x11clipboard.h
• SDL_x11dyn.c
• SDL_x11dyn.h
• SDL_x11events.c
• SDL_x11events.h
• SDL_x11framebuffer.c
• SDL_x11framebuffer.h
• SDL_x11keyboard.c
• SDL_x11keyboard.h
• SDL_x11messagebox.c
• SDL_x11messagebox.h
• SDL_x11modes.c
• SDL_x11modes.h
• SDL_x11mouse.c
• SDL_x11mouse.h
• SDL_x11opengl.c
• SDL_x11opengl.h
• SDL_x11opengles.c
• SDL_x11opengles.h
• SDL_x11shape.c
• SDL_x11shape.h
• SDL_x11sym.h
• SDL_x11touch.c
• SDL_x11touch.h
• SDL_x11video.c
• SDL_x11video.h
• SDL_x11window.c
• SDL_x11window.h
• SDL_x11xinput2.c
• SDL_x11xinput2.h
• edid-parse.c
• edid.h
• imKStoUCS.c
• imKStoUCS.h

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags