kc3-lang/SDL/src/stdlib

Diff

• Show log

  Commit

• Hash : 342f62ca
  Author :
  Date : 2020-03-10T16:29:28
  

  Fixed bug 5022 - SDL_iconv_string can get stuck in an infinite loop when encountering invalid characters
  
  ciremo6483
  
  In `SDL_iconv_string` the `while (inbytesleft > 0)` loop can end up in a state where it never terminates because the library `iconv` function called from `SDL_iconv` doesn't consume any bytes.
  
  This happened when a `WCHAR_T` input string was being converted to `UTF-8` but contained invalid characters. It would first It would first skip a few bytes due to `case SDL_ICONV_EILSEQ` but when there were 3 bytes remaining of `inbytesleft` `iconv` just didn't consume anything more (but didn't throw an error either).
  
  It just so happens that the Microsoft Classic IntelliMouse `product_string` contains such invalid characters (`"Microsoft? Classic IntelliMouse?"`), meaning the function would get stuck with said mouse plugged in.
  
  A fix for this would be to check if `inbytesleft` was unchanged after an iteration and in that case either decrement the counter like when `SDL_ICONV_EILSEQ` is returned or simply break the loop.
  

• Files

• SDL_getenv.c
• SDL_iconv.c
• SDL_malloc.c
• SDL_qsort.c
• SDL_stdlib.c
• SDL_string.c
• SDL_strtokr.c

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags