kc3-lang/angle

2021-09-13T20:10:10

Revert "GL: Relax the assertion to exclude BoundAsAttachment bit" This reverts commit b27bca08ef4ee20a0952b8efeb7c132bdb2ebb50. Reason for revert: Wrong fix. Original change's description: > GL: Relax the assertion to exclude BoundAsAttachment bit > > Front end has added DIRTY_BIT_BOUND_AS_ATTACHMENT when texture is > attached to FBO. This bit usually is processed at Texture::syncState > time. But there are situations that This call may not been called before > texture is been used, since existing code not expecting merely attach > tetxure to FBO will insert dirty bit to texture and there is this place > updateProgramTextureBindings() in GL backend is hitting assertion > because of this new bit. This CL adds a new check > hasAnyDirtyBitExcludingBoundAsAttachmentBit to avoid hitting assertion. > > Bug: angleproject:6381 > Change-Id: I615c27e5d5efe751a25d5c9ecf11c1409a699f46 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3158547 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: angleproject:6381 Change-Id: I0e7bf066a3736c72918f1fe36d195b5c516b569c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3158297 Reviewed-by: Charlie Lao <cclao@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Charlie Lao <cclao@google.com>