Author :
Yuxin Hu
Date :
2024-07-25 14:07:38
Hash :c9744617 Message :Fix Unknown Android Git Hash in Android Builds
The ANGLE git hash is generated by running the script
src/commit_id.py during compile time. However, in Android repo,
access to .git is not guaranteed. This results the "unknown hash"
value being generated by src/commit_id.py when compiling ANGLE in
Android repo. To fix it, instead of invoking the src/commit_id.py
during compile time, invoke the script
during ANGLE to Android roll time. This change:
1) Removes the code in
generate_android_bp.py that exports the build target angle_commit_id
into Android.bp, so that the script src/commit_id.py is not invoked
when compiling ANGLE in Android.
2) Invokes src/commit_id.py in aosp_roll.sh, to generate the
angle_commit.h when we roll ANGLE changes into Android.
Sample results with this change in Android is
https://googleplex-android-review.git.corp.google.com/c/platform/external/angle/+/28476591
Bug: b/348044346
Change-Id: I91862ba6ab20ffb2cf9e99ee9b4fa6b83727c634
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5741631
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu