kc3-lang/angle

Log

Author Commit Date CI Message
Geoff Lang 057b76e1 2019-04-12T14:48:59 Implement GL_CHROMIUM_lose_context. This is useful for testing context lost behaviour. BUG=angleproject:3379 Change-Id: If0e1538553b1761e313fc36ccde5138cd495200f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1566141 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 95c0fae6 2019-04-16T22:46:08 Vulkan: Clear surface images if emulated format This was done for renderbuffers but was missing for surfaces. Bug: angleproject:2722 Change-Id: I019805d6ca43eef86d2d46e7c72c1013803f2139 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1570149 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Michael Spang 3b2c6bfd 2019-04-16T17:19:50 Vulkan: Implement glImportMemoryFdEXT Allow importing opaque file descriptors into memory objects on linux. Currently this just holds onto the file descriptor rather than calling vkAllocateMemory immediately. The latter will be easier once we have support for suballocation (anglebug.com/2162). Bug: angleproject:3289 Change-Id: Ia80ce07b2a9ec95b9063feb9bfeb24ffe77fa40e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552028 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 20a71631 2019-04-17T07:01:35 Roll ./third_party/spirv-tools/src 3335c61147d7..3aad3e9228b3 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3335c61147d7..3aad3e9228b3 Created with: gclient setdep -r ./third_party/spirv-tools/src@3aad3e9228b3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=cwallez@google.com Change-Id: I9f5b217d748244b82001189f743c70de2d26a77e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1571180 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis c832cdd7 2019-04-15T14:53:01 dEQP test_expectations parser should output an error on unused lines. dEQP test_expectations parser should allow nested overrides. When an expectation line is not used for any test, it's likely duplicated or misspelled, or the test was removed. The parser should output these errors to make it easier to keep the expectations up to date. Also necessary to allow longer/more specific expectations to override shorter ones, so the scenario where you FAIL one set of tests across platforms, and SKIP a subset of that group on one platform will still be allowed. Bug: angleproject:3368 Change-Id: If0470cb6fb12f8d3daa97df0c701185fa086668c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564725 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Sunny Sachanandani b8a8ffd3 2019-04-11T21:09:37 Add support for RGB10A2 in eglCreatePbufferFromClientBuffer Bug: chromium:937108 Change-Id: I689562ebff9f9f85ecb8af918bbb788b16b0f91b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565420 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Michael Spang e0da9cef 2019-04-16T14:34:51 Pack handle type enum for glImportMemoryFd & glImportSemaphoreFd Bug: angleproject:3289 Change-Id: Ic20b1d55641494b46622e1e28d93e2ca30655ea6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1566143 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Sascha Kolodzey 50eb1e6f 2019-04-16T12:18:35 D3D: Update dynamic BufferUsage flags. Changed the mapping between gl::BufferUsage flags and D3DBufferUsage flags. Only gl::BufferUsage::DynamicDraw gets mapped to D3DBufferUsage::DYNAMIC now. This reflects a better mapping between GL and D3D. BUG=angleproject:3366 Change-Id: I5062f91fdb3664339e2c259b399d5f47401675d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1569465 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mingyu Hu 7d64c486 2019-03-12T14:27:40 GL_ANGLE_multiview has been renamed to GL_OVR_multiview2. changes include: 1) GL_OVR_multiview to GL_OVR_multiview2 extension directive change 2) Removal of all references to side by side. We no longer support multiple views in a single 2DTexture. Only 2DTextureArray's are supported 3) WebGL 2 (ES3) is required for multiview Bug: angleproject:3341 Change-Id: Ie0c1d21d7610f8feebdb2e4d01c6947f57e69328 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552023 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Corentin Wallez e02ad4d3 2019-04-16T14:12:37 Suppress tests crashing on teardown on Win Intel D3D11 BUG=angleproject:3349 Change-Id: Ib86f8b87d719919c980240d3220521a3c7f8a942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1569466 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
angle-autoroll bb1e670b 2019-04-16T07:01:35 Roll ./third_party/spirv-tools/src 102e430a88db..3335c61147d7 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/102e430a88db..3335c61147d7 Created with: gclient setdep -r ./third_party/spirv-tools/src@3335c61147d7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=cwallez@google.com Change-Id: I0b0e3294b65fe060cf5f68c7b11a4c672d808522 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1568762 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Qin Jiajia e7da32f1 2018-12-27T15:31:47 Fix the failure in UpdateImageTextureInUse If we update the texture data between two dispatch calls, ReadPixels can't get right result after the second dispatch call. The failure reason is that after the first dispatch, ReadPixels will sync framebufer state which will update color render target. Finally, TextureD3D::ensureRenderTarget is reached. However, we are in compute pipeline. mTexStorage->isRenderTarget() will be false. That results the current texture will create a new render target storage. But the UAV is still bound with the previous texture storage. If there is no texture dirty bit between these two dispatch calls, applyTexturesForCompute won't be called. After the second dispatch, readPixels will read data from the new texture storage which is not updated. Bug: angleproject:3015 Change-Id: Ib2494ab8bf6e12faefc0a7370719d383526c36ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1390710 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Jonah Ryan-Davis ccd91316 2019-04-12T14:13:22 Use primaryGPUIndex over activeGPUIndex when determining the system GPU. Mac OPENGL/AMD dEQP test suppressions were being ignored because in SystemInfo the activeGPUIndex was used when the primaryGPUIndex should have been used. Bug: angleproject:3373 Change-Id: I2664049b956bf8903c6d7094ec27646766e7ce16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565056 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi d3ec341d 2019-04-10T11:37:07 Fix LineLoopStateChangeTest to actually draw square and hourglass The test claimed to be drawing an hourglass followed by a square. That is: ---- \/ /\ ---- followed by: ---- | | | | ---- With the end result being: ---- |\/| |/\| ---- However, in reality it was drawing two hour glasses with the same result. That is: ---- \/ /\ ---- followed by: |\/| |/\| Bug: angleproject:3361 Change-Id: I59a2930f78e6e448b6ccb2e5f70c73ff0f15a2ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561650 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 5646a7cc 2019-04-12T16:42:56 Uniform buffers not dirtied for gl_VertexID workaround on D3D11. Related to: https://chromium-review.googlesource.com/c/angle/angle/+/1520988 The program uniform buffers were dirtied for this edge case, but it should have been the driver uniform buffers. This CL fixes this and adds a tests case which catches this. Bug: 945903 Change-Id: I6142771e200513ed0251fc97cec68d371d39ec1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565059 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shrek Shao <shrekshao@google.com>
Jamie Madill 2664da8b 2019-04-08T16:26:52 Correct texImage uses of texture type -> target. Similarly to how the subImage calls were corrected. glTexImage and the family of related functions apply to a single texture target. This means we need a different TexImage call for each cube face. This is distinct from TexStorage calls which take a Cube map directly. Note this is mostly a refactoring change. But it does increase code consistency and should allow for more efficient code reuse. Bug: angleproject:3356 Change-Id: I252f8983cdda3a8f0223c44cbbe8d8e2dd319a88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558673 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Geoff Lang ba9a21af 2019-04-15T09:25:25 Update suggested reviewers documentation. BUG=angleproject:1944 Change-Id: I17becf44a86969c0929e51b548cf90220027fb75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565060 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 639729c3 2019-04-15T07:01:35 Roll ./third_party/spirv-tools/src 98b3f26c2f1f..102e430a88db (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/98b3f26c2f1f..102e430a88db Created with: gclient setdep -r ./third_party/spirv-tools/src@102e430a88db The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=ynovikov@google.com Change-Id: I367824273259bd2a34cce14d89d67354496b9c15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1567286 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 065f8dc3 2019-04-11T12:56:00 Vulkan: Set appropriate GL conformant bit for returned configs The Khronos conformance tests only test configs that have the conformant bit set. ANGLE is currently targetting OpenGL ES 2.0 conformance, so this change is setting the EGL_OPENGL_ES2_BIT bit to indicate this. ES 2.0 conformance reporting is being restricted by ANGLE_VULKAN_CONFORMANT_CONFIGS_ONLY for official builds, but ES 3.0 conformance will be reported for builds without ANGLE_VULKAN_CONFORMANT_CONFIGS_ONLY enabled. Bug: angleproject:3374 Test: CQ Dry Run Change-Id: Ie31f63c3ea3b7bddfceec80ebc28f079ffd363df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564717 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Courtney Goeltzenleuchter 8f0210f7 2019-04-10T10:44:10 Always enable NPOT for Vulkan backend Vulkan natively supports non power-of-two textures so indicate that support for front-end. Bug: angle-project:3239 Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_texture_completeness_2d_npot_t_repeat --use-angle=vulkan Change-Id: Id9058b6e9afd1d43e5d74612f808ce39beafd35f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561963 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ben Wagner 1e064014 2019-04-12T14:10:17 Fix 'not all control paths return a value' and add to extra_warnings Bug: angleproject:3356 Change-Id: I9831b2035bc1e887c6d5a68a444e69e2bf5aa60a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565055 Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 23667b7e 2019-04-10T12:49:56 Update test result output from ANGLE dEQP gtests. * prints lines for total, passed, failed, not supported, skipped, and exception results. * prints unexpected passed and failed tests each individually using the dEQP name of the test. * moves skipped test detection into the test loop. skipped tests will now print a message that they've been skipped. Bug: angleproject:3369 Change-Id: Idbfc0154a658eda3f52b5bfd30fbff0860a00133 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561970 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6c85037d 2019-04-12T12:49:29 Move ANGLE CQ to linux-angle-rel and mac-angle-rel. This will allow mac_angle_rel_ng and linux_angle_rel_ng to be removed. Bug: chromium:822310 Change-Id: I259f84c195ed4cfde17a441bf13d812a477537d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565053 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4877ef35 2019-04-12T10:36:00 Ensure deleteTexture preserves correct texture cache. Also adds a test contributed by jgilbert@mozilla.com. Bug: angleproject:3375 Change-Id: Ibd52daa074bf53b2b213193ccf5a612705a89c67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565052 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0e30681d 2019-04-10T15:09:53 Vulkan: Add design docs on line segment raster. The docs are based on an internal google document available at go/vangle-line-rasterization. The link won't work for non-Googlers. Also cleans up the format of the markdown file somewhat. Bug: angleproject:3344 Change-Id: Ic466c44099e25f12b9afc4565bbd0fe37097af9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561969 Reviewed-by: Kenneth Russell <kbr@chromium.org>
Jamie Madill df5ae9f6 2019-04-11T14:49:23 Vulkan: Write design doc explaining SPIR-V generation. The two-pass approach first uses ANGLE's shader translator followed by glslang. The doc explains it in more detail with links. Bug: angleproject:3345 Change-Id: I04fd31993e3cd62ac409f2696e18f7ec39e5c6ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560252 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov a95940c6 2019-04-12T10:54:05 Suppress flaky dEQP 3.1 test functional.shaders.builtin_functions.uniform.findLSBMinusOne.highp_compute on D3D11 Bug: angleproject:2619 Change-Id: Ia7a83429d03b871967d2d6c5ecd3ce82111b98fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565427 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tobin Ehlis 9af10e8a 2019-04-11T16:20:57 Incorrectly placed extension directive is an error The ESSL 1.00 spec states "...the extension directives must occur before any non-preprocessor tokens." This change makes the occurance of an extension directive after non-preprocessor tokens a compilation error. Bug: angleproject:3285 Change-Id: I9f8631366151c92fb6d8b4408596917012d9a3e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565411 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Nico Weber 0de5b648 2019-04-11T22:11:13 Remove explicit -Wextra-semi, -Winconsistent-missing-override flags. They're enabled via the chromium_code config already these days. No intended behavior change. Bug: chromium:926235,chromium:428099 Change-Id: I6927d6e3ec85f40454da61969d7a22dfabef1bde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564781 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
angle-autoroll e6f4515a 2019-04-12T07:01:35 Roll ./third_party/spirv-tools/src 82ebbbba15c2..98b3f26c2f1f (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82ebbbba15c2..98b3f26c2f1f Created with: gclient setdep -r ./third_party/spirv-tools/src@98b3f26c2f1f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=ynovikov@google.com Change-Id: I6b754fbe2656eca4ceb730919a47206fb7eb5b60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565771 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill cfc73cc1 2019-04-08T16:26:51 Correct subImage uses of texture type -> target. Texture "types" are the same as texture "targets" except for cube maps. Cube map targets specify a single face. Cube map types specify a whole cube map. The subImage functions should take a target instead of a type. We were using both in different places. This CL corrects all uses in subImage calls to "target". It also adds a helper for getting a target texture from a target. And clarifies the naming of the texture query methods. Bug: angleproject:3356 Change-Id: I06eb5c5666eec9b8934becf2ba57a066d5cdabde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558672 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov e29b61e6 2019-04-11T17:02:42 Skip ParallelShaderCompileTestES31.LinkAndDispatchManyPrograms Flaky on Win NVIDIA D3D11 Bug: angleproject:3359 Change-Id: I56a0e4266f1cd0913852a43852666dee055a8e00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564562 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 2249d4a7 2019-04-05T16:48:55 Vulkan: remove clear depth ability from clearWithDraw This partially reverts the following change: 60ec8f576 Vulkan: break dependency to the depthClamp feature The feature is no longer necessary, and simplifies the usage of utility shaders. Bug: angleproject:2361 Change-Id: I1e87ac8d2517c5a3b50e3d0cddd55c852e0e3e7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1555313 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Shahbaz Youssefi 127990f9 2019-04-04T13:52:04 Vulkan: Use render pass loadOp for scissored clears At this point, every clear is done through render pass loadOp, except masked color or stencil clears. The only fallback is clearWithDraw, that can clear both color and stencil at the same time. Bug: angleproject:2361 Change-Id: I805fc12475e832ad2f573f665cdfeb766e61a6d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553740 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Shahbaz Youssefi d581f918 2019-04-11T10:21:05 Vulkan: few more EGL dEQP suppressions on Android Follow up to c02ef98fb199341d644e4751ac682d858595420e. Bug: angleproject:2546 Change-Id: Ibad7befc5bed95544c0cf15a79d25b47ec8a00bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564710 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov e6b23e45 2019-04-10T17:19:15 Skip Texture2DTestES3.TextureImplPropogatesDirtyBits on Win AMD GL Bug: angleproject:3371 Change-Id: I7601e6b658835b9c948acab98491f5bd01ea9497 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1562517 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis 34cbc544 2019-04-05T11:30:10 Use ANGLE's gpu_info_util libraries for test expectations 3. Remove gpu_info.h and gpu_info.cc and use ANGLE's own gpu_info_util to to gather device info instead. - Support collecting info for and parsing expectations of specific Android devices such as Nexus 5X and Pixel 2. - Change parser behavior to more closely follow: bit.ly/chromium-test-list-format Bug: angleproject:2677 Change-Id: I4c0b9342142b718e884484a6bcaac2dff3ac575a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553822 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 893ccb48 2019-04-09T16:19:20 Skip EGLSurfaceTest.SwapInterval on Nexus 5X and 6P GLES Bug: angleproject:3364 Change-Id: I51dd45cfcd1c548266712b71eac0dca60574e69e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558960 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 76a9a97f 2019-04-10T10:28:41 Minor update to auto-roller infra docs. Bug: angleproject:1944 Change-Id: I06e613f002d390e85faadc9bec903e83fdd9fdec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560596 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c02ef98f 2019-04-09T16:09:44 Vulkan: update GLES3 and EGL expectations Few GLES3 expectations were updated in preparation for running those tests on the bots (one change on Linux, a handful on Android). A number of EGL tests were discovered to crash on Android. They are suppressed as well. Note that most of these tests were previously marked as failing or flaky on the GLES backend as well, and they are marked as SKIP everywhere instead. Bug: angleproject:2341 Bug: angleproject:2546 Bug: angleproject:2950 Bug: angleproject:3186 Change-Id: If52d5faeea994c8b6200b713b3c2f1b1a1aeff92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560251 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Michael Spang a0b00e97 2019-04-09T18:45:22 Vulkan: Expose GL_EXT_memory_object_fd & GL_EXT_semaphore_fd If the vulkan driver has support for VK_KHR_external_memory_fd or VK_KHR_external_semaphore_fd, add the GL versions of these to the vulkan renderer's extensions. Bug: angleproject:3289 Change-Id: I7f04b5cf883f93f6ccd579c2b75d6831b854bfd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552027 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll a131a151 2019-04-10T07:01:34 Roll ./third_party/spirv-tools/src d90aae9a5a6c..82ebbbba15c2 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d90aae9a5a6c..82ebbbba15c2 Created with: gclient setdep -r ./third_party/spirv-tools/src@82ebbbba15c2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=ynovikov@google.com Change-Id: I834daaff382898fee3733d3f05054421b4af6deb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560892 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten f39b4f02 2019-04-09T12:04:51 Vulkan Android: Remove workaround to clamp the point size This is to remove the workaround introduced by anglebug.com/2599 since Nexus 5x devices aren't in the farm anymore and the tests pass on Pixel devices. Bug: angleproject:2599 Test: angle_deqp_gles2_tests Test: angle_end2end_tests Change-Id: I14f724494909486a2164ddd734a95b6980429f29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559202 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Michael Spang d3c57452 2019-04-09T15:37:10 Fix leak of MemoryObjectManager from context state Bug: chromium:951049 Change-Id: I4e9e2cfe3c287fcb6e536ec20c20acbfda1d8405 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559203 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org>
Jamie Madill e4458b7b 2019-04-08T16:26:50 Fix glCopyTexSubImage3D. Two bugs were present in our implementation. We were using the y offset for z in ensureSubImageInitialized. And for our D3D back-end we were potentially reading from the wrong image index. Bug: chromium:947342 Change-Id: If39671a911e08fcc641b9ba6f5910e3a2c16eb5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558671 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi a254fa28 2019-04-09T14:25:59 Rename getCurrentDisplay to getDisplay There is always only one display that can be associated with a context, so get*Current*Display is confusing. Bug: None Change-Id: Iff3a9fc5ad1154b046bb30d7f46a468802ba7fcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558958 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi af0301a8 2019-04-09T10:43:04 Vulkan: fix CPU throttling frames to 2 Previously, the CPU was throttled to be at most N frames ahead, N being the number of swapchain images. N is now fixed to 2, regardless of the number of swapchain images. If N < 2, we would be stalling the CPU unnecessarily, and if N > 2, the CPU could get too far ahead. Effectively, here is how the throttling plays out with this commit: Submit (Fence 1) + Present Submit (Fence 2) + Present Wait Fence 1 Submit (Fence 3) + Present Wait Fence 2 Submit (Fence 4) + Present Wait Fence 3 Submit (Fence 5) + Present Wait Fence 4 ... Bug: angleproject:2942 Change-Id: I3b8c3bb88e52d62231306ec84aad50d2bf472d8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558681 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 3702d8c9 2019-04-08T13:44:06 Propogate dirty bit signals from TextureImpl to Texture up to Context. If TextureImpl sets a local dirty bit and signals gl::Texture of it, the dirtyness is not propogated to context. This can result in draw calls with textures that are not synchronized BUG=949985 Change-Id: I9baf82c96598265a6a4850f1fd48e213b5e98ab5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556699 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Tim Van Patten 7d689863 2019-04-08T12:31:33 Re-Enable MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN The test MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN was disabled for Vulkan Android due to Nexus 5x and Pixel 2 issues. The Nexus 5x has been removed from the test infrastructure and the Pixel 2 issue seems to have sorted itself out. Bug: angleproject:2817 Test: angle_end2end_tests MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN Change-Id: I85bb56707def2906194c34942fcd74a811255abc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558293 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi fc15ae55 2019-04-08T23:32:32 Vulkan: parallelize internal shader compilation As glslang is rolling frequently now, internal shaders frequently require recompilation. This change parallelizes shader compilation to speed up this process. Bug: angleproject:3333 Change-Id: Icace083559bff73dfb9b5fe7cc2c59ce8137a2dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558680 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9f7585bf 2019-04-08T16:34:03 Formalize preference for handling generated code. This documents the discussion and conclusion on preferring to bake generated code into the repository. Bug: angleproject:3333 Change-Id: I1afc338c59d5bcb2a64f843081aba5120820e9ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558676 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 0086a8ac 2019-04-09T09:15:59 Skip LineLoopStateChangeTest.DrawElementsThenDrawArrays on Win Vulkan AMD Bug: angleproject:3361 Change-Id: I39c595e1b8ab73520422e2dd3433cd007a1415a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559789 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 304f857d 2019-04-09T07:01:34 Roll ./third_party/spirv-tools/src e8c2d95ed45f..d90aae9a5a6c (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8c2d95ed45f..d90aae9a5a6c Created with: gclient setdep -r ./third_party/spirv-tools/src@d90aae9a5a6c The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=ynovikov@google.com Change-Id: Ie83b6a4df33b1733153216721b5a9e1f4f883047 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558757 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b81b08e4 2019-04-09T07:01:09 Roll ./third_party/glslang/src e06c7e9a515b..0527c9db8148 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e06c7e9a515b..0527c9db8148 Created with: gclient setdep -r ./third_party/glslang/src@0527c9db8148 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=ynovikov@google.com Change-Id: I76730e84198452d79381d030a757080c03de092a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558755 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 82418c82 2019-04-05T15:56:03 Add support for updating glslang_validator binary from Linux. Updates the glslang_validator binary for Linux in the same commit. Bug: angleproject:3333 Change-Id: Ide42781ec4951e7c09307a0a3b96c36c6ea29d23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553828 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a7440a22 2019-04-08T15:50:30 Add glslang and SPIRV autorollers to wrangling doc Bug: angleproject:1944 Change-Id: I9d93ec16044e2a40eeee5073e77696c86338f651 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558670 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 65d10f3b 2019-03-21T16:30:31 Vulkan: Implement robust resource initialization If a texture or renderbuffer needs to be cleared for robust access or due to having emulated channels, it is immediately cleared. The former relies on a front-end feature that optimizes robust access clears only to levels and layers that are not fully initialized through data upload. Bug: angleproject:2722 Change-Id: Icdab856eb4ffe963f78569b6d80d9ff5cb27ff9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1535056 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
shrekshao 8413faba 2019-04-04T17:13:18 Fix formsRenderingFeedbackLoopWith check To make it pass the following webgl conformance test https://github.com/KhronosGroup/WebGL/blob/master/sdk/tests/conformance/rendering/rendering-sampling-feedback-loop.html It used to fail due to 1. Didn't check if texture unit is sampler complete 2. Only checked active drawbuffers. But drawbuffer settings shouldn't be taken into account when checking drawing feedback loop. On top of applying these 2 functional fixes, I also tried to do some optimization by unwrapping the nested for loop for program sampler bindings and texture unit in `Program::samplesFromTexture` and putting them outside of the draw buffer loop according to the old comment by Antonie @piman. https://codereview.chromium.org/2461973002/ > ... turning it around (for each texture check if it's also an attachment, instead of for each attachment check if it's a bound texture). In particular, we have an upper bound on the number of attachments, so we can look them up outside the loop into a fixed size buffer on the stack - and the very common case will be to only have 1 of them making the inner loop cheap. But this unwraps sort of breaks the code structure. An alternative way would be passed in a framebuffer pointer into `Program::samplesFromTexture` but that would ends up in tight class coupling. I am a bit unsure here. Would like to hear if think this change is okay in terms of code style. In addition to further speed up this check (as it runs for every draw validation) I added a cache mLastColorAttachmentId indicating the last i of GL_COLORATTACHMENTi that is not GL_NONE to shorten this inner loop. In most scenario we won't have up to max number of color attachments. A side note: this is still failing https://github.com/KhronosGroup/WebGL/blob/master/sdk/tests/conformance2/rendering/depth-stencil-feedback-loop.html But it's because the test case doesn't fit the spec at this moment. I will update this test later. Bug: chromium:660844 Change-Id: I6d718dada71a5d989caac04de03f2454f2377612 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553963 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
Jamie Madill bfc5df16 2019-04-08T12:54:56 Remove function pointers in CopyTexture3DTest. No longer needed with the ANGLE loader. Bug: None Change-Id: If206c529efaee5b81b68059341dcc6e841126842 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556698 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi edef895a 2019-04-04T10:03:09 Vulkan: make sure clear value is completely initialized If clearing only depth or stencil, the other channels contained garbage. Additionally, this removes the clearing of emulated channels. Emulated textures are cleared once, and they don't need to be recleared. Bug: angleproject:2361 Change-Id: I01aa6be116d44f6c0115a1c25322db2e579a7b23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553739 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill d5ff4fad 2019-04-08T09:25:23 Add standalone glslang_validator as a download hook. This change allows us to download a copy of the standalone glslang validator during gclient runhooks. This decouples run_code_generation from the version of glslang stored in source tree. This prevents the error where a developer would run into a code generation conflict due to a change in version of glslang. Currently only the Windows version is stored in the tree. A follow-up CL will add Linux. The validator will only initially support Windows or Linux. Documentation for the script is located in tools/glslang/README.md. This CL also updates the Vulkan shader generation script to use the new binary for Windows. Bug: angleproject:3333 Change-Id: Ia6146a283a2bcfdf84c42411d6b5d8bae136bf1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553823 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 9f958344 2019-04-08T09:40:40 Add MD browser to DEPS. This tool can allow you to browser markdown files in the repository locally. Run tools/md_browser/md_browser.py and navigate to localhost:8080. It will point you to the root README.md. From there you can put in relative links to navigate to your new or changed markdown files. Bug: angleproject:3333 Change-Id: I5b4d608e2ad7408280868eb6561f95f3e55d8e8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556696 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 90b1865e 2019-03-29T00:00:27 More unittests for BitSet Bug: angleproject:2361 Change-Id: Icca49086d95ddb0d2d50e5ba71ae9b748eeabf3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545203 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5d50678e 2019-04-06T15:04:03 Roll glslang forward 1240db678cae..e06c7e9a515b Manual roll to unblock the autoroller stuck on presubmit failure. Bug: None Change-Id: I97094add66a42154309addea43fe6aa5e1411c43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556694 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi efec568b 2019-04-03T15:19:26 Expand clear tests for more mask combinations The test was previously either masking every three aspect (color, depth and stencil) or none. This was not exercising every clear path in the Vulkan backend. Bug: angleproject:3241 Change-Id: Ief4085ea302ec17bffe30b1f8510ae357fd01290 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551523 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi c7565353 2019-04-03T14:03:56 Vulkan: break dependency to the depthClamp feature Image clear's masked clear path using a draw call was using this feature to clear the depth buffer, but this feature is not available on ARM and some Qualcomm devices. This change adds a push constant to the vertex shader used in this call to export the depth clear value, removing the need to rely on depth clamping. Bug: angleproject:3241 Change-Id: I565cd5f731c441820e0702e51dfdf02d0bc7de06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551522 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Shahbaz Youssefi f6c937f8 2019-04-02T17:04:08 Vulkan: fix masked stencil clear Previously, masked stencil clear was done by clearing every stencil bit to the ClearValue & Mask. The correct behavior as implemented in this change is to clear only the bits that are set in Mask. This can only be done through a draw call, with ClearValue as the stencil reference, and Mask as the stencil write mask. Note: this change relies on the depthClamp Vulkan feature which is not available on ARM. Bug: angleproject:3241 Change-Id: I0a181c32f881ee813f144e7bdd6f42c8ea6f1966 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548442 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Tobin Ehlis 194a9674 2019-04-05T09:20:46 Vulkan:Return HW's SUBPIXEL_BITS Plumb the physical HW's subPixelPrecisionBits limit to be returned in the query for GL_SUBPIXEL_BITS. Default value remains 4 for all other backends. Bug: angleproject:3351 Change-Id: I5564e5090e7211b8daeaa91ea30eceb23c5ea227 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553967 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Tim Van Patten 5f388c24 2019-03-14T09:54:23 Vulkan: dEQP-EGL.functional.image.modify.* Determine the destination internalFormat correctly. dEQP-EGL.functional.image.modify.renderbuffer_rgb565_tex_subimage_rgb8 dEQP-EGL.functional.image.modify.renderbuffer_rgba4_tex_subimage_rgba8 dEQP-EGL.functional.image.modify.tex_rgb565_tex_subimage_rgb8 dEQP-EGL.functional.image.modify.tex_rgba4_tex_subimage_rgba8 dEQP-EGL.functional.image.modify.tex_rgba8_tex_subimage_rgba5_a1 dEQP-EGL.functional.image.modify.tex_rgba8_tex_subimage_rgba4 dEQP-EGL.functional.image.modify.tex_rgba5_a1_tex_subimage_rgba8 dEQP-EGL.functional.image.modify.tex_rgba5_a1_tex_subimage_rgba4 dEQP-EGL.functional.image.modify.tex_rgba4_tex_subimage_rgba8 dEQP-EGL.functional.image.modify.tex_rgba4_tex_subimage_rgba5_a1 dEQP-EGL.functional.image.modify.renderbuffer_rgba4_tex_subimage_rgba8 dEQP-EGL.functional.image.modify.renderbuffer_rgba4_tex_subimage_rgba5_a1 dEQP-EGL.functional.image.modify.renderbuffer_rgb5_a1_tex_subimage_rgba8 dEQP-EGL.functional.image.modify.renderbuffer_rgb5_a1_tex_subimage_rgba4 Bug: angleproject:3170 Change-Id: Ic9870390b2d4a0dcbe561efd3fb1597faadb7d79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1524404 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll b9a71427 2019-04-05T07:01:35 Roll ./third_party/spirv-tools/src e2ddb9371edb..e8c2d95ed45f (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e2ddb9371edb..e8c2d95ed45f Created with: gclient setdep -r ./third_party/spirv-tools/src@e8c2d95ed45f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: Idc4d741c4ddd93a7a3ac8516572fbd38f47f2c6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1554562 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1aef340c 2019-04-05T07:01:33 Roll ./third_party/spirv-headers/src 111a25e4ae45..2434b89345a5 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/111a25e4ae45..2434b89345a5 Created with: gclient setdep -r ./third_party/spirv-headers/src@2434b89345a5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: Ia36909b72970b177fbaf6074899469d673a27297 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1554561 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Michael Spang 9de3ddb5 2019-04-03T16:23:40 Generate entrypoints for GL_EXT_memory_object_fd & GL_EXT_semaphore_fd This adds entrypoints for the Linux variants of GL_EXT_memory_object & GL_EXT_semaphore. Bug: angleproject:3289 Change-Id: I40de40f27aa82cd9479d5913dac0a7493919bb8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552026 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Michael Spang fb201c5e 2019-04-03T14:57:35 Implement resource management for GL_EXT_memory_object This implements glCreateMemoryObjectsEXT, glDeleteMemoryObjectsEXT, and glIsMemoryObjectEXT. It's not possible to do anything useful with them yet. Bug: angleproject:3289 Change-Id: I8882b657e9de564b5f97f8dea87838f67b1928f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552025 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Michael Spang 7a8c3e5e 2019-04-03T14:49:57 Generate entrypoints for GL_EXT_memory_object & GL_EXT_semaphore This adds entrypoints for two new extensions that will be useful for importing external Vulkan objects into ANGLE. Bug: angleproject:3289 Change-Id: I206dc76eda5c6c8d836db7c6413c5544326aa722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552024 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 27f115aa 2019-04-01T10:33:21 Vulkan: clean up framebuffer clear The Qualcomm bug workaround is changed such that clears still go through the render pass loadOp, but the render pass is immediately closed. This allows us to remove a few fallback methods. Bug: angleproject:2361 Change-Id: I24c3884a183f8bb40673e922773f70faffad848f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545524 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 896e7ded 2019-04-04T10:59:55 Use compressed internal format as 'format' in tables. Previously we would store the unsized 'base' format as the internal format. For instance for GL_COMPRESSED_RGB_S3TC_DXT1_EXT we would store GL_RGB. With the new spec validation for TexSubImage it becomes clearer to store the internal format of the compressed texture as the 'format'. Bug: angleproject:3170 Change-Id: I7446418896eabd3d4f143e9cae4976889b973674 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553379 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 85b04bb2 2019-04-02T12:57:36 Minor cleanups to copy vertex. Makes the files parsable as c++ files. Bug: chromium:943709 Change-Id: I6f7d718f9773fe4a7f72828ee9cd56beb5577c66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545528 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 12b25347 2019-04-04T07:36:09 Roll ./third_party/glslang/src ef807f4bc543..1240db678cae (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ef807f4bc543..1240db678cae Created with: gclient setdep -r ./third_party/glslang/src@1240db678cae The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: I9582981b9b1d2494f03e1c2fbd88a4c70d41a89c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552498 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 43997017 2019-03-30T23:24:01 Vulkan: fix non-float clear with draw Instead of using one draw call that clears all attachments, multiple draw calls are issued that clear a single attachment each. This allows us to have a manageable number of variations for the ImageClear.frag shader, now that non-float format support is introduced. Bug: angleproject:3187 Change-Id: Ic0c1067a396250bd80f31d00cad5a272acff8be8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545523 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi f9f18ef0 2019-04-03T10:07:18 Vulkan: Allow vertex-only pipelines This allows issuing draw calls which only manipulate depth/stencil. Bug: angleproject:3241 Change-Id: I62ab18a185ea5b234d3559f30c5b2b8ecb317bbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550900 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 13264033 2019-04-03T15:18:16 Minor cleanups to run_code_generation. Prints more info when a particular file is not found. Bug: angleproject:3333 Change-Id: I11ceb0d319023cd1fd23fd25297e5367030342a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550899 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 84661549 2019-04-03T15:22:02 Add presubmit to commit queue. This should prevent CLs failing presubmit checks from landing. Bug: angleproject:3288 Change-Id: I7d4ee56bd2cbe0089248d1737275aaeac8394d96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551839 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0719a88e 2019-04-03T13:15:17 Fix OOB access for dynamic attribs with offsets. We were not properly adding the offset to compute the right bounds. Bug: chromium:943709 Change-Id: I93e714b46dd366d5833fffa858ea3ab0322ffa92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548441 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 91524d8c 2019-04-02T15:31:30 Disable Clear and TextureUpload perf tests on D3D11 The tests crash on Nvidia in the driver. Bug: 945415 Change-Id: I0f635eb5d99ecaeeaff055793b1b5fd3a314b055 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548440 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 24980278 2019-04-03T09:03:51 D3D11: Skip DepthTexturesWithMipmaps on AMD/D3D11. Possible driver bug. Bug: angleproject:3342 Change-Id: Ia171a7ac0d764859c4440b1fe2986aa931ff75c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550799 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6266dd9f 2019-04-03T09:15:09 Roll ./third_party/glslang/src e0d59bbe1857..ef807f4bc543 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e0d59bbe1857..ef807f4bc543 Created with: gclient setdep -r ./third_party/glslang/src@ef807f4bc543 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: I6d65dfbb90b5b8deee9e90c873d5d2ac03a14afe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550141 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5688c85b 2019-04-03T07:01:35 Roll ./third_party/spirv-tools/src 320a7de5c9a5..e2ddb9371edb (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/320a7de5c9a5..e2ddb9371edb Created with: gclient setdep -r ./third_party/spirv-tools/src@e2ddb9371edb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: Ib84307d822bafaec4d9185e75c830266d72bd6d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550083 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
jchen10 89899748 2019-01-16T08:32:25 ParallelCompile: D3D compute This parallelizes the compiling and linking for compute shaders on the D3D backend. Bug: chromium:849576 Change-Id: Idd6b418cb9c2448209c15eab2756599f8ff7af4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1415725 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
James Darpinian 2889dff6 2019-03-27T16:25:11 Mac: Support using an IOSurface as the default framebuffer Bug: angleproject:2764 Change-Id: I3fdab330b59ed996f68e3063debca29323a66cf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542599 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 892d1805 2019-03-27T14:21:34 Vulkan: Have the WindowSurfaceVk own the submit semaphores. Chaining of submit semaphores is only needed for window surfaces because they are required for the first usage of the swap chain image and final present of the image. Move ownership of the submit semaphores from RendererVk to WindowSurfaceVk and update all calls to finish and flush to be piped through a ContextVk which tracks the currently bound window surface. BUG=angleproject:2464 Change-Id: I4b3083124d7910a5dee297afc219e3a3f28057f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542257 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jeff Gilbert 1af744b5 2019-04-01T16:33:11 Windows SDK includes need to be lowercase for MinGW builds. Bug: angleproject:3336 Change-Id: If2075b3ed2fe0be95ab2ec9cd0398afef691dee8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548433 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi db4ed317 2019-03-29T00:32:45 Vulkan: glClearBuffer* implementation Refactors FramebufferVk::clear such that specific render targets could be cleared, with clear values not necessarily set through glClearColor etc. FramebufferVk::clearWithRenderPassOp is modified so that loadOp and clear values are set after the render pass has been registered in the graph. This allows multiple glClearBuffer calls to coalesce into the same render pass. glClearBuffer calls are then implemented simply as calls to the refactored clear function with the appropriate parameters. Bug: angleproject:3187 Change-Id: I2fdfcbea5bf244f63ec981b91caca47f5ee3cd3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545204 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis 750935f4 2019-04-02T11:27:19 Ignore flaky dEQP failures on Windows More flaky failures that were being hidden by test retries. Might take a few more patches in order to disable test retries. Bug: angleproject:3271 Bug: angleproject:1729 Change-Id: I97eb02d6e93892a04db8b09992f32c4c20dbd49b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1549314 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Geoff Lang 66ae5315 2019-04-01T16:35:53 Add a mac_toolchain update DEP. Update use_system_xcode to match Chrome. BUG=948286 Change-Id: I85f44622efaf4f018d00046e4fc5dc0757f38539 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545127 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi d3fd67e0 2019-03-29T23:22:34 Add a test for glClearBuffers of render targets of same FBO This test is to ensure the upcoming Vulkan implementation can coalesce all the calls into a single render pass clear. Bug: angleproject:2361 Change-Id: I816907b3512715c1d3217689413b6c8e9842a37a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544973 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 1d72f658 2019-03-29T22:42:45 Add a test for glClearColor followed by glClearBuffer This test is to ensure the upcoming Vulkan implementation uses the right colors for each render target. Bug: angleproject:2361 Change-Id: Ibc6f8b474ac598a20d8cc9ac1c7fd18667370cbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544972 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 04e9e559 2019-04-01T14:40:21 Use revision.h for glslang dirty checks. This file changes a lot less than git HEAD. And it should guard against the same changes. Should reduce the instances of developer confusion regarding run_code_generation being out of data. Also update the presubmit check to print a more helpful message in the case where the code does need to be regenerated. Bug: angleproject:3333 Change-Id: I190dab5be50fc42512bdfc11c2d200f34f3b2092 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545123 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 7a6e421e 2019-04-02T10:21:51 Move presubmit from ci -> try. The ci section is for continuous integration. This change should allow for the presubmit tester to show up on the list of additional trybots. Bug: angleproject:3288 Change-Id: I95ac359434557a76cb4f87a1d38aaec90879e406 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545527 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 6cb0cff5 2019-03-28T11:01:22 Add a test for masked/scissored multi-attachment clear Done after noticing a bug in the Vulkan backend where masked (and possibly scissored) color clears were only clearing the first attachment. Bug: angleproject:2361 Change-Id: I471d337b1c3a3a5e17748690ae2222a6351773ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544971 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 925cad81 2019-04-01T15:32:58 Add a presubmit builder. This runs the run_presubmit canned recipe. It should work the same as it would in Chromium or Dawn or most other repos. It should prevent rollers and devs from landing several common types of dirty changes. This CL adds the builder that then we can test manually before adding it to the CQ. Bug: angleproject:3288 Change-Id: I45e78669d0b6c34cef50ab9cb45c33a1b8bb6aca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548293 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0