Log

Author Commit Date CI Message
angle-autoroll 0b7e347a 2022-08-03T07:00:46 Roll Chromium from 0920d63e6fcc to fe6c14e1fc75 (234 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0920d63e6fcc..fe6c14e1fc75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/920ededbb7..c8168ef10e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7cc5dcaf53..3787411136 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2a52133e52 * third_party/fuchsia-sdk/sdk: version:9.20220802.1.1..version:9.20220802.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b11b8b482f..b59b9a6691 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c16cded755..d7b966b45a Clang version changed llvmorg-15-init-17529-ga210f404:llvmorg-16-init-572-gdde41c6c Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/b11b8b482f214d8b2e278e2337796d7bdd74fb36..b59b9a6691d38a1a25a605841ef70b5f93d53ad6/scripts/update.py Bug: None Tbr: jmadill@google.com Change-Id: Ia7be20282220c02fa20386fc8662c47a8e7b427e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3807263 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 05d86e06 2022-08-02T18:30:52 Add temporary logging of gold_session.Initialize stdout. Normally looks like: Loaded 1549 known hashes ... Suspecting that in failure cases it's going to result in something different. Bug: angleproject:7550 Change-Id: I0190d4f679fc4161fc36a3008ba2e7d6d4764277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804752 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll 47684b26 2022-08-02T19:03:35 Roll Chromium from d268b4c8a6b1 to 0920d63e6fcc (256 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d268b4c8a6b1..0920d63e6fcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b1d3dcea6a..920ededbb7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/03d22b4428..7cc5dcaf53 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2ecd8167d1..ee25a7fdb8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..81c03c3de9 * third_party/fuchsia-sdk/sdk: version:9.20220801.2.1..version:9.20220802.1.1 * third_party/r8: 5xaODYedSIJ21XAwZcpj4pG3NuVyKXrw43631PdtgK0C..fyrZX7YFSdaFh8Uqs1iTtsYtS8351A4ndoz7WiIIrDgC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e72ce0a99e..c16cded755 No update to Clang. Bug: angleproject:6430 Tbr: jmadill@google.com Change-Id: I1300a11225b7c1c30eeafd189aa8b3f45f31a072 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3805752 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 351a2a6b 2022-08-02T16:14:08 Skip multi draw indirect tests on Linux/Intel/Vulkan. This test suite seems to have become flaky. Bug: angleproject:7549 Change-Id: Ib8b8c22fb6b228137fe2e5ca19b00d70ce1fee25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804749 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov 19c6600c 2022-08-02T12:45:57 Refactoring: move a few common functions to angle_test_util. Drop ScriptTest, Jamie says no longer needed. Bug: angleproject:7299 Change-Id: I32bdd1d70701f63b578b4f79512868daac3ad520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3805381 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 13da8b97 2022-08-02T08:52:06 Tests: Add Octopath Traveler trace Test: angle_perftests --gtest_filter="*octopath_traveler*" Bug: angleproject:7543 Change-Id: I6187058f99c1598051a118ac65e0121e9c35ac9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3805739 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill c0f2a5ac 2022-08-02T15:54:40 Skip TimerQueriesTest flakes on NV/Linux. TimerQueriesTest.Timestamp/ES2_Vulkan_AsyncCommandQueue TimerQueriesTest.TimeElapsed/ES2_Vulkan_AsyncCommandQueue Bug: angleproject:7548 Change-Id: I3bd4ccd8241ae230ef074e1c453d4f4d880daf47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804748 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 245198f1 2022-08-02T15:37:34 Skip flaky tests on Linux/Vulkan. FramebufferTest_ES3.SurfaceDimensionsChangeAndFragCoord/* Bug: angleproject:7546 Change-Id: I911ce59305f1ec6bdc2a8ec2b6d9247c60526b4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804747 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Jamie Madill f62b4b94 2022-08-02T15:19:59 Skip flaky image load/store tests on Win/D3D11. Bug: angleproject:7345 Change-Id: I64e752b8959c0fb726ee8fd8ed733bdb469ca511 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804746 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Jamie Madill c29100a8 2022-08-02T14:07:40 Skip flaky test on SwiftShader. MultithreadingTestES3.ThreadCWaitBeforeThreadBSyncFinish Flakes on both Win and Linux SwiftShader. Bug: angleproject:7419 Change-Id: Ia5f4ca3ee1bb6aedbcd41fa6d4cefe4b872cae6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804744 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Eddie Hatfield 6e6f3e6d 2022-07-29T11:13:24 Convert GLenum to string for failed trace prereq message Bug: angleproject:5784 Change-Id: I14bc01afe97a2475d8b0f278840a279b663da7db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3794304 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
angle-autoroll 1353f119 2022-08-02T10:01:01 Roll vulkan-deps from 4818e22b9347 to 9501e63393f3 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/4818e22b9347..9501e63393f3 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ed5fab5096..bf1244cefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I358c61ce7d8920c94dcdff12a39faa1a80558ba3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3803998 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 8eaa0ccf 2022-08-02T12:03:21 Revert "[Metal] Disable ANGLE's Metal backend on older GPUs." This reverts commit cc2095d259222de434af06ce8515f17449a8f66d. Reason for revert: breaks rolling into Chromium https://ci.chromium.org/ui/p/chromium/builders/try/ios-simulator/1234241/overview Original change's description: > [Metal] Disable ANGLE's Metal backend on older GPUs. > > Disable creation of EGL_PLATFORM_ANGLE_TYPE_METAL_ANGLE displays on: > iOS: MTLGPUFamilyApple2 and older (A8 and older GPUs) > macOS and Mac Catalyst: MTLGPUFamilyMac1 and older > > This is a partial integration of this recent WebKit fix: > https://bugs.webkit.org/show_bug.cgi?id=242764 > > Refactored to eliminate duplicate copies of this code between libANGLE > and the test suites. > > Fixed: angleproject:7514 > Change-Id: I00dd1096bc8e72516f3f77fffcb7d4a886d6f2e4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780876 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> Change-Id: If1e78ebc0c8e12a1fa0954d91bdd59fbd734251f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804879 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0d0d9168 2022-08-02T10:01:31 Roll SwiftShader from 67158b90f83c to 678ffefb1b3b (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/67158b90f83c..678ffefb1b3b 2022-08-01 sugoi@google.com Increase subTexelPrecisionBits from 4 to 8 2022-08-01 swiftshader.regress@gmail.com Regres: Update test lists @ 80aaa8a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I3357d7fa5749e21e95223f64f704fcee1362f78f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804267 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 60a02ca6 2022-08-02T07:00:32 Roll Chromium from bfa66f9bea8c to d268b4c8a6b1 (202 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bfa66f9bea8c..d268b4c8a6b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/35807fca11..b1d3dcea6a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/03e060ebda..56cc5bc223 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/57cf1a6ce6..03d22b4428 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..682d9b1d88 * third_party/fuchsia-sdk/sdk: version:9.20220801.1.1..version:9.20220801.2.1 * third_party/r8: auReXfxxD74XGdPdi-rYsKrp4sRwYwgNjh_W0PT7vNcC..5xaODYedSIJ21XAwZcpj4pG3NuVyKXrw43631PdtgK0C * tools/skia_goldctl/linux: BquSeorcTU84O2_A8IoWetGrcfLWxLfZCo9sve1Wt2IC..0NA1CyaNhIxt00SqtGFZVHJ-K7ioB4L6a5rT4MzyQ48C * tools/skia_goldctl/mac_amd64: -t3YY_sZ-jtMAYZ2PlhjudFnEUgk4m-HjlIwSip4tOAC..FWI4Q_ogCO1xBJ0xpOqci1On1AsY-RHqGDYlvqf3AiQC * tools/skia_goldctl/mac_arm64: x_xKUnqrgizoTO8mxX4RkyhpQ-nUp_x_go9YH-tc--QC..3dJEBjpviigMA6es0-th0SJsyrnw5_4wTMyBddvEByUC * tools/skia_goldctl/win: AOoQr1u4-cOIEYJDAgVxGWoTiPaRcjrSsjjAaB-u_ggC..TwW8GVww_8ATYlTEN2pHq5xuXkLqTN5mrqFZjRWD2GgC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Iafbe821b783b5f6860bf26cba0325e0a8d846a1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3803997 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell cc2095d2 2022-07-21T16:40:59 [Metal] Disable ANGLE's Metal backend on older GPUs. Disable creation of EGL_PLATFORM_ANGLE_TYPE_METAL_ANGLE displays on: iOS: MTLGPUFamilyApple2 and older (A8 and older GPUs) macOS and Mac Catalyst: MTLGPUFamilyMac1 and older This is a partial integration of this recent WebKit fix: https://bugs.webkit.org/show_bug.cgi?id=242764 Refactored to eliminate duplicate copies of this code between libANGLE and the test suites. Fixed: angleproject:7514 Change-Id: I00dd1096bc8e72516f3f77fffcb7d4a886d6f2e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780876 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev c517463a 2022-07-28T00:00:00 Add NoUnclampedBlendColor limitation Although ES 3.0 and ES 2.0 with floating-point color buffer extensions must support unclamped constant blend color, some drivers clamp it anyway. To let applications know the effective behavior, ANGLE state management has been expanded to simulate what the OpenGL ES driver is doing. So far, this bug has been confirmed only on Adreno GPUs. Unconditionally enabled this limitation on D3D9 as it cannot support unclamped blend color by design. Bug: angleproject:7536 Change-Id: I7e28a5553e79669d8482d48c6e79bdd811971ade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3791350 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 81554b66 2022-07-27T16:53:03 Vulkan: Reduce Framebuffer dirtyBits for swapchain only changes For window system framebuffer, the change to it is very limited. Most time it is only swapchain image changes. Right now we are also setting depth/stencil buffer dirty and processing layer count update and color mask and blending update when only color image changed. This CL avoids setting depth/stencil dirty bit for swap chain image changes. It also avoids color mask and blending update (they still gets updated for draw buffer change or draw franmebuffer binding changes). Bug: b/240475351 Change-Id: I0697a38d5939187244d67f01c0bc53fc28e11664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3789471 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 49523e69 2022-08-01T19:50:16 Roll Chromium from e810ac85e1c8 to bfa66f9bea8c (1114 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e810ac85e1c8..bfa66f9bea8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1404d7f2be..35807fca11 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/af18ab7c6f..03e060ebda * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6c8f712bc4..e3598c2dc0 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/2a908eebb7..012c3438e0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7975a43bbd..57cf1a6ce6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/53bd4e2349..2ecd8167d1 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/5ecb4635f0..de32b18623 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c3f526a3a1 * third_party/fuchsia-sdk/sdk: version:9.20220727.1.1..version:9.20220801.1.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/64bbf98854..8d1d3e3419 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/37aede243e..b11b8b482f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6440bc4b73..e72ce0a99e * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/345862f410..41d69d665a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/94f4798869..aba87cc71e No update to Clang. Bug: angleproject:5417 Tbr: jmadill@google.com Change-Id: I0801e4f1ce89666c81b187de21238f9bca5375ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3803578 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 606a9239 2022-07-31T21:01:31 Tests: Add Ni no Kuni trace Test: angle_perftests --gtest_filter="*ni_no_kuni*" Bug: angleproject:7507 Change-Id: I129a9f053dab24f277c42d22876732b83e4de933 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3802565 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
angle-autoroll 0b4ee2a8 2022-08-01T19:16:01 Roll vulkan-deps from 73766817e984 to 4818e22b9347 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/73766817e984..4818e22b9347 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0bcddf345f..d4801c93c5 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e734be0bb5..8ac3b50e9d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2f5947d981..ed5fab5096 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I2a06e1ede4a1421324e3fd75f8e61fcd083f9688 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3803576 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6887c950 2022-08-01T16:16:33 Roll SwiftShader from 80aaa8a74b74 to 67158b90f83c (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/80aaa8a74b74..67158b90f83c 2022-07-29 capn@google.com Update SPIR-V Tools to 54cd5e196 2022-07-29 capn@google.com Update SPIR-V Headers to 0bcc62492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I485370fd29be3fd6c5617d9b50b006e65c2fd17b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3803318 Commit-Queue: Jamie Madill <jmadill@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao dc77621b 2022-07-29T16:46:40 Vulkan: Fix RefCountedDescriptorPoolHelper leak DynamicDescriptorPool::mDescriptorPools really owns the pool, make it std::unique_ptr instead of plain c++ pointer to automatic handle object destruction. Bug: chromium:1346946 Change-Id: Iec2fff920d624cd983d314086cc08832c6c61984 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3795008 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov d6acced1 2022-07-25T18:11:20 Add flag --save-screenshots (implied by --screenshot-dir). --screenshot-dir and --render-test-output-dir behave differently on Android. --screenshot-dir is passed as is and therefore means a device directory, and --render-test-output-dir has special handling in Android wrappers that substitutes this flag with a temporary location on the device then copying files to the local directory set by this flag. Cody pointed out that there are many docs referring to --screenshot-dir so behavior should be preserved. So --save-screenshots is implied when this flag is set. Otherwise, it defaults to false, so --render-test-output-dir just on its own won't save screenshots, only when --save-screenshots is added as well. This also allows to produce other artifacts without necessarily producing screenshots by using --render-test-output-dir without --save-screenshots. Bug: angleproject:7299 Change-Id: Ib1a268ddeb7eba9f120e3f37a429ea0e4bbe2411 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785296 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Jamie Madill 7399fc7f 2022-07-25T16:22:44 infra: Update wrangling docs with Sheriff-o-Matic. The new SoM integration will simplify tracking the broken builds for ANGLE wranglers. Also includes several other documentation updates. Bug: chromium:1288021 Change-Id: I3ffb4e4dde4f4ddfde7288e9338c023c485aea89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785293 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 9af3ae0d 2022-07-29T19:51:39 Roll vulkan-deps from 2d409ca4e3b6 to 73766817e984 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2d409ca4e3b6..73766817e984 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8dc0030ecb..54cd5e1963 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cbdb019150..2f5947d981 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com,jmadill@google.com Change-Id: I14943fefa9b7a46d225ad83c5023d2d1ab9fc752 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3794301 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao a0eff729 2022-07-26T13:14:36 Vulkan: Reduce descriptorSets usage from UtilsVk Every time you get into UtilsVk to do conversion or emulation, it allocates a new descriptorSet. Right now it relies on the pool eviction to recycle the pool when no more free descriptorSet in the pool. This end up with quickly pushing the pool's size to maximum, and more than one pool been created. This CL intends to recycle individual DescriptorSet for the UtilsVk instead of the entire pool. With asphalt_9 while sitting in the menu, after this CL UtilsVk only uses one pool of size 16 (it really only uses 2 descriptorSets), versus before the CL you see two pools of size of 512. This CL also removes descriptorPoolBinding in UtilsVk since these are not really used and we are updating mUse for every allocation, which should prevent it from eviction when it should not be. Bug: b/235523746 Change-Id: I1d49455ffeb4b2a9678402e16d5e694c530c9d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788566 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yiwei Zhang 8f9e15cc 2022-07-26T00:22:38 Vulkan: avoid excessive log for FORMAT_IMPLEMENTATION_DEFINED This is a widely used format for camera stack. The current logging is too verbose when there's camera-gpu interop. Bug: b/240097793 Test: no more WARN logs for camera gpu usage Change-Id: Ie841182f1f67212cc1c479c5a9109d4bd1190e87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3786931 Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com>
Yuxin Hu 427086a9 2022-07-22T10:45:24 Vulkan: remove SpirvVaryingPrecisionFixer Bug: angleproject:7488 Change-Id: I957839bd8fbdf1cd849d5ed7e9edd65fd1a5f2cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780874 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll a629fb0a 2022-07-29T20:14:21 Roll VK-GL-CTS from e3066ef682d7 to 0170b4a25e36 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e3066ef682d7..0170b4a25e36 2022-07-29 piotr.byszewski@mobica.com Test NULL set layouts with non-independent sets 2022-07-29 piotr.byszewski@mobica.com Read vk.xml instead of vulkan_core.h 2022-07-29 piotr.byszewski@mobica.com Remove mandatory_features.txt 2022-07-29 jbauman@google.com Port deqp-vk to Fuchsia 2022-07-29 ziga@lunarg.com Fix passing temporary object as reference 2022-07-29 pdaniell@nvidia.com Improve image capability check compressed image tests 2022-07-29 rgarcia@igalia.com Test conditional rendering does not affect render pass clears 2022-07-29 ilkka.saarelainen@siru.fi Add dynamic rendering MSRTSS tests 2022-07-29 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main" into main 2022-07-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 to vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,yuxinhu@google.com Change-Id: I710f4a69b6a811a21c97001dffd099f22fa6710e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3794302 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Nicolas Capens cbab97d4 2022-07-29T11:03:21 Remove needless IOSurface alignment validation IOSurface buffers are copied instead of imported directly into Vulkan, since they're not guaranteed to satisfy alignment and padding requirements (see minImportedHostPointerAlignment and vkGetMemoryHostPointerPropertiesEXT). So we don't need to check its alignment as part of eglCreatePbufferFromClientBuffer() validation. Bug: angleproject:7538 Change-Id: Ic449e7cdd60e62cd3009854897ffcd369e32fc7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792178 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Auto-Submit: Nicolas Capens <nicolascapens@google.com>
angle-autoroll 9c6c072c 2022-07-29T10:01:38 Roll vulkan-deps from d28e244d3e12 to 2d409ca4e3b6 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d28e244d3e12..2d409ca4e3b6 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cc5fca057e..8dc0030ecb * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/87d2aa9d77..ff92049ebd * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fe3ea8d5f7..0bcddf345f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/cd379e6992..e734be0bb5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c55f470906..cbdb019150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I6491ec0a8d80a984e94a437c54e7655ecccaf816 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3793768 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 326441d0 2022-07-29T10:01:52 Roll SwiftShader from e8c074d7684b to 80aaa8a74b74 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e8c074d7684b..80aaa8a74b74 2022-07-29 capn@google.com Assert the minMemoryMapAlignment value 2022-07-29 capn@google.com Increase memory allocation alignment to 256 2022-07-29 capn@google.com Separate allocation alignment from offset alignment 2022-07-29 capn@google.com Increase minImportedHostPointerAlignment to 4096 2022-07-29 capn@google.com Report the maximum buffer offset alignment requirement 2022-07-29 capn@google.com Rename getDepthValue to readDepth If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: If2cd4f43727d8cadb57fb383960549c78fbf9ed9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792593 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lingfeng Yang 3ccaddf9 2022-07-26T10:02:01 Vulkan: EXT_YUV_target: layout(yuv) support This CL adds support for layout(yuv) in the shader, via a new decoration. The SPIRV decoration enum number is WIP and depends on final spec. The decoration is only active if enabled via a flag in ShaderLang, which will be connected with the feature supports_yuv_target in a future CL. Bug: b/223456677 Change-Id: I29a724e689d1336a3e42c83d7afa944a11e07353 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3765890 Auto-Submit: Lingfeng Yang <lfy@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Shahbaz Youssefi f000215d 2022-07-26T21:16:14 Vulkan: Optimize transform feedback buffer tracking Prior to this CL, if transform feedback was active at the time of render pass closure, its buffers were cached in ContextVk. Later, these buffers were used to close the render pass if they were used for any other reason (such as vertex attribute). However, this meant that the render pass could close unnecessarily if transform feedback was ended right after the render pass is closed. The closure of the render pass was an awkward place to cache the used transform feedback buffers (because at that point, the buffers are actually no longer used). Instead, this change makes sure that the buffers are cached when transform feedback buffers are first used by the render pass, and the cache is cleared at the end of the render pass. Bug: angleproject:4622 Change-Id: I31c0a1e20d48f2e261e2cf37adb0a46db683e6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788309 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Lingfeng Yang 6142b839 2022-07-26T13:57:53 Vulkan: EXT_YUV_target: add vk feature This Vulkan feature will be set to true once we detect support from underlying Vk driver (method TBD). Bug: b/223456677 Change-Id: I5003068c3119f43befb92579d4b656e3a9346363 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788564 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Lingfeng Yang <lfy@google.com>
Peng Huang 3dd6f5f7 2022-07-24T18:49:44 Reland "Disable share context lock for Chromium" This is a reland of commit e1741f4ba7dae4f6f09829b9152360544c912d1f Original change's description: > Disable share context lock for Chromium > > Bug: chromium:1336126 > Change-Id: I93b4e738a8816e6b318e5d5823bc9130f17deb37 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781368 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> Bug: chromium:1336126,angleproject:7537 Change-Id: I15811bc2fef0ba22f6ac13d51c72ed96b2a12507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792046 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao 5db09e9b 2022-07-21T10:45:12 Vulkan: Try allocate from existing DescriptorPool before create new When we allocate a new descriptorSet, right now we only look at current bound pool or the last pool, or allocate a new pool. We never look at the other pools for the possibility of allocation. This is likely due to we never free descriptorSet in the past. With the recent CLs, we now release invalid descriptorSets when texture or buffer gets deleted or re-specified. This opens up opportunity to allocate from other existing pools before allocating a new pool. This CL changes the allocation logic to add the pass to iterate over existing pools for allocation before allocating a new pool, thus reducing the number of descriptorSetPools. This CL also consolidates DynamicDescriptorPool::getOrAllocateDescriptorSet()'s actual descriptorSet allocation logic with DynamicDescriptorPool::allocateDescriptorSet(). This CL also moves mEmptyDescriptorSets from ProgramExecutableVk to DynamicDescriptorPool so that we will only have one empty descriporSet per pool instead of per program. Bug: b/235523746 Change-Id: I012346acce17f785ee6683ec55fdf21be00ea1a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780847 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill c48cfa02 2022-07-28T16:07:34 Revert "Disable share context lock for Chromium" This reverts commit e1741f4ba7dae4f6f09829b9152360544c912d1f. Reason for revert: Breaks SwANGLE tests when rolled into Chrome: https://chromium-review.googlesource.com/c/chromium/src/+/3789604/ Original change's description: > Disable share context lock for Chromium > > Bug: chromium:1336126 > Change-Id: I93b4e738a8816e6b318e5d5823bc9130f17deb37 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781368 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> Bug: chromium:1336126 Change-Id: Id3484b79aa9f8b914eca0f72c20d286ec1c03857 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792164 Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 08df7ce4 2022-07-28T10:59:30 Test Runner: Disable --bot-mode on Fuchsia. This flag is a bit hard to get going because of the differences in the Fuchsia system APIs. Disable it explicitly for now to avoid issues when we switch bot configs. Bug: angleproject:7312 Change-Id: I47cd038b198f265a6b60893faf6f50f02be49fda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3792163 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 39c5f321 2022-07-28T10:01:38 Roll vulkan-deps from 7158d6e8eaad to d28e244d3e12 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7158d6e8eaad..d28e244d3e12 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7b75c5dc7d..f0ce653a25 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b15de0fef2..c55f470906 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I74c0c197b204fdaa07e5b0a57be0364ad23db41a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790474 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6fb8d909 2022-07-28T10:01:52 Roll SwiftShader from 1739966fee2a to e8c074d7684b (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1739966fee2a..e8c074d7684b 2022-07-28 capn@google.com Refactor float to fixed-point conversion 2022-07-27 swiftshader.regress@gmail.com Regres: Update test lists @ 1739966f 2022-07-27 srisser@google.com Expose shaderUniformTexelBufferArray* indexing 2022-07-27 srisser@google.com Expose uniformBufferArray dynamic indexing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I68cf3f4b273ed28e07531bafc33f86c50ceebbb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790237 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a04f8c58 2022-07-28T07:00:34 Roll Chromium from 85c57e6023c8 to e810ac85e1c8 (442 revisions) https://chromium.googlesource.com/chromium/src.git/+log/85c57e6023c8..e810ac85e1c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/faf85adb8b..1404d7f2be * testing: https://chromium.googlesource.com/chromium/src/testing/+log/844e20e207..7975a43bbd * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c3a4a17539..53bd4e2349 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..84a7988038 * third_party/fuchsia-sdk/sdk: version:9.20220726.2.1..version:9.20220727.1.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/184bc29dd8..37aede243e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8c41d19417..6440bc4b73 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8f4235f7ff..94f4798869 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Idcfce9695e1de7d4856bc05e70102e76bcefca92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3790472 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan e7affd55 2022-06-23T13:49:18 d3d11: allow selecting render device by PCI vendor/device ID Similar my change in the Vulkan backend, we can match by PCI vendor/device ID in D3D11 device selection. Bug: angleproject:7460 Change-Id: I6f7bff1dad5b589357693bf747157b2dacb1f69f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720734 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Auto-Submit: Steven Noonan <steven@valvesoftware.com> Reviewed-by: Steven Noonan <steven@valvesoftware.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peng Huang e3701f90 2022-07-19T15:19:50 Remove WARN() in getPixelFormatInfo() This WARN() cause log flood on Android while playing youtube videos in Chrome. Bug: angleproject:7509 Change-Id: I42e046d5b0908ef7d3ca0704c27236198026a637 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3773873 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 80022b96 2022-07-26T21:07:04 Vulkan: Fix xfb buffer redefine to smaller size In 89e11878b275b15735eaf273ababfa6fd43a2e3d, a use-after-free bug was fixed where glBufferData redefined a buffer, leading to a change in storage. This was only tested for the case where the new buffer was larger than the old buffer. When the new buffer is smaller however, another issue remains where the buffer size as cached by the transform feedback object used the old object's size. This is worked around in this change, with a fix for the real issue (that the buffer state is updated after calling into the backend instead of before) coming up. Bug: chromium:1345042 Change-Id: I6c9e9344705fefe49926a14cf6ce73ce84305872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788308 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov fb97cfcd 2022-07-27T11:49:41 Roll chromium_revision 1201dfbc62..85c57e6023 (1027387:1028671) Skip failing dEQP-EGL.functional.image.api.create_image_gles2_android_native_* tests Change log: https://chromium.googlesource.com/chromium/src/+log/1201dfbc62..85c57e6023 Full diff: https://chromium.googlesource.com/chromium/src/+/1201dfbc62..85c57e6023 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f14f6d206b..faf85adb8b5817fd75744e98c450f2b9e46ed7a2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fe57e98eeb..af18ab7c6f * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/eb79671bfb..6c8f712bc4 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b954e3e656..039323b945 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/955e2ff5fb..2a908eebb7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1f497ac0b0..844e20e207 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/13bb7f697c..fabdc7fefb * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/8f37aa7698..d76d39e8c8 * third_party/android_sdk/public: tRoD45SCi7UleQqSV7MrMQO1_e5P8ysphkCcj6z_cCQC..-VRKr36Uw8L_iFqqo9nevIBgNMggND5iWxjidyjnCgsC * third_party/android_sdk/public: gMHhUuoQRKfxr-MBn3fNNXZtkAVXtOwMwT7kfx8jkIgC..9lGp8nTUCRRWGMnI_96HcKfzjnxEJKUcfvfwmA3wXNkC * third_party/android_sdk/public: g7n_-r6yJd_SGRklujGB1wEt8iyr77FZTUJVS9w6O34C..RSI3iwryh7URLGRgJHsCvUxj092woTPnKt4pwFcJ6L8C * third_party/android_sdk/public: lL3IGexKjYlwjO_1Ga-xwxgwbE_w-lmi2Zi1uOlWUIAC..eo5KvW6UVor92LwZai8Zulc624BQZoCu-yn7wa1z_YcC * third_party/android_system_sdk: oSfDIvHlCa6W0gS79Q5OOfB9E4eBg3uAvi3BEDN21U0C..RGY8Vyf8jjszRIJRFxZj7beXSUEHTQM90MtYejUvdMgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..84a7988038 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/debf6402b3..2cd48234f1 * third_party/fuchsia-sdk/sdk: version:9.20220720.2.1..version:9.20220726.2.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3d8d88e8bb..184bc29dd8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/15fc47eb8b..8c41d19417 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8e7aadf254..8f4235f7ff DEPS diff: https://chromium.googlesource.com/chromium/src/+/1201dfbc62..85c57e6023/DEPS Clang version changed llvmorg-15-init-15652-g89a99ec9:llvmorg-15-init-17529-ga210f404 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3d8d88e8bb600789ba3e798f38ff314521aac524..184bc29dd86c3994a02b4f3feca125ffe785319c/scripts/update.py Bug: chromium:1347817 Change-Id: I6b80fc411a6986d116e121921fcb5223c1964184 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3789322 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Steven Noonan b8e741d2 2022-06-23T13:36:17 Vulkan: allow selecting render device by PCI device/vendor IDs The EGL_ANGLE_platform_angle_device_id extension is deliberately vague about the meaning of "device ID high" and "device ID low", stating it's platform-specific. We can use these for representing the PCI device/vendor IDs that can be discovered via various (OS-specific) external means. Bug: angleproject:7460 Change-Id: Iff462687749e815fa074ef8ff392b6730ef46fa8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720733 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Peng Huang e1741f4b 2022-07-24T18:49:44 Disable share context lock for Chromium Bug: chromium:1336126 Change-Id: I93b4e738a8816e6b318e5d5823bc9130f17deb37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781368 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Lubosz Sarnecki 0dc29af9 2022-07-26T19:16:16 Context: Also disable ASTC on mState when emulation is disabled. GL_KHR_texture_compression_astc_ldr was incorrectly exposed on the GL_EXTENSIONS string in cases where no native support was available and the emulation was not built. To prevent this the context must disable it on mState.mExtensions in addition to mSupportedExtensions. Bug: angleproject:7415 Change-Id: I1161e460b0b224a03557053b5804c104e270f388 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788402 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 630e50c3 2022-07-27T10:01:25 Roll SwiftShader from b6ddcf331865 to 1739966fee2a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b6ddcf331865..1739966fee2a 2022-07-26 swiftshader.regress@gmail.com Regres: Update test lists @ b6ddcf33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I8db29c92febb3840d716ce53fe5f175e9bb769e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788618 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 255893f6 2022-07-27T10:01:38 Roll vulkan-deps from 03d4f8e01303 to 7158d6e8eaad (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/03d4f8e01303..7158d6e8eaad Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/607771c362..7b75c5dc7d * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e4cfa190df..cc5fca057e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I98498fb257b98d353a89591f6949f430bbf3f754 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788146 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill b968b6c9 2022-07-26T14:34:41 Test Utils: Get executable path from command line. This simplifies the process fork test and will allow the test to work on Fuchsia. Bug: angleproject:3161 Change-Id: I5bb5424c44957f2faef1970b3cbc5e52b8aff630 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788297 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Stephen White 3f59c285 2022-07-12T17:29:36 D3D11: implement image load/store format reinterpretation. Reinterpretation requires all UAV textures to be in a TYPELESS format. Implement an ensureUnorderedAccess() that converts the texture's storage to one with the D3D11_BIND_UNORDERED_ACCESS flag, which, prior to this change, was set unconditionally for all textures in an >= ES 3.1 context. If this flag is set at D3D texture creation time, use the appropriate TYPELESS format. Implementation uses a BindFlags struct, which subsumes the existing renderTarget for clarity. Factor out the relevant bits of ensureRenderTarget() into an ensureBindFlags() helper function, and make ensureRenderTarget() and ensureUnorderedAccess() wrappers around it. Add the corresponding typeless formats to the texture format table. Bug: angleproject:7501, angleproject:7520 Change-Id: Id21b9db3229aceca121da6ba6507704417034ec4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780588 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Jamie Madill 83dfd839 2022-06-07T11:57:07 dEQP: Allow running against system GL. Bug: angleproject:7396 Change-Id: I6d6231ebfdea0f1df483c5764b086b14f8384d3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3692266 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
mark a. foltz a78c01b2 2022-07-22T13:52:55 [Cast Convergence] Remove is_chromecast in ANGLE. is_chromecast is going to be removed from Chromium. This is_chromecast with is_castos, which will be set for builds that target Nest Linux devices. Upstream bug: https://crbug.com/1337084 Umbrella bug: https://crbug.com/1219802 Design doc (internal only): https://go/unified-cast-web-runtime Bug: angleproject:7521 Change-Id: Id1a0df72e37868eabd1f851123eec615f6657570 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782573 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Lubosz Sarnecki 5c5a14c3 2022-07-19T16:03:08 Tests: Add Battle Of Polytopia trace. Test: angle_perftests --gtest_filter="*battle_of_polytopia*" Bug: angleproject:7529 Change-Id: Ib9ad862fa5d2a3cd761bdbf42b2b91c2fe63f99b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780915 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 4e046256 2022-07-25T17:17:28 Translator: Fix deep copy of loops and branches Fixed nullptr dereference when the loop or branch doesn't have an expression. Bug: angleproject:7518 Change-Id: Ib888634e409dcbc27ef060bb46017e8911097eef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785294 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sungyong Choi 313884ce 2022-06-30T08:49:08 Vulkan: Move dmabuf extensions support Moves dmabuf support functions from DisplayVkWayland to DisplayVkLinux to support other linux winsys. Bug: angleproject:7480 Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Change-Id: I2a36557815b8e5c4bab7ec1d9248989345e536c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3735863 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jeff Vigil <j.vigil@samsung.com>
angle-autoroll 39119a8b 2022-07-26T10:01:38 Roll vulkan-deps from 50a58c2a73cb to 03d4f8e01303 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/50a58c2a73cb..03d4f8e01303 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6ef2e49216..607771c362 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bbff1dc594..b15de0fef2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I1015186b364a8d9bf4249ed3565acedded6d2587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3787784 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 54da2952 2022-07-25T16:00:47 Remove suppressions added due to VK_ATTACHMENT_UNUSED bug This was affecting old Qualcomm-based phones only. Bug: angleproject:3423 Change-Id: Id18c95f8df562d572177035a8cb88327d9f2d200 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785292 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a3cda607 2022-07-26T10:01:25 Roll SwiftShader from 16e026a959f1 to b6ddcf331865 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/16e026a959f1..b6ddcf331865 2022-07-25 srisser@google.com Expose float preserve capability 2022-07-25 swiftshader.regress@gmail.com Regres: Update test lists @ 16e026a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I95e1010e049c3e4f4a66b0a308cbac6b441483fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3787801 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 88dd868f 2022-07-25T06:44:38 FrameCapture: Fix and optimize multi-context reset Follow on to fd89020c This CL: - Fixes missing eglMakeCurrent calls when switching contexts to reset container state - Optimizes when those calls are made, so we only call eglMakeCurrent in Reset when we absolutely have to - Moves MaybeResetContextState to the end, after any per-context reset work has been done Test: Asphalt 9 MEC Bug: angleproject:4599 Bug: angleproject:7507 Change-Id: I52912aa13e3a11735ed3ec93080a21e9cbff113a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3784728 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi be708446 2022-07-25T15:24:52 Vulkan: Remove the bindEmptyForUnusedDescriptorSets workaround Only applied to older Qualcomm-based phones. Bug: angleproject:2727 Change-Id: I37a611e2ff79d898eff9401467407543f3c690b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785290 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Jamie Madill 673a41ae 2022-07-25T12:41:40 dEQP: Isolate headers in tcuANGLEPlatform.h. Refactoring change only. Will simplify future dEQP changes. Bug: angleproject:7396 Change-Id: I034bf5c421902c53f279e01b0727490909da3990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785286 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 8e63c6e8 2022-07-25T15:10:11 Remove suppressions for tests which pass with Intel Mesa 20.0.8 Bug: angleproject:3616, angleproject:3614, angleproject:2782 Change-Id: I220d71593270164f77bda92f533608e431c6c9b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780159 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev df879d49 2022-07-22T00:00:00 Return INVALID_VALUE for online BC compression As per discussion with OpenGL ES WG, implementations are allowed to generate INVALID_VALUE when online BC compression is not supported. Bug: angleproject:6441 Change-Id: I0e282c970f1e03afbc590dc9a46b8ce38d869691 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780923 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Peter Kasting 4a14030d 2022-07-22T10:09:53 Avoid streaming a wide string to a (narrow) ostringstream. This stream overload was removed in C++20. Bug: chromium:1284275 Change-Id: I73188e09cc93c7bd475ab1536dac74e92ea12605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781611 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8d2988f7 2022-07-25T12:06:51 infra: Add sheriff_rotations to luci properties. This should allow ANGLE builders to show up in Sheriff-o-Matic. Bug: chromium:1288021 Change-Id: Ic3ab746160a2249362b64bbc063e88848a5b23c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785285 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov da2d1e0a 2022-07-25T16:12:14 Update extension support (July 25, 2022). Linux Intel testing was switched from HD630 to UHD630 GPU. Bug: chromium:1342945 Change-Id: Ic02e71a9ee3d5cdb2a6808405551bf3f60512914 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780158 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 3b020cc1 2022-07-25T13:59:21 Roll VK-GL-CTS from cb1dc55bc044 to e3066ef682d7 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/cb1dc55bc044..e3066ef682d7 2022-07-23 quic_mnetsch@quicinc.com Merge dev/VK_EXT_shader_module_identifier to vk-gl-cts/main 2022-07-23 quic_mnetsch@quicinc.com Merge vk-gl-cts/dev/VK_EXT_multisampled_render_to_single_sampled to vk-gl-cts/main 2022-07-22 quic_mnetsch@quicinc.com Notice of withdrawal of Vulkan CTS 1.2.7.x 2022-07-22 quic_mnetsch@quicinc.com Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main 2022-07-22 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main 2022-07-22 piotr.byszewski@mobica.com Fix validation errors for DR multiview tests 2022-07-22 jbolz@nvidia.com Support commandPoolResetCommandBuffer==VK_FALSE for VulkanSC 2022-07-22 vidar.lillebo@arm.com Add tests for VK_EXT_image_compression_control_swapchain 2022-07-22 antto.makinen@siru.fi Add coverage of indirect dispatches on the compute queue 2022-07-22 rgarcia@igalia.com Test dynamic patch control points without tessellation 2022-07-22 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,yuxinhu@google.com Change-Id: Ic3bdc4c896e144cadb5dd5b049763a649b9ac126 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3784727 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4fdc3754 2022-07-25T10:01:38 Roll vulkan-deps from f00ffae9c319 to 50a58c2a73cb (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f00ffae9c319..50a58c2a73cb Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7e6b7c26a2..6ef2e49216 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d8d051381f..0cccd0a65a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I2e12b09f11d2e43e8dc73cac7f6f5089c6cc1a90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3784025 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop e3933465 2022-07-21T11:35:17 Vulkan: Allow dither for some color blend modes Some color blend modes are known to work with our dither emulation. Test: Candy Crush on Pixel 6 Bug: b/232574868 Change-Id: I1b57e243afcf4643e2cd12f862408050751fa987 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780846 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop fd89020c 2022-07-18T20:26:38 FrameCapture: Reset VertexArray state This change includes three things: - Tracking resources by context - Resetting VertexArray state - Splitting ResetReplay into per-context All three are needed to properly Reset Vertex Array objects. Vertex Arrays are considered container objects, which means they are not shared with other contexts. We've had a hole in Reset where we did not take multiple contexts into account. To address this, we now also track which contextID was used to modify a resource. For objects that need to know which context they are bound to, we track them in a map and return the correct index when getTrackedResource is called. To generate the calls to reset Vertex Array state, we are able to mirror what has been done for other ResourceTypeIDs. In order to properly Reset resources in multiple contexts, we have to bind the correct context before emitting the Reset calls. This has been done for Setup already, so we have a template to follow. With this CL, we now emit multiple functions to Reset state, similar to the following: void ResetReplayContextShared() { // Reset shared objects ... } void ResetReplayContext5() { // Bind the right context eglMakeCurrent(EGL_NO_DISPLAY, EGL_NO_SURFACE, EGL_NO_SURFACE, context5); // Reset container objects for context5 ... } void ResetReplayContext6() { // Bind the right context eglMakeCurrent(EGL_NO_DISPLAY, EGL_NO_SURFACE, EGL_NO_SURFACE, context6); // Reset container objects for context6 ... } void ResetReplay() { EGLContext context = eglGetCurrentContext(); ResetReplayContextShared(); ResetReplayContext5(); ResetReplayContext6(); eglMakeCurrent(EGL_NO_DISPLAY, EGL_NO_SURFACE, EGL_NO_SURFACE, context); } Test: Ni no Kuni MEC Bug: angleproject:4599 Bug: angleproject:7507 Change-Id: Ic585534f07172474aab0ce1d0396b0b064379f88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3761874 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 00e48c13 2022-07-20T17:35:01 Vulkan: Destroy DescriptorPoolHelper when its unused. DynamicDescriptorPool keeps an array of DescriptorPoolHelpers. Right now we only grow this array of pools, we never shrink the pool count. This is partly due to we never release descriptorSet. But in the past few CLs, we now release invalid descriptorSet when texture/buffer gets deleted or re-specified. This means we could now have a pool with no valid descriptorSets. This CL adds the ability to actually release the pool when all of its descriptorSets has been released, thus reduce the pool count when a lot of textures have been deleted. Bug: b/235523746 Change-Id: I2d5047269154cc8ece8305408f08f2ad7c9dd8a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780845 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Yuxin Hu b23ea680 2022-07-22T12:06:42 Vulkan: Re-enable multisample framebuffer fetch Bug: angleproject:7351 Bug: angleproject:3586 Bug: angleproject:6195 Bug: angleproject:7512 Bug: b/234173199 Change-Id: Ib70732f8c075de777e534f950a7e421e75969f59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781613 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 6d6b9967 2022-07-22T20:16:18 Roll Chromium from d2f8d8516036 to 1201dfbc6265 (220 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d2f8d8516036..1201dfbc6265 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1d40290874..f14f6d206b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8b46ec0615..fe57e98eeb * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/49e658031b..eb79671bfb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9222b02eb9..1f497ac0b0 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5bf30e53b5..c3a4a17539 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3384fbd903 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0ba2fd429d..debf6402b3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9f9696f98f..8e7aadf254 No update to Clang. Bug: None Tbr: romanl@google.com,ynovikov@google.com Change-Id: I09ec0218b7dab0e1a7607148b23de436dd6fdebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782572 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 2b43d630 2022-07-22T14:19:05 Remove unused (and incorrect on Android) mTestSuiteName. On Android it ends up being just: _ Bug: angleproject:7299 Change-Id: I3dabcfcbacc3f43338b6fa91ebd9917e43f783ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780587 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Lingfeng Yang c2aaeadb 2022-07-14T13:27:38 Vulkan: Skip nonexistent attachments when calculating samples When FBO 0 is bound, FramebufferVk can get into a state where the color attachment is considered null (such as surfaceless). Then, getSamples() is called with null color attachment, resulting in an assertion or nullptr crash. Fix getSamples() to respect the color attachments mask. The entry point that brought this about was also a dispatch, not a draw. In a future CL, we should also optimize syncState to not consider draw related state if the task is a dispatch. Also fixes b/234620157 Bug: b/223456677 Change-Id: I8cc969de941f43a2eb66871033d6ec7ddf8b8a66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764435 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Lingfeng Yang <lfy@google.com>
angle-autoroll 72795eb0 2022-07-22T14:27:38 Roll Chromium from 9d88fd8904e8 to d2f8d8516036 (510 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9d88fd8904e8..d2f8d8516036 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bed2979286..1d40290874 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d4d55fbf05..8b46ec0615 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/88bf407048..49e658031b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbe80d6926..9222b02eb9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bbffded4b5..5bf30e53b5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..07e4a3d3cc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39e33e6eca..0ba2fd429d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0ca99b7456..3d8d88e8bb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b453316b9e..15fc47eb8b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6786537981..9f9696f98f No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I5ec8ebbca47422958b75e05fa32b2fea232043c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782858 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 788c5454 2022-07-22T14:45:21 Roll VK-GL-CTS from 692df061716d to cb1dc55bc044 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/692df061716d..cb1dc55bc044 2022-07-22 quic_mnetsch@quicinc.com Merge pull request #338 from PanGao-h/patch-1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,romanl@google.com Change-Id: I7a1522977d7b5df19ab32bf1e29e4152ca415502 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782859 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 90fa855b 2022-07-22T10:11:01 Suppress the early_fragment_tests PLS test on Pixel 6 Bug: angleproject:7279 Change-Id: Id56d43f9061e9f6d08388ff49b2f65a88408c145 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782862 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov adeb750d 2022-07-21T18:49:00 Validate that skipped tests are skipped by suite. Before this change, any test failing to produce trace files would be marked as "Skipped" regardless of whether it was skipped by suite or just failed to produce trace files for some other reason. This change adds FailedToTrace status to differentiate between the two cases. If a test is FailedToTrace it will need to be explicitly added to the capture_replay expectation file (probably SKIP_FOR_CAPTURE). This change caught that OcclusionQueriesNoSurfaceTestES3.SwitchingContextsWithQuery/* was incorrectly specified as NOT_RUN when the intent was to SKIP. Bug: angleproject:5133 Bug: angleproject:7516 Change-Id: I451b4d5fd799d15ef92fab678aa20d2b6cc42c9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3781902 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 08df2000 2022-07-22T10:01:38 Roll vulkan-deps from 5cb0a31b27bf to f00ffae9c319 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5cb0a31b27bf..f00ffae9c319 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a13608020f..fe3ea8d5f7 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8b603f8d06..cd379e6992 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/52aadfabb5..bbff1dc594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Iab940a361c1e26fc9b8fa5b47ee636a430bb1941 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782616 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lingfeng Yang 7d6f3d94 2022-07-14T13:25:04 glValidateProgramPipelines: Skip draw state error check Certain apps will call this API while having a surfaceless context, making it improperly fail. dEQP tests that previously relied on the full draw states check were actually relying on the part where the draw state check included a check that the pipeline object had programs/shaders. Relax the validation of the pipeline to only include that validation, and not also the framebuffer state / VBO state / etc. Bug: b/223456677 Change-Id: I9211761934668aae8a20f07ac4f36b7f6c1281da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764434 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov c95e2b7d 2022-07-21T17:03:19 Remove a few cases that are skipped by end2end. Following https://crrev.com/c/3780583. A few obvious NOT_RUN cases where bugs and skipped tests match those in angle_end2end_tests_expectations.txt Bug: angleproject:7516 Change-Id: I63a78b0800d2e4fedfe7d4730df6b55b22508dc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3779645 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Chris Dalton d57ce815 2022-07-16T16:33:08 Use "readwrite" PLS images when possible We actually only need readonly/writeonly aliases on ESSL, non r32f/r32ui. For all other cases, this change updates the compiler to emit a single readwrite image. We also optimize this image with the "restrict" qualifier since PLS specifically disallows aliasing. Removing the aliased load and store also eliminates our issue with an Intel driver bug, and all the PLS tests now pass without any workarounds. Bug: angleproject:7279 Bug: angleproject:7398 Change-Id: I350b239793647da33add96509b8f4b1bbef02245 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3767537 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Chris Dalton aa7e6751 2022-07-15T23:33:30 Automatically enable early_fragment_tests when PLS is declared When PLS is polyfilled by shader images, we need early_fragment_tests in order to match the same depth/stencil behavior as when it is implemented as framebuffer fetch. Bug: angleproject:7279 Change-Id: I37f5a8682cc96a14ef247d53ed243e4aceb15f39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3767535 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Chris Dalton 77aa34ae 2022-07-16T13:08:00 Add support for PLS as function arguments Bug: angleproject:7279 Change-Id: I89d5c02148cbdbbd02dc4840ffada2c96c2a849b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3767534 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Roman Lavrov 3a0d7249 2022-07-21T13:38:21 Ignore tests skipped by the suite. This way we don't have to add skipped tests to capture_replay_expectations as well. Bug: angleproject:5133 Bug: angleproject:7512 Bug: angleproject:7516 Change-Id: Iabc5f4738b51ce23890c07b8a0548cbc6bec1274 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780583 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuxin Hu d0fe12db 2022-07-20T10:16:38 Vulkan: Disable Multisample Framebuffer Fetch Disable the multisample framebuffer fetch temporarily to unblock the angle to chromium roller. Will re-enable after https://ci.chromium.org/ui/p/chromium/builders/try/win10_chromium_x64_rel_ng/1240846/overview is resolved. Bug: angleproject:7351 Bug: angleproject:3586 Bug: angleproject:6195 Bug: angleproject:7512 Bug: b/234173199 Change-Id: I435b257dd07d973d06d5cacd779e943eed32097b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3777059 Reviewed-by: Roman Lavrov <romanl@google.com>
Peng Huang b78d471a 2022-07-21T09:53:37 Add angle_enable_share_context_lock build flag This flags can be used to enable the share context lock. Without this lock, the client need to use gl calls in a threadsafe way. It is true by default. Bug: chromium:1336126 Change-Id: I984f8cfb0379195f6ebe11b0997e401f2421affa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780582 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Yuly Novikov 115d8361 2022-07-21T13:59:48 Switch Linux Intel testing to UHD 630 GPU Replacing 0x5912 HD 630 with 0x9bc5 UHD 630. Also updating Mesa from 19.0.2 to 20.0.8. Since no problems were observed on the new configuration during the experiment, removing max-processes and flaky-retries workarounds. Bug: chromium:1342945 Change-Id: I51150092c67802ffd54796dd3b067cd6473dfb86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3780922 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Chris Dalton c460c299 2022-06-21T11:20:45 Implement GLSL additions for ANGLE_shader_pixel_local_storage Specs out, implements, and thoroughly tests the GLSL additions for ANGLE_shader_pixel_local_storage. Adds a simple transformation that rewrites PLS directly into shader images. Updates the existing PLS tests to use the newly built-in PLS features and ensures they continue passing. For now, applications call glBindImageTexture to configure their pixel local storage. The OpenGL ES API side of this extension will follow shortly. Bug: angleproject:7279 Change-Id: I141183069b5cbfcca01cbb77b5b36d3e5f834bf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3761876 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 25f7d39f 2022-07-21T10:01:38 Roll vulkan-deps from c42337d9ef75 to 5cb0a31b27bf (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c42337d9ef75..5cb0a31b27bf Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/93ebf698a0..e4cfa190df * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/16847a6100..87d2aa9d77 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/eb67f9bbef..52aadfabb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Iaaa8bdbee6b56f8e1e07722c690548ad46533a5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3778411 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dba01bdc 2022-07-21T07:25:29 Roll Chromium from 16ae342caefb to 9d88fd8904e8 (515 revisions) https://chromium.googlesource.com/chromium/src.git/+log/16ae342caefb..9d88fd8904e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/60d303b648..bed2979286 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a4506d5d63..d4d55fbf05 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe41fffbb7..cbe80d6926 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9cb6988560..bbffded4b5 * third_party/android_build_tools/lint: OkpY7I7TtDs4jihQ9SmckN-GEVBpZ2y9xr4M7TimTqoC..INnGGTfg5gGJutJiBtWI6-QwusHDDnKvZzI53Q3UiecC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..abcd8ba23e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f3edc50445..39e33e6eca * third_party/fuchsia-sdk/sdk: version:9.20220719.3.1..version:9.20220720.2.1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9a213cebd..b453316b9e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/264e097ed4..6786537981 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I98dbfe79734915da7b6f1d70870cf85c28fc782b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3779248 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 992018c7 2022-07-20T17:31:47 Suppress VUID-VkGraphicsPipelineCreateInfo-pStages-06896. Bug: angleproject:7513 Change-Id: I2877c069e33d2ec5e92cf759dc3ab1d270e1a414 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3776759 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov 1e619503 2022-07-20T11:55:49 Skip TracePerfTest vulkan_car_chase on Linux Intel Flaky VK_ERROR_DEVICE_LOST on Intel UHD 630 Mesa 20.0.8 Bug: angleproject:7125 Change-Id: I7e99819a586e3f146728f49dfdeebf9e8ddcb219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3777097 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 84bfb6ce 2022-07-20T07:43:28 Roll Chromium from 806fa2d991d9 to 16ae342caefb (283 revisions) https://chromium.googlesource.com/chromium/src.git/+log/806fa2d991d9..16ae342caefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f304e1f508..60d303b648 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1307a6e5be..fe41fffbb7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ab2ff5cdd4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f05fcf7051..f3edc50445 * third_party/fuchsia-sdk/sdk: version:9.20220719.1.1..version:9.20220719.3.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2b481239f6..37eadcf61d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/394db6d2a8..264e097ed4 * tools/skia_goldctl/linux: Ri4sbgofBQTekhs0H-MmBCEBFmTBIzjMFWjrISXy44QC..BquSeorcTU84O2_A8IoWetGrcfLWxLfZCo9sve1Wt2IC * tools/skia_goldctl/mac_amd64: 2FFjh0Xtg__05cZwoN_kBY9gONiqBgS4k96j4PiERwQC..-t3YY_sZ-jtMAYZ2PlhjudFnEUgk4m-HjlIwSip4tOAC * tools/skia_goldctl/mac_arm64: CDhGE0xDG5UpFXKhktNh4Hn1ahNh3qpRQ1KDKvRjuWgC..x_xKUnqrgizoTO8mxX4RkyhpQ-nUp_x_go9YH-tc--QC * tools/skia_goldctl/win: 2hLrGJKgXQCcX5OqtWO__r1MDSY-ix-DaFzXPUcuOJQC..AOoQr1u4-cOIEYJDAgVxGWoTiPaRcjrSsjjAaB-u_ggC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Id9bff94ea34661824d0b45739a7f45dc1fdf0f3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3775142 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lingfeng Yang fc97b2da 2022-07-14T13:18:56 Vulkan: Always use depth<=256 AHB image siblings Android will sometimes use an uninitialized value for the layerCount, which results in huge, many-GB allocations down the line. If we see a big value there, force to 1. Bug: b/223456677 Change-Id: I201e9901d9c726a9af73d025ac33850d11a5a38a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764433 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Lingfeng Yang <lfy@google.com>